Bug#264081: Plugin quoting bugs

Darren Salt pkg-vdr-dvb-devel@lists.alioth.debian.org
Sat, 07 Aug 2004 13:03:42 +0100


I demand that Thomas Schmidt may or may not have written...

> * Darren Salt schrieb am 07.08.04, um 00:56 Uhr:
>> Despite the quoting code in plugin-loader.sh, I'm still seeing plugins not
>> being loaded, with vdr complaining about things like "plugin '"xine' not
>> found". (Note the extra ".)

> Hmm, i can not reproduce this here, everything works perfect. Only plugins
> with an empty plugin.<pluginname>.conf are called with -P "pluginname " but
> this also works perfect.

Hmm...

>> Since shell array variables are already in use (aren't they bashisms, and
>> shouldn't vdr.init use /bin/bash?), we may as well wander deeper into bash
>> territory to fix this [...]

> Ok, i changed to /bin/bash in vdr.init, but your fixes do not work here, in
> fact they break the ability to use plugins with commandline-options, vdr
> fails to start when i use your fixes + commandline-options i a
> plugin.<pluginname>.conf.

Ouch. Probably best to ignore them, then.

> Are you sure that this happens with the delivered runvdr-script, or may
> this be a problem in your c-version of runvdr?

Possibly; I wrote that because of shell quoting problems. OTOH, passing
$PLUGINS to a short Perl script ('print join("\n",@ARGV),"\n"') shows similar
problems.

I've not tried with bash, though.

-- 
| Darren Salt | d youmustbejoking,demon,co,uk | nr. Ashington,
| Debian,     | s zap,tartarus,org            | Northumberland
| RISC OS     | @                             | Toon Army
|   <URL:http://www.youmustbejoking.demon.co.uk/progs.packages.html>

Whoops! Here comes Mr Jelly!