Bug#276083: marked as done ([PATCH] keymap-loading interface for budget-ci)

Debian Bug Tracking System pkg-vdr-dvb-devel@lists.alioth.debian.org
Mon, 25 Oct 2004 01:03:17 -0700


Your message dated Mon, 25 Oct 2004 03:47:09 -0400
with message-id <E1CLzZN-0006c1-00@newraff.debian.org>
and subject line Bug#276083: fixed in linuxtv-dvb 1.1.1-4
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 11 Oct 2004 22:39:20 +0000
>From linux@youmustbejoking.demon.co.uk Mon Oct 11 15:39:20 2004
Return-path: <linux@youmustbejoking.demon.co.uk>
Received: from anchor-post-32.mail.demon.net [194.217.242.90] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CH8p5-0001bj-00; Mon, 11 Oct 2004 15:39:20 -0700
Received: from youmustbejoking.demon.co.uk ([212.228.127.8] helo=pentagram.youmustbejoking.demon.co.uk)
	by anchor-post-32.mail.demon.net with esmtp (Exim 4.42)
	id 1CH8ov-000KBu-7b
	for submit@bugs.debian.org; Mon, 11 Oct 2004 22:39:16 +0000
Received: from riscpc ([192.168.0.2])
	by pentagram.youmustbejoking.demon.co.uk with esmtp (Exim 3.36 #1 (Debian))
	id 1CH8Ta-0003gs-01
	for <submit@bugs.debian.org>; Mon, 11 Oct 2004 23:17:06 +0100
Date: Mon, 11 Oct 2004 22:31:09 +0100
From: Darren Salt <linux@youmustbejoking.demon.co.uk>
Message-ID: <4CFC63B3AD%linux@youmustbejoking.demon.co.uk>
User-Agent: Messenger-Pro/2.72b9 (MsgServe/2.13) (RISC-OS/4.02) POPstar/2.06-ds.2
To: submit@bugs.debian.org
Subject: [PATCH] keymap-loading interface for budget-ci
X-Editor: Zap 1.46 (24 Sep 2004) ds, ZapEmail 0.28.1 (09 Aug 2004) (32)
X-SDate: Mon, 4059 Sep 1993 22:31:09 +0100
X-Message-Flag: Outlook Express is broken. Upgrade to mail(1).
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="1608610353--239176158--2033598025"
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

This message is in MIME format which your mailer apparently does not support.
You either require a newer version of your software which supports MIME, or
a separate MIME decoding utility.  Alternatively, ask the sender of this
message to resend it in a different format.

--1608610353--239176158--2033598025
Content-Type: text/plain; charset=us-ascii

Package: dvb-driver-source
Version: 1.1.1-3
Severity: wishlist
Tags: patch

The attached patch adds a file /proc/budget_ci_ir which accepts a set of 64
keysyms (128 bytes) for programming of the remote control keymap. The code is
derived from the /proc interface code implemented in av7110_ir.c.

It should be written to by budget_ci_loadkeys (patch sent separately).

(Note also that this patch is applicable to kernel 2.6.8.1: budget_ci.c there
is identical. It should also be applicable, with trivial reject resolution,
to current linuxtv kernel CVS.)

-- 
| Darren Salt   | linux (or ds) at | nr. Ashington,
| woody, sarge, | youmustbejoking  | Northumberland
| RISC OS       | demon co uk      | Toon Army
|   <URL:http://www.youmustbejoking.demon.co.uk/progs.linux.html>

Experiments should be reproducible. They should all fail in the same way.

--1608610353--239176158--2033598025
Content-Type: text/plain; charset=iso-8859-1; name="budget-ci-keys.patch"
Content-Disposition: attachment; filename="budget-ci-keys.patch"
Content-Transfer-Encoding: quoted-printable

--- linux/drivers/media/dvb/ttpci/budget-ci.c.orig	2003-11-20 10:50:15.00=
0000000 +0000
+++ linux/drivers/media/dvb/ttpci/budget-ci.c	2004-09-27 22:16:19.0000000=
00 +0100
@@ -34,6 +34,7 @@
 #include <linux/slab.h>
 #include <linux/interrupt.h>
 #include <linux/input.h>
+#include <linux/proc_fs.h>
=20
 #if (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0))
 #include "input_fake.h"
@@ -181,10 +182,48 @@
 }
=20
=20
+static int budget_ci_ir_write_proc (struct file *file,
+				    const char __user *buffer,
+				    unsigned long count, void *data)
+{
+	/* adapted from av7110_ir.c */
+	char *page;
+	int i;
+	struct input_dev *input =3D (struct input_dev *)data;
+
+	if (count < sizeof (key_map))
+		return -EINVAL;
+=09
+	page =3D (char *)vmalloc(sizeof (key_map));
+	if (!page)
+		return -ENOMEM;
+=09
+	if (copy_from_user(page, buffer, sizeof (key_map))) {
+		vfree(page);
+		return -EFAULT;
+	}
+
+	memcpy (&key_map, page, sizeof (key_map));
+	vfree(page);
+
+	memset (input->keybit, 0, sizeof(input->keybit));
+
+	for (i=3D0; i<sizeof(key_map)/sizeof(key_map[0]); i++) {
+		if (key_map[i] > KEY_MAX)
+			key_map[i] =3D 0;
+		else if (key_map[i] > KEY_RESERVED)
+			set_bit (key_map[i], input->keybit);
+	}
+
+	return count;
+}
+
+
 static int msp430_ir_init (struct budget_ci *budget_ci)
 {
 	struct saa7146_dev *saa =3D budget_ci->budget.dev;
 	int i;
+	static struct proc_dir_entry *e;
=20
 	memset(&budget_ci->input_dev, 0, sizeof(struct input_dev));
=20
@@ -204,6 +243,13 @@
=20
 	saa7146_setgpio(saa, 3, SAA7146_GPIO_IRQHI);=20
=20
+	e =3D create_proc_entry ("budget_ci_ir", S_IFREG | S_IRUGO | S_IWUSR, N=
ULL);
+	if (e) {
+		e->write_proc =3D budget_ci_ir_write_proc;
+		e->data =3D &budget_ci->input_dev;
+		e->size =3D sizeof (key_map);
+	}
+
 	return 0;
 }
=20
@@ -213,6 +259,8 @@
 	struct saa7146_dev *saa =3D budget_ci->budget.dev;
 	struct input_dev *dev =3D &budget_ci->input_dev;
=20
+	remove_proc_entry ("budget_ci_ir", NULL);
+
 	saa7146_write(saa, IER, saa7146_read(saa, IER) & ~MASK_06);
 	saa7146_setgpio(saa, 3, SAA7146_GPIO_INPUT);
 	saa7146_setgpio(saa, 2, SAA7146_GPIO_INPUT);

--1608610353--239176158--2033598025--

---------------------------------------
Received: (at 276083-close) by bugs.debian.org; 25 Oct 2004 07:54:30 +0000
>From katie@ftp-master.debian.org Mon Oct 25 00:54:30 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CLzgT-0008Nm-00; Mon, 25 Oct 2004 00:54:30 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1CLzZN-0006c1-00; Mon, 25 Oct 2004 03:47:09 -0400
From: Debian VDR Team <pkg-vdr-dvb-devel@lists.alioth.debian.org>
To: 276083-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#276083: fixed in linuxtv-dvb 1.1.1-4
Message-Id: <E1CLzZN-0006c1-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Mon, 25 Oct 2004 03:47:09 -0400
Delivered-To: 276083-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Source: linuxtv-dvb
Source-Version: 1.1.1-4

We believe that the bug you reported is fixed in the latest version of
linuxtv-dvb, which is due to be installed in the Debian FTP archive:

dvb-dev_1.1.1-4_all.deb
  to pool/main/l/linuxtv-dvb/dvb-dev_1.1.1-4_all.deb
dvb-driver-source_1.1.1-4_all.deb
  to pool/main/l/linuxtv-dvb/dvb-driver-source_1.1.1-4_all.deb
linuxtv-dvb_1.1.1-4.diff.gz
  to pool/main/l/linuxtv-dvb/linuxtv-dvb_1.1.1-4.diff.gz
linuxtv-dvb_1.1.1-4.dsc
  to pool/main/l/linuxtv-dvb/linuxtv-dvb_1.1.1-4.dsc



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 276083@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Debian VDR Team <pkg-vdr-dvb-devel@lists.alioth.debian.org> (supplier of updated linuxtv-dvb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 16 Oct 2004 12:40:09 +0200
Source: linuxtv-dvb
Binary: dvb-dev dvb-driver-source
Architecture: source all
Version: 1.1.1-4
Distribution: unstable
Urgency: low
Maintainer: Debian VDR Team <pkg-vdr-dvb-devel@lists.alioth.debian.org>
Changed-By: Debian VDR Team <pkg-vdr-dvb-devel@lists.alioth.debian.org>
Description: 
 dvb-dev    - Dummy package for upgrade purposes only
 dvb-driver-source - sources for drivers for the Fujitsu Siemens DVB card
Closes: 276083
Changes: 
 linuxtv-dvb (1.1.1-4) unstable; urgency=low
 .
   * Thomas Schmidt <thomas.schmidt@in.stud.tu-ilmenau.de>
     - Added 11_budget_ci_loadkeys.dpatch, to add a /proc-entry for
       budget-ci-based-cards, to be able to programm keymaps for
       remotes on such cards, thanks to Darren Salt (closes: #276083)
     - Build-depend on dpatch (>= 2.0.9)
Files: 
 efe8336618f6f76aeebf6d292b9bfb9c 753 misc extra linuxtv-dvb_1.1.1-4.dsc
 6cbb58a3eecf8445d99560e9825f570f 10522 misc extra linuxtv-dvb_1.1.1-4.diff.gz
 829da0131e2e7246d654e485e7027ab2 5430 devel extra dvb-dev_1.1.1-4_all.deb
 4ed15ec9eee93b2b71afc3e1a8316aad 287774 misc extra dvb-driver-source_1.1.1-4_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBfKvggeVih7XOVJcRAtMlAKCG9SBM1HFNVBnwx5dr72s0GkbkogCeNlMB
WibpvGTqeVyCs93FD4HEOR8=
=ImrM
-----END PGP SIGNATURE-----