Bug#563084: vdr: Fix some dvd menu

[Tobias Grimm]

Hello!

matthieu castet wrote:

> The abi is broken because I add a member in dvdspu class ?

Yes.

> But dvdspu is only used by dvd plugin. Do you need to rebuild others ?

Technically not, but by the inofficial "VDR Packaging Policy" every ABI
change requires all plugins to be rebuilt. That's why VDR provides a
virtual package for each new ABI and plugins depend on it.

> If you want I can rework the patch to avoid that.

If that's possible without any drawbacks, this would be great.

> PS : I have done some debug with an other vdr user and :
> - this patch should be applied with
> http://article.gmane.org/gmane.linux.vdr/41531/match= patch

Does this work? Klaus seemed to be sceptical.

> - there is a missing Hide in Draw.

I think, I've seen this in the vdr 1.7.11. diff too.

> I will resend you a patch. Tell me if you want that I avoid breaking
> plugin API.

If it's possible to not break the ABI, please do so.

The KDE guys have put together a nice list of do's and don'ts:

http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++

bye,

Tobias

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-vdr-dvb-devel/attachments/20100115/22da427a/attachment.pgp>