[Bram@moolenaar.net: Re: Bug#329826: file locking, swap file names, and symlinks]

James Vega jamessan at jamessan.com
Sat Dec 3 16:41:07 UTC 2005


----- Forwarded message from Bram Moolenaar <Bram at moolenaar.net> -----

From: Bram Moolenaar <Bram at moolenaar.net>
To: James Vega <jamessan at jamessan.com>
Cc: pgk-vim-maintainers at lists.alioth.debian.org
Subject: Re: Bug#329826: file locking, swap file names, and symlinks
Date: Sat, 03 Dec 2005 16:09:31 +0100
X-Gmail-Received: 9a4656e739a3f2b1c8a6490d32b263cd00cc5a7c
X-MultiKabel-MailScanner-Information: Please contact helpdesk at quicknet.nl for more information
X-MultiKabel-MailScanner: Found to be clean
X-MultiKabel-MailScanner-SpamCheck: not spam
X-MultiKabel-MX-MailScanner-Information: Please contact helpdesk at quicknet.nl for more information
X-MultiKabel-MX-MailScanner: Found to be clean
X-MultiKabel-MX-MailScanner-SpamCheck: 
X-MailScanner-From: bram at moolenaar.net


James -

> On Mon, Oct 17, 2005 at 01:14:03PM +0200, Stefano Zacchiroli wrote:
> > On Sun, Oct 16, 2005 at 07:38:57PM +0200, Bram Moolenaar wrote:
> > > I thought this was already checked for, but now that I try I indeed see
> > > that there is no warning for editing the same file through a symbolic
> > > link.  I'll add a remark in the todo list.
> > 
> > In the meantime, here's a patch that fixes the misbehaviour on vim 6.4.
> 
> Attached is an updated patch which fixes the following bugs in the
> previous patch:
> 
>  - Relative paths for the symlink were not expanded, which could cause
>    an infinite loop of resolving the symlink or placing the swap file in
>    different directories based on the pwd when invoking Vim.
> 
>  - Handling of readlink's return code to determine whether a file was
>    resolved or an error occured.

Thanks.  Note that the f_resolve() function also has code to handle
symlinks.  It should probably be moved to a common function to avoid
duplication.

Another issue is not being able to write in the target directory.  Then
using the directory of the symlink might be an alternative.  I'll have
to think about that.

- Bram

-- 
Eight Megabytes And Continually Swapping.

 /// Bram Moolenaar -- Bram at Moolenaar.net -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://www.ICCF.nl         ///

----- End forwarded message -----


James
-- 
GPG Key: 1024D/61326D40 2003-09-02 James Vega <jamessan at jamessan.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-vim-maintainers/attachments/20051203/925f2296/attachment.pgp


More information about the pkg-vim-maintainers mailing list