[Pkg-virtualbox-devel] Bug#474195: virtualbox-ose: Don't fail in vboxadd init script, if the module cannot get loaded

Daniel Hahler debian-bugs at thequod.de
Fri Apr 4 01:39:23 UTC 2008


Package: virtualbox-ose
Version: 1.5.6-dfsg-4
Severity: important
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu hardy ubuntu-patch

Because the virtualbox-ose-guest-utils package does not depend on the
vboxadd kernel module, its init script should not fail, if the module
cannot get loaded.

Please use "exit 0" instead of "exit 1", otherwise upgrades/installs
will fail.
Even if the package would depend on the kernel module, it should
probably still not cause the package not being installable.


*** /tmp/tmpUcXytA
In Ubuntu, we've applied the attached patch to achieve the following:

  * debian/virtualbox-ose-guest-utils.init: "exit 0" in case the module
    cannot be loaded

We thought you might be interested in doing the same. 
-------------- next part --------------
diff -u virtualbox-ose-1.5.6-dfsg/debian/virtualbox-ose-guest-utils.init virtualbox-ose-1.5.6-dfsg/debian/virtualbox-ose-guest-utils.init
--- virtualbox-ose-1.5.6-dfsg/debian/virtualbox-ose-guest-utils.init
+++ virtualbox-ose-1.5.6-dfsg/debian/virtualbox-ose-guest-utils.init
@@ -35,7 +35,7 @@
 		# vboxadd not installed, or has a problem
 		log_failure_msg 'cannot modprobe vboxadd kernel module';
 		log_end_msg 1
-		exit 1
+		exit 0
 	fi
 
 	start-stop-daemon --start --quiet --exec /usr/sbin/vboxadd-timesync -- --daemonize


More information about the Pkg-virtualbox-devel mailing list