kiax 0.8.51 - please review & upload

[George Danchev]

On Sunday 25 June 2006 14:28, Santiago Garcia Mantinan wrote:
> Hi!
>
> I'm back from the USA and I've been looking at our kiax echo cancellation
> problem a bit..

Hello, welcome back ;-)

> > I'm not sure if our iaxclient 0.0+svn20060520 source package has the
> > adequate support for Echo Cancellation (as implemented by Tipic) in its
> > lib/libspeex/mdf.c or we are supposed to have that functionality from the
> > separate speex package itselt... ? Any explanations welcome ;-)
>
> For what I see if we allow the user to set echo cancellation we get a
> segfault, so... it is not that the filter is not working but that kiax
> segfaults when using it.

Confirmed.

> The stuff that dials with the filters is mainly this at iaxwrapper.cpp:
>
>   int flag = settings->getFilterFlag();
>   debug( func+" filter flag=%d\n",flag);
>   iaxc_set_filters(flag);

That code is fine.

> I can read on my tests a filter flag of 15 prior to the segfault, now...
> I'd like to know why it is segfaulting, I mean, I would expect it not to
> work well, but not to segfault, I don't know why this happens, could this
> be that kiax is only implemented to use the echo cancellation of it's
> modified nonfree stuff?

Right, that is the case here. I think the problem is at our libspeex packages, 
e.g. if you diff mdf.c implementations kiax has and our libspeex has, you 
will find at least one different expectation in speex_echo_cancel function 
(last argument):

kiax-0.8.51-src/lib/libspeex/mdf.c:speex_echo_cancel
/** Performs echo cancellation on a frame */
void speex_echo_cancel(SpeexEchoState *st, short *ref, short *echo, short 
*out, float *Yout)
{

speex-1.1.12/libspeex/mdf.c:speex_echo_cancel
/** Performs echo cancellation on a frame */
void speex_echo_cancel(SpeexEchoState *st, short *ref, short *echo, short 
*out, spx_int32_t *Yout)
{

I'm still not sure if this will be enough to fix that out, but will give it a 
try at some point.

-- 
pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>
fingerprint 1AE7 7C66 0A26 5BFF DF22 5D55 1C57 0C89 0E4B D0AB