Bug#368145: pciradio.c:1810: error: syntax error before string constant

Tzafrir Cohen tzafrir.cohen at xorcom.com
Sun May 21 05:47:02 UTC 2006


On Sat, May 20, 2006 at 11:19:58PM +0200, Stephan Seitz wrote:
> On Sat, May 20, 2006 at 11:05:43PM +0300, Tzafrir Cohen wrote:
> >+#ifdef LINUX26
> >+module_param(debug, int, 0600);
> >+#else
> >MODULE_PARM(debug, "i");
> >-MODULE_DESCRIPTION("Zapate Telephony PCI Radio Card Zaptel Driver");
> >+#endif
> 
> I’m not sure. Doesn’t LINUX26 only match kernels 2.6? IMHO you need to 
> distinguish between kernel 2.6.17 and < 2.6.16 and 2.4.

The new format was added at 2.6 . The old format has probably only been
depracated now. Take a look at, e.g, wctdm.c .

> 
> And
> #include <linux/moduleparam.h>
> must be included as well with the same conditionals.

I'll try to check it with 2.6.17 later on...

-- 
Tzafrir Cohen      sip:tzafrir at local.xorcom.com
icq#16849755       iax:tzafrir at local.xorcom.com
+972-50-7952406           
tzafrir.cohen at xorcom.com  http://www.xorcom.com



More information about the Pkg-voip-maintainers mailing list