Bug#454488: gnugk: use of adduser in preinst without pre-depends

[Steve Langasek]

Package: gnugk
Version: 2:2.2.6-2
Severity: serious

Current versions of gnugk are doing something very bizarre in the maintainer
scripts.  You seem to have merged the postinst and preinst into a single
script, which makes no sense at all since there's no overlapping behavior
between the two; and in the process, you're calling adduser from the preinst
but don't pre-depend on adduser, which is a policy violation, and doesn't
seem to belong in the preinst anyway since it's not needed as a prerequisite
for unpacking the package.

And you've dropped support for several of the values of $1 that are valid
under policy (abort-remove and abort-deconfigure), which means that if
either of these operations ever fail your package gets to be in an unclean
state for no good reason.

And of course, there's the fact that you're using the #DEBHELPER# token,
which is only going to do the right thing for one of postinst or preinst,
since it can't contain correct values for both scripts at the same time (bug
#454259).

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org