Bug#513893: kphone: TCP only SRV doesn't work

[anoop]

Package: kphone
Version: 1:4.2-6
Severity: normal


I had NAPTR with just _sip._tcp.x.x . The way kphone calls SipClient::getResSearch(...) from SipClient::getNAPTR(...) will 
never result in this record being found without the following patch - unless I'm missing something. The patch could very 
well introduce other bugs - I haven't tested it against DNS config with both tcp and udp SRV. But the point is that the way 
getResSearch() gets called from getNAPTR(), it will never find the tcp NAPTR and subsequently the tcp SRV.

I'm not sure if this is related to bug number #367408.

patch follows:
---------------------------
--- dissipate2/sipclient.cpp.~1.5.~	2005-07-04 03:03:07.000000000 -0500
+++ dissipate2/sipclient.cpp	2009-02-02 00:29:50.000000000 -0600
@@ -1524,16 +1524,14 @@
 						break;
 					} else {
 						tmpName = QString( name );
-						if( UDP ) {
 							if( tmpName.contains( "_udp" ) ) {
 								domainName = QString( name );
 							}
-						} else {
-							if( tmpName.contains( "_tcp" ) ) {
+						else if( tmpName.contains( "_tcp" ) ) {
 								domainName = QString( name );
 							}
-						}
 						printf("NAPTR: %s\n",name);
+
 						xptr+=j;
 					}
 				} else if( ty == T_SRV ) {
---------------------------

-- System Information:
Debian Release: 5.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages kphone depends on:
ii  libasound2                 1.0.16-2      ALSA library
ii  libc6                      2.7-18        GNU C Library: Shared libraries
ii  libgcc1                    1:4.3.2-1.1   GCC support library
ii  libice6                    2:1.0.4-1     X11 Inter-Client Exchange library
ii  libjack0.100.0-0           0.109.2-5     JACK Audio Connection Kit (librari
ii  libpng12-0                 1.2.27-2      PNG library - runtime
ii  libqt3-mt                  3:3.3.8b-5+b1 Qt GUI Library (Threaded runtime v
ii  libsm6                     2:1.0.3-2     X11 Session Management library
ii  libssl0.9.8                0.9.8g-15     SSL shared libraries
ii  libstdc++6                 4.3.2-1.1     The GNU Standard C++ Library v3
ii  libx11-6                   2:1.1.5-2     X11 client-side library
ii  libxext6                   2:1.0.4-1     X11 miscellaneous extension librar
ii  libxt6                     1:1.0.5-3     X11 toolkit intrinsics library

kphone recommends no packages.

kphone suggests no packages.

-- no debconf information