<html><head><meta name="qrichtext" content="1" /></head><body style="font-size:9pt;font-family:Sans Serif">
<p>Jan,</p>
<p></p>
<p>Are you able to address Steve's comments below?</p>
<p></p>
<p>Thanks,</p>
<p>Mark</p>
<p></p>
<p>---------- Forwarded Message ----------</p>
<p></p>
<p>Subject: Re: unfreeze request - radiusclient-<span style="color:#ff0000">ng</span> (0.5.5-1)</p>
<p>Date: Saturday 10 February 2007 01:22</p>
<p>From: Steve <span style="color:#ff0000">Langasek</span> <<span style="color:#ff0000">vorlon</span>@<span style="color:#ff0000">debian</span>.org></p>
<p>To: Mark Purcell <<span style="color:#ff0000">msp</span>@<span style="color:#ff0000">debian</span>.org></p>
<p>Cc: <span style="color:#ff0000">debian</span>-release@lists.<span style="color:#ff0000">debian</span>.org, radiusclient-<span style="color:#ff0000">ng</span>@packages.<span style="color:#ff0000">debian</span>.org</p>
<p></p>
<p>On Tue, Feb 06, 2007 at 11:04:36PM +0000, Mark Purcell wrote:</p>
<p><span style="color:#008000">> This unfreeze request is purely an upstream bug fix for 64-bit</span></p>
<p><span style="color:#008000">> architectures.</span></p>
<p></p>
<p>Well, no, it isn't.</p>
<p></p>
<p><span style="color:#008000">> diff -Nru /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/include/radiusclient-ng.h</span></p>
<p><span style="color:#008000">> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/include/radiusclient-ng.h ---</span></p>
<p><span style="color:#008000">> /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/include/radiusclient-ng.h </span></p>
<p><span style="color:#008000">> 2005-07-21 09:01:07.000000000 +0100 +++</span></p>
<p><span style="color:#008000">> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/include/radiusclient-ng.h </span></p>
<p><span style="color:#008000">> 2006-05-17 19:14:35.000000000 +0100</span></p>
<p></p>
<p><snip></p>
<p></p>
<p>This part is a 64-bit fix, sure.</p>
<p></p>
<p><span style="color:#008000">> diff -Nru /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/lib/avpair.c</span></p>
<p><span style="color:#008000">> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/lib/avpair.c ---</span></p>
<p><span style="color:#008000">> /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/lib/avpair.c 2005-04-01</span></p>
<p><span style="color:#008000">> 02:33:10.000000000 +0100 +++</span></p>
<p><span style="color:#008000">> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/lib/avpair.c 2006-05-30</span></p>
<p><span style="color:#008000">> 20:18:03.000000000 +0100</span></p>
<p></p>
<p><snip></p>
<p></p>
<p>This part is not. It's probably a legitimate bugfix, but it's completely</p>
<p>undocumented, upstream or otherwise. I'm not going to <span style="color:#ff0000">ok</span> updates that</p>
<p>include undocumented changes I can't understand (and I've done enough RADIUS</p>
<p>to be wary of assuming the correctness of any patch based just on the local</p>
<p>diff context).</p>
<p></p>
<p><span style="color:#008000">> diff -Nru /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/lib/sendserver.c</span></p>
<p><span style="color:#008000">> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/lib/sendserver.c ---</span></p>
<p><span style="color:#008000">> /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/lib/sendserver.c 2005-07-21</span></p>
<p><span style="color:#008000">> 09:01:07.000000000 +0100 +++</span></p>
<p><span style="color:#008000">> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/lib/sendserver.c 2006-07-05</span></p>
<p><span style="color:#008000">> 01:27:54.000000000 +0100</span></p>
<p></p>
<p><snip> Also doesn't appear to include any 64-bit fixes. (the type change of</p>
<p><span style="color:#ff0000">salen</span> might be, but hard to say given that the effects of the change are</p>
<p>non-local and there's no real documentation in the changelog...)</p>
<p></p>
<p><span style="color:#008000">> diff -Nru /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/src/radiusclient.c</span></p>
<p><span style="color:#008000">> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/src/radiusclient.c ---</span></p>
<p><span style="color:#008000">> /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/src/radiusclient.c 2005-03-01</span></p>
<p><span style="color:#008000">> 14:58:44.000000000 +0000 +++</span></p>
<p><span style="color:#008000">> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/src/radiusclient.c 2006-04-04</span></p>
<p><span style="color:#008000">> 21:52:04.000000000 +0100</span></p>
<p></p>
<p><snip></p>
<p></p>
<p>Another maybe, maybe-not 64-bit fix.</p>
<p></p>
<p>It's certainly RC to make sure any packages we're shipping on 64-bit <span style="color:#ff0000">archs</span></p>
<p>are actually usable there, so you're welcome to isolate the 64-bit fixes and</p>
<p>upload to testing-proposed-updates with just those changes. Otherwise,</p>
<p>you can try to get upstream to give an explanation for each of these</p>
<p>changes and I'll take another look.</p>
<p></p>
<p>Thanks,</p>
<p>--</p>
<p>Steve <span style="color:#ff0000">Langasek</span> Give me a lever long enough and a Free OS</p>
<p>Debian Developer to set it on, and I can move the world.</p>
<p><span style="color:#ff0000">vorlon</span>@<span style="color:#ff0000">debian</span>.org <span style="color:#ff0000">http</span>://<span style="color:#ff0000">www</span>.<span style="color:#ff0000">debian</span>.org/</p>
<p></p>
<p>-------------------------------------------------------</p>
<p></p>
</body></html>