[Pkg-vsquare-devel] Bug#460734: vde2: poor error handling

[graziano]

Package: vde2
Version: 2.1.6+r154-1+b1
Followup-For: Bug #460734

Hello again,

I have more information for this 'bug'. Well, it's actually not the bug I
thought, since the error is due to poor error hadnling. In my
experimentations with the package, the command line I used to use was
wrong, hence the Bus error. Looking at the source code it looks like the
main problems are because a lot of error checking (even as innocent as
File not found) is not done, hence carrying around NULL pointers. In
particular the problem was after vde_open in slirpvde.c (around line 429)
which doesn't check if the open was succesful, and after vde_datafd
(around line 443) where the return value is not check (in this case the
previous open failed).

Anyway, I think the error should be downgrade to wishlist of something
like that.

thanks
graziano


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24-rc7 (SMP w/2 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/bash

Versions of packages vde2 depends on:
ii  adduser                  3.105           add and remove users and groups
ii  libc6                    2.7-6           GNU C Library: Shared libraries
ii  libvdeplug2              2.1.6+r154-1+b1 Virtual Distributed Ethernet - Plu

Versions of packages vde2 recommends:
ii  daemon                        0.6.3-1    turns other processes into daemons

-- no debconf information