[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
pfeldman at chromium.org
pfeldman at chromium.org
Thu Oct 29 20:43:44 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit b13d607a4913c666a88953b7c9dcb438bb545a30
Author: pfeldman at chromium.org <pfeldman at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Oct 13 08:28:45 2009 +0000
2009-10-12 Pavel Feldman <pfeldman at chromium.org>
Reviewed by Adam Roben.
Web Inspector: Use proper web view in inspector layout
tests for windows.
https://bugs.webkit.org/show_bug.cgi?id=30298
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::showWebInspector):
(LayoutTestController::closeWebInspector):
(LayoutTestController::evaluateInWebInspector):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index e8296aa..55b8782 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,17 @@
+2009-10-12 Pavel Feldman <pfeldman at chromium.org>
+
+ Reviewed by Adam Roben.
+
+ Web Inspector: Use proper web view in inspector layout
+ tests for windows.
+
+ https://bugs.webkit.org/show_bug.cgi?id=30298
+
+ * DumpRenderTree/win/LayoutTestControllerWin.cpp:
+ (LayoutTestController::showWebInspector):
+ (LayoutTestController::closeWebInspector):
+ (LayoutTestController::evaluateInWebInspector):
+
2009-10-12 Fumitoshi Ukai <ukai at chromium.org>
Reviewed by Sam Weinig.
diff --git a/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp b/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp
index e9338ce..a230fb0 100644
--- a/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp
+++ b/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp
@@ -876,34 +876,46 @@ void LayoutTestController::addUserStyleSheet(JSStringRef source)
void LayoutTestController::showWebInspector()
{
- COMPtr<IWebViewPrivate> webView;
- if (FAILED(WebKitCreateInstance(__uuidof(WebView), 0, __uuidof(webView), reinterpret_cast<void**>(&webView))))
+ COMPtr<IWebView> webView;
+ if (FAILED(frame->webView(&webView)))
+ return;
+
+ COMPtr<IWebViewPrivate> viewPrivate(Query, webView);
+ if (!viewPrivate)
return;
COMPtr<IWebInspector> inspector;
- if (SUCCEEDED(webView->inspector(&inspector)))
+ if (SUCCEEDED(viewPrivate->inspector(&inspector)))
inspector->show();
}
void LayoutTestController::closeWebInspector()
{
- COMPtr<IWebViewPrivate> webView;
- if (FAILED(WebKitCreateInstance(__uuidof(WebView), 0, __uuidof(webView), reinterpret_cast<void**>(&webView))))
+ COMPtr<IWebView> webView;
+ if (FAILED(frame->webView(&webView)))
+ return;
+
+ COMPtr<IWebViewPrivate> viewPrivate(Query, webView);
+ if (!viewPrivate)
return;
COMPtr<IWebInspector> inspector;
- if (SUCCEEDED(webView->inspector(&inspector)))
+ if (SUCCEEDED(viewPrivate->inspector(&inspector)))
inspector->close();
}
void LayoutTestController::evaluateInWebInspector(long callId, JSStringRef script)
{
- COMPtr<IWebViewPrivate> webView;
- if (FAILED(WebKitCreateInstance(__uuidof(WebView), 0, __uuidof(webView), reinterpret_cast<void**>(&webView))))
+ COMPtr<IWebView> webView;
+ if (FAILED(frame->webView(&webView)))
+ return;
+
+ COMPtr<IWebViewPrivate> viewPrivate(Query, webView);
+ if (!viewPrivate)
return;
COMPtr<IWebInspector> inspector;
- if (FAILED(webView->inspector(&inspector)))
+ if (FAILED(viewPrivate->inspector(&inspector)))
return;
COMPtr<IWebInspectorPrivate> inspectorPrivate(Query, inspector);
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list