[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
simon.fraser at apple.com
simon.fraser at apple.com
Thu Oct 29 20:46:13 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 09cfc1310c868f88a24304c1806036d9017dc067
Author: simon.fraser at apple.com <simon.fraser at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Oct 16 20:28:08 2009 +0000
2009-10-16 Simon Fraser <simon.fraser at apple.com>
Reviewed by Eric Carlson.
Transform transitions that used to be accelerated are no longer so
https://bugs.webkit.org/show_bug.cgi?id=30453
The change in r49633, to not run accelerated animations/transitions on layers that
are not attached, broke accelerated transitions/animations in many cases where they start
as soon as the page loads. This change reverts the code that tests for the GraphicsLayer being
attached.
No test, because it's not possible from a test to know whether a transition is accelerated or not.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 1997b3b..44c93c5 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,21 @@
+2009-10-16 Simon Fraser <simon.fraser at apple.com>
+
+ Reviewed by Eric Carlson.
+
+ Transform transitions that used to be accelerated are no longer so
+ https://bugs.webkit.org/show_bug.cgi?id=30453
+
+ The change in r49633, to not run accelerated animations/transitions on layers that
+ are not attached, broke accelerated transitions/animations in many cases where they start
+ as soon as the page loads. This change reverts the code that tests for the GraphicsLayer being
+ attached.
+
+ No test, because it's not possible from a test to know whether a transition is accelerated or not.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::startAnimation):
+ (WebCore::RenderLayerBacking::startTransition):
+
2009-10-16 Kevin Ollivier <kevino at theolliviers.com>
wxMSW build fix, build the MSW source to get methods that use the MSW version of
diff --git a/WebCore/rendering/RenderLayerBacking.cpp b/WebCore/rendering/RenderLayerBacking.cpp
index bf58a2e..50e4756 100644
--- a/WebCore/rendering/RenderLayerBacking.cpp
+++ b/WebCore/rendering/RenderLayerBacking.cpp
@@ -1034,10 +1034,6 @@ bool RenderLayerBacking::startAnimation(double beginTime, const Animation* anim,
if (!hasOpacity && !hasTransform)
return false;
- // Don't start animations if we're not rooted, because we won't get the callback that the animation started.
- if (!m_graphicsLayer->hasAncestor(compositor()->rootPlatformLayer()))
- return false;
-
KeyframeValueList transformVector(AnimatedPropertyWebkitTransform);
KeyframeValueList opacityVector(AnimatedPropertyOpacity);
@@ -1079,10 +1075,6 @@ bool RenderLayerBacking::startTransition(double beginTime, int property, const R
bool didAnimate = false;
ASSERT(property != cAnimateAll);
- // Don't start animations if we're not rooted, because we won't get the callback that the animation started.
- if (!m_graphicsLayer->hasAncestor(compositor()->rootPlatformLayer()))
- return false;
-
if (property == (int)CSSPropertyOpacity) {
const Animation* opacityAnim = toStyle->transitionForProperty(CSSPropertyOpacity);
if (opacityAnim && !opacityAnim->isEmptyOrZeroDuration()) {
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list