[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
eric at webkit.org
eric at webkit.org
Thu Oct 29 20:46:15 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 96efcb24e454b0d8b1de59e70a8978d33907148e
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Oct 16 20:56:51 2009 +0000
2009-10-16 Andrew Scherkus <scherkus at chromium.org>
Reviewed by Eric Seidel.
Fix Chromium media controls to render a disabled play button when the element is unintialized.
https://bugs.webkit.org/show_bug.cgi?id=30410
Covered by existing layout tests.
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaPlayButton): Include check for NETWORK_EMPTY to render disabled play button.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 3d44f34..5b30826 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2009-10-16 Andrew Scherkus <scherkus at chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Fix Chromium media controls to render a disabled play button when the element is unintialized.
+
+ https://bugs.webkit.org/show_bug.cgi?id=30410
+
+ Covered by existing layout tests.
+
+ * rendering/RenderMediaControlsChromium.cpp:
+ (WebCore::paintMediaPlayButton): Include check for NETWORK_EMPTY to render disabled play button.
+
2009-10-16 Oliver Hunt <oliver at apple.com>
Reviewed by Gavin Barraclough.
diff --git a/WebCore/rendering/RenderMediaControlsChromium.cpp b/WebCore/rendering/RenderMediaControlsChromium.cpp
index bba2fa2..1847aad 100644
--- a/WebCore/rendering/RenderMediaControlsChromium.cpp
+++ b/WebCore/rendering/RenderMediaControlsChromium.cpp
@@ -91,7 +91,8 @@ static bool paintMediaPlayButton(RenderObject* object, const RenderObject::Paint
static Image* mediaPause = platformResource("mediaPause");
static Image* mediaPlayDisabled = platformResource("mediaPlayDisabled");
- if (mediaElement->networkState() == HTMLMediaElement::NETWORK_NO_SOURCE)
+ if (mediaElement->networkState() == HTMLMediaElement::NETWORK_EMPTY ||
+ mediaElement->networkState() == HTMLMediaElement::NETWORK_NO_SOURCE)
return paintMediaButton(paintInfo.context, rect, mediaPlayDisabled);
return paintMediaButton(paintInfo.context, rect, mediaElement->paused() ? mediaPlay : mediaPause);
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list