[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

darin darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 06:39:42 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 0f425084fd286624c52c72547aafb9512faec04a
Author: darin <darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Sep 18 16:15:42 2002 +0000

    	- fixed 3027470 -- hitting tab when the google.com text field is selected
    	(all bars hidden) makes border flash
    
            * kwq/KWQNSTextField.mm:
            (-[KWQNSTextField textDidEndEditing:]): Added. Don't call super when the next
    	valid key view is nil.
            (-[KWQSecureTextField textDidEndEditing:]): Ditto. Too bad we can't share code
    	here. Maybe I'll figure out a way later.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2002-12-03 b/WebCore/ChangeLog-2002-12-03
index bfa9e61..00e8004 100644
--- a/WebCore/ChangeLog-2002-12-03
+++ b/WebCore/ChangeLog-2002-12-03
@@ -1,3 +1,14 @@
+2002-09-18  Darin Adler  <darin at apple.com>
+
+	- fixed 3027470 -- hitting tab when the google.com text field is selected
+	(all bars hidden) makes border flash
+
+        * kwq/KWQNSTextField.mm:
+        (-[KWQNSTextField textDidEndEditing:]): Added. Don't call super when the next
+	valid key view is nil.
+        (-[KWQSecureTextField textDidEndEditing:]): Ditto. Too bad we can't share code
+	here. Maybe I'll figure out a way later.
+
 2002-09-17  Darin Adler  <darin at apple.com>
 
 	- fixed 3025022 -- Crash in KWQKHTMLPartImpl::redirectionTimerStartedOrStopped()
diff --git a/WebCore/ChangeLog-2003-10-25 b/WebCore/ChangeLog-2003-10-25
index bfa9e61..00e8004 100644
--- a/WebCore/ChangeLog-2003-10-25
+++ b/WebCore/ChangeLog-2003-10-25
@@ -1,3 +1,14 @@
+2002-09-18  Darin Adler  <darin at apple.com>
+
+	- fixed 3027470 -- hitting tab when the google.com text field is selected
+	(all bars hidden) makes border flash
+
+        * kwq/KWQNSTextField.mm:
+        (-[KWQNSTextField textDidEndEditing:]): Added. Don't call super when the next
+	valid key view is nil.
+        (-[KWQSecureTextField textDidEndEditing:]): Ditto. Too bad we can't share code
+	here. Maybe I'll figure out a way later.
+
 2002-09-17  Darin Adler  <darin at apple.com>
 
 	- fixed 3025022 -- Crash in KWQKHTMLPartImpl::redirectionTimerStartedOrStopped()
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index bfa9e61..00e8004 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,14 @@
+2002-09-18  Darin Adler  <darin at apple.com>
+
+	- fixed 3027470 -- hitting tab when the google.com text field is selected
+	(all bars hidden) makes border flash
+
+        * kwq/KWQNSTextField.mm:
+        (-[KWQNSTextField textDidEndEditing:]): Added. Don't call super when the next
+	valid key view is nil.
+        (-[KWQSecureTextField textDidEndEditing:]): Ditto. Too bad we can't share code
+	here. Maybe I'll figure out a way later.
+
 2002-09-17  Darin Adler  <darin at apple.com>
 
 	- fixed 3025022 -- Crash in KWQKHTMLPartImpl::redirectionTimerStartedOrStopped()
diff --git a/WebCore/kwq/KWQNSTextField.mm b/WebCore/kwq/KWQNSTextField.mm
index cb2b545..af4735c 100644
--- a/WebCore/kwq/KWQNSTextField.mm
+++ b/WebCore/kwq/KWQNSTextField.mm
@@ -190,7 +190,7 @@
 - (void)setMaximumLength:(int)len
 {
     NSString *oldValue = [self stringValue];
-    if ((int)[oldValue length] > len){
+    if ((int)[oldValue length] > len) {
         [self setStringValue:[oldValue substringToIndex:len]];
     }
     [formatter setMaximumLength:len];
@@ -273,6 +273,30 @@
     return [super becomeFirstResponder];
 }
 
+- (void)textDidEndEditing:(NSNotification *)notification
+{
+    // If we are tabbing nowhere, we don't want to flash as we deselect and reselect.
+    // So we handle those cases here and don't call super.
+    switch ([[[notification userInfo] objectForKey:@"NSTextMovement"] intValue]) {
+        case NSTabTextMovement:
+            if (![self nextValidKeyView]) {
+                [self selectText:self];
+                [self _KWQ_scrollFrameToVisible];
+                return;
+            }
+            break;
+        case NSBacktabTextMovement:
+            if (![self previousValidKeyView]) {
+                [self selectText:self];
+                [self _KWQ_scrollFrameToVisible];
+                return;
+            }
+            break;
+    }
+    
+    [super textDidEndEditing:notification];
+}
+
 @end
 
 // This cell is used so that our frame includes the place where the focus rectangle is drawn.
@@ -421,4 +445,28 @@
     return [super becomeFirstResponder];
 }
 
+- (void)textDidEndEditing:(NSNotification *)notification
+{
+    // If we are tabbing nowhere, we don't want to flash as we deselect and reselect.
+    // So we handle those cases here and don't call super.
+    switch ([[[notification userInfo] objectForKey:@"NSTextMovement"] intValue]) {
+        case NSTabTextMovement:
+            if (![self nextValidKeyView]) {
+                [self selectText:self];
+                [self _KWQ_scrollFrameToVisible];
+                return;
+            }
+            break;
+        case NSBacktabTextMovement:
+            if (![self previousValidKeyView]) {
+                [self selectText:self];
+                [self _KWQ_scrollFrameToVisible];
+                return;
+            }
+            break;
+    }
+    
+    [super textDidEndEditing:notification];
+}
+
 @end
diff --git a/WebCore/kwq/KWQTextField.mm b/WebCore/kwq/KWQTextField.mm
index cb2b545..af4735c 100644
--- a/WebCore/kwq/KWQTextField.mm
+++ b/WebCore/kwq/KWQTextField.mm
@@ -190,7 +190,7 @@
 - (void)setMaximumLength:(int)len
 {
     NSString *oldValue = [self stringValue];
-    if ((int)[oldValue length] > len){
+    if ((int)[oldValue length] > len) {
         [self setStringValue:[oldValue substringToIndex:len]];
     }
     [formatter setMaximumLength:len];
@@ -273,6 +273,30 @@
     return [super becomeFirstResponder];
 }
 
+- (void)textDidEndEditing:(NSNotification *)notification
+{
+    // If we are tabbing nowhere, we don't want to flash as we deselect and reselect.
+    // So we handle those cases here and don't call super.
+    switch ([[[notification userInfo] objectForKey:@"NSTextMovement"] intValue]) {
+        case NSTabTextMovement:
+            if (![self nextValidKeyView]) {
+                [self selectText:self];
+                [self _KWQ_scrollFrameToVisible];
+                return;
+            }
+            break;
+        case NSBacktabTextMovement:
+            if (![self previousValidKeyView]) {
+                [self selectText:self];
+                [self _KWQ_scrollFrameToVisible];
+                return;
+            }
+            break;
+    }
+    
+    [super textDidEndEditing:notification];
+}
+
 @end
 
 // This cell is used so that our frame includes the place where the focus rectangle is drawn.
@@ -421,4 +445,28 @@
     return [super becomeFirstResponder];
 }
 
+- (void)textDidEndEditing:(NSNotification *)notification
+{
+    // If we are tabbing nowhere, we don't want to flash as we deselect and reselect.
+    // So we handle those cases here and don't call super.
+    switch ([[[notification userInfo] objectForKey:@"NSTextMovement"] intValue]) {
+        case NSTabTextMovement:
+            if (![self nextValidKeyView]) {
+                [self selectText:self];
+                [self _KWQ_scrollFrameToVisible];
+                return;
+            }
+            break;
+        case NSBacktabTextMovement:
+            if (![self previousValidKeyView]) {
+                [self selectText:self];
+                [self _KWQ_scrollFrameToVisible];
+                return;
+            }
+            break;
+    }
+    
+    [super textDidEndEditing:notification];
+}
+
 @end

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list