[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677
darin
darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 06:55:44 UTC 2009
The following commit has been merged in the debian/unstable branch:
commit e03cf1ebc4c7616f77bb17cbb507dab1a58cfd6d
Author: darin <darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Oct 29 01:18:17 2002 +0000
WebFoundation:
- fixed storage leak of WebFileDatabaseOp objects
* Database.subproj/WebFileDatabase.m:
(-[WebFileDatabase setObject:forKey:]): Release op so it doesn't leak.
(-[WebFileDatabase removeObjectForKey:]): Release op so it doesn't leak.
(-[WebFileDatabase lazySync:]): Retain op before removing it from the list,
since we want to work with it a bit before releasing it.
WebCore:
- fixed storage leak of items in QListBox
* kwq/KWQListBox.h: Added private deleteItems method.
* kwq/KWQListBox.mm:
(QListBox::~QListBox): Call deleteItems().
(QListBox::deleteItems): Move the code to delete all the items
here from clear(), since clear() is not called on destruction.
(QListBox::clear): Call deleteItems().
WebKit:
- fixed storage leak of WebNetscapePluginPackage objects
* Plugins.subproj/WebBasePluginPackage.m:
(+[WebBasePluginPackage pluginWithPath:]): Add missing autorelease.
* Plugins.subproj/WebBasePluginPackage.h:
* Plugins.subproj/WebPluginController.h:
* Plugins.subproj/WebPluginController.m:
* Plugins.subproj/WebPluginPackage.h:
* Plugins.subproj/WebPluginPackage.m:
Not __MyCompanyName__, but rather Apple Computer.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog-2002-12-03 b/WebCore/ChangeLog-2002-12-03
index 91497ac..6528247 100644
--- a/WebCore/ChangeLog-2002-12-03
+++ b/WebCore/ChangeLog-2002-12-03
@@ -1,3 +1,14 @@
+2002-10-28 Darin Adler <darin at apple.com>
+
+ - fixed storage leak of items in QListBox
+
+ * kwq/KWQListBox.h: Added private deleteItems method.
+ * kwq/KWQListBox.mm:
+ (QListBox::~QListBox): Call deleteItems().
+ (QListBox::deleteItems): Move the code to delete all the items
+ here from clear(), since clear() is not called on destruction.
+ (QListBox::clear): Call deleteItems().
+
2002-10-28 Chris Blumenberg <cblu at apple.com>
Lowercase the text encoding name.
diff --git a/WebCore/ChangeLog-2003-10-25 b/WebCore/ChangeLog-2003-10-25
index 91497ac..6528247 100644
--- a/WebCore/ChangeLog-2003-10-25
+++ b/WebCore/ChangeLog-2003-10-25
@@ -1,3 +1,14 @@
+2002-10-28 Darin Adler <darin at apple.com>
+
+ - fixed storage leak of items in QListBox
+
+ * kwq/KWQListBox.h: Added private deleteItems method.
+ * kwq/KWQListBox.mm:
+ (QListBox::~QListBox): Call deleteItems().
+ (QListBox::deleteItems): Move the code to delete all the items
+ here from clear(), since clear() is not called on destruction.
+ (QListBox::clear): Call deleteItems().
+
2002-10-28 Chris Blumenberg <cblu at apple.com>
Lowercase the text encoding name.
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 91497ac..6528247 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,14 @@
+2002-10-28 Darin Adler <darin at apple.com>
+
+ - fixed storage leak of items in QListBox
+
+ * kwq/KWQListBox.h: Added private deleteItems method.
+ * kwq/KWQListBox.mm:
+ (QListBox::~QListBox): Call deleteItems().
+ (QListBox::deleteItems): Move the code to delete all the items
+ here from clear(), since clear() is not called on destruction.
+ (QListBox::clear): Call deleteItems().
+
2002-10-28 Chris Blumenberg <cblu at apple.com>
Lowercase the text encoding name.
diff --git a/WebCore/kwq/KWQListBox.h b/WebCore/kwq/KWQListBox.h
index c84ea81..8e4dc89 100644
--- a/WebCore/kwq/KWQListBox.h
+++ b/WebCore/kwq/KWQListBox.h
@@ -59,6 +59,8 @@ public:
void selectionChanged() { _selectionChanged.call(); }
private:
+ void deleteItems();
+
QListBoxItem *_head;
bool _insertingItems;
diff --git a/WebCore/kwq/KWQListBox.mm b/WebCore/kwq/KWQListBox.mm
index 9991e30..480794b 100644
--- a/WebCore/kwq/KWQListBox.mm
+++ b/WebCore/kwq/KWQListBox.mm
@@ -109,6 +109,7 @@ QListBox::~QListBox()
KWQBrowserDelegate *delegate = [browser delegate];
[browser setDelegate:nil];
[delegate release];
+ deleteItems();
}
uint QListBox::count() const
@@ -120,7 +121,7 @@ uint QListBox::count() const
return count;
}
-void QListBox::clear()
+void QListBox::deleteItems()
{
QListBoxItem *next;
for (QListBoxItem *item = _head; item; item = next) {
@@ -128,7 +129,11 @@ void QListBox::clear()
delete item;
}
_head = 0;
-
+}
+
+void QListBox::clear()
+{
+ deleteItems();
NSBrowser *browser = (NSBrowser *)getView();
[browser loadColumnZero];
}
diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index 5fe0849..6cd907f 100644
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,5 +1,19 @@
2002-10-28 Darin Adler <darin at apple.com>
+ - fixed storage leak of WebNetscapePluginPackage objects
+
+ * Plugins.subproj/WebBasePluginPackage.m:
+ (+[WebBasePluginPackage pluginWithPath:]): Add missing autorelease.
+
+ * Plugins.subproj/WebBasePluginPackage.h:
+ * Plugins.subproj/WebPluginController.h:
+ * Plugins.subproj/WebPluginController.m:
+ * Plugins.subproj/WebPluginPackage.h:
+ * Plugins.subproj/WebPluginPackage.m:
+ Not __MyCompanyName__, but rather Apple Computer.
+
+2002-10-28 Darin Adler <darin at apple.com>
+
- fixed bug that caused us to leak all WebResourceHandles used for subresources
* WebCoreSupport.subproj/WebSubresourceClient.m:
diff --git a/WebKit/ChangeLog-2002-12-03 b/WebKit/ChangeLog-2002-12-03
index 5fe0849..6cd907f 100644
--- a/WebKit/ChangeLog-2002-12-03
+++ b/WebKit/ChangeLog-2002-12-03
@@ -1,5 +1,19 @@
2002-10-28 Darin Adler <darin at apple.com>
+ - fixed storage leak of WebNetscapePluginPackage objects
+
+ * Plugins.subproj/WebBasePluginPackage.m:
+ (+[WebBasePluginPackage pluginWithPath:]): Add missing autorelease.
+
+ * Plugins.subproj/WebBasePluginPackage.h:
+ * Plugins.subproj/WebPluginController.h:
+ * Plugins.subproj/WebPluginController.m:
+ * Plugins.subproj/WebPluginPackage.h:
+ * Plugins.subproj/WebPluginPackage.m:
+ Not __MyCompanyName__, but rather Apple Computer.
+
+2002-10-28 Darin Adler <darin at apple.com>
+
- fixed bug that caused us to leak all WebResourceHandles used for subresources
* WebCoreSupport.subproj/WebSubresourceClient.m:
diff --git a/WebKit/Misc.subproj/WebFileDatabase.m b/WebKit/Misc.subproj/WebFileDatabase.m
index b239bbe..300ee57 100644
--- a/WebKit/Misc.subproj/WebFileDatabase.m
+++ b/WebKit/Misc.subproj/WebFileDatabase.m
@@ -567,6 +567,7 @@ static void databaseInit()
[setCache setObject:object forKey:key];
op = [[WebFileDatabaseOp alloc] initWithCode:WebFileDatabaseSetObjectOp key:key object:object];
[ops addObject:op];
+ [op release];
[self setTimer];
[mutex unlock];
@@ -585,6 +586,7 @@ static void databaseInit()
[removeCache addObject:key];
op = [[WebFileDatabaseOp alloc] initWithCode:WebFileDatabaseRemoveObjectOp key:key object:nil];
[ops addObject:op];
+ [op release];
[self setTimer];
[mutex unlock];
@@ -830,6 +832,7 @@ static void databaseInit()
op = [ops lastObject];
if (op) {
+ [op retain];
[ops removeLastObject];
[op perform:self];
[setCache removeObjectForKey:[op key]];
diff --git a/WebKit/Plugins.subproj/WebBasePluginPackage.h b/WebKit/Plugins.subproj/WebBasePluginPackage.h
index e262d46..2bcca09 100644
--- a/WebKit/Plugins.subproj/WebBasePluginPackage.h
+++ b/WebKit/Plugins.subproj/WebBasePluginPackage.h
@@ -3,7 +3,7 @@
// WebKit
//
// Created by Chris Blumenberg on Tue Oct 22 2002.
-// Copyright (c) 2002 __MyCompanyName__. All rights reserved.
+// Copyright (c) 2002 Apple Computer, Inc. All rights reserved.
//
#import <Foundation/Foundation.h>
diff --git a/WebKit/Plugins.subproj/WebBasePluginPackage.m b/WebKit/Plugins.subproj/WebBasePluginPackage.m
index c079bdd..103d4c4 100644
--- a/WebKit/Plugins.subproj/WebBasePluginPackage.m
+++ b/WebKit/Plugins.subproj/WebBasePluginPackage.m
@@ -3,10 +3,11 @@
// WebKit
//
// Created by Chris Blumenberg on Tue Oct 22 2002.
-// Copyright (c) 2002 __MyCompanyName__. All rights reserved.
+// Copyright (c) 2002 Apple Computer, Inc. All rights reserved.
//
#import <WebKit/WebBasePluginPackage.h>
+
#import <WebKit/WebNetscapePluginPackage.h>
#import <WebKit/WebPluginPackage.h>
@@ -20,7 +21,7 @@
pluginPackage = [[WebNetscapePluginPackage alloc] initWithPath:pluginPath];
}
- return pluginPackage;
+ return [pluginPackage autorelease];
}
- initWithPath:(NSString *)pluginPath
@@ -51,16 +52,18 @@
[super dealloc];
}
-
-- (NSString *)name{
+- (NSString *)name
+{
return name;
}
-- (NSString *)path{
+- (NSString *)path
+{
return path;
}
-- (NSString *)filename{
+- (NSString *)filename
+{
return [path lastPathComponent];
}
diff --git a/WebKit/Plugins.subproj/WebPluginController.h b/WebKit/Plugins.subproj/WebPluginController.h
index f636638..98bfd08 100644
--- a/WebKit/Plugins.subproj/WebPluginController.h
+++ b/WebKit/Plugins.subproj/WebPluginController.h
@@ -3,7 +3,7 @@
// WebKit
//
// Created by Chris Blumenberg on Wed Oct 23 2002.
-// Copyright (c) 2002 __MyCompanyName__. All rights reserved.
+// Copyright (c) 2002 Apple Computer, Inc. All rights reserved.
//
#import <Foundation/Foundation.h>
diff --git a/WebKit/Plugins.subproj/WebPluginController.m b/WebKit/Plugins.subproj/WebPluginController.m
index 053d299..5a316bb 100644
--- a/WebKit/Plugins.subproj/WebPluginController.m
+++ b/WebKit/Plugins.subproj/WebPluginController.m
@@ -3,7 +3,7 @@
// WebKit
//
// Created by Chris Blumenberg on Wed Oct 23 2002.
-// Copyright (c) 2002 __MyCompanyName__. All rights reserved.
+// Copyright (c) 2002 Apple Computer, Inc. All rights reserved.
//
#import <WebKit/WebController.h>
diff --git a/WebKit/Plugins.subproj/WebPluginPackage.h b/WebKit/Plugins.subproj/WebPluginPackage.h
index 76084d4..9e3e25f 100644
--- a/WebKit/Plugins.subproj/WebPluginPackage.h
+++ b/WebKit/Plugins.subproj/WebPluginPackage.h
@@ -3,7 +3,7 @@
// WebKit
//
// Created by Chris Blumenberg on Tue Oct 22 2002.
-// Copyright (c) 2002 __MyCompanyName__. All rights reserved.
+// Copyright (c) 2002 Apple Computer, Inc. All rights reserved.
//
#import <Foundation/Foundation.h>
diff --git a/WebKit/Plugins.subproj/WebPluginPackage.m b/WebKit/Plugins.subproj/WebPluginPackage.m
index 5cab266..fb983bd 100644
--- a/WebKit/Plugins.subproj/WebPluginPackage.m
+++ b/WebKit/Plugins.subproj/WebPluginPackage.m
@@ -3,7 +3,7 @@
// WebKit
//
// Created by Chris Blumenberg on Tue Oct 22 2002.
-// Copyright (c) 2002 __MyCompanyName__. All rights reserved.
+// Copyright (c) 2002 Apple Computer, Inc. All rights reserved.
//
#import <WebKit/WebPluginPackage.h>
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list