[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

trey trey at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:08:01 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 4dad059befcf55e4acfe2c9c717f99525404aa5b
Author: trey <trey at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Nov 25 07:39:27 2002 +0000

    Tests:
    
    	Added a test for new URL parsing functions in WebNSStringExtras.
    
            * WebFoundation-Misc/Makefile.am:  Add new test.
            * WebFoundation-Misc/ifurlparsing-test.chk: Added.
            * WebFoundation-Misc/ifurlparsing-test.m: Added.
            (FormatStringForDisplay):
            (FormatStrForDisplay):
            (PrintRangeResult):
            (TestURL):
            (main):
            * test.list:
    
    WebFoundation:
    
    	Adding routines to parse URLs, operating on ranges instead of substrings for perf.
    
            * Misc.subproj/WebNSStringExtras.h:
            * Misc.subproj/WebNSStringExtras.m:
            (-[NSString _web_hasCaseInsensitivePrefix:]):  Nit cleanup.
            (pieceBeforeColon):   Utility function.
            (pieceAfterColon):   Utility function.
            (-[NSString _web_rangeOfURLScheme]):  New SPI.  Cache NSCharacterSet with legal
    	scheme chars, since creating it is a huge pig.
            (-[NSString _web_rangeOfURLResourceSpecifier]):  New SPI.
            (-[NSString _web_rangeOfURLUserPasswordHostPort]):  New SPI.
            (rangeOfUserAndPassword):   Utility function.
            (rangeOfHostAndPort):   Utility function.
            (-[NSString _web_rangeOfURLUser]):  New SPI.
            (-[NSString _web_rangeOfURLPassword]):  New SPI.
            (-[NSString _web_rangeOfURLHost]):  New SPI.
            (-[NSString _web_rangeOfURLPort]):  New SPI.
            (-[NSString _web_looksLikeAbsoluteURL]):  Now just calls _web_rangeOfURLScheme for
    	equivalent functionality as before.
    
    WebKit:
    
    	Added URLString method to WebHistoryItem to avoid silly conversions between
    	NSURL and NSString.  When the dust settles with our plans for NSURL we can
    	rationalize this API with the rest of WebKit.
    
            * History.subproj/WebHistoryItem.h:
            * History.subproj/WebHistoryItem.m:
            (-[WebHistoryItem URLString]):
    
    WebBrowser:
    
    	Auto-complete handles absolute URLs typed by the user.  Lots of fixes with
    	better handling of various URLs (with user:password, with port,...).
    
    	Various auto-complete database operations speed ups, ranging from 32% to 64%.
    	The most important case is the initial db load, which was running 115 msec on
    	a 2x1.2Ghz, and is now 42msec.  I think this will eliminate a noticeable first-use
    	delay on slow machines.  We also eliminate some heap thrashing.
    
    	Speedups were achieved by getting rid of URL-String conversions, using new
    	range-based URL parsing methods instead of NSURL and caching the index of the
    	"cooked" string within the raw URL string (with no space cost because we had
    	bits in a bitfield available).
    
            * CompletionController.h:
            * CompletionController.m:
            (+[CompletionController _tree_create]):  Set cookedStringLoc for root node.
            (recursiveDestroyTree):  Name change.
            (+[CompletionController _tree_destroy]):  Name change.
            (_keyStringFromItem):  Get rid of conversions, return index for caching.
            (_keyStringFromNode):  Use cached cooked string index if available.
            (_findPotentialNode):  Fixed edge case of cursor setting when an exact match was hit.
            (+[CompletionController _tree_addItem:]):  Cache the index of the cooked string
    	in new nodes.
            (+[CompletionController _tree_deleteItem:]):  Adopt some internal name changes.
            (+[CompletionController _tree_setCursorAtStart:]):  Newly factored code.
            (+[CompletionController _tree_findItem:cursor:]):  On search for "", set the cursor
    	ahead of all nodes in the tree.
            (DumpAutoCompleteTree):  Nit.
            (_rawStringFromItem):    Newly factored code.
            (_indexOfCookedURLString):  Return the index of the cooked string instead of the
    	substring at that position, allowing clients to cache this number.
            (-[CompletionController _executeQuery]):  Handle cases of the user typing an
    	absolute URL, or a partial string starting with "www."
            (-[CompletionController _reflectSelectedRow]):  Updating the text field works
    	differently when the user typed an absolute URL.
            (-[CompletionController completeString:]):  Nuke FIXME.
            (-[CompletionController control:textView:doCommandBySelector:]):  Nuke FIXME.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index 65d1aa0..ef5d3ac 100644
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,13 @@
+2002-11-24  Trey Matteson  <trey at apple.com>
+
+	Added URLString method to WebHistoryItem to avoid silly conversions between
+	NSURL and NSString.  When the dust settles with our plans for NSURL we can
+	rationalize this API with the rest of WebKit.
+
+        * History.subproj/WebHistoryItem.h:
+        * History.subproj/WebHistoryItem.m:
+        (-[WebHistoryItem URLString]):
+
 2002-11-24  Chris Blumenberg  <cblu at apple.com>
 
 	Added element keys for the image ALT and link TITLE attributes. This will eventually be used to fix other bugs. Also made WebKit and WebCore use the same element keys to simplify the conversion of the element dictionary.
diff --git a/WebKit/ChangeLog-2002-12-03 b/WebKit/ChangeLog-2002-12-03
index 65d1aa0..ef5d3ac 100644
--- a/WebKit/ChangeLog-2002-12-03
+++ b/WebKit/ChangeLog-2002-12-03
@@ -1,3 +1,13 @@
+2002-11-24  Trey Matteson  <trey at apple.com>
+
+	Added URLString method to WebHistoryItem to avoid silly conversions between
+	NSURL and NSString.  When the dust settles with our plans for NSURL we can
+	rationalize this API with the rest of WebKit.
+
+        * History.subproj/WebHistoryItem.h:
+        * History.subproj/WebHistoryItem.m:
+        (-[WebHistoryItem URLString]):
+
 2002-11-24  Chris Blumenberg  <cblu at apple.com>
 
 	Added element keys for the image ALT and link TITLE attributes. This will eventually be used to fix other bugs. Also made WebKit and WebCore use the same element keys to simplify the conversion of the element dictionary.
diff --git a/WebKit/History.subproj/WebHistoryItem.h b/WebKit/History.subproj/WebHistoryItem.h
index c73cbf4..03ebe38 100644
--- a/WebKit/History.subproj/WebHistoryItem.h
+++ b/WebKit/History.subproj/WebHistoryItem.h
@@ -34,6 +34,7 @@
 - (id)initFromDictionaryRepresentation:(NSDictionary *)dict;
 
 - (NSURL *)URL;
+- (NSString *)URLString;
 - (NSString *)target;
 - (NSString *)parent;
 - (NSString *)title;
diff --git a/WebKit/History.subproj/WebHistoryItem.m b/WebKit/History.subproj/WebHistoryItem.m
index 381fc4d..cff82d3 100644
--- a/WebKit/History.subproj/WebHistoryItem.m
+++ b/WebKit/History.subproj/WebHistoryItem.m
@@ -83,6 +83,12 @@
     return _URLString ? [NSURL _web_URLWithString:_URLString] : nil;
 }
 
+// FIXME: need to decide it this class ever returns URLs, and the name of this method
+- (NSString *)URLString
+{
+    return _URLString;
+}
+
 - (NSString *)target
 {
     return _target;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list