[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

darin darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:26:53 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 254780560133cb1d92c85d21b9a3aeaf0bb3a6e2
Author: darin <darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Mar 3 19:31:04 2003 +0000

            Reviewed by Dave.
    
    	- fixed 3183445 -- hang in QCString::length reloading page with lots of text in textarea
    
            * khtml/html/html_formimpl.cpp: (encodeCString): Compute string length only once outside the loop
            to avoid being O(n^2) in the size of the string.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2003-10-25 b/WebCore/ChangeLog-2003-10-25
index c04996b..94dd64d 100644
--- a/WebCore/ChangeLog-2003-10-25
+++ b/WebCore/ChangeLog-2003-10-25
@@ -1,5 +1,14 @@
 2003-03-03  Darin Adler  <darin at apple.com>
 
+        Reviewed by Dave.
+
+	- fixed 3183445 -- hang in QCString::length reloading page with lots of text in textarea
+
+        * khtml/html/html_formimpl.cpp: (encodeCString): Compute string length only once outside the loop
+        to avoid being O(n^2) in the size of the string.
+
+2003-03-03  Darin Adler  <darin at apple.com>
+
         Reviewed by Trey.
 
 	- fixed 3180364 -- infinite loop in JavaScript at www.vw.dk (due to document.anchors problem) leads to hang
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index c04996b..94dd64d 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,5 +1,14 @@
 2003-03-03  Darin Adler  <darin at apple.com>
 
+        Reviewed by Dave.
+
+	- fixed 3183445 -- hang in QCString::length reloading page with lots of text in textarea
+
+        * khtml/html/html_formimpl.cpp: (encodeCString): Compute string length only once outside the loop
+        to avoid being O(n^2) in the size of the string.
+
+2003-03-03  Darin Adler  <darin at apple.com>
+
         Reviewed by Trey.
 
 	- fixed 3180364 -- infinite loop in JavaScript at www.vw.dk (due to document.anchors problem) leads to hang
diff --git a/WebCore/khtml/html/html_formimpl.cpp b/WebCore/khtml/html/html_formimpl.cpp
index e84b3d8..0e8b9fe 100644
--- a/WebCore/khtml/html/html_formimpl.cpp
+++ b/WebCore/khtml/html/html_formimpl.cpp
@@ -165,12 +165,13 @@ static QCString encodeCString(const QCString& e)
     // http://www.w3.org/TR/html4/interact/forms.html#h-17.13.4.1
     // safe characters like NS handles them for compatibility
     static const char *safe = "-._*";
-    QCString encoded(( e.length()+e.contains( '\n' ) )*3+1);
+    int elen = e.length();
+    QCString encoded(( elen+e.contains( '\n' ) )*3+1);
     int enclen = 0;
 
     //QCString orig(e.data(), e.size());
 
-    for(unsigned pos = 0; pos < e.length(); pos++) {
+    for(unsigned pos = 0; pos < elen; pos++) {
         unsigned char c = e[pos];
 
         if ( (( c >= 'A') && ( c <= 'Z')) ||

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list