[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

darin darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:32:59 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit b5d80e27a01e435d341aea4fc057c4ed44d69e6c
Author: darin <darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Apr 1 17:10:07 2003 +0000

            Reviewed by Trey.
    
    	- fixed 3202542 -- REGRESSION: preinitialized password inputs do not show dots (affects mac.com)
    
            * kwq/KWQTextField.mm: (-[KWQTextField setPasswordMode:]): Remove code that sets the string
            value to "". This is not needed, and because a text changed signal is sent out it makes the
            caller think the text was deleted intentionally. Added code to move the string from the current
            field in use to the other field, so changing the password mode does not make the string go away.
            The old code was fragile and depended on the order of operations.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2003-10-25 b/WebCore/ChangeLog-2003-10-25
index d28d815..717fec6 100644
--- a/WebCore/ChangeLog-2003-10-25
+++ b/WebCore/ChangeLog-2003-10-25
@@ -1,3 +1,15 @@
+2003-04-01  Darin Adler  <darin at apple.com>
+
+        Reviewed by Trey.
+
+	- fixed 3202542 -- REGRESSION: preinitialized password inputs do not show dots (affects mac.com)
+
+        * kwq/KWQTextField.mm: (-[KWQTextField setPasswordMode:]): Remove code that sets the string
+        value to "". This is not needed, and because a text changed signal is sent out it makes the
+        caller think the text was deleted intentionally. Added code to move the string from the current
+        field in use to the other field, so changing the password mode does not make the string go away.
+        The old code was fragile and depended on the order of operations.
+
 2003-03-31  Darin Adler  <darin at apple.com>
 
         * English.lproj/InfoPlist.strings: Changed "1.0 Beta" to "1.0 Beta 2".
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index d28d815..717fec6 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,15 @@
+2003-04-01  Darin Adler  <darin at apple.com>
+
+        Reviewed by Trey.
+
+	- fixed 3202542 -- REGRESSION: preinitialized password inputs do not show dots (affects mac.com)
+
+        * kwq/KWQTextField.mm: (-[KWQTextField setPasswordMode:]): Remove code that sets the string
+        value to "". This is not needed, and because a text changed signal is sent out it makes the
+        caller think the text was deleted intentionally. Added code to move the string from the current
+        field in use to the other field, so changing the password mode does not make the string go away.
+        The old code was fragile and depended on the order of operations.
+
 2003-03-31  Darin Adler  <darin at apple.com>
 
         * English.lproj/InfoPlist.strings: Changed "1.0 Beta" to "1.0 Beta 2".
diff --git a/WebCore/kwq/KWQTextField.mm b/WebCore/kwq/KWQTextField.mm
index 2651483..63bbf9d 100644
--- a/WebCore/kwq/KWQTextField.mm
+++ b/WebCore/kwq/KWQTextField.mm
@@ -123,20 +123,23 @@
         return;
     }
     
-    [self setStringValue:@""];
     if (!flag) {
+        // Don't use [self setStringValue:] because there are unwanted side effects,
+        // like sending out a text changed signal.
+        [super setStringValue:[secureField stringValue]];
         [secureField removeFromSuperview];
     } else {
         if (secureField == nil) {
             secureField = [[KWQSecureTextField alloc] initWithQLineEdit:widget];
             [secureField setFormatter:formatter];
             [secureField setFont:[self font]];
+            [secureField setEditable:[self isEditable]];
             [self setUpTextField:secureField];
             [self updateSecureFieldFrame];
         }
+        [secureField setStringValue:[super stringValue]];
         [self addSubview:secureField];
     }
-    [self setStringValue:@""];
 }
 
 - (void)setEditable:(BOOL)flag

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list