[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

mjs mjs at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:43:21 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit cd0dc331268cd53e0f54f4894fe5352d87ee126f
Author: mjs <mjs at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed May 28 23:53:54 2003 +0000

            Reviewed by Darin.
    
    	- fixed 3263157 - REGRESSION: tabbing into a secure password field shows contents
    
            * kwq/KWQTextField.mm:
            (-[KWQSecureTextField textDidEndEditing:]): Make sure to restore bullet mode if we
    	accidentally lose it.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@4442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2003-10-25 b/WebCore/ChangeLog-2003-10-25
index 2eaafed..1bcac69 100644
--- a/WebCore/ChangeLog-2003-10-25
+++ b/WebCore/ChangeLog-2003-10-25
@@ -1,3 +1,13 @@
+2003-05-28  Maciej Stachowiak  <mjs at apple.com>
+
+        Reviewed by Darin.
+
+	- fixed 3263157 - REGRESSION: tabbing into a secure password field shows contents
+
+        * kwq/KWQTextField.mm:
+        (-[KWQSecureTextField textDidEndEditing:]): Make sure to restore bullet mode if we
+	accidentally lose it.
+
 2003-05-27  Maciej Stachowiak  <mjs at apple.com>
 
         Rolled in fix from Safari-80~1-branch
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 2eaafed..1bcac69 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,13 @@
+2003-05-28  Maciej Stachowiak  <mjs at apple.com>
+
+        Reviewed by Darin.
+
+	- fixed 3263157 - REGRESSION: tabbing into a secure password field shows contents
+
+        * kwq/KWQTextField.mm:
+        (-[KWQSecureTextField textDidEndEditing:]): Make sure to restore bullet mode if we
+	accidentally lose it.
+
 2003-05-27  Maciej Stachowiak  <mjs at apple.com>
 
         Rolled in fix from Safari-80~1-branch
diff --git a/WebCore/kwq/KWQTextField.mm b/WebCore/kwq/KWQTextField.mm
index c2e940d..65262c2 100644
--- a/WebCore/kwq/KWQTextField.mm
+++ b/WebCore/kwq/KWQTextField.mm
@@ -612,6 +612,27 @@
     [[self delegate] fieldEditorDidMouseDown:event];
 }
 
+- (void)textDidEndEditing:(NSNotification *)notification
+{
+    [super textDidEndEditing:notification];
+
+    // When tabbing from one secure text field to another, the super
+    // call above will change the focus, and then turn off bullet mode
+    // for the secure field, leaving the plain text showing. As a
+    // workaround for this AppKit bug, we detect this circumstance
+    // (changing from one secure field to another) and set selectable
+    // to YES, and then back to whatever it was - this has the side
+    // effect of turning on bullet mode.
+
+    NSTextView *textObject = [notification object];
+    id delegate = [textObject delegate];
+    if (delegate != self && [delegate isKindOfClass:[NSSecureTextField class]]) {
+	BOOL oldSelectable = [textObject isSelectable];
+	[textObject setSelectable:YES];
+	[textObject setSelectable:oldSelectable];
+    }
+}
+
 @end
 
 @implementation KWQSecureTextFieldCell

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list