[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677
hyatt
hyatt at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:43:55 UTC 2009
The following commit has been merged in the debian/unstable branch:
commit 6f7ebf7492378d766c209078b22697684dd75c6b
Author: hyatt <hyatt at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Jun 2 22:41:49 2003 +0000
Fix for 3276099. value() was wrong for radio buttons. Needed
to get it from the attribute since I was no longer caching
anything in m_value.
Reviewed by kocienda
* khtml/html/html_formimpl.cpp:
(HTMLInputElementImpl::value):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@4470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog-2003-10-25 b/WebCore/ChangeLog-2003-10-25
index 489e991..1bad949 100644
--- a/WebCore/ChangeLog-2003-10-25
+++ b/WebCore/ChangeLog-2003-10-25
@@ -1,3 +1,14 @@
+2003-06-02 David Hyatt <hyatt at apple.com>
+
+ Fix for 3276099. value() was wrong for radio buttons. Needed
+ to get it from the attribute since I was no longer caching
+ anything in m_value.
+
+ Reviewed by kocienda
+
+ * khtml/html/html_formimpl.cpp:
+ (HTMLInputElementImpl::value):
+
2003-06-02 Ken Kocienda <kocienda at apple.com>
Code written by darin
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 489e991..1bad949 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,14 @@
+2003-06-02 David Hyatt <hyatt at apple.com>
+
+ Fix for 3276099. value() was wrong for radio buttons. Needed
+ to get it from the attribute since I was no longer caching
+ anything in m_value.
+
+ Reviewed by kocienda
+
+ * khtml/html/html_formimpl.cpp:
+ (HTMLInputElementImpl::value):
+
2003-06-02 Ken Kocienda <kocienda at apple.com>
Code written by darin
diff --git a/WebCore/khtml/html/html_formimpl.cpp b/WebCore/khtml/html/html_formimpl.cpp
index b8f5abd..d7bed9e 100644
--- a/WebCore/khtml/html/html_formimpl.cpp
+++ b/WebCore/khtml/html/html_formimpl.cpp
@@ -1595,11 +1595,18 @@ void HTMLInputElementImpl::setChecked(bool _checked)
DOMString HTMLInputElementImpl::value() const
{
- if ((m_type == CHECKBOX || m_type == RADIO) && m_value.isNull()) {
- if (checked())
- return DOMString("on");
- else
- return DOMString("");
+ if (m_type == CHECKBOX || m_type == RADIO) {
+ DOMString val = getAttribute(ATTR_VALUE);
+
+ // If no attribute exists, then just use "on" or "" based off the checked() state
+ // of the control.
+ if (val.isNull()) {
+ if (checked())
+ return DOMString("on");
+ else
+ return DOMString("");
+ }
+ return val;
}
if (m_value.isNull())
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list