[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

darin darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:17:48 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 0c35e090789e284c75355755262a94b14b37e621
Author: darin <darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Dec 30 05:12:10 2002 +0000

            Reviewed by Don.
    
    	- fixed 3136801 -- scrolling a page that contains a QuickTime movie leaves garbage behind
    
            * Plugins.subproj/WebBaseNetscapePluginView.m:
            (-[WebBaseNetscapePluginView tellQuickTimeToChill]): Added. Calls a QuickDraw SPI
    	CallDrawingNotifications to let QuickTime know it should take a nature break.
            (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): Call tellQuickTimeToChill.
            (-[WebBaseNetscapePluginView viewHasMoved:]): Call tellQuickTimeToChill.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index 20a2294..56f57df 100644
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -2,6 +2,18 @@
 
         Reviewed by Don.
 
+	- fixed 3136801 -- scrolling a page that contains a QuickTime movie leaves garbage behind
+
+        * Plugins.subproj/WebBaseNetscapePluginView.m:
+        (-[WebBaseNetscapePluginView tellQuickTimeToChill]): Added. Calls a QuickDraw SPI
+	CallDrawingNotifications to let QuickTime know it should take a nature break.
+        (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): Call tellQuickTimeToChill.
+        (-[WebBaseNetscapePluginView viewHasMoved:]): Call tellQuickTimeToChill.
+
+2002-12-29  Darin Adler  <darin at apple.com>
+
+        Reviewed by Don.
+
 	- follow-on to my fix for 3125877 that fixes a crash I observed when a plug-in fails to NPP_New
         
         I filed bug 3136870 about the fact that we don't do a good job reporting the error.
diff --git a/WebKit/Plugins.subproj/WebBaseNetscapePluginView.m b/WebKit/Plugins.subproj/WebBaseNetscapePluginView.m
index d282ec4..9b177bd 100644
--- a/WebKit/Plugins.subproj/WebBaseNetscapePluginView.m
+++ b/WebKit/Plugins.subproj/WebBaseNetscapePluginView.m
@@ -26,6 +26,10 @@
 
 #import <AppKit/NSEvent_Private.h>
 #import <Carbon/Carbon.h>
+#import <QD/QuickdrawPriv.h>
+
+// This is not yet in QuickdrawPriv.h, although it's supposed to be.
+void CallDrawingNotifications(CGrafPtr port, Rect *mayDrawIntoThisRect, int drawingType);
 
 // FIXME: Why 0.1? Why not 0? Why not an even larger number?
 #define NullEventIntervalActive 	0.1
@@ -835,11 +839,27 @@ typedef struct {
     return YES;
 }
 
+-(void)tellQuickTimeToChill
+{
+    // Make a call to the secret QuickDraw API that makes QuickTime calm down.
+    WindowRef windowRef = [[self window] windowRef];
+    if (!windowRef) {
+        return;
+    }
+    CGrafPtr port = GetWindowPort(windowRef);
+    Rect bounds;
+    GetPortBounds(port, &bounds);
+    CallDrawingNotifications(port, &bounds, kBitsProc);
+}
+
 - (void)viewWillMoveToWindow:(NSWindow *)newWindow
 {
+    [self tellQuickTimeToChill];
+
     // We must remove the tracking rect before we move to the new window.
     // Once we move to the new window, it will be too late.
     [self removeTrackingRect];
+
     [super viewWillMoveToWindow:newWindow];
 }
 
@@ -858,6 +878,7 @@ typedef struct {
 
 -(void)viewHasMoved:(NSNotification *)notification
 {
+    [self tellQuickTimeToChill];
     [self setWindow];
     [self resetTrackingRect];
 }

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list