[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

mjs mjs at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:30:08 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 70bfd5473be3541b846ab7bd01149b5894fb84c6
Author: mjs <mjs at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Mar 18 23:31:56 2003 +0000

            Reviewed by John.
    
    	- fixed 3080337 - default values seem to be "no" when third param of window.open is an empty string
    
            * khtml/ecma/kjs_window.cpp:
            (WindowFunc::tryCall): Treat empty string the same as missing for
    	third argument - leave all chrome on. Also remove support for
    	scrollbars= property
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2003-10-25 b/WebCore/ChangeLog-2003-10-25
index 76889ee..d10c23d 100644
--- a/WebCore/ChangeLog-2003-10-25
+++ b/WebCore/ChangeLog-2003-10-25
@@ -1,3 +1,14 @@
+2003-03-18  Maciej Stachowiak  <mjs at apple.com>
+
+        Reviewed by John.
+
+	- fixed 3080337 - default values seem to be "no" when third param of window.open is an empty string
+	
+        * khtml/ecma/kjs_window.cpp:
+        (WindowFunc::tryCall): Treat empty string the same as missing for
+	third argument - leave all chrome on. Also remove support for
+	scrollbars= property
+
 2003-03-18  Darin Adler  <darin at apple.com>
 
         Reviewed by Maciej.
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 76889ee..d10c23d 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,14 @@
+2003-03-18  Maciej Stachowiak  <mjs at apple.com>
+
+        Reviewed by John.
+
+	- fixed 3080337 - default values seem to be "no" when third param of window.open is an empty string
+	
+        * khtml/ecma/kjs_window.cpp:
+        (WindowFunc::tryCall): Treat empty string the same as missing for
+	third argument - leave all chrome on. Also remove support for
+	scrollbars= property
+
 2003-03-18  Darin Adler  <darin at apple.com>
 
         Reviewed by Maciej.
diff --git a/WebCore/khtml/ecma/kjs_window.cpp b/WebCore/khtml/ecma/kjs_window.cpp
index 3e6c324..fe01b4c 100644
--- a/WebCore/khtml/ecma/kjs_window.cpp
+++ b/WebCore/khtml/ecma/kjs_window.cpp
@@ -1126,15 +1126,12 @@ Value WindowFunc::tryCall(ExecState *exec, Object &thisObj, const List &args)
       // scan feature argument
       v = args[2];
       QString features;
-      if (!v.isNull() && v.type() != UndefinedType) {
+      if (!v.isNull() && v.type() != UndefinedType && v.toString(exec).length() > 0) {
         features = v.toString(exec).qstring();
         // specifying window params means false defaults
         winargs.menuBarVisible = false;
         winargs.toolBarsVisible = false;
         winargs.statusBarVisible = false;
-#if APPLE_CHANGES
-	winargs.scrollbarsVisible = false;
-#endif
         QStringList flist = QStringList::split(',', features);
         QStringList::ConstIterator it = flist.begin();
         while (it != flist.end()) {
@@ -1202,10 +1199,6 @@ Value WindowFunc::tryCall(ExecState *exec, Object &thisObj, const List &args)
             winargs.resizable = (val == "1" || val == "yes");
           else if (key == "fullscreen")
             winargs.fullscreen = (val == "1" || val == "yes");
-#if APPLE_CHANGES
-          else if (key == "scrollbars")
-            winargs.scrollbarsVisible = (val == "1" || val == "yes");
-#endif
         }
       }
 

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list