[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677
trey
trey at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:36:23 UTC 2009
The following commit has been merged in the debian/unstable branch:
commit 41788b2ade63e13b27c9efc63f4636c6b2fc3b46
Author: trey <trey at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Apr 11 02:01:50 2003 +0000
WebCore:
3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields
New WC support function.
Reviewed by Darin.
* kwq/WebCoreBridge.h:
* kwq/WebCoreBridge.mm:
(-[WebCoreBridge elementWithName:inForm:]): Run through the form's elements
looking for a matching name.
WebKit:
3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields
Just glue for calling a new WC function.
Reviewed by Darin.
* WebView.subproj/WebHTMLRepresentation.h:
* WebView.subproj/WebHTMLRepresentation.m:
(-[WebHTMLRepresentation elementWithName:inForm:]):
WebBrowser:
3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields
User new WC SPI to lookup the element for each field at submit time,
and test them for AUTOCOMPLETE=OFF or if they are password fields.
This is in the "saving data for previous forms case". Saving creds in
the keychain is done elsewhere.
Reviewed by Darin.
* FormCompletionController.m:
(+[FormCompletionController _frame:willSubmitRegularForm:withValues:]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@4069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog-2003-10-25 b/WebCore/ChangeLog-2003-10-25
index b646128..c02f144 100644
--- a/WebCore/ChangeLog-2003-10-25
+++ b/WebCore/ChangeLog-2003-10-25
@@ -1,3 +1,16 @@
+2003-04-10 Trey Matteson <trey at apple.com>
+
+ 3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields
+
+ New WC support function.
+
+ Reviewed by Darin.
+
+ * kwq/WebCoreBridge.h:
+ * kwq/WebCoreBridge.mm:
+ (-[WebCoreBridge elementWithName:inForm:]): Run through the form's elements
+ looking for a matching name.
+
=== Safari-72 ===
2003-04-10 Maciej Stachowiak <mjs at apple.com>
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index b646128..c02f144 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,16 @@
+2003-04-10 Trey Matteson <trey at apple.com>
+
+ 3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields
+
+ New WC support function.
+
+ Reviewed by Darin.
+
+ * kwq/WebCoreBridge.h:
+ * kwq/WebCoreBridge.mm:
+ (-[WebCoreBridge elementWithName:inForm:]): Run through the form's elements
+ looking for a matching name.
+
=== Safari-72 ===
2003-04-10 Maciej Stachowiak <mjs at apple.com>
diff --git a/WebCore/kwq/WebCoreBridge.h b/WebCore/kwq/WebCoreBridge.h
index 0ce5695..463c9ce 100644
--- a/WebCore/kwq/WebCoreBridge.h
+++ b/WebCore/kwq/WebCoreBridge.h
@@ -164,6 +164,7 @@ enum FrameBorderStyle {
- (NSString *)renderTreeAsExternalRepresentation;
- (NSDictionary *)elementAtPoint:(NSPoint)point;
+- (id <WebDOMElement>)elementWithName:(NSString *)name inForm:(id <WebDOMElement>)form;
- (id <WebDOMElement>)elementForView:(NSView *)view;
- (BOOL)elementDoesAutoComplete:(id <WebDOMElement>)element;
- (BOOL)elementIsPassword:(id <WebDOMElement>)element;
diff --git a/WebCore/kwq/WebCoreBridge.mm b/WebCore/kwq/WebCoreBridge.mm
index 3246e7f..c160075 100644
--- a/WebCore/kwq/WebCoreBridge.mm
+++ b/WebCore/kwq/WebCoreBridge.mm
@@ -506,6 +506,23 @@ static HTMLFormElementImpl *formElementFromDOMElement(id <WebDOMElement>element)
return nil;
}
+- (id <WebDOMElement>)elementWithName:(NSString *)name inForm:(id <WebDOMElement>)form
+{
+ HTMLFormElementImpl *formElement = formElementFromDOMElement(form);
+ if (formElement) {
+ QPtrList<HTMLGenericFormElementImpl> elements = formElement->formElements;
+ QString targetName = QString::fromNSString(name);
+ for (unsigned int i = 0; i < elements.count(); i++) {
+ HTMLGenericFormElementImpl *elt = elements.at(i);
+ // Skip option elements, other duds
+ if (elt->name() == targetName) {
+ return [WebCoreDOMElement elementWithImpl:elt];
+ }
+ }
+ }
+ return nil;
+}
+
- (BOOL)elementDoesAutoComplete:(id <WebDOMElement>)element
{
HTMLInputElementImpl *inputElement = inputElementFromDOMElement(element);
@@ -545,8 +562,7 @@ static HTMLFormElementImpl *formElementFromDOMElement(id <WebDOMElement>element)
HTMLFormElementImpl *formElement = formElementFromDOMElement(form);
if (formElement) {
QPtrList<HTMLGenericFormElementImpl> elements = formElement->formElements;
- unsigned int i;
- for (i = 0; i < elements.count(); i++) {
+ for (unsigned int i = 0; i < elements.count(); i++) {
if (elements.at(i)->isEnumeratable()) { // Skip option elements, other duds
NSView *view = viewForElement(elements.at(i));
if (view) {
diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index 3e92b30..8b6690c 100644
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,15 @@
+2003-04-10 Trey Matteson <trey at apple.com>
+
+ 3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields
+
+ Just glue for calling a new WC function.
+
+ Reviewed by Darin.
+
+ * WebView.subproj/WebHTMLRepresentation.h:
+ * WebView.subproj/WebHTMLRepresentation.m:
+ (-[WebHTMLRepresentation elementWithName:inForm:]):
+
=== Safari-72 ===
2003-04-10 Maciej Stachowiak <mjs at apple.com>
diff --git a/WebKit/WebView.subproj/WebHTMLRepresentation.h b/WebKit/WebView.subproj/WebHTMLRepresentation.h
index 3ee76b7..b225f75 100644
--- a/WebKit/WebView.subproj/WebHTMLRepresentation.h
+++ b/WebKit/WebView.subproj/WebHTMLRepresentation.h
@@ -51,6 +51,7 @@
- (NSAttributedString *)attributedStringFrom: (id<WebDOMNode>)startNode startOffset: (int)startOffset to: (id<WebDOMNode>)endNode endOffset: (int)endOffset;
+- (id <WebDOMElement>)elementWithName:(NSString *)name inForm:(id <WebDOMElement>)form;
- (id <WebDOMElement>)elementForView:(NSView *)view;
- (BOOL)elementDoesAutoComplete:(id <WebDOMElement>)element;
- (BOOL)elementIsPassword:(id <WebDOMElement>)element;
diff --git a/WebKit/WebView.subproj/WebHTMLRepresentation.m b/WebKit/WebView.subproj/WebHTMLRepresentation.m
index f1bd70b..03ad99f 100644
--- a/WebKit/WebView.subproj/WebHTMLRepresentation.m
+++ b/WebKit/WebView.subproj/WebHTMLRepresentation.m
@@ -113,6 +113,11 @@
return [_private->bridge attributedStringFrom: startNode startOffset: startOffset to: endNode endOffset: endOffset];
}
+- (id <WebDOMElement>)elementWithName:(NSString *)name inForm:(id <WebDOMElement>)form
+{
+ return [_private->bridge elementWithName:name inForm:form];
+}
+
- (id <WebDOMElement>)elementForView:(NSView *)view
{
return [_private->bridge elementForView:view];
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list