[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

darin darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:51:04 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 04b2f69d32bab7974dadd83cc12c123189ebe6de
Author: darin <darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Aug 12 18:26:09 2003 +0000

            Reviewed by Ken.
    
            - fixed 3226083 -- REGRESSION (Panther): white box overlaying select lists at nvidia.com drivers page
    
            * kwq/KWQListBox.mm: (QListBox::QListBox): Call releaseGState on the clip view
            that we make for the list box. This prevents the incorrect graphics state caching
            that causes the problem, although it's not entirely clear why this is necessary.
            This may ultimately turn out to be an AppKit bug, and if so we can roll out this change
            when the AppKit itself is fixed.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@4807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2003-10-25 b/WebCore/ChangeLog-2003-10-25
index 16c9c2c..cc8179c 100644
--- a/WebCore/ChangeLog-2003-10-25
+++ b/WebCore/ChangeLog-2003-10-25
@@ -1,3 +1,15 @@
+2003-08-12  Darin Adler  <darin at apple.com>
+
+        Reviewed by Ken.
+
+        - fixed 3226083 -- REGRESSION (Panther): white box overlaying select lists at nvidia.com drivers page
+
+        * kwq/KWQListBox.mm: (QListBox::QListBox): Call releaseGState on the clip view
+        that we make for the list box. This prevents the incorrect graphics state caching
+        that causes the problem, although it's not entirely clear why this is necessary.
+        This may ultimately turn out to be an AppKit bug, and if so we can roll out this change
+        when the AppKit itself is fixed.
+
 2003-08-12  David Hyatt  <hyatt at apple.com>
 
 	Fix for 3373462, XML shows up as blank because the root is inline.  The fix is
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 16c9c2c..cc8179c 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,15 @@
+2003-08-12  Darin Adler  <darin at apple.com>
+
+        Reviewed by Ken.
+
+        - fixed 3226083 -- REGRESSION (Panther): white box overlaying select lists at nvidia.com drivers page
+
+        * kwq/KWQListBox.mm: (QListBox::QListBox): Call releaseGState on the clip view
+        that we make for the list box. This prevents the incorrect graphics state caching
+        that causes the problem, although it's not entirely clear why this is necessary.
+        This may ultimately turn out to be an AppKit bug, and if so we can roll out this change
+        when the AppKit itself is fixed.
+
 2003-08-12  David Hyatt  <hyatt at apple.com>
 
 	Fix for 3373462, XML shows up as blank because the root is inline.  The fix is
diff --git a/WebCore/kwq/KWQListBox.mm b/WebCore/kwq/KWQListBox.mm
index 7e469f2..621bdcf 100644
--- a/WebCore/kwq/KWQListBox.mm
+++ b/WebCore/kwq/KWQListBox.mm
@@ -68,7 +68,15 @@ QListBox::QListBox(QWidget *parent)
     [scrollView setVerticalLineScroll:[tableView rowHeight]];
     
     [tableView release];
-    
+
+    // Something about the way we use the scroll view tickles what seems to be a bug
+    // in NSView's graphics state caching. In Panther, this led to a regression
+    // where list boxes would not update properly. Telling the clip view inside the
+    // scroll view we create not to cache the graphics state works around the problem.
+    // Eventually the AppKit team will pinpoint the problem and find a better fix.
+    // See Radar 3226083 for more details.
+    [[scrollView contentView] releaseGState];
+
     setView(scrollView);
     
     [scrollView release];

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list