[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

mjs mjs at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:51:42 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit ef3cfc51b94c3ade89a9f2933ca23bf0d4334b15
Author: mjs <mjs at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Aug 14 00:26:33 2003 +0000

            Reviewed by Ken.
    
    	- fixed 3365242 - non-repro abort in HTMLTokenizer at ajc.com
    
            * WebView.subproj/WebDataSourcePrivate.m:
            (-[WebDataSource _receivedData:]): ref the data source around
    	processing the data and afterwards, to avoid crashing if a script
    	in this chunk of data made the frame go away.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@4819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index 3d3eeaa..b824b15 100644
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,14 @@
+2003-08-12  Maciej Stachowiak  <mjs at apple.com>
+
+        Reviewed by Ken.
+
+	- fixed 3365242 - non-repro abort in HTMLTokenizer at ajc.com
+	
+        * WebView.subproj/WebDataSourcePrivate.m:
+        (-[WebDataSource _receivedData:]): ref the data source around
+	processing the data and afterwards, to avoid crashing if a script
+	in this chunk of data made the frame go away.
+
 2003-08-13  Richard Williamson   <rjw at apple.com>
 
 	Fixed 3376077.  Override automaticallyNotifiesObserversForKey: to
diff --git a/WebKit/WebView.subproj/WebDataSourcePrivate.m b/WebKit/WebView.subproj/WebDataSourcePrivate.m
index 3cc4561..fcb9dad 100644
--- a/WebKit/WebView.subproj/WebDataSourcePrivate.m
+++ b/WebKit/WebView.subproj/WebDataSourcePrivate.m
@@ -578,8 +578,13 @@
     _private->gotFirstByte = YES;
     [self _commitIfReady];
 
+    // parsing some of the page can result in running a script which
+    // could possibly destroy the frame and data source. So retain
+    // self temporarily.
+    [self retain];
     [[self representation] receivedData:data withDataSource:self];
     [[[[self webFrame] frameView] documentView] dataSourceUpdated:self];
+    [self release];
 }
 
 - (void)_finishedLoading

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list