[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

mjs mjs at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:51:56 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 5e2443cc4f228bb9d0769091296123ca40025a5c
Author: mjs <mjs at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Aug 15 00:49:12 2003 +0000

    Back out the last change, because the tree is closed. I am an idiot.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@4828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2003-10-25 b/WebCore/ChangeLog-2003-10-25
index fe7fb69..05dfc9d 100644
--- a/WebCore/ChangeLog-2003-10-25
+++ b/WebCore/ChangeLog-2003-10-25
@@ -1,14 +1,3 @@
-2003-08-14  Maciej Stachowiak  <mjs at apple.com>
-
-        Fixed by Darin, reviewed by me (and originally figured out by John).
-
-	- fixed 3375592 - New Yahoo Maps doesn't work right
-	
-        * kwq/KWQTextCodec.mm:
-        (KWQTextDecoder::convertUTF16): Don't pass through null characters.
-        (KWQTextDecoder::appendOmittingNullsAndBOMs): Ditto.
-        (KWQTextDecoder::convertUsingTEC): Ditto.
-
 2003-08-14  Vicki Murley  <vicki at apple.com>
 
         Reviewed by John. 
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index fe7fb69..05dfc9d 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,14 +1,3 @@
-2003-08-14  Maciej Stachowiak  <mjs at apple.com>
-
-        Fixed by Darin, reviewed by me (and originally figured out by John).
-
-	- fixed 3375592 - New Yahoo Maps doesn't work right
-	
-        * kwq/KWQTextCodec.mm:
-        (KWQTextDecoder::convertUTF16): Don't pass through null characters.
-        (KWQTextDecoder::appendOmittingNullsAndBOMs): Ditto.
-        (KWQTextDecoder::convertUsingTEC): Ditto.
-
 2003-08-14  Vicki Murley  <vicki at apple.com>
 
         Reviewed by John. 
diff --git a/WebCore/kwq/KWQTextCodec.mm b/WebCore/kwq/KWQTextCodec.mm
index 7288d50..8bfc304 100644
--- a/WebCore/kwq/KWQTextCodec.mm
+++ b/WebCore/kwq/KWQTextCodec.mm
@@ -47,7 +47,7 @@ private:
     OSStatus createTECConverter();
     OSStatus convertOneChunkUsingTEC(const unsigned char *inputBuffer, int inputBufferLength, int &inputLength,
         void *outputBuffer, int outputBufferLength, int &outputLength);
-    static void appendOmittingNullsAndBOMs(QString &s, const UniChar *characters, int byteCount);
+    static void appendOmittingBOMs(QString &s, const UniChar *characters, int byteCount);
     
     KWQTextDecoder(const KWQTextDecoder &);
     KWQTextDecoder &operator=(const KWQTextDecoder &);
@@ -254,9 +254,7 @@ QString KWQTextDecoder::convertUTF16(const unsigned char *s, int length)
         } else {
             c = (_bufferedBytes[0] << 8) | p[0];
         }
-        if (c) {
-            result.append(reinterpret_cast<QChar *>(&c), 1);
-        }
+        result.append(reinterpret_cast<QChar *>(&c), 1);
         _numBufferedBytes = 0;
         p += 1;
         len -= 1;
@@ -270,7 +268,7 @@ QString KWQTextDecoder::convertUTF16(const unsigned char *s, int length)
             for (int i = 0; i < runLength; ++i) {
                 UniChar c = p[0] | (p[1] << 8);
                 p += 2;
-                if (c && c != BOM) {
+                if (c != BOM) {
                     buffer[bufferLength++] = c;
                 }
             }
@@ -278,7 +276,7 @@ QString KWQTextDecoder::convertUTF16(const unsigned char *s, int length)
             for (int i = 0; i < runLength; ++i) {
                 UniChar c = (p[0] << 8) | p[1];
                 p += 2;
-                if (c && c != BOM) {
+                if (c != BOM) {
                     buffer[bufferLength++] = c;
                 }
             }
@@ -319,14 +317,13 @@ OSStatus KWQTextDecoder::createTECConverter()
     return noErr;
 }
 
-void KWQTextDecoder::appendOmittingNullsAndBOMs(QString &s, const UniChar *characters, int byteCount)
+void KWQTextDecoder::appendOmittingBOMs(QString &s, const UniChar *characters, int byteCount)
 {
     ASSERT(byteCount % sizeof(UniChar) == 0);
     int start = 0;
     int characterCount = byteCount / sizeof(UniChar);
     for (int i = 0; i != characterCount; ++i) {
-        UniChar c = characters[i];
-        if (c == 0 || c == BOM) {
+        if (characters[i] == BOM) {
             if (start != i) {
                 s.append(reinterpret_cast<const QChar *>(&characters[start]), i - start);
             }
@@ -445,13 +442,13 @@ QString KWQTextDecoder::convertUsingTEC(const unsigned char *chs, int len, bool
                 return QString();
         }
 
-        appendOmittingNullsAndBOMs(result, buffer, bytesWritten);
+        appendOmittingBOMs(result, buffer, bytesWritten);
     }
     
     if (flush) {
         unsigned long bytesWritten = 0;
         TECFlushText(_converter, reinterpret_cast<unsigned char *>(buffer), sizeof(buffer), &bytesWritten);
-        appendOmittingNullsAndBOMs(result, buffer, bytesWritten);
+        appendOmittingBOMs(result, buffer, bytesWritten);
     }
 
     // Workaround for a bug in the Text Encoding Converter (see bug 3225472).

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list