[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

darin darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:56:47 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit f2e9dbee527ce5949cf8742c20d0b2abee093407
Author: darin <darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sun Sep 21 04:00:16 2003 +0000

            Reviewed by Dave.
    
            - fixed 3419380 -- JavaScript Date.getTimezoneOffset is off by one hour (during daylight savings)
    
            * kjs/date_object.cpp: (DateProtoFuncImp::call): The daylight savings correction
            in here was incorrect. Perhaps I should have corrected it for the non-BSD case too,
            but I'm not sure the issue is the same.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
index 8bbf53a..215e503 100644
--- a/JavaScriptCore/ChangeLog
+++ b/JavaScriptCore/ChangeLog
@@ -1,3 +1,13 @@
+2003-09-20  Darin Adler  <darin at apple.com>
+
+        Reviewed by Dave.
+
+        - fixed 3419380 -- JavaScript Date.getTimezoneOffset is off by one hour (during daylight savings)
+
+        * kjs/date_object.cpp: (DateProtoFuncImp::call): The daylight savings correction
+        in here was incorrect. Perhaps I should have corrected it for the non-BSD case too,
+        but I'm not sure the issue is the same.
+
 2003-09-17  Darin Adler  <darin at apple.com>
 
         Reviewed by Maciej.
diff --git a/JavaScriptCore/ChangeLog-2003-10-25 b/JavaScriptCore/ChangeLog-2003-10-25
index 8bbf53a..215e503 100644
--- a/JavaScriptCore/ChangeLog-2003-10-25
+++ b/JavaScriptCore/ChangeLog-2003-10-25
@@ -1,3 +1,13 @@
+2003-09-20  Darin Adler  <darin at apple.com>
+
+        Reviewed by Dave.
+
+        - fixed 3419380 -- JavaScript Date.getTimezoneOffset is off by one hour (during daylight savings)
+
+        * kjs/date_object.cpp: (DateProtoFuncImp::call): The daylight savings correction
+        in here was incorrect. Perhaps I should have corrected it for the non-BSD case too,
+        but I'm not sure the issue is the same.
+
 2003-09-17  Darin Adler  <darin at apple.com>
 
         Reviewed by Maciej.
diff --git a/JavaScriptCore/kjs/date_object.cpp b/JavaScriptCore/kjs/date_object.cpp
index 96d4e34..fb13180 100644
--- a/JavaScriptCore/kjs/date_object.cpp
+++ b/JavaScriptCore/kjs/date_object.cpp
@@ -390,12 +390,14 @@ Value DateProtoFuncImp::call(ExecState *exec, Object &thisObj, const List &args)
     break;
   case GetTimezoneOffset:
 #if defined BSD || defined(__APPLE__)
-    result = Number(-( t->tm_gmtoff / 60 ) + ( t->tm_isdst ? 60 : 0 ));
+    result = Number(-t->tm_gmtoff / 60);
 #else
 #  if defined(__BORLANDC__)
 #error please add daylight savings offset here!
+    // FIXME: Using the daylight value was wrong for BSD, maybe wrong here too.
     result = Number(_timezone / 60 - (_daylight ? 60 : 0));
 #  else
+    // FIXME: Using the daylight value was wrong for BSD, maybe wrong here too.
     result = Number(( timezone / 60 - ( daylight ? 60 : 0 )));
 #  endif
 #endif

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list