[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

[kocienda]

The following commit has been merged in the debian/unstable branch:
commit 087b7da602fd8ee5f82b16ce61c10499c695e390
Author: kocienda <kocienda at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Oct 23 15:41:02 2003 +0000

            Reviewed by David
    
    	Fix for these bugs:
    
    	<rdar://problem/3171929>: Safari picks a different button in a
    	form when you hit return if the first button has no name
    	<rdar://problem/3200386>: investigate which button is activated
    	when hitting return in form text input fields
    
    	HTML spec says that buttons must have names to be considered
    	successful. However, other browsers do not impose this constraint.
    	Therefore, we behave differently, and can use different buttons than
    	the author intended.
    
            * khtml/html/html_formimpl.cpp:
            (HTMLButtonElementImpl::isSuccessfulSubmitButton)
            (HTMLInputElementImpl::isSuccessfulSubmitButton)
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2003-10-25 b/WebCore/ChangeLog-2003-10-25
index 12a585d..96da027 100644
--- a/WebCore/ChangeLog-2003-10-25
+++ b/WebCore/ChangeLog-2003-10-25
@@ -1,3 +1,23 @@
+2003-10-23  Ken Kocienda  <kocienda at apple.com>
+
+        Reviewed by David
+
+	Fix for these bugs:
+
+	<rdar://problem/3171929>: Safari picks a different button in a 
+	form when you hit return if the first button has no name
+	<rdar://problem/3200386>: investigate which button is activated 
+	when hitting return in form text input fields
+
+	HTML spec says that buttons must have names to be considered
+	successful. However, other browsers do not impose this constraint.
+	Therefore, we behave differently, and can use different buttons than
+	the author intended.
+
+        * khtml/html/html_formimpl.cpp:
+        (HTMLButtonElementImpl::isSuccessfulSubmitButton)
+        (HTMLInputElementImpl::isSuccessfulSubmitButton)
+
 2003-10-22  David Hyatt  <hyatt at apple.com>
 
 	Fix for 3460726, the user agent string was returning nil.  
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 12a585d..96da027 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,23 @@
+2003-10-23  Ken Kocienda  <kocienda at apple.com>
+
+        Reviewed by David
+
+	Fix for these bugs:
+
+	<rdar://problem/3171929>: Safari picks a different button in a 
+	form when you hit return if the first button has no name
+	<rdar://problem/3200386>: investigate which button is activated 
+	when hitting return in form text input fields
+
+	HTML spec says that buttons must have names to be considered
+	successful. However, other browsers do not impose this constraint.
+	Therefore, we behave differently, and can use different buttons than
+	the author intended.
+
+        * khtml/html/html_formimpl.cpp:
+        (HTMLButtonElementImpl::isSuccessfulSubmitButton)
+        (HTMLInputElementImpl::isSuccessfulSubmitButton)
+
 2003-10-22  David Hyatt  <hyatt at apple.com>
 
 	Fix for 3460726, the user agent string was returning nil.  
diff --git a/WebCore/khtml/html/html_formimpl.cpp b/WebCore/khtml/html/html_formimpl.cpp
index 3020edf..aa576ff 100644
--- a/WebCore/khtml/html/html_formimpl.cpp
+++ b/WebCore/khtml/html/html_formimpl.cpp
@@ -1031,7 +1031,14 @@ void HTMLButtonElementImpl::defaultEventHandler(EventImpl *evt)
 
 bool HTMLButtonElementImpl::isSuccessfulSubmitButton() const
 {
-    return m_type == SUBMIT && !m_disabled && !name().isEmpty();
+    // HTML spec says that buttons must have names
+    // to be considered successful. However, other browsers
+    // do not impose this constraint. Therefore, we behave
+    // differently and can use different buttons than the 
+    // author intended. 
+    // Remove the name constraint for now.
+    // Was: m_type == SUBMIT && !m_disabled && !name().isEmpty()
+    return m_type == SUBMIT && !m_disabled;
 }
 
 bool HTMLButtonElementImpl::isActivatedSubmit() const
@@ -1437,7 +1444,13 @@ DOMString HTMLInputElementImpl::altText() const
 
 bool HTMLInputElementImpl::isSuccessfulSubmitButton() const
 {
-    return !m_disabled && (m_type == IMAGE || (m_type == SUBMIT && !name().isEmpty()));
+    // HTML spec says that buttons must have names
+    // to be considered successful. However, other browsers
+    // do not impose this constraint. Therefore, we behave
+    // differently and can use different buttons than the 
+    // author intended. 
+    // Was: (m_type == SUBMIT && !name().isEmpty())
+    return !m_disabled && (m_type == IMAGE || m_type == SUBMIT);
 }
 
 bool HTMLInputElementImpl::isActivatedSubmit() const

-- 
WebKit Debian packaging