[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677
darin
darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 08:08:26 UTC 2009
The following commit has been merged in the debian/unstable branch:
commit 59a46d3f270df5b001b2e6f3339c6f87af4264b2
Author: darin <darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Sat Nov 1 01:26:31 2003 +0000
Reviewed by John.
- fixed 3457875 -- text disappears from fields in forms upon certain types of scrolling
* kwq/KWQTextField.mm: (-[KWQTextField control:textShouldBeginEditing:]):
Call releaseGState on the field editor and its clip view to prevent undesirable caching.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 93aa4e3..6eefc30 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,12 @@
+2003-10-31 Darin Adler <darin at apple.com>
+
+ Reviewed by John.
+
+ - fixed 3457875 -- text disappears from fields in forms upon certain types of scrolling
+
+ * kwq/KWQTextField.mm: (-[KWQTextField control:textShouldBeginEditing:]):
+ Call releaseGState on the field editor and its clip view to prevent undesirable caching.
+
2003-10-31 Ken Kocienda <kocienda at apple.com>
Reviewed by Darin
diff --git a/WebCore/kwq/KWQTextField.mm b/WebCore/kwq/KWQTextField.mm
index 1b9154c..662494d 100644
--- a/WebCore/kwq/KWQTextField.mm
+++ b/WebCore/kwq/KWQTextField.mm
@@ -276,6 +276,19 @@
}
WebCoreBridge *bridge = KWQKHTMLPart::bridgeForWidget(widget);
+
+ // In WebHTMLView, we set a clip. This is not typical to do in an
+ // NSView, and while correct for any one invocation of drawRect:,
+ // it causes some bad problems if that clip is cached between calls.
+ // The cached graphics state, which some views keep around, does
+ // cache the clip in this undesirable way. Consequently, we want to
+ // turn off this caching for all views contained in a WebHTMLView that
+ // would otherwise do it. Here we turn it off for the editor (NSTextView)
+ // used for text fields in forms and the clip view it's embedded in.
+ // See bug 3457875 and 3310943 for more context.
+ [fieldEditor releaseGState];
+ [[fieldEditor superview] releaseGState];
+
return [bridge control:control textShouldBeginEditing:fieldEditor];
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list