[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

[sullivan]

The following commit has been merged in the debian/unstable branch:
commit 65729d23f0501a795969a78327e3b43c6a49df40
Author: sullivan <sullivan at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Nov 4 18:57:06 2003 +0000

            - fixed <rdar://problem/3472813>: REGRESSION (100-111): Some tabs start
            out scrolled down to focused text field
    
            Reviewed by Ken.
    
            * WebView.subproj/WebHTMLView.m:
            (-[WebHTMLView acceptsFirstResponder]):
            The logic to avoid accepting first responder on clicks was too broad;
            it was rejecting first-responder-ness even for clicks outside of this
            view. Clicking a tab item was going through some logic in NSTabView
            looking for the first valid key view starting with the web view, but the
            web view was returning NO due to this faulty click logic. Thus the
            first subview text field was becoming first responder, and causing scroll.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index 3b97c8a..ebe460f 100644
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,19 @@
+2003-11-04  John Sullivan  <sullivan at apple.com>
+
+        - fixed <rdar://problem/3472813>: REGRESSION (100-111): Some tabs start 
+        out scrolled down to focused text field
+
+        Reviewed by Ken.
+
+        * WebView.subproj/WebHTMLView.m:
+        (-[WebHTMLView acceptsFirstResponder]):
+        The logic to avoid accepting first responder on clicks was too broad;
+        it was rejecting first-responder-ness even for clicks outside of this
+        view. Clicking a tab item was going through some logic in NSTabView
+        looking for the first valid key view starting with the web view, but the
+        web view was returning NO due to this faulty click logic. Thus the
+        first subview text field was becoming first responder, and causing scroll.
+
 2003-11-03  Chris Blumenberg  <cblu at apple.com>
 
 	Fixed:
diff --git a/WebKit/WebView.subproj/WebHTMLView.m b/WebKit/WebView.subproj/WebHTMLView.m
index 4804505..6c4801b 100644
--- a/WebKit/WebView.subproj/WebHTMLView.m
+++ b/WebKit/WebView.subproj/WebHTMLView.m
@@ -956,7 +956,8 @@ static WebHTMLView *lastHitView = nil;
     // Do accept first responder at any other time, for example from keyboard events,
     // or from calls back from WebCore once we begin mouse-down event handling.
     NSEvent *event = [NSApp currentEvent];
-    if ([event type] == NSLeftMouseDown && event != _private->mouseDownEvent) {
+    if ([event type] == NSLeftMouseDown && event != _private->mouseDownEvent && 
+        NSPointInRect([event locationInWindow], [self convertRect:[self visibleRect] toView:nil])) {
         return NO;
     }
     return YES;

-- 
WebKit Debian packaging