[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

darin darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 08:10:24 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 19a74761d2cf926dc4eb4a2179a27a34207e70c2
Author: darin <darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sat Nov 8 23:24:54 2003 +0000

            Reviewed by John.
    
            - fixed 3477509 -- REGRESSION (112-113): crash in KHTMLPart::processObjectRequest at espn.com, chosun.com
    
            * khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Use a dynamic_cast to check the type of the
            part rather than assuming it's always a KHTMLPart. The crash was caused by casting a KWQPluginPart to
            KHTMLPart.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 4c4a7b3..aaedb50 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,5 +1,15 @@
 2003-11-08  Darin Adler  <darin at apple.com>
 
+        Reviewed by John.
+
+        - fixed 3477509 -- REGRESSION (112-113): crash in KHTMLPart::processObjectRequest at espn.com, chosun.com
+
+        * khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Use a dynamic_cast to check the type of the
+        part rather than assuming it's always a KHTMLPart. The crash was caused by casting a KWQPluginPart to
+        KHTMLPart.
+
+2003-11-08  Darin Adler  <darin at apple.com>
+
         Reviewed by Richard.
 
         - event cleanup motivated by questions on khtml-devel
diff --git a/WebCore/khtml/khtml_part.cpp b/WebCore/khtml/khtml_part.cpp
index 80ff339..80f80f0 100644
--- a/WebCore/khtml/khtml_part.cpp
+++ b/WebCore/khtml/khtml_part.cpp
@@ -3237,8 +3237,11 @@ bool KHTMLPart::processObjectRequest( khtml::ChildFrame *child, const KURL &_url
     // before we could connect the signals, so make sure to send the
     // completed() signal for the child by hand:
     if (url.isEmpty() || url.url() == "about:blank") {
-      KParts::ReadOnlyPart *part = child->m_part;
-      static_cast<KHTMLPart *>(part)->completed();
+      ReadOnlyPart *readOnlyPart = child->m_part;
+      KHTMLPart *part = dynamic_cast<KHTMLPart *>(readOnlyPart);
+      if (part) {
+        part->completed();
+      }
     }
 #else
   if(url.protocol() == "javascript" || url.url() == "about:blank") {

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list