[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

kocienda kocienda at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 08:10:51 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 4ebbc44e9b60c5c690eab7d42b472d647b1b35af
Author: kocienda <kocienda at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Nov 10 22:41:21 2003 +0000

            Reviewed by Hyatt
    
    	Fix for this bug:
    
    	<rdar://problem/3477795>: REGRESSION: can't submit form without
    	submit button by hitting return (cocoadev.com)
    
    	When I changed submitting forms using the return key in a text field
    	to go through a search for the correct submit or image input
    	element to use when submitting, I neglected to cover the case of
    	forms which have neither a submit or image input element. When
    	I encounter a form such as this now, I submit it anyway after
    	performing the submit or image input element and failing to find one.
    
            * khtml/html/html_formimpl.cpp:
            (HTMLFormElementImpl::performSubmitClick)
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 96ad105..0787ad8 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,22 @@
+2003-11-10  Ken Kocienda  <kocienda at apple.com>
+
+        Reviewed by Hyatt
+
+	Fix for this bug:
+
+	<rdar://problem/3477795>: REGRESSION: can't submit form without 
+	submit button by hitting return (cocoadev.com)
+
+	When I changed submitting forms using the return key in a text field
+	to go through a search for the correct submit or image input 
+	element to use when submitting, I neglected to cover the case of
+	forms which have neither a submit or image input element. When
+	I encounter a form such as this now, I submit it anyway after
+	performing the submit or image input element and failing to find one.
+
+        * khtml/html/html_formimpl.cpp:
+        (HTMLFormElementImpl::performSubmitClick)
+
 2003-11-10  Richard Williamson   <rjw at apple.com>
 
 	Fixed 3478765.  Use ICU to access unicode properties.
diff --git a/WebCore/khtml/html/html_formimpl.cpp b/WebCore/khtml/html/html_formimpl.cpp
index ab237c1..20d8f19 100644
--- a/WebCore/khtml/html/html_formimpl.cpp
+++ b/WebCore/khtml/html/html_formimpl.cpp
@@ -145,11 +145,13 @@ long HTMLFormElementImpl::length() const
 #if APPLE_CHANGES
 void HTMLFormElementImpl::performSubmitClick()
 {
+    bool submitFound = false;
     QPtrListIterator<HTMLGenericFormElementImpl> it(formElements);
     for (; it.current(); ++it) {
         if (it.current()->id() == ID_INPUT) {
             HTMLInputElementImpl *element = static_cast<HTMLInputElementImpl *>(it.current());
             if (element->isSuccessfulSubmitButton() && element->renderer()) {
+                submitFound = true;
                 if (element->inputType() == HTMLInputElementImpl::IMAGE) {
                     // have to send simulated clicks differently for image types
                     // since they do not have a widget
@@ -166,6 +168,8 @@ void HTMLFormElementImpl::performSubmitClick()
             }
         }
     }
+    if (!submitFound) // submit the form without a submit or image input
+        prepareSubmit();
 }
 #endif
 

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list