[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

sullivan sullivan at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 08:21:05 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 2cb4be981cbf92bfca5c7a408e79b6a2c35bf796
Author: sullivan <sullivan at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Jan 6 23:39:26 2004 +0000

            - fixed <rdar://problem/3484465>: REGRESSION (118): button click does
            not take focus away from <textarea>; breaks Outlook Web Access
    
            Reviewed by Dave.
    
            * khtml/khtmlview.cpp:
            (KHTMLView::dispatchMouseEvent):
            Removed nodeimpl == nil test that was preventing button/link clicks
            from blurring previously-focused text field.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index ad2a619..2089299 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,15 @@
+2004-01-06  John Sullivan  <sullivan at apple.com>
+
+        - fixed <rdar://problem/3484465>: REGRESSION (118): button click does 
+        not take focus away from <textarea>; breaks Outlook Web Access
+
+        Reviewed by Dave.
+
+        * khtml/khtmlview.cpp:
+        (KHTMLView::dispatchMouseEvent):
+        Removed nodeimpl == nil test that was preventing button/link clicks
+        from blurring previously-focused text field.
+
 2004-01-06  David Hyatt  <hyatt at apple.com>
 
 	Fix for 3520636, infinite loop in page breaking code when printing.
diff --git a/WebCore/khtml/khtmlview.cpp b/WebCore/khtml/khtmlview.cpp
index 1a798ae..548b71a 100644
--- a/WebCore/khtml/khtmlview.cpp
+++ b/WebCore/khtml/khtmlview.cpp
@@ -1675,11 +1675,14 @@ bool KHTMLView::dispatchMouseEvent(int eventId, DOM::NodeImpl *targetNode, bool
         }
         else if (eventId == EventImpl::MOUSEDOWN_EVENT) {
             // Focus should be shifted on mouse down, not on a click.  -dwh
+            // Blur current focus node when a link/button is clicked; this
+            // is expected by some sites that rely on onChange handlers running
+            // from form fields before the button click is processed.
 	    DOM::NodeImpl* nodeImpl = targetNode;
 	    for ( ; nodeImpl && !nodeImpl->isFocusable(); nodeImpl = nodeImpl->parentNode());
             if (nodeImpl && nodeImpl->isMouseFocusable())
                 m_part->xmlDocImpl()->setFocusNode(nodeImpl);
-            else if (!nodeImpl)
+            else
                 m_part->xmlDocImpl()->setFocusNode(0);
         }
     }

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list