[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

kocienda kocienda at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 08:37:02 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 5aafc30f7d0cc1461b2fdba80660f8e347d97d9c
Author: kocienda <kocienda at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Apr 26 18:34:18 2004 +0000

            Reviewed by John
    
            Fix for this bug:
    
            <rdar://problem/3633458>: "REGRESSION (125-137): Can't drag a selection unless it starts at beginning of line"
    
            * khtml/khtml_part.cpp:
            (KHTMLPart::isPointInsideSelection): I flubbed when I converted this
            code to use my new positionForCoordinates helper. I failed to add in
            the passed in values for x and y to the absolute coordinates for the
            clicked node. So, the "unless it starts at beginning of line" behavior
            is exactly as one would expect.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@6484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 00ea685..43d2267 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,18 @@
+2004-04-26  Ken Kocienda  <kocienda at apple.com>
+
+        Reviewed by John
+        
+        Fix for this bug:
+        
+        <rdar://problem/3633458>: "REGRESSION (125-137): Can't drag a selection unless it starts at beginning of line"
+
+        * khtml/khtml_part.cpp:
+        (KHTMLPart::isPointInsideSelection): I flubbed when I converted this
+        code to use my new positionForCoordinates helper. I failed to add in
+        the passed in values for x and y to the absolute coordinates for the
+        clicked node. So, the "unless it starts at beginning of line" behavior 
+        is exactly as one would expect.
+
 2004-04-25  David Hyatt  <hyatt at apple.com>
 
 	Eliminate overhangingContents.  This concept was redundant with the overflowHeight mechanism that I
diff --git a/WebCore/khtml/khtml_part.cpp b/WebCore/khtml/khtml_part.cpp
index dade478..f81f60b 100644
--- a/WebCore/khtml/khtml_part.cpp
+++ b/WebCore/khtml/khtml_part.cpp
@@ -4514,7 +4514,7 @@ bool KHTMLPart::isPointInsideSelection(int x, int y)
     }
     int ax, ay;
     innerNode->renderer()->absolutePosition(ax, ay);
-    Position pos(innerNode->positionForCoordinates(ax, ay));
+    Position pos(innerNode->positionForCoordinates(ax + x, ay + y));
     if (pos.isEmpty()) {
         return false;
     }

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list