[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

kocienda kocienda at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 08:40:14 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit a0caa78a157fe04384370d6195c269cc8fd4c79e
Author: kocienda <kocienda at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon May 17 21:56:34 2004 +0000

            Reviewed by John
    
            Remove overrides in WebView for scrollPageDown and scrollPageUp.
            NSView behavior gives us just what we want, and there is no
            special behavior required for editing.
    
            <rdar://problem/3655364>: "Editing:�scrollPageDown:�ethod�nimplemented�WebKit�diting�PI)"
            <rdar://problem/3655365>: "Editing:�scrollPageUp:�ethod�nimplemented�WebKit�diting�PI)"
    
            * WebView.subproj/WebView.h: Comment methods out and add a note about why.
            * WebView.subproj/WebView.m: Remove stubbed out implementation.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@6619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index 264eb8e..c9cad8e 100644
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,17 @@
+2004-05-17  Ken Kocienda  <kocienda at apple.com>
+
+        Reviewed by John
+
+        Remove overrides in WebView for scrollPageDown and scrollPageUp.
+        NSView behavior gives us just what we want, and there is no
+        special behavior required for editing.
+
+        <rdar://problem/3655364>: "Editing:Ê-scrollPageDown:ÊmethodÊunimplementedÊ(WebKitÊeditingÊAPI)"
+        <rdar://problem/3655365>: "Editing:Ê-scrollPageUp:ÊmethodÊunimplementedÊ(WebKitÊeditingÊAPI)"
+
+        * WebView.subproj/WebView.h: Comment methods out and add a note about why.
+        * WebView.subproj/WebView.m: Remove stubbed out implementation.
+
 2004-05-14  Vicki Murley  <vicki at apple.com>
 
         Reviewed by mjs.
diff --git a/WebKit/WebView.subproj/WebView.h b/WebKit/WebView.subproj/WebView.h
index 0d3863e..2c1e88a 100644
--- a/WebKit/WebView.subproj/WebView.h
+++ b/WebKit/WebView.subproj/WebView.h
@@ -607,8 +607,7 @@ extern NSString * const WebViewDidChangeSelectionNotification;
 - (void)pageUp:(id)sender;
 - (void)scrollLineDown:(id)sender;
 - (void)scrollLineUp:(id)sender;
-- (void)scrollPageDown:(id)sender;
-- (void)scrollPageUp:(id)sender;
+// Use default responder behavior for scrollPageDown: and scrollPageUp:.
 
     /* Selections */
 
diff --git a/WebKit/WebView.subproj/WebView.m b/WebKit/WebView.subproj/WebView.m
index 61a629b..dbec7b8 100644
--- a/WebKit/WebView.subproj/WebView.m
+++ b/WebKit/WebView.subproj/WebView.m
@@ -2746,24 +2746,6 @@ static NSFont *_fontFromStyle(DOMCSSStyleDeclaration *style)
     [[self nextResponder] tryToPerform:@selector(scrollLineUp:) with:sender];
 }
 
-- (void)scrollPageDown:(id)sender
-{
-    if ([self _currentSelectionIsEditable]) {
-        ERROR("unimplemented");
-        return;
-    }
-    [[self nextResponder] tryToPerform:@selector(scrollPageDown:) with:sender];
-}
-
-- (void)scrollPageUp:(id)sender
-{
-    if ([self _currentSelectionIsEditable]) {
-        ERROR("unimplemented");
-        return;
-    }
-    [[self nextResponder] tryToPerform:@selector(scrollPageUp:) with:sender];
-}
-
 
     /* Selections */
 

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list