[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

[kocienda]

The following commit has been merged in the debian/unstable branch:
commit 4620363526fb516aab1a7857bf38ce7f9c8d2316
Author: kocienda <kocienda at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Jul 6 22:18:06 2004 +0000

            Reviewed by me
    
            * khtml/html/html_tableimpl.cpp:
            (HTMLTableElementImpl::addChild): Added a better comment in the
            code I just checked in a few minutes ago.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@6967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index e189257..c5e2f6c 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,5 +1,13 @@
 2004-07-06  Ken Kocienda  <kocienda at apple.com>
 
+        Reviewed by me
+
+        * khtml/html/html_tableimpl.cpp:
+        (HTMLTableElementImpl::addChild): Added a better comment in the
+        code I just checked in a few minutes ago.
+
+2004-07-06  Ken Kocienda  <kocienda at apple.com>
+
         Reviewed by Hyatt
         
         Fix for this bug:
diff --git a/WebCore/khtml/html/html_tableimpl.cpp b/WebCore/khtml/html/html_tableimpl.cpp
index 42e03bd..10b1526 100644
--- a/WebCore/khtml/html/html_tableimpl.cpp
+++ b/WebCore/khtml/html/html_tableimpl.cpp
@@ -316,7 +316,13 @@ NodeImpl *HTMLTableElementImpl::addChild(NodeImpl *child)
         return this;
     }
     
-    // check node allowed
+    // We do not want this check-node-allowed test here, however the code to
+    // build up tables relies on childAllowed failing to make sure that the
+    // table is well-formed, the primary work being to add a tbody element.
+    // As 99.9999% of tables on the weeb do not have tbody elements, it seems
+    // odd to traverse an "error" case for the most common table markup.
+    // See <rdar://problem/3719373> Table parsing and construction relies on 
+    // childAllowed failures to build up proper DOM
     if (child->nodeType() == Node::DOCUMENT_FRAGMENT_NODE) {
         // child is a DocumentFragment... check all its children instead of child itself
         for (NodeImpl *c = child->firstChild(); c; c = c->nextSibling())

-- 
WebKit Debian packaging