[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

sullivan sullivan at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 08:52:25 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit fcc51b310021d826725bf0a9875f15931376beaa
Author: sullivan <sullivan at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Jul 23 21:42:11 2004 +0000

            Reviewed by Maciej.
    
            - fixed <rdar://problem/3691569> REGRESSION (142): cmd-shift-clicking on a link
            now also extends selection (even if there wasn't one before)
    
            * khtml/khtml_part.cpp:
            (KHTMLPart::handleMousePressEventSingleClick):
            Uh, duh. Got a ! wrong last time somehow, so it did even more the wrong thing
            than ever. I did test this before, so my best guess is an accidental undo or
            something before committing.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@7115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 5ffac1e..c9ce4c1 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,16 @@
+2004-07-23  John Sullivan  <sullivan at apple.com>
+
+        Reviewed by Maciej.
+
+        - fixed <rdar://problem/3691569> REGRESSION (142): cmd-shift-clicking on a link 
+        now also extends selection (even if there wasn't one before)
+
+        * khtml/khtml_part.cpp:
+        (KHTMLPart::handleMousePressEventSingleClick):
+        Uh, duh. Got a ! wrong last time somehow, so it did even more the wrong thing
+        than ever. I did test this before, so my best guess is an accidental undo or
+        something before committing.
+
 2004-07-23  David Hyatt  <hyatt at apple.com>
 
 	Fix for 3735084 and 3737209, when you can find no line boxes in your previous sibling, the line box to dirty
diff --git a/WebCore/khtml/khtml_part.cpp b/WebCore/khtml/khtml_part.cpp
index 5a41a76..e5d7bab 100644
--- a/WebCore/khtml/khtml_part.cpp
+++ b/WebCore/khtml/khtml_part.cpp
@@ -4402,7 +4402,7 @@ void KHTMLPart::handleMousePressEventSingleClick(khtml::MousePressEvent *event)
         if (!innerNode.isNull() && innerNode.handle()->renderer() &&
             innerNode.handle()->renderer()->shouldSelect()) {
             // Extend the selection if the Shift key is down, unless the click is in a link.
-            bool extendSelection = (mouse->state() & ShiftButton) && (!event->url().isNull());
+            bool extendSelection = (mouse->state() & ShiftButton) && (event->url().isNull());
 
             // Don't restart the selection when the mouse is pressed on an
             // existing selection so we can allow for text dragging.

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list