[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

mjs mjs at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 07:32:20 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 08b95c999f743b7f1790bc2ae8524a42768bf088
Author: mjs <mjs at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sun Mar 30 07:20:05 2003 +0000

            Reviewed by Trey.
    
    	- fixed 3180786 - Can't log in to the LL Bean Web site
    
    	The problem on this site was misnested tags, leading to two FORM
    	elements that were nested. Both their onSubmit handlers fired, and
    	the outer one returned false. The fix was to avoid bubbling submit
    	events, since this can never be useful in a valid document and
    	because that is what other browsers seem to do, and what Win IE
    	documents.
    
            * khtml/html/html_formimpl.cpp:
            (HTMLFormElementImpl::prepareSubmit): Don't allow the submit event to bubble.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2003-10-25 b/WebCore/ChangeLog-2003-10-25
index 49f8141..a68e280 100644
--- a/WebCore/ChangeLog-2003-10-25
+++ b/WebCore/ChangeLog-2003-10-25
@@ -1,3 +1,19 @@
+2003-03-29  Maciej Stachowiak  <mjs at apple.com>
+
+        Reviewed by Trey.
+
+	- fixed 3180786 - Can't log in to the LL Bean Web site
+
+	The problem on this site was misnested tags, leading to two FORM
+	elements that were nested. Both their onSubmit handlers fired, and
+	the outer one returned false. The fix was to avoid bubbling submit
+	events, since this can never be useful in a valid document and
+	because that is what other browsers seem to do, and what Win IE
+	documents.
+	
+        * khtml/html/html_formimpl.cpp:
+        (HTMLFormElementImpl::prepareSubmit): Don't allow the submit event to bubble.
+
 2003-03-28  Maciej Stachowiak  <mjs at apple.com>
 
         Reviewed by Ken.
diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 49f8141..a68e280 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,19 @@
+2003-03-29  Maciej Stachowiak  <mjs at apple.com>
+
+        Reviewed by Trey.
+
+	- fixed 3180786 - Can't log in to the LL Bean Web site
+
+	The problem on this site was misnested tags, leading to two FORM
+	elements that were nested. Both their onSubmit handlers fired, and
+	the outer one returned false. The fix was to avoid bubbling submit
+	events, since this can never be useful in a valid document and
+	because that is what other browsers seem to do, and what Win IE
+	documents.
+	
+        * khtml/html/html_formimpl.cpp:
+        (HTMLFormElementImpl::prepareSubmit): Don't allow the submit event to bubble.
+
 2003-03-28  Maciej Stachowiak  <mjs at apple.com>
 
         Reviewed by Ken.
diff --git a/WebCore/khtml/html/html_formimpl.cpp b/WebCore/khtml/html/html_formimpl.cpp
index 1711c04..42b9b5e 100644
--- a/WebCore/khtml/html/html_formimpl.cpp
+++ b/WebCore/khtml/html/html_formimpl.cpp
@@ -469,7 +469,7 @@ bool HTMLFormElementImpl::prepareSubmit()
     m_insubmit = true;
     m_doingsubmit = false;
 
-    if ( dispatchHTMLEvent(EventImpl::SUBMIT_EVENT,true,true) && !m_doingsubmit )
+    if ( dispatchHTMLEvent(EventImpl::SUBMIT_EVENT,false,true) && !m_doingsubmit )
         m_doingsubmit = true;
 
     m_insubmit = false;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list