[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

darin darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 08:08:16 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 7f0a19124370feac34d403fbc8653c5c39249a44
Author: darin <darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Oct 31 20:14:21 2003 +0000

            Reviewed by Dave.
    
            - fixed 3464759 -- REGRESSION (100-107): Pressing on link loses mouse-down feedback almost instantly
    
            * khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): Pass true for the "read-only"
            flag in prepareMoveEvent to prevent us from updating :hover and :active while the mouse is down.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index d86076a..a21871b 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,12 @@
+2003-10-31  Darin Adler  <darin at apple.com>
+
+        Reviewed by Dave.
+
+        - fixed 3464759 -- REGRESSION (100-107): Pressing on link loses mouse-down feedback almost instantly
+
+        * khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): Pass true for the "read-only"
+        flag in prepareMoveEvent to prevent us from updating :hover and :active while the mouse is down.
+
 2003-10-31  Ken Kocienda  <kocienda at apple.com>
 
         Reviewed by David
diff --git a/WebCore/khtml/khtmlview.cpp b/WebCore/khtml/khtmlview.cpp
index 921f267..769da6e 100644
--- a/WebCore/khtml/khtmlview.cpp
+++ b/WebCore/khtml/khtmlview.cpp
@@ -619,11 +619,12 @@ void KHTMLView::layout()
 #endif
     
 #ifdef INCREMENTAL_REPAINTING
-    if (root->needsLayout()) {
+    if (root->needsLayout())
 #else
     // Do not allow a full layout if we had a clip object set.
-    if ( root->needsLayout() && !m_layoutObject) {
+    if ( root->needsLayout() && !m_layoutObject)
 #endif
+    {
         //qDebug("needs layout, delaying repaint");
         scheduleRelayout();
         return;
@@ -770,8 +771,11 @@ void KHTMLView::viewportMouseMoveEvent( QMouseEvent * _mouse )
     int xm, ym;
     viewportToContents(_mouse->x(), _mouse->y(), xm, ym);
 
+    // Treat mouse move events while the mouse is pressed as "read-only" in prepareMouseEvent.
+    // This means that :hover and :active freeze in the state they were in when the mouse
+    // was pressed, rather than updating for nodes the mouse moves over as you hold the mouse down.
     DOM::NodeImpl::MouseEvent mev( _mouse->stateAfter(), DOM::NodeImpl::MouseMove );
-    m_part->xmlDocImpl()->prepareMouseEvent( false, xm, ym, &mev );
+    m_part->xmlDocImpl()->prepareMouseEvent( d->mousePressed, xm, ym, &mev );
 #if APPLE_CHANGES
     if (KWQ(m_part)->passSubframeEventToSubframe(mev))
         return;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list