[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677

kocienda kocienda at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 08:09:21 UTC 2009


The following commit has been merged in the debian/unstable branch:
commit 3454f6f8e8dadcb95c09d83af8839e68222171f0
Author: kocienda <kocienda at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Nov 5 18:10:05 2003 +0000

            Reviewed by Darin
    
    	Fix for this bug:
    
    	<rdar://problem/3455910>: hitting up or down arrows when focus
    	is on a pop-up menu should pop the menu
    
            * WebView.subproj/WebFrameView.m:
            (-[WebFrameView keyDown:]): Call super with the event if focus
    	is on a pop up button.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index cd94fd9..8d2bb08 100644
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,5 +1,18 @@
 2003-11-05  Ken Kocienda  <kocienda at apple.com>
 
+        Reviewed by Darin
+
+	Fix for this bug:
+
+	<rdar://problem/3455910>: hitting up or down arrows when focus 
+	is on a pop-up menu should pop the menu
+
+        * WebView.subproj/WebFrameView.m:
+        (-[WebFrameView keyDown:]): Call super with the event if focus 
+	is on a pop up button.
+
+2003-11-05  Ken Kocienda  <kocienda at apple.com>
+
         Reviewed by Maciej
 
         Fix for these bugs:
diff --git a/WebKit/WebView.subproj/WebFrameView.m b/WebKit/WebView.subproj/WebFrameView.m
index 8ddca8e..c5b33fb 100644
--- a/WebKit/WebView.subproj/WebFrameView.m
+++ b/WebKit/WebView.subproj/WebFrameView.m
@@ -610,7 +610,11 @@ static NSMutableDictionary *viewTypes;
                 callSuper = NO;
                 break;
             case NSUpArrowFunctionKey:
-                if (![self allowsScrolling]) {
+                if (![self allowsScrolling] ||
+                    [[[self window] firstResponder] isKindOfClass:[NSPopUpButton class]]) {
+                    // Let arrow keys go through to pop up buttons
+                    // <rdar://problem/3455910>: hitting up or down arrows when focus is on a 
+                    // pop-up menu should pop the menu
                     callSuper = YES;
                     break;
                 }
@@ -624,7 +628,11 @@ static NSMutableDictionary *viewTypes;
                 callSuper = NO;
                 break;
             case NSDownArrowFunctionKey:
-                if (![self allowsScrolling]) {
+                if (![self allowsScrolling] ||
+                    [[[self window] firstResponder] isKindOfClass:[NSPopUpButton class]]) {
+                    // Let arrow keys go through to pop up buttons
+                    // <rdar://problem/3455910>: hitting up or down arrows when focus is on a 
+                    // pop-up menu should pop the menu
                     callSuper = YES;
                     break;
                 }

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list