[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.15-1-40151-g37bb677
darin
darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sat Sep 26 08:44:17 UTC 2009
The following commit has been merged in the debian/unstable branch:
commit d7fe0588304619aa7b42497950d042a5c21ade24
Author: darin <darin at 268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Jun 8 00:10:30 2004 +0000
Reviewed by Chris.
- fixed <rdar://problem/3676761>: (REGRESSION: Text Bigger/Smaller commands are always disabled in TOT)
* WebView.subproj/WebHTMLView.m: Add @interface declaration for WebTextSizing category
on WebHTMLView. This must have gotten lost somewhere along the way.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@6785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index f85e311..971ccb2 100644
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,21 +1,30 @@
+2004-06-07 Darin Adler <darin at apple.com>
+
+ Reviewed by Chris.
+
+ - fixed <rdar://problem/3676761>: (REGRESSION: Text Bigger/Smaller commands are always disabled in TOT)
+
+ * WebView.subproj/WebHTMLView.m: Add @interface declaration for WebTextSizing category
+ on WebHTMLView. This must have gotten lost somewhere along the way.
+
2004-06-05 Trey Matteson <trey at apple.com>
- WebKit no longer causes an endless stream of dragexit events to
- occur at the DHTML level when hovering over an element that is
- not accepting the drag.
+ WebKit no longer causes an endless stream of dragexit events to
+ occur at the DHTML level when hovering over an element that is
+ not accepting the drag.
Reviewed by Chris
* WebView.subproj/WebView.m:
(-[WebView _dragOperationForDraggingInfo:]): If the potential target refuses
- the item, don't turn around and immediately tell it to cancel the drag, which is
- what leads to the exit event happening at the DOM level. If the target just
- refused the drag, it should not have anything it needs to cancel.
+ the item, don't turn around and immediately tell it to cancel the drag, which is
+ what leads to the exit event happening at the DOM level. If the target just
+ refused the drag, it should not have anything it needs to cancel.
2004-06-03 Trey Matteson <trey at apple.com>
- DHTML dragging uses the Cocoa NSDragOperation on both the source and dest ends.
- Most of the real work is in WebCore.
+ DHTML dragging uses the Cocoa NSDragOperation on both the source and dest ends.
+ Most of the real work is in WebCore.
Reviewed by rjw
@@ -24,7 +33,7 @@
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView _startDraggingImage:at:operation:event:]): Remember drag op from WC.
(-[WebHTMLView mouseDragged:]): Pass None for the op (alternate code path that will
- be going away).
+ be going away).
(-[WebHTMLView draggingSourceOperationMaskForLocal:]): Use the WC drag op.
* WebView.subproj/WebHTMLViewInternal.h:
* WebView.subproj/WebHTMLViewPrivate.h:
@@ -33,7 +42,7 @@
2004-06-04 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3674921>: (can't drag an image from Desktop to Blot document)
+ Fixed: <rdar://problem/3674921>: (can't drag an image from Desktop to Blot document)
Reviewed by mjs.
@@ -60,9 +69,8 @@
2004-06-03 Richard Williamson <rjw at apple.com>
- Add SPI to allow setting of plugin load path.
-
- Reviewed by Hyatt.
+ Add SPI to allow setting of plugin load path.
+ Reviewed by Hyatt.
* Plugins.subproj/WebPluginDatabase.h:
* Plugins.subproj/WebPluginDatabase.m:
@@ -100,11 +108,10 @@
2004-06-02 Richard Williamson <rjw at apple.com>
- conformsToProtocol:@protocol(WebPlugin) becomes
- respondsToSelector:@selector(webPlugInInitialize) because
- protocol was changed to an informal protocol.
-
- Reviewed by Kevin.
+ conformsToProtocol:@protocol(WebPlugin) becomes
+ respondsToSelector:@selector(webPlugInInitialize) because
+ protocol was changed to an informal protocol.
+ Reviewed by Kevin.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge frameRequiredForMIMEType:URL:]):
@@ -113,22 +120,22 @@
2004-06-01 Trey Matteson <trey at apple.com>
- First cut at source side of DHTML dragging. Most of the work is in WebCore.
+ First cut at source side of DHTML dragging. Most of the work is in WebCore.
Reviewed by hyatt.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge startDraggingImage:at:event:]): Added image and loc args for
- when WC tells WK to start a drag.
+ when WC tells WK to start a drag.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView _startDraggingImage:at:event:]): New image and loc args coming
- from WebCore. Hysteresis is moved to WC.
+ from WebCore. Hysteresis is moved to WC.
(-[WebHTMLView mouseDragged:]): Call new _startDragging method.
(-[WebHTMLView draggedImage:movedTo:]): Pass event to WC.
(-[WebHTMLView draggedImage:endedAt:operation:]): Pass event to WC.
(-[WebHTMLView mouseUp:]): Reset firstMouseDownEvent. Fixes bug where
- we would occasionally short-circuit WC event handling due to aliasing
- problem with this event.
+ we would occasionally short-circuit WC event handling due to aliasing
+ problem with this event.
* WebView.subproj/WebHTMLViewPrivate.h:
2004-06-02 Darin Adler <darin at apple.com>
@@ -1015,7 +1022,6 @@
2004-05-18 David Hyatt <hyatt at apple.com>
Improve layout scheduling.
-
Reviewed by kocienda
* WebView.subproj/WebFrame.m:
@@ -1027,25 +1033,23 @@
2004-05-18 Richard Williamson <rjw at apple.com>
Finished implementation of windowScriptObject.
-
- Reviewed by Maciej.
+ Reviewed by Maciej.
* WebView.subproj/WebView.m:
(-[WebView windowScriptObject]):
2004-05-18 Richard Williamson <rjw at apple.com>
- Added WebKit portion of webView:windowScriptObjectAvailable:
- implementation. Still need to implement creating the WebScriptObject
- wrapper on the WebCore side.
-
+ Added WebKit portion of webView:windowScriptObjectAvailable:
+ implementation. Still need to implement creating the WebScriptObject
+ wrapper on the WebCore side.
+
Reviewed by Maciej.
- Removed "_" from _setPageWidthForPrinting:. This method facilitates
- a work-around for carbon printing. At some point we may make this
- method public API.
-
- Reviewed by Chris.
+ Removed "_" from _setPageWidthForPrinting:. This method facilitates
+ a work-around for carbon printing. At some point we may make this
+ method public API.
+ Reviewed by Chris.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge overrideMediaType]):
@@ -1073,15 +1077,14 @@
2004-05-17 David Hyatt <hyatt at apple.com>
- Fix for performance regression in PLT caused by not setting _timeOfLastCompletedLoad, causing
+ Fix for performance regression in PLT caused by not setting _timeOfLastCompletedLoad, causing
page cache to release during the benchmark.
-
* WebView.subproj/WebFrame.m:
(-[WebFrame _setState:]):
2004-05-17 Chris Blumenberg <cblu at apple.com>
- Implemented new WebView pasteboard methods. Made a lot of factoring changes related to pasteboard management.
+ Implemented new WebView pasteboard methods. Made a lot of factoring changes related to pasteboard management.
Reviewed by john.
@@ -1105,7 +1108,7 @@
(-[WebHTMLView _dragImageForLinkElement:]): tweak
(-[WebHTMLView _handleMouseDragged:]): call renamed methods
(-[WebHTMLView pasteboardTypesForSelection]): new
- (-[WebTextView writeSelectionWithPasteboardTypes:toPasteboard:]): new, code moved from _writeSelectionToPasteboard:
+ (-[WebTextView writeSelectionWithPasteboardTypes:toPasteboard:]): new, code moved from _writeSelectionToPasteboard:
* WebView.subproj/WebHTMLViewPrivate.h:
* WebView.subproj/WebImageView.h:
* WebView.subproj/WebImageView.m:
@@ -1147,14 +1150,13 @@
Reviewed by mjs.
- <rdar://problem/3642427>: framework marketing number should be 2.0 for DoubleBarrel release
+ <rdar://problem/3642427>: framework marketing number should be 2.0 for DoubleBarrel release
* WebKit.pbproj/project.pbxproj: change CFBundleShortVersionString to 2.0
2004-05-14 David Hyatt <hyatt at apple.com>
- Eliminate timedLayout.
-
+ Eliminate timedLayout.
Reviewed by darin
* WebView.subproj/WebFrame.m:
@@ -1170,7 +1172,7 @@
2004-05-14 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3655495>: (exception loading applets)
+ Fixed: <rdar://problem/3655495>: (exception loading applets)
Reviewed by kocienda.
@@ -1179,7 +1181,7 @@
2004-05-14 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3655204>: (repro assertion failure and crash loading java applets)
+ Fixed: <rdar://problem/3655204>: (repro assertion failure and crash loading java applets)
Reviewed by kocienda.
@@ -1188,7 +1190,7 @@
2004-05-14 Chris Blumenberg <cblu at apple.com>
- Copied headers from WebCore.
+ Copied headers from WebCore.
* DOM.subproj/DOMCore.h:
* DOM.subproj/DOMEvents.h:
@@ -1203,14 +1205,14 @@
2004-05-13 Richard Williamson <rjw at apple.com>
- Backed out mistaken change that I didn't mean to checkin.
+ Backed out mistaken change that I didn't mean to checkin.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2004-05-13 Richard Williamson <rjw at apple.com>
- Updated to reflect new API.
+ Updated to reflect new API.
Reviewed by Chris.
@@ -1221,7 +1223,7 @@
2004-05-13 Chris Blumenberg <cblu at apple.com>
- Fixed some indenting issues in public headers.
+ Fixed some indenting issues in public headers.
* Plugins.subproj/WebJavaPlugIn.h:
* Plugins.subproj/WebPlugin.h:
@@ -1244,9 +1246,9 @@
2004-05-13 Richard Williamson <rjw at apple.com>
- Updated to implementation to reflect new API. Left old SPI
- in place for compatibility. Can remove when the Java plug-in
- updates.
+ Updated to implementation to reflect new API. Left old SPI
+ in place for compatibility. Can remove when the Java plug-in
+ updates.
Reviewed by Chris.
@@ -1268,16 +1270,16 @@
2004-05-13 Chris Blumenberg <cblu at apple.com>
- - Added stubs for WebView action and drag & drop customization API's
- - Fixed: <rdar://problem/3616555>: (API: Make DOM extensions and WebKit DOM operations public)
+ - Added stubs for WebView action and drag & drop customization API's
+ - Fixed: <rdar://problem/3616555>: (API: Make DOM extensions and WebKit DOM operations public)
Reviewed by rjw.
* DOM.subproj/WebDOMOperations.h: added remaining DOM operations
* DOM.subproj/WebDOMOperationsPrivate.h:
- * Misc.subproj/WebKit.h: added new public headers
+ * Misc.subproj/WebKit.h: added new public headers
* WebKit.pbproj/project.pbxproj:
- * WebKit.exp: added symbol for WebElementDOMNodeKey
+ * WebKit.exp: added symbol for WebElementDOMNodeKey
* WebView.subproj/WebUIDelegate.h: added new UI delegate methods
* WebView.subproj/WebView.h: added new pasteboard related methods
* WebView.subproj/WebView.m:
@@ -1292,11 +1294,11 @@
2004-05-13 Richard Williamson <rjw at apple.com>
- Changed imports of all DOM headers. DOM headers
- should be imported using the normal #import <WebCore/foo.h>,
- they import is modified when copied to WebKit.
+ Changed imports of all DOM headers. DOM headers
+ should be imported using the normal #import <WebCore/foo.h>,
+ they import is modified when copied to WebKit.
- Other approved API changes. Currently unimplemented.
+ Other approved API changes. Currently unimplemented.
Reviewed by Chris.
@@ -1343,22 +1345,22 @@
2004-05-12 Chris Blumenberg <cblu at apple.com>
- Fixed:
- <rdar://problem/3633296>: (Japanese input is not working properly in Carbon Web Kit applications (including CarbonWeb))
- <rdar://problem/3631390>: (can't toggle between Input Methods (IMEs) using cmd-space in Carbon Web Kit applications)
+ Fixed:
+ <rdar://problem/3633296>: (Japanese input is not working properly in Carbon Web Kit applications (including CarbonWeb))
+ <rdar://problem/3631390>: (can't toggle between Input Methods (IMEs) using cmd-space in Carbon Web Kit applications)
Reviewed by rjw.
- * Carbon.subproj/CarbonWindowAdapter.m:
+ * Carbon.subproj/CarbonWindowAdapter.m:
(-[CarbonWindowAdapter sendSuperEvent:]): call [NSInputContext processInputKeyBindings:inEvent] just as NSApp does
* Carbon.subproj/HIWebView.m:
(HIWebViewEventHandler): [NSApp setWindowsNeedUpdate:YES] must be called before events so that ActivateTSMDocument is called to set an active document. Without an active document, TSM will use a default document which uses a bottom-line input window which we don't want.
2004-05-11 Chris Blumenberg <cblu at apple.com>
- Fixed:
- <rdar://problem/3616537>: (API: Make WebResource, WebArchive and related API's public)
- <rdar://problem/3616471>: (API: provide way to get from WebFrame to DOMDocument and vice versa)
+ Fixed:
+ <rdar://problem/3616537>: (API: Make WebResource, WebArchive and related API's public)
+ <rdar://problem/3616471>: (API: provide way to get from WebFrame to DOMDocument and vice versa)
Reviewed by rjw.
@@ -1400,8 +1402,8 @@
Reviewed by Darin.
- - avoid redecoding animated images that are only used once for
- ~2.5% iBench speedup (WebCore part of fix)
+ - avoid redecoding animated images that are only used once for
+ ~2.5% iBench speedup (WebCore part of fix)
* WebCoreSupport.subproj/WebImageRenderer.h:
* WebCoreSupport.subproj/WebImageRenderer.m:
@@ -1419,27 +1421,27 @@
Reviewed by Ken.
- - avoid messing with undo manager needlessly for ~1% HTML iBench speedup
+ - avoid messing with undo manager needlessly for ~1% HTML iBench speedup
* WebCoreSupport.subproj/WebBridge.h:
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge registerCommandForUndo:]): mark undo/redo item flag
(-[WebBridge registerCommandForRedo:]): ditto
(-[WebBridge clearUndoRedoOperations]): check flag before removing items,
- and clear it after removing them
+ and clear it after removing them
2004-05-08 Maciej Stachowiak <mjs at apple.com>
Reviewed by Darin.
- - -[WebFrame childFrames] is so hot that a special internal
- version which avoids the copy and autorelease results in a .75%
- performance improvement on HTML iBench.
+ - -[WebFrame childFrames] is so hot that a special internal
+ version which avoids the copy and autorelease results in a .75%
+ performance improvement on HTML iBench.
* WebView.subproj/WebFramePrivate.h: Prototype new method.
* WebView.subproj/WebFrame.m:
- (-[WebFrame _internalChildFrames]): New method, just returns
- internal value instead of copying.
+ (-[WebFrame _internalChildFrames]): New method, just returns
+ internal value instead of copying.
(-[WebFrame _descendantFrameNamed:]): Use it
(-[WebFrame _textSizeMultiplierChanged]): likewise
@@ -1448,12 +1450,12 @@
(-[WebFrame _saveDocumentAndScrollState]): likewise
(-[WebFrame _numPendingOrLoadingRequests:]): likewise
(-[WebFrame _checkLoadComplete]): Refactored this and it's two
- helpers a little so we could get away with using
- _internalChildFrames.
+ helpers a little so we could get away with using
+ _internalChildFrames.
(-[WebFrame _checkLoadCompleteForThisFrame]): Renamed from
- _isLoadComplete
- (-[WebFrame _recursiveCheckLoadComplete]): renamed from (class
- method) _recursiveCheckCompleteFromFrame:
+ _isLoadComplete
+ (-[WebFrame _recursiveCheckLoadComplete]): renamed from (class
+ method) _recursiveCheckCompleteFromFrame:
* WebView.subproj/WebDataSource.m:
(-[WebDataSource _defersCallbacksChanged]): Use it
(-[WebDataSource isLoading]): likewise
@@ -1463,7 +1465,7 @@
2004-05-10 Chris Blumenberg <cblu at apple.com>
- Forgot to commit this copied header.
+ Forgot to commit this copied header.
* DOM.subproj/DOMExtensions.h:
@@ -1475,7 +1477,7 @@
2004-05-05 Chris Blumenberg <cblu at apple.com>
- - DOM Extensions API tweaks
+ - DOM Extensions API tweaks
Reviewed by kocienda.
@@ -1551,7 +1553,7 @@
2004-04-28 Chris Blumenberg <cblu at apple.com>
- - Made WebArchive and WebResource conform to NSCoding and NSCopying.
+ - Made WebArchive and WebResource conform to NSCoding and NSCopying.
Reviewed by rjw.
@@ -1622,10 +1624,9 @@
2004-04-27 David Hyatt <hyatt at apple.com>
- Cut the time spent on an operation inside widthForNextCharacter from 17% of the function time down to less than
- 5% merely by adding a check for non-zero letter-spacing (thus avoiding double precision math in the
- common case where we just add 0 between letters).
-
+ Cut the time spent on an operation inside widthForNextCharacter from 17% of the function time down to less than
+ 5% merely by adding a check for non-zero letter-spacing (thus avoiding double precision math in the
+ common case where we just add 0 between letters).
Reviewed by rjw
* WebCoreSupport.subproj/WebTextRenderer.m:
@@ -1676,15 +1677,15 @@
2004-04-27 Richard Williamson <rjw at apple.com>
- Fixes for:
+ Fixes for:
- <rdar://problem/3279301>: API: WebKitErrorCannotFindPlugin and WebKitErrorCannotLoadPlugin should use PlugIn
- <rdar://problem/3278513>: API: Need API to control the size of WebHistory
- <rdar://problem/3564519>: API: please add a way to set the media type for a WebView
- <rdar://problem/3565642>: API: allow a way to extend the MIME types that a WebView will display
- <rdar://problem/3577693>: API: add ability to subclass WebView but still use it with Carbon
+ <rdar://problem/3279301>: API: WebKitErrorCannotFindPlugin and WebKitErrorCannotLoadPlugin should use PlugIn
+ <rdar://problem/3278513>: API: Need API to control the size of WebHistory
+ <rdar://problem/3564519>: API: please add a way to set the media type for a WebView
+ <rdar://problem/3565642>: API: allow a way to extend the MIME types that a WebView will display
+ <rdar://problem/3577693>: API: add ability to subclass WebView but still use it with Carbon
- Reviewed by Chris.
+ Reviewed by Chris.
* Carbon.subproj/HIWebView.h:
* Carbon.subproj/HIWebView.m:
@@ -1724,9 +1725,8 @@
2004-04-27 David Hyatt <hyatt at apple.com>
- Eliminate the preferences for timed/resource layouts. Accessing them is now taking 0.5% on the cvs-base
- test, so we're just going to hardcode the values instead.
-
+ Eliminate the preferences for timed/resource layouts. Accessing them is now taking 0.5% on the cvs-base
+ test, so we're just going to hardcode the values instead.
Reviewed by mjs
* WebView.subproj/WebFrame.m:
@@ -1758,14 +1758,14 @@
2004-04-26 Richard Williamson <rjw at apple.com>
- Added support for specifying composite operation on an
- image element, i.e.:
+ Added support for specifying composite operation on an
+ image element, i.e.:
- <img composite="source-over" src="triangle.png">
- <img style="position:relative; left:-200px;" composite="destination-in" src="circle.png">
+ <img composite="source-over" src="triangle.png">
+ <img style="position:relative; left:-200px;" composite="destination-in" src="circle.png">
- This feature was requested by the dashboard guys. They can use it to apply
- transparency masks to widgies.
+ This feature was requested by the dashboard guys. They can use it to apply
+ transparency masks to widgies.
Reviewed by Ken.
@@ -1782,8 +1782,7 @@
2004-04-26 Chris Blumenberg <cblu at apple.com>
- More header doc changes after John's review.
-
+ More header doc changes after John's review.
* WebView.subproj/WebDataSourcePrivate.h:
* WebView.subproj/WebResource.h:
@@ -1811,9 +1810,9 @@
2004-04-23 Chris Blumenberg <cblu at apple.com>
- Reviewed by John
+ Reviewed by John
- Added header doc comments to proposed API's.
+ Added header doc comments to proposed API's.
* WebView.subproj/WebArchive.h:
* WebView.subproj/WebFramePrivate.h:
@@ -1835,28 +1834,27 @@
2004-04-22 Richard Williamson <rjw at apple.com>
- Updates to plugin binding APIs.
- Updates to Java plugin APIs.
- Transparency fix for Dashboard.
-
+ Updates to plugin binding APIs.
+ Updates to Java plugin APIs.
+ Transparency fix for Dashboard.
Reviewed by John and Greg Bolsinga.
* Plugins.subproj/WebPluginJava.h: Added.
- New API for Java plugin.
+ New API for Java plugin.
- * Plugins.subproj/npfunctions.h:
+ * Plugins.subproj/npfunctions.h:
* Plugins.subproj/npruntime.h:
(_NPString::):
(_NPString::_NPVariant::):
* Plugins.subproj/npsap.h: Added.
- New API for plugin bindings.
+ New API for plugin bindings.
- * WebView.subproj/WebHTMLView.m:
+ * WebView.subproj/WebHTMLView.m:
(-[WebHTMLView drawRect:]):
- Update for Dashboard. View must fill with transparency when not
- drawing background.
+ Update for Dashboard. View must fill with transparency when not
+ drawing background.
- * copy-webcore-files-to-webkit:
+ * copy-webcore-files-to-webkit:
2004-04-22 Ken Kocienda <kocienda at apple.com>
@@ -1934,7 +1932,7 @@
2004-04-20 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3605209>: "HITLIST: REGRESSION (131-132): iframes/frames no longer dump on layout tests"
+ Fixed: <rdar://problem/3605209>: "HITLIST: REGRESSION (131-132): iframes/frames no longer dump on layout tests"
Reviewed by hyatt.
@@ -1976,7 +1974,7 @@
2004-04-19 Chris Blumenberg <cblu at apple.com>
- Added support for pasting frames via WebArchives.
+ Added support for pasting frames via WebArchives.
Reviewed by kocienda.
@@ -1995,9 +1993,9 @@
2004-04-16 Richard Williamson <rjw at apple.com>
- Added an SPI to allow ObjC instances to be easily bound to
- JS. This is needed by the dashboard guys for their prototyping.
- Eventually they will use new API.
+ Added an SPI to allow ObjC instances to be easily bound to
+ JS. This is needed by the dashboard guys for their prototyping.
+ Eventually they will use new API.
Reviewed by Chris.
@@ -2007,8 +2005,8 @@
2004-04-16 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3587599>: Mail Page, Web Archives don't preserve subframes
- Moved code that assembled subresource URLs from DOM nodes from WebCore to WebKit.
+ Fixed: <rdar://problem/3587599>: Mail Page, Web Archives don't preserve subframes
+ Moved code that assembled subresource URLs from DOM nodes from WebCore to WebKit.
Reviewed by rjw.
@@ -2088,8 +2086,7 @@
2004-04-15 David Hyatt <hyatt at apple.com>
- Make sure isOpaque returns NO when the WebHTMLVIew doesn't draw its background.
-
+ Make sure isOpaque returns NO when the WebHTMLVIew doesn't draw its background.
Reviewed by darin
* WebView.subproj/WebFrameView.m:
@@ -2104,9 +2101,9 @@
2004-04-14 Richard Williamson <rjw at apple.com>
- Updated fix for 3576315. Don't hardcode 22 as the titlebar
- height. (Note, other places in CarbonWindowFrame DO hardcode
- window geometry information, yuck!).
+ Updated fix for 3576315. Don't hardcode 22 as the titlebar
+ height. (Note, other places in CarbonWindowFrame DO hardcode
+ window geometry information, yuck!).
Reviewed by Hyatt.
@@ -2140,8 +2137,8 @@
2004-04-13 Chris Blumenberg <cblu at apple.com>
- - Added WebElementDOMNodeKey as a potential API so that clients can get the node from an element dictionary.
- - Removed WebElementIsEditableKey. This functionality is available via [DOMNode isContentEditable].
+ - Added WebElementDOMNodeKey as a potential API so that clients can get the node from an element dictionary.
+ - Removed WebElementIsEditableKey. This functionality is available via [DOMNode isContentEditable].
Reviewed by rjw.
@@ -2160,7 +2157,7 @@
2004-04-13 Chris Blumenberg <cblu at apple.com>
- Fixed deployment build failure.
+ Fixed deployment build failure.
Reviewed by john.
@@ -2169,7 +2166,7 @@
2004-04-12 Chris Blumenberg <cblu at apple.com>
- Factored out WebArchive to DOM code so that it could be used by both [WebHTMLView _pasteFromPasteboard:] and [WebView insertWebArchive:replacingDOMRange:].
+ Factored out WebArchive to DOM code so that it could be used by both [WebHTMLView _pasteFromPasteboard:] and [WebView insertWebArchive:replacingDOMRange:].
Reviewed by kocienda.
@@ -2355,9 +2352,9 @@
2004-04-08 Chris Blumenberg <cblu at apple.com>
- Fixed:
- <rdar://problem/3616873>: support for pasting and drag and dropping of URLS to editable WebViews
- <rdar://problem/3546417>: support for pasting and drag and dropping of images to editable WebViews
+ Fixed:
+ <rdar://problem/3616873>: support for pasting and drag and dropping of URLS to editable WebViews
+ <rdar://problem/3546417>: support for pasting and drag and dropping of images to editable WebViews
Reviewed by rjw.
@@ -2397,7 +2394,7 @@
2004-04-08 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3548274>: API: DOM API for WebKit clients
+ Fixed: <rdar://problem/3548274>: API: DOM API for WebKit clients
Reviewed by kocienda.
@@ -2406,7 +2403,7 @@
2004-04-08 Chris Blumenberg <cblu at apple.com>
- Moved WebArchive to its own file.
+ Moved WebArchive to its own file.
Reviewed by kocienda.
@@ -2424,7 +2421,7 @@
2004-04-07 Chris Blumenberg <cblu at apple.com>
- Created WebDOMOperations which are WebKit-specific categories on DOM objects.
+ Created WebDOMOperations which are WebKit-specific categories on DOM objects.
Reviewed by rjw.
@@ -2476,11 +2473,11 @@
2004-04-07 Richard Williamson <rjw at apple.com>
- Fix for 3604388. The runtime version check (_CFExecutableLinkedOnOrAfter) used by many of
- our frameworks doesn't work for CFM apps. So, conditional panther bugs fixes aren't
- being pickup by CFM apps that use WebKit, specifically Contribute. This particular radar
- describes a problem that was conditionally fixed in the AppKit for panther. The work-around
- is to force NSBitmapImageRep to execute to conditional code.
+ Fix for 3604388. The runtime version check (_CFExecutableLinkedOnOrAfter) used by many of
+ our frameworks doesn't work for CFM apps. So, conditional panther bugs fixes aren't
+ being pickup by CFM apps that use WebKit, specifically Contribute. This particular radar
+ describes a problem that was conditionally fixed in the AppKit for panther. The work-around
+ is to force NSBitmapImageRep to execute to conditional code.
Reviewed by Maciej.
@@ -2489,8 +2486,8 @@
2004-04-06 Richard Williamson <rjw at apple.com>
- Fixed 3510805. Only release pool in timer if the current nesting level of the
- pool matches the nesting level when the pool was created.
+ Fixed 3510805. Only release pool in timer if the current nesting level of the
+ pool matches the nesting level when the pool was created.
Reviewed by Chris.
@@ -2501,7 +2498,7 @@
2004-04-06 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3613974>: remove "to Clipboard" from context menus because it is redundant
+ Fixed: <rdar://problem/3613974>: remove "to Clipboard" from context menus because it is redundant
Reviewed by john.
@@ -2520,7 +2517,7 @@
2004-04-05 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3612580>: SPI: WebPlugin selection
+ Fixed: <rdar://problem/3612580>: SPI: WebPlugin selection
Reviewed by kocienda.
@@ -2534,7 +2531,7 @@
2004-04-02 Chris Blumenberg <cblu at apple.com>
- Forgot to add the WebKit copy of DOMExtensions.h.
+ Forgot to add the WebKit copy of DOMExtensions.h.
* DOM.subproj/DOMExtensions.h: Added.
@@ -2553,7 +2550,7 @@
2004-04-02 Chris Blumenberg <cblu at apple.com>
- Moved the DOM extensions to their own headers
+ Moved the DOM extensions to their own headers
Reviewed by kocienda.
@@ -2566,9 +2563,9 @@
2004-04-01 Richard Williamson <rjw at apple.com>
- Fixed 3609493. Don't remove the plugin's view until after
- sending pluginDestroy. This change was requested by Greg
- and is needed in the Lavender update.
+ Fixed 3609493. Don't remove the plugin's view until after
+ sending pluginDestroy. This change was requested by Greg
+ and is needed in the Lavender update.
Reviewed by Greg Bolsinga.
@@ -2611,7 +2608,7 @@
2004-03-31 Richard Williamson <rjw at apple.com>
- Changed to reflect NP_runtime.h to npruntime.h.
+ Changed to reflect NP_runtime.h to npruntime.h.
* copy-webcore-files-to-webkit:
@@ -2630,7 +2627,7 @@
2004-03-30 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3604391>: Plug-in context menus (Flash) don't work in Carbon WebKit applications (e.g., CarbonWeb)
+ Fixed: <rdar://problem/3604391>: Plug-in context menus (Flash) don't work in Carbon WebKit applications (e.g., CarbonWeb)
Reviewed by rjw.
@@ -2716,10 +2713,9 @@
2004-03-25 David Hyatt <hyatt at apple.com>
- Implement the rest of the search field.
+ Implement the rest of the search field.
- Implement onscroll at the document level.
-
+ Implement onscroll at the document level.
Reviewed by darin
* English.lproj/Localizable.strings:
@@ -2735,20 +2731,20 @@
2004-03-25 Richard Williamson <rjw at apple.com>
- Netscape plugin API header cleanup.
+ Netscape plugin API header cleanup.
- Replaced our hacked up version of npapi.h with the
- "official SDK" npapi.h. Moved our changes to the new
- npfunctions.h. npfunctions.h really replaces what was defined in
- the Netscape npupp.h header. However, rather than use the "official SDK"
- npupp.h I think the cleaner npfunctions.h is better. npupp.h actually
- has a bunch of Mac classic specific stuff that is no longer needed.
+ Replaced our hacked up version of npapi.h with the
+ "official SDK" npapi.h. Moved our changes to the new
+ npfunctions.h. npfunctions.h really replaces what was defined in
+ the Netscape npupp.h header. However, rather than use the "official SDK"
+ npupp.h I think the cleaner npfunctions.h is better. npupp.h actually
+ has a bunch of Mac classic specific stuff that is no longer needed.
- Copied npruntime.h to WebKit using Ken's copy-o-matic mechanism.
+ Copied npruntime.h to WebKit using Ken's copy-o-matic mechanism.
- Made npapi.h, npruntime.h, and npfunctions.h SPI. With a bit
- more consideration they will become API. They will also eventually be made
- available for other platforms/vendors are mozilla.org.
+ Made npapi.h, npruntime.h, and npfunctions.h SPI. With a bit
+ more consideration they will become API. They will also eventually be made
+ available for other platforms/vendors are mozilla.org.
Reviewed by Ken.
@@ -2780,14 +2776,13 @@
Reviewed by me
* DOM.subproj/DOMHTML.h: Checking in copied over version of
- modified file.
+ modified file.
2004-03-23 David Hyatt <hyatt at apple.com>
- Fix for 3513627, HTML mail prints upside down occasionally. Change printing so that it never resizes the
- WebHTMLView when formatting for printing. When computing page rects, instead of using the view's bounds,
- use the root layer's width instead.
-
+ Fix for 3513627, HTML mail prints upside down occasionally. Change printing so that it never resizes the
+ WebHTMLView when formatting for printing. When computing page rects, instead of using the view's bounds,
+ use the root layer's width instead.
Reviewed by darin
* WebView.subproj/WebHTMLView.m:
@@ -2797,8 +2792,7 @@
2004-03-17 David Hyatt <hyatt at apple.com>
- Expose ageLimitDate so that the autocomplete code can access it.
-
+ Expose ageLimitDate so that the autocomplete code can access it.
Reviewed by john
* History.subproj/WebHistory.m:
@@ -2807,7 +2801,7 @@
2004-03-17 Richard Williamson <rjw at apple.com>
- Fixed 3591667. Plugin view is added to view hierarchy before calling init.
+ Fixed 3591667. Plugin view is added to view hierarchy before calling init.
Reviewed by Ken.
@@ -2897,8 +2891,8 @@
2004-03-11 Richard Williamson <rjw at apple.com>
- Workaround for 3585644. Force the window number of the
- mouse moved event to be correct.
+ Workaround for 3585644. Force the window number of the
+ mouse moved event to be correct.
Reviewed by Chris.
@@ -2983,7 +2977,7 @@
2004-03-11 Chris Blumenberg <cblu at apple.com>
- Made WebArchive a class instead of a data object. This allows clients to easily get the main resource and subresources from a WebArchive.
+ Made WebArchive a class instead of a data object. This allows clients to easily get the main resource and subresources from a WebArchive.
Reviewed by kocienda.
@@ -3017,7 +3011,7 @@
2004-03-10 Chris Blumenberg <cblu at apple.com>
- Made dragging of web archives work.
+ Made dragging of web archives work.
Reviewed by rjw.
@@ -3031,7 +3025,7 @@
2004-03-09 Chris Blumenberg <cblu at apple.com>
- Made web archives use NSPropertyListBinaryFormat_v1_0 instead of NSPropertyListXMLFormat_v1_0 because NSPropertyListBinaryFormat_v1_0 is 3-5 times faster to serialize and parse.
+ Made web archives use NSPropertyListBinaryFormat_v1_0 instead of NSPropertyListXMLFormat_v1_0 because NSPropertyListBinaryFormat_v1_0 is 3-5 times faster to serialize and parse.
Reviewed by rjw.
@@ -3041,8 +3035,8 @@
2004-03-09 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3577508>: API: web archive related API's
- Implemented WebKit side of: <rdar://problem/3144033>: ability to save web sites (images and all)
+ Fixed: <rdar://problem/3577508>: API: web archive related API's
+ Implemented WebKit side of: <rdar://problem/3144033>: ability to save web sites (images and all)
Reviewed by rjw.
@@ -3168,7 +3162,7 @@
2004-03-05 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3560132>: REGRESSION: Safari crashed in -[NSPasteboard setData:forType:] dragging a map out of Mapquest.com
+ Fixed: <rdar://problem/3560132>: REGRESSION: Safari crashed in -[NSPasteboard setData:forType:] dragging a map out of Mapquest.com
Reviewed by john.
@@ -3254,8 +3248,8 @@
2004-03-04 Chris Blumenberg <cblu at apple.com>
- - Made image dragging and copying always work without needing to re-download by using the data source's WebResource of the image instead of relying on the Foundation cache.
- - Fixed a "drag to self" problem I introduced in my last check-in. You could drag a URL from a WebHTMLView and drop it on its own WebView which we shouldn't allow.
+ - Made image dragging and copying always work without needing to re-download by using the data source's WebResource of the image instead of relying on the Foundation cache.
+ - Fixed a "drag to self" problem I introduced in my last check-in. You could drag a URL from a WebHTMLView and drop it on its own WebView which we shouldn't allow.
Reviewed by rjw.
@@ -3290,14 +3284,14 @@
2004-03-03 Chris Blumenberg <cblu at apple.com>
- Fixed a typo.
+ Fixed a typo.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView concludeDragOperation:]):
2004-03-03 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3576070>: REGRESSION: web view won't accept drag of webloc file
+ Fixed: <rdar://problem/3576070>: REGRESSION: web view won't accept drag of webloc file
Reviewed by rjw.
@@ -3318,10 +3312,10 @@
Reviewed by Chris
* copy-webcore-files-to-webkit: Fixed up this script so that
- it does not fail if it is running "non-locally", like for
- B&I. The idiom is to check these files into WebKit after
- copying them from WebCore, hence this script is merely
- a convenience to keep the files in sync.
+ it does not fail if it is running "non-locally", like for
+ B&I. The idiom is to check these files into WebKit after
+ copying them from WebCore, hence this script is merely
+ a convenience to keep the files in sync.
2004-03-02 Ken Kocienda <kocienda at apple.com>
@@ -3332,8 +3326,8 @@
2004-03-02 Richard Williamson <rjw at apple.com>
- Added WebJavaScriptObject API. The location of this file may
- change.
+ Added WebJavaScriptObject API. The location of this file may
+ change.
Reviewed by Chris.
@@ -3342,7 +3336,7 @@
2004-03-02 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3575598>: REGRESSION: Safari crashes at IS&T website
+ Fixed: <rdar://problem/3575598>: REGRESSION: Safari crashes at IS&T website
Reviewed by darin.
@@ -3361,9 +3355,9 @@
2004-03-01 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3574979>: REGRESSION (129-TOT): crash loading macromedia.com
+ Fixed: <rdar://problem/3574979>: REGRESSION (129-TOT): crash loading macromedia.com
- deliverResource was being called after it had already been called in setDefersCallbacks:.
+ deliverResource was being called after it had already been called in setDefersCallbacks:.
Reviewed by rjw.
@@ -3386,18 +3380,18 @@
Reviewed by me
* DOM.subproj/DOM.h: Oh, it's like the Keystone Cops this afternoon...
- Backed out an unintended change to thsi file.
+ Backed out an unintended change to thsi file.
2004-03-01 Ken Kocienda <kocienda at apple.com>
Reviewed by me
* copy-webcore-files-to-webkit: Dumb typing error on my part in making
- my previous quick fix. This quick fix works.
+ my previous quick fix. This quick fix works.
2004-03-01 Chris Blumenberg <cblu at apple.com>
- Updated the WebKit project file to 1.1 because a previous check-in reverted to 1.01.
+ Updated the WebKit project file to 1.1 because a previous check-in reverted to 1.01.
* WebKit.pbproj/project.pbxproj:
@@ -3409,7 +3403,7 @@
2004-03-01 Chris Blumenberg <cblu at apple.com>
- Found a bug in my last check-in. If a load that originates from a WebResource is cancelled before the data from the WebResource is delivered, callbacks are sent anyway.
+ Found a bug in my last check-in. If a load that originates from a WebResource is cancelled before the data from the WebResource is delivered, callbacks are sent anyway.
Reviewed by rjw.
@@ -3426,8 +3420,8 @@
2004-03-01 Chris Blumenberg <cblu at apple.com>
- - Made WebResource loading not use Foundation at all. This allows "Mail Page" and paste to more directly load subresources without any indirection involving NSURLConnection and the Foundation cache.
- - Made WebIconLoader a subclass of WebBaseResourceHandleDelegate. This makes favicons appear in the activity window among other things.
+ - Made WebResource loading not use Foundation at all. This allows "Mail Page" and paste to more directly load subresources without any indirection involving NSURLConnection and the Foundation cache.
+ - Made WebIconLoader a subclass of WebBaseResourceHandleDelegate. This makes favicons appear in the activity window among other things.
Reviewed by kocienda.
@@ -3554,9 +3548,9 @@
2004-02-26 Chris Blumenberg <cblu at apple.com>
- WebKit side of:
- <rdar://problem/3056566>: mail a link to this page
- <rdar://problem/2961206>: implement ability to e-mail entire page
+ WebKit side of:
+ <rdar://problem/3056566>: mail a link to this page
+ <rdar://problem/2961206>: implement ability to e-mail entire page
Reviewed by john.
@@ -3654,7 +3648,7 @@
2004-02-24 Chris Blumenberg <cblu at apple.com>
- I forgot to add these files in my last check-in.
+ I forgot to add these files in my last check-in.
* WebView.subproj/WebResource.h: Added.
* WebView.subproj/WebResource.m: Added.
@@ -3675,7 +3669,7 @@
2004-02-24 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3565476>: design/implement new pasteboard type for HTML that includes subresources
+ Fixed: <rdar://problem/3565476>: design/implement new pasteboard type for HTML that includes subresources
Reviewed by rjw.
@@ -3753,15 +3747,15 @@
Reviewed by mjs.
- - fix build breakage caused by removal of kWindowNoBufferingAttribute.
+ - fix build breakage caused by removal of kWindowNoBufferingAttribute.
* Carbon.subproj/CarbonWindowAdapter.m:
(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
- always used a retained backing store type
+ always used a retained backing store type
2004-02-20 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3563402>: when copying HTML, relative URLs should be made absolute
+ Fixed: <rdar://problem/3563402>: when copying HTML, relative URLs should be made absolute
Reviewed by dave.
@@ -3825,15 +3819,15 @@
Reviewed by John.
- - redo visited link history checking for a 2% speed improvement
+ - redo visited link history checking for a 2% speed improvement
* History.subproj/WebHistory.m:
(-[_WebCoreHistoryProvider containsItemForURLString:]): Removed.
(-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]): Implemented.
- For https and http URLs with empty path, add a slash. Make a CFString
- using the passed-in latin1 buffer without copying.
+ For https and http URLs with empty path, add a slash. Make a CFString
+ using the passed-in latin1 buffer without copying.
(-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]): Ditto
- for unicode.
+ for unicode.
(matchLetter): New static helper function.
(matchUnicodeLetter): Ditto.
@@ -3912,14 +3906,13 @@
2004-02-04 David Hyatt <hyatt at apple.com>
- Fix deployment build bustage.
-
+ Fix deployment build bustage.
* Plugins.subproj/WebBaseNetscapePluginView.m:
(ConsoleConnectionChangeNotifyProc):
2004-02-04 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3546028>: Safari should not give plug-ins any time, thus use 0% CPU, when not in the currently active session
+ Fixed: <rdar://problem/3546028>: Safari should not give plug-ins any time, thus use 0% CPU, when not in the currently active session
Reviewed by john.
@@ -3952,7 +3945,7 @@
2004-02-02 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3546924>: REGRESSION: dragging text or images over a WebView is jerky
+ Fixed: <rdar://problem/3546924>: REGRESSION: dragging text or images over a WebView is jerky
Reviewed by mjs.
@@ -3966,7 +3959,7 @@
2004-02-02 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3546426>: when copying images via context menus, only some data is added to the pasteboard
+ Fixed: <rdar://problem/3546426>: when copying images via context menus, only some data is added to the pasteboard
Reviewed by john.
@@ -3989,7 +3982,7 @@
2004-02-02 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3546379>: support for editing via drag & drop
+ Fixed: <rdar://problem/3546379>: support for editing via drag & drop
Reviewed by kocienda.
@@ -4020,7 +4013,7 @@
2004-01-30 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3536126>: REGRESSION (Merlot): WebKit dragging is in strange location
+ Fixed: <rdar://problem/3536126>: REGRESSION (Merlot): WebKit dragging is in strange location
Reviewed by kocienda.
@@ -4090,7 +4083,7 @@
2004-01-28 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3197222>: need context menu items for back, forward, refresh.
+ Fixed: <rdar://problem/3197222>: need context menu items for back, forward, refresh.
Reviewed by rjw.
@@ -4133,10 +4126,10 @@
2004-01-27 Chris Blumenberg <cblu at apple.com>
- Fixed:
- <rdar://problem/3541812>: Implement Paste menu item
- <rdar://problem/3541814>: Implement Delete menu item
- <rdar://problem/3541811>: Implement Cut menu item
+ Fixed:
+ <rdar://problem/3541812>: Implement Paste menu item
+ <rdar://problem/3541814>: Implement Delete menu item
+ <rdar://problem/3541811>: Implement Cut menu item
Reviewed by dave.
@@ -4294,9 +4287,8 @@
2004-01-09 David Hyatt <hyatt at apple.com>
- Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's resizing not scheduling actual
- layouts via WebCore.
-
+ Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's resizing not scheduling actual
+ layouts via WebCore.
Reviewed by darin
* WebView.subproj/WebHTMLView.m:
@@ -4321,17 +4313,17 @@
Reviewed by John.
- <rdar://problem/3522298>: Error on MIT's x509 certificate site
+ <rdar://problem/3522298>: Error on MIT's x509 certificate site
* WebCoreSupport.subproj/WebKeyGeneration.cpp:
(addCertificatesToKeychainFromData): Sign the freshly minted public key
- using RSA/MD5 instead of RSA/SHA-1, because MIT only supports MD5.
+ using RSA/MD5 instead of RSA/SHA-1, because MIT only supports MD5.
2004-01-08 Richard Williamson <rjw at apple.com>
- Fixed 3524430. This was a regression introduced when we added '-' and '?' to the word boundary detection.
+ Fixed 3524430. This was a regression introduced when we added '-' and '?' to the word boundary detection.
- Also backed out workaround for 3521759 as it's no longer needed with correct argument passing to ATSUPositionToOffset.
+ Also backed out workaround for 3521759 as it's no longer needed with correct argument passing to ATSUPositionToOffset.
Reviewed by Hyatt.
@@ -4341,7 +4333,7 @@
2004-01-08 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3522900>: REGRESSION (100-117): Java plug-in description is garbled when displaying Plug-ins.html
+ Fixed: <rdar://problem/3522900>: REGRESSION (100-117): Java plug-in description is garbled when displaying Plug-ins.html
Reviewed by darin.
@@ -4355,7 +4347,7 @@
2004-01-06 Richard Williamson <rjw at apple.com>
- Fixed 3513660. Make ATSU layout and draw with integer glyph boundaries. This fix should be removed if/when we convert WebCore to use floats for measuring/positioning (3521781).
+ Fixed 3513660. Make ATSU layout and draw with integer glyph boundaries. This fix should be removed if/when we convert WebCore to use floats for measuring/positioning (3521781).
Reviewed by John.
@@ -4364,9 +4356,9 @@
2004-01-05 Richard Williamson <rjw at apple.com>
- Fix for 3514454. Work-around added for 3521759.
+ Fix for 3514454. Work-around added for 3521759.
- Filed 3521781 to cover deeper problem.
+ Filed 3521781 to cover deeper problem.
Reviewed by Kocienda.
@@ -4376,24 +4368,24 @@
2003-12-22 John Sullivan <sullivan at apple.com>
- - WebKit part of fix for <rdar://problem/3515706>:
- REGRESSION (100-118): Web Kit printing does not honor Page Setup scale factor
+ - WebKit part of fix for <rdar://problem/3515706>:
+ REGRESSION (100-118): Web Kit printing does not honor Page Setup scale factor
Reviewed by Darin.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView _userScaleFactorForPrintOperation:]):
- new method, extracts the scale factor provided by the user in
- the Page Setup dialog
+ new method, extracts the scale factor provided by the user in
+ the Page Setup dialog
(-[WebHTMLView _scaleFactorForPrintOperation:]):
- take user scale factor into account
+ take user scale factor into account
(-[WebHTMLView knowsPageRange:]):
- renamed local var scaleFactor -> totalScaleFactor for clarity;
- take user scale factor into account for print width; now assumes
+ renamed local var scaleFactor -> totalScaleFactor for clarity;
+ take user scale factor into account for print width; now assumes
computePageRects returns autoreleased result.
* WebKit.pbproj/project.pbxproj:
- Xcode version wars; Darin says these don't affect the build.
+ Xcode version wars; Darin says these don't affect the build.
2003-12-21 Darin Adler <darin at apple.com>
@@ -4407,11 +4399,11 @@
2003-12-19 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3515255>: Standalone image drag makes ocassionally makes 2 copies
+ Fixed: <rdar://problem/3515255>: Standalone image drag makes ocassionally makes 2 copies
Reviewed by john.
- * WebKit.pbproj/project.pbxproj: Xcode 1.1 file format change
+ * WebKit.pbproj/project.pbxproj: Xcode 1.1 file format change
* WebView.subproj/WebImageView.h:
* WebView.subproj/WebImageView.m: copied double-drag protection code from WebHTMLView
(-[WebImageView mouseDown:]): set ignoringMouseDraggedEvents to NO
@@ -4422,8 +4414,8 @@
2003-12-18 Richard Williamson <rjw at apple.com>
- Fixed 3511415. We have to un-visually order visually ordered text
- before passing to ATSU.
+ Fixed 3511415. We have to un-visually order visually ordered text
+ before passing to ATSU.
Reviewed by John.
@@ -4435,7 +4427,7 @@
2003-12-17 Richard Williamson <rjw at apple.com>
- Fixed 3503011 (really, this time). Always use integer width for '-' and '?', as we do for spaces, to ensure
+ Fixed 3503011 (really, this time). Always use integer width for '-' and '?', as we do for spaces, to ensure
that 'words' (as defined by out rounding hack) start on integer boundaries.
Reviewed by John.
@@ -4445,9 +4437,9 @@
2003-12-17 Chris Blumenberg <cblu at apple.com>
- Fixed:
- <rdar://problem/3393758>: REGRESSION (85-100): Flash onKeyUp event non-functional
- <rdar://problem/3479020>: REGRESSION (85-100): Safari sends plug-in key events to wrong instance of plug-in
+ Fixed:
+ <rdar://problem/3393758>: REGRESSION (85-100): Flash onKeyUp event non-functional
+ <rdar://problem/3479020>: REGRESSION (85-100): Safari sends plug-in key events to wrong instance of plug-in
Reviewed by darin.
@@ -4489,12 +4481,12 @@
2003-12-16 Ken Kocienda <kocienda at apple.com>
* WebCoreSupport.subproj/WebBridge.m: ObjC runtime needs a declaration for new
- _calculatedExpiration SPI in NSURLResponse in Foundation
+ _calculatedExpiration SPI in NSURLResponse in Foundation
2003-12-16 Richard Williamson <rjw at apple.com>
- Fixed 3512348: Rewrote _CG_drawHighlightForRun:style:atPoint: to use width
- iterators. Much faster, better cheaper, etc.
+ Fixed 3512348: Rewrote _CG_drawHighlightForRun:style:atPoint: to use width
+ iterators. Much faster, better cheaper, etc.
Reviewed by Dave.
@@ -4503,7 +4495,7 @@
2003-12-16 Richard Williamson <rjw at apple.com>
- Fixed 3503011. Added '-' and '?' to rounding hack.
+ Fixed 3503011. Added '-' and '?' to rounding hack.
Reviewed by John.
@@ -4524,18 +4516,18 @@
Reviewed by Darin
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3512199>: WebBridge expiresTimeForResponse can be
- improved to use better expiration calculations
+ <rdar://problem/3512199>: WebBridge expiresTimeForResponse can be
+ improved to use better expiration calculations
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge expiresTimeForResponse:]): Switch to use new
- _calculatedExpiration SPI method on NSURLResponse.
+ _calculatedExpiration SPI method on NSURLResponse.
2003-12-15 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3505546>: always get keychain prompt when sending mail using cert downloaded with Safari
+ Fixed: <rdar://problem/3505546>: always get keychain prompt when sending mail using cert downloaded with Safari
Reviewed by john.
@@ -4568,9 +4560,9 @@
2003-12-12 Chris Blumenberg <cblu at apple.com>
- Fixed:
- <rdar://problem/3396936>: can't obtain a digital ID from Verisign, form submission fails
- <rdar://problem/3505208>: keys added to keychain from KEYGEN need better UI names
+ Fixed:
+ <rdar://problem/3396936>: can't obtain a digital ID from Verisign, form submission fails
+ <rdar://problem/3505208>: keys added to keychain from KEYGEN need better UI names
Reviewed by rjw.
@@ -4606,23 +4598,23 @@
Reviewed by Darin
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3489280>: redirect via post blows cache, causing everything to get reloaded
+ <rdar://problem/3489280>: redirect via post blows cache, causing everything to get reloaded
- Now POST requests reload the main document by default, but will not reload
- all subresources.
+ Now POST requests reload the main document by default, but will not reload
+ all subresources.
* WebCoreSupport.subproj/WebSubresourceClient.m:
(+[WebSubresourceClient startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
* WebView.subproj/WebFrame.m:
(-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
- Take the cache policy for subresources from the original request, rather than
- the data source's current request.
+ Take the cache policy for subresources from the original request, rather than
+ the data source's current request.
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient _isPostOrRedirectAfterPost:redirectResponse:]): New helper.
(-[WebMainResourceClient connection:willSendRequest:redirectResponse:]):
- Call new helper to set the cache policy on the main resource load.
+ Call new helper to set the cache policy on the main resource load.
=== Safari-117 ===
@@ -4631,14 +4623,14 @@
Reviewed by Darin
* WebCoreSupport.subproj/WebBridge.m: time_t is a signed type, so
- casting -1 to a time_t does not work to make a max value.
- We'll go with INT_MAX.
+ casting -1 to a time_t does not work to make a max value.
+ We'll go with INT_MAX.
2003-12-11 Ken Kocienda <kocienda at apple.com>
Reviewed and C++ heavy-lifting by Darin
- Fix warnings in C++ files.
+ Fix warnings in C++ files.
* WebCoreSupport.subproj/WebKeyGeneration.cpp:
(signedPublicKeyAndChallengeString): Add cast to remove warning.
@@ -4661,18 +4653,18 @@
Reviewed by Richard.
- WebKit part of fix for:
+ WebKit part of fix for:
- <rdar://problem/3487160>: Implement synchronous loading for XMLHttpRequest
+ <rdar://problem/3487160>: Implement synchronous loading for XMLHttpRequest
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2003-12-10 Richard Williamson <rjw at apple.com>
- Added method to get to the bridge from a view. This is
- used to ultimately get the part and KJS::Window for a
- particular applet.
+ Added method to get to the bridge from a view. This is
+ used to ultimately get the part and KJS::Window for a
+ particular applet.
Reviewed by Hyatt.
@@ -4697,7 +4689,7 @@
2003-12-10 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3505537>: certificates downloaded from Verisign are multipart/mixed, must be parsed out
+ Fixed: <rdar://problem/3505537>: certificates downloaded from Verisign are multipart/mixed, must be parsed out
Reviewed by kocienda.
@@ -4712,7 +4704,7 @@
2003-12-09 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3504237>: add downloaded certificates to keychain
+ Fixed: <rdar://problem/3504237>: add downloaded certificates to keychain
Reviewed by darin.
@@ -4742,7 +4734,7 @@
2003-12-08 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3234676>: Support for KEYGEN tag (ie 509 email certificates from www.thawte.com)
+ Fixed: <rdar://problem/3234676>: Support for KEYGEN tag (ie 509 email certificates from www.thawte.com)
Reviewed by mjs.
@@ -4846,9 +4838,9 @@
2003-12-02 Chris Blumenberg <cblu at apple.com>
- Fixed:
- <rdar://problem/3439222>: always hangs opening plain text file on a particular machine due to missing font, no UI to detect
- <rdar://problem/3492983>: Certain fonts cause Safari to hang on text/plain pages
+ Fixed:
+ <rdar://problem/3439222>: always hangs opening plain text file on a particular machine due to missing font, no UI to detect
+ <rdar://problem/3492983>: Certain fonts cause Safari to hang on text/plain pages
Reviewed by rjw.
@@ -4862,15 +4854,15 @@ non-nil is returned.
Reviewed by Richard.
- <rdar://problem/3487185>: implement security checks for XMLHttpRequest
+ <rdar://problem/3487185>: implement security checks for XMLHttpRequest
- * WebCoreSupport.subproj/WebSubresourceClient.m:
+ * WebCoreSupport.subproj/WebSubresourceClient.m:
(-[WebSubresourceClient connection:willSendRequest:redirectResponse:]): Let
- WebCore know about redirects.
+ WebCore know about redirects.
2003-12-01 Richard Williamson <rjw at apple.com>
- Moved grungy polling code from WebKit to the JavaPlugin.
+ Moved grungy polling code from WebKit to the JavaPlugin.
Reviewed by Chris.
@@ -4881,12 +4873,12 @@ non-nil is returned.
Reviewed by John
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3496873>: Move key event helper functions to WebKit
+ <rdar://problem/3496873>: Move key event helper functions to WebKit
* Misc.subproj/WebNSEventExtras.h: Add declarations for new key event
- helpers.
+ helpers.
* Misc.subproj/WebNSEventExtras.m:
(-[NSEvent _web_isKeyEvent:]): Added.
(-[NSEvent _web_isDeleteKeyEvent]): Added.
@@ -4895,7 +4887,7 @@ non-nil is returned.
(-[NSEvent _web_isReturnOrEnterKeyEvent]): Added.
(-[NSEvent _web_isTabKeyEvent]): Added.
* WebKit.pbproj/project.pbxproj: Made WebNSEventExtras.h a private header
- so WebBrowser can use the new helpers.
+ so WebBrowser can use the new helpers.
=== Safari-115 ===
@@ -4903,13 +4895,11 @@ non-nil is returned.
Reviewed by Ken.
- WebKit part of fix for:
-
- <rdar://problem/3487134>: Implement http request/response status and headers for XMLHttpRequest
-
+ WebKit part of fix for:
+ <rdar://problem/3487134>: Implement http request/response status and headers for XMLHttpRequest
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge startLoadingResource:withURL:customHeaders:]): Added customHeaders
- parameter.
+ parameter.
(-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): Ditto.
* WebCoreSupport.subproj/WebSubresourceClient.h:
* WebCoreSupport.subproj/WebSubresourceClient.m:
@@ -4977,8 +4967,7 @@ non-nil is returned.
Reviewed by Ken.
- - fixed 3490086 - support http post for XMLHttpRequest
-
+ - fixed 3490086 - support http post for XMLHttpRequest
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge startLoadingResource:withURL:postData:]):
* WebCoreSupport.subproj/WebSubresourceClient.h:
@@ -4989,7 +4978,7 @@ non-nil is returned.
2003-11-20 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3491229>: Need UI and localized strings for <KEYGEN> support
+ Fixed: <rdar://problem/3491229>: Need UI and localized strings for <KEYGEN> support
Reviewed by john.
@@ -5005,10 +4994,10 @@ non-nil is returned.
2003-11-20 Richard Williamson <rjw at apple.com>
- Added spin of event loop during applet lookup poll. This
- is necessary to allow timers and performOnMainThread: methods
- a chance to fire. The plugin depends on these mechanisms during
- initialization.
+ Added spin of event loop during applet lookup poll. This
+ is necessary to allow timers and performOnMainThread: methods
+ a chance to fire. The plugin depends on these mechanisms during
+ initialization.
Reviewed by Chris.
@@ -5017,9 +5006,9 @@ non-nil is returned.
2003-11-20 Ken Kocienda <kocienda at apple.com>
- John and I decided to apply the _web_ prefix to the tab key
- event method in the extras file, but I neglected to do this
- before checking in. Fixed now.
+ John and I decided to apply the _web_ prefix to the tab key
+ event method in the extras file, but I neglected to do this
+ before checking in. Fixed now.
* Misc.subproj/WebNSEventExtras.h:
* Misc.subproj/WebNSEventExtras.m:
@@ -5031,9 +5020,9 @@ non-nil is returned.
Reviewed by John
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3482159>: Tabbing to links gets "stuck" in "style switcher" on zeldman.com
+ <rdar://problem/3482159>: Tabbing to links gets "stuck" in "style switcher" on zeldman.com
* Misc.subproj/WebNSEventExtras.h: Added.
* Misc.subproj/WebNSEventExtras.m: Added.
@@ -5041,7 +5030,7 @@ non-nil is returned.
* WebKit.pbproj/project.pbxproj:
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView keyDown:]): Pass the key event to super unconditionally
- if it is a tab key. This fixes the bug.
+ if it is a tab key. This fixes the bug.
2003-11-19 John Sullivan <sullivan at apple.com>
@@ -5063,7 +5052,7 @@ non-nil is returned.
2003-11-19 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3489935>: Mentioning "to Disk" in context menus such as "Download Linked File To Disk..." is redundant
+ Fixed: <rdar://problem/3489935>: Mentioning "to Disk" in context menus such as "Download Linked File To Disk..." is redundant
Reviewed by john.
@@ -5074,8 +5063,7 @@ non-nil is returned.
2003-11-19 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3488783>: Flash at http://www.sjwilson.net/reef/ does not load photos
-
+ Fixed: <rdar://problem/3488783>: Flash at http://www.sjwilson.net/reef/ does not load photos
Reviewed by rjw.
* Misc.subproj/WebKitNSStringExtras.h:
@@ -5086,8 +5074,8 @@ non-nil is returned.
2003-11-19 Richard Williamson <rjw at apple.com>
- More LiveConnect stuff. Horrible polling hack that
- blocks main thread waiting for applet to fully initialize.
+ More LiveConnect stuff. Horrible polling hack that
+ blocks main thread waiting for applet to fully initialize.
Reviewed by Ken.
@@ -5098,9 +5086,8 @@ non-nil is returned.
2003-11-19 David Hyatt <hyatt at apple.com>
- Make updateScrollers guard non-static, so that it applies only to the view whose scrollers are being
- updated.
-
+ Make updateScrollers guard non-static, so that it applies only to the view whose scrollers are being
+ updated.
Reviewed by darin
* WebView.subproj/WebDynamicScrollBarsView.h:
@@ -5109,7 +5096,7 @@ non-nil is returned.
2003-11-18 Richard Williamson <rjw at apple.com>
- More live connect stubs. We're getting close.
+ More live connect stubs. We're getting close.
Reviewed by Chris.
@@ -5144,16 +5131,15 @@ non-nil is returned.
Reviewed by Dave.
- WebKit part of fix for:
+ WebKit part of fix for:
- <rdar://problem/3131664>: add support for the window.print() command used for "print this page" buttons
-
+ <rdar://problem/3131664>: add support for the window.print() command used for "print this page" buttons
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge print]): Call delegate.
* WebView.subproj/WebDefaultUIDelegate.m:
(-[WebDefaultUIDelegate webViewPrint:]): Implemented (do nothing).
* WebView.subproj/WebUIDelegatePrivate.h: Added. Add extra SPI method webViewPrint:
- for UI delegate.
+ for UI delegate.
* WebKit.pbproj/project.pbxproj: Install WebUIDelegatePrivate.h as private header
2003-11-15 Darin Adler <darin at apple.com>
@@ -5208,9 +5194,9 @@ non-nil is returned.
Reviewed by John.
- - fixed 3362841 - javascript History Object length property is always 0
+ - fixed 3362841 - javascript History Object length property is always 0
- * WebCoreSupport.subproj/WebBridge.m:
+ * WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge historyLength]): Add one to the length to match other browsers.
2003-11-14 John Sullivan <sullivan at apple.com>
@@ -5243,8 +5229,8 @@ non-nil is returned.
The fix is to avoid all usages of [NSURL host] by replacing all
such calls with a private URL method added to WebNSURLExtras.
- I copied a number of URL methods from the private NSURL
- extras file in Foundation to the WebKit URL extras file.
+ I copied a number of URL methods from the private NSURL
+ extras file in Foundation to the WebKit URL extras file.
* Misc.subproj/WebNSDataExtras.h: Added. Helper for new URL extras.
* Misc.subproj/WebNSDataExtras.m: Ditto.
@@ -5260,7 +5246,7 @@ non-nil is returned.
* WebKit.pbproj/project.pbxproj:
* WebView.subproj/WebView.m:
(-[WebView userAgentForURL:]): Replace call to [NSURL host] with new
- extras _web_hostString method.
+ extras _web_hostString method.
=== Safari-114 ===
@@ -5311,39 +5297,39 @@ non-nil is returned.
Reviewed by John
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3483284>: Tabbing to links needs to honor new
- WebKit tab-to-links preference
+ <rdar://problem/3483284>: Tabbing to links needs to honor new
+ WebKit tab-to-links preference
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge dealloc]): Remove self from notification center.
(-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): Now
- checks for WebCoreKeyboardAccessTabsToLinks preference.
+ checks for WebCoreKeyboardAccessTabsToLinks preference.
(-[WebBridge keyboardUIMode]): Adds self to notification center
- to pick up changes to WebPreferences.
+ to pick up changes to WebPreferences.
2003-11-13 Ken Kocienda <kocienda at apple.com>
Reviewed by John
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3481719>: WebKit needs preference for tabbing to links
+ <rdar://problem/3481719>: WebKit needs preference for tabbing to links
* WebView.subproj/WebPreferences.m:
(+[WebPreferences initialize]): Add initialization of new
- WebKitTabToLinksPreferenceKey.
+ WebKitTabToLinksPreferenceKey.
(-[WebPreferences setTabsToLinks:]): Added preference setter.
(-[WebPreferences tabsToLinks]): Added preference getter.
* WebView.subproj/WebPreferencesPrivate.h: Declared new methods as
- SPI on WebPreferences.
+ SPI on WebPreferences.
2003-11-12 Richard Williamson <rjw at apple.com>
- Fixed 3475082. Remove unnecessary orderKey before showKey.
+ Fixed 3475082. Remove unnecessary orderKey before showKey.
- Written by Ed Voas.
+ Written by Ed Voas.
Reviewed by Richard.
@@ -5352,7 +5338,7 @@ non-nil is returned.
2003-11-12 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3482147>: replace _releaseFutureIconForURL assertion with a log statement
+ Fixed: <rdar://problem/3482147>: replace _releaseFutureIconForURL assertion with a log statement
Reviewed by rjw.
@@ -5361,9 +5347,9 @@ non-nil is returned.
2003-11-10 Richard Williamson <rjw at apple.com>
- Fixed 3478765. Use ICU to access unicode properties.
- Fixed 3478831. Unicode property/conversion functions should be 32 bit savvy.
- Fixed 3478885. Remove dead arabic shaping code
+ Fixed 3478765. Use ICU to access unicode properties.
+ Fixed 3478831. Unicode property/conversion functions should be 32 bit savvy.
+ Fixed 3478885. Remove dead arabic shaping code
Reviewed by Darin.
@@ -5385,7 +5371,7 @@ non-nil is returned.
2003-11-10 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3478351>: Safari: URL Alias on Dock failed to open the 2byte URL
+ Fixed: <rdar://problem/3478351>: Safari: URL Alias on Dock failed to open the 2byte URL
Reviewed by dave.
@@ -5394,8 +5380,8 @@ non-nil is returned.
2003-11-10 Richard Williamson <rjw at apple.com>
- Use ICU for upper/lower conversion. Fixed 3477157, 3478455, 3478456, 3478457, 3478486.
- Remaining issues with surrogates (3477159) and Turkish I (3478482).
+ Use ICU for upper/lower conversion. Fixed 3477157, 3478455, 3478456, 3478457, 3478486.
+ Remaining issues with surrogates (3477159) and Turkish I (3478482).
Reviewed by Ken.
@@ -5405,7 +5391,7 @@ non-nil is returned.
2003-11-07 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3240778>: add "save" menu item to contextual menu for text pages
+ Fixed: <rdar://problem/3240778>: add "save" menu item to contextual menu for text pages
Reviewed by darin.
@@ -5417,7 +5403,7 @@ non-nil is returned.
2003-11-08 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3478022>: assertion failure while loading WMP content
+ Fixed: <rdar://problem/3478022>: assertion failure while loading WMP content
Reviewed by darin.
@@ -5427,7 +5413,7 @@ non-nil is returned.
2003-11-07 Richard Williamson <rjw at apple.com>
- Fixed 3477067. Use our case unicode conversion routines.
+ Fixed 3477067. Use our case unicode conversion routines.
Reviewed by Ken.
@@ -5436,7 +5422,7 @@ non-nil is returned.
2003-11-06 Richard Williamson <rjw at apple.com>
- Fixed 3476393. Call scrollPoint: recursively up the view hierarchy to ensure point is visible.
+ Fixed 3476393. Call scrollPoint: recursively up the view hierarchy to ensure point is visible.
Reviewed by Ken.
@@ -5461,8 +5447,8 @@ non-nil is returned.
2003-11-05 Richard Williamson <rjw at apple.com>
- Fixed 3413067, 3405797, 3456877
- Use ATSUI to render Arabic and Hebrew.
+ Fixed 3413067, 3405797, 3456877
+ Use ATSUI to render Arabic and Hebrew.
Reviewed by John.
@@ -5471,32 +5457,32 @@ non-nil is returned.
2003-11-05 John Sullivan <sullivan at apple.com>
- - fixed <rdar://problem/3469791>: Bigger/Smaller commands are
- disabled for HTML Mail in separate window (w/WebKit-111)
+ - fixed <rdar://problem/3469791>: Bigger/Smaller commands are
+ disabled for HTML Mail in separate window (w/WebKit-111)
Reviewed by Darin.
* WebView.subproj/WebFrameView.m:
(-[WebFrameView acceptsFirstResponder]):
- always be willing to become first responder, even if no page
- has yet been loaded.
+ always be willing to become first responder, even if no page
+ has yet been loaded.
(-[WebFrameView becomeFirstResponder]):
- if no page has yet been loaded (so our scrollview refuses
- first responder-ness), don't do any special becoming-first-
- responder shenanigans.
+ if no page has yet been loaded (so our scrollview refuses
+ first responder-ness), don't do any special becoming-first-
+ responder shenanigans.
- Also removed obsolete overrides for nextKeyView, nextValidKeyView,
- previousKeyView, and previousValidKeyView that are no longer
- required now that we handle the key loop more like NSScrollView.
+ Also removed obsolete overrides for nextKeyView, nextValidKeyView,
+ previousKeyView, and previousValidKeyView that are no longer
+ required now that we handle the key loop more like NSScrollView.
* WebView.subproj/WebFrameViewPrivate.h:
- removed now-unused ivar inNextValidKeyView
+ removed now-unused ivar inNextValidKeyView
2003-11-05 Richard Williamson <rjw at apple.com>
- Fixed 3029966. Animated backgrounds specified in <BODY> don't animate
- Fixed 3474824. Tiled animated GIFs don't animate.
- Fixed 3029966. Animated backgrounds specified with CSS don't animate.
+ Fixed 3029966. Animated backgrounds specified in <BODY> don't animate
+ Fixed 3474824. Tiled animated GIFs don't animate.
+ Fixed 3029966. Animated backgrounds specified with CSS don't animate.
Reviewed by Chris.
@@ -5511,7 +5497,7 @@ non-nil is returned.
2003-11-05 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3201364>: Safari crashes when hosting carbon plug-in using drag and drop
+ Fixed: <rdar://problem/3201364>: Safari crashes when hosting carbon plug-in using drag and drop
Reviewed by rjw.
@@ -5520,7 +5506,7 @@ non-nil is returned.
2003-11-05 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3474360>: should attempt to resolve symbolic links when choosing "Save Link As..."
+ Fixed: <rdar://problem/3474360>: should attempt to resolve symbolic links when choosing "Save Link As..."
Reviewed by kocienda.
@@ -5531,14 +5517,14 @@ non-nil is returned.
Reviewed by Darin
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3455910>: hitting up or down arrows when focus
- is on a pop-up menu should pop the menu
+ <rdar://problem/3455910>: hitting up or down arrows when focus
+ is on a pop-up menu should pop the menu
* WebView.subproj/WebFrameView.m:
(-[WebFrameView keyDown:]): Call super with the event if focus
- is on a pop up button.
+ is on a pop up button.
2003-11-05 Ken Kocienda <kocienda at apple.com>
@@ -5556,14 +5542,14 @@ non-nil is returned.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge fileButtonWithDelegate:]): Method now takes a
- delegate object.
+ delegate object.
* WebCoreSupport.subproj/WebFileButton.h:
* WebCoreSupport.subproj/WebFileButton.m:
(-[WebFileButton initWithBridge:delegate:]):
(-[WebFileButton initWithFrame:]):
(-[WebFileButton dealloc]):
(-[WebFileButton chooseFilename:]): Sends callback rather than posting
- a notification.
+ a notification.
(-[WebFileButton chooseButtonPressed:]): Ditto.
(-[WebFileButton mouseDown:]):
(-[WebFileButton acceptsFirstResponder]):
@@ -5620,11 +5606,10 @@ non-nil is returned.
2003-11-04 Chris Blumenberg <cblu at apple.com>
- Fixed:
- <rdar://problem/3472403>: RTFD of copied text and images should use original image data not tiffs
- <rdar://problem/3472435>: dragging local image file downloads it instead of copies it
- <rdar://problem/3472450>: copied and dragged local image files are TIFF, not original image data
-
+ Fixed:
+ <rdar://problem/3472403>: RTFD of copied text and images should use original image data not tiffs
+ <rdar://problem/3472435>: dragging local image file downloads it instead of copies it
+ <rdar://problem/3472450>: copied and dragged local image files are TIFF, not original image data
Reviewed by john.
* Misc.subproj/WebNSPasteboardExtras.h:
@@ -5668,9 +5653,9 @@ non-nil is returned.
2003-11-03 Chris Blumenberg <cblu at apple.com>
- Fixed:
- <rdar://problem/3472377>: Provide NSRTFDPboardType on pasteboard when copying or dragging images
- <rdar://problem/3470809>: REGRESSION (111-112): Can't copy & paste image into Photoshop 7
+ Fixed:
+ <rdar://problem/3472377>: Provide NSRTFDPboardType on pasteboard when copying or dragging images
+ <rdar://problem/3470809>: REGRESSION (111-112): Can't copy & paste image into Photoshop 7
Reviewed by hyatt.
@@ -5688,7 +5673,7 @@ non-nil is returned.
Reviewed by kocienda.
- - fixed <rdar://problem/3471096>: non-B&I builds should not use order files, because they cause false "regressions" in perf.
+ - fixed <rdar://problem/3471096>: non-B&I builds should not use order files, because they cause false "regressions" in perf.
* WebKit.pbproj/project.pbxproj: added empty SECTORDER_FLAGS variables to the Development and Deployment build styles
@@ -5703,7 +5688,7 @@ non-nil is returned.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView updateFocusRing]): New method. Uses the "keyness"
- of the view's window to toggle focus ring drawing.
+ of the view's window to toggle focus ring drawing.
(-[WebHTMLView windowDidBecomeKey:]): Calls updateFocusRing.
(-[WebHTMLView windowDidResignKey:]): Ditto.
@@ -5711,11 +5696,11 @@ non-nil is returned.
Reviewed by Darin.
- - remove use of obsolete HTTLCookiePolicyBaseURL SPI
+ - remove use of obsolete HTTLCookiePolicyBaseURL SPI
- * WebCoreSupport.subproj/WebSubresourceClient.m:
- startLoadingResource:withURL:referrer:forDataSource:]): Use
- setMainDocumentURL, not setHTTPCookiePolicyBaseURL.
+ * WebCoreSupport.subproj/WebSubresourceClient.m:
+ startLoadingResource:withURL:referrer:forDataSource:]): Use
+ setMainDocumentURL, not setHTTPCookiePolicyBaseURL.
* WebView.subproj/WebFrame.m:
(-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): Likewise.
* WebView.subproj/WebMainResourceClient.m:
@@ -5753,8 +5738,7 @@ non-nil is returned.
2003-10-31 David Hyatt <hyatt at apple.com>
- Fix for 3466542, add a real minimum font size setting.
-
+ Fix for 3466542, add a real minimum font size setting.
Reviewed by john
* WebView.subproj/WebPreferences.h:
@@ -5773,16 +5757,16 @@ non-nil is returned.
Fix for this bug:
<rdar://problem/3469088>: focus not removed from text link
- when user hits cmd-L or clicks in window chrome
+ when user hits cmd-L or clicks in window chrome
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView deselectText]): Added new method just to deselect text.
(-[WebHTMLView resignFirstResponder]): Just deseclect text if we
- are doing a programmatic setting of focus. Deselect all otherwise.
+ are doing a programmatic setting of focus. Deselect all otherwise.
2003-10-30 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3458368>: drawing to the screen while window hidden: http://www.bhphotovideo.com/
+ Fixed: <rdar://problem/3458368>: drawing to the screen while window hidden: http://www.bhphotovideo.com/
Reviewed by john.
@@ -5803,7 +5787,7 @@ non-nil is returned.
(-[WebGraphicsBridge setFocusRingStyle:radius:color:]): Added.
* WebKit.pbproj/project.pbxproj:
* WebView.subproj/WebFrameView.m: Create a WebGraphicsBridge
- when creating a WebFrameView.
+ when creating a WebFrameView.
=== Safari-112 ===
@@ -5811,16 +5795,15 @@ non-nil is returned.
Reviewed by Darin.
- - fixed 3467632 - Leak of plugin info visiting http://www.ebay.com
-
+ - fixed 3467632 - Leak of plugin info visiting http://www.ebay.com
* Plugins.subproj/WebBasePluginPackage.m:
(-[WebBasePluginPackage dealloc]): Release lastModifiedDate.
2003-10-29 Chris Blumenberg <cblu at apple.com>
- WebKit part of fix for:
- <rdar://problem/3467744>: Photoshop files (.psd) don't show up in Open dialog in Safari, but can be viewed
- <rdar://problem/3109132>: Can't open movie file via open panel even though it can be dropped in browser window
+ WebKit part of fix for:
+ <rdar://problem/3467744>: Photoshop files (.psd) don't show up in Open dialog in Safari, but can be viewed
+ <rdar://problem/3109132>: Can't open movie file via open panel even though it can be dropped in browser window
Reviewed by john.
@@ -5831,7 +5814,7 @@ non-nil is returned.
2003-10-29 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3438716>: jpg and gif images copied from Safari and placed in mail are sent as tiff
+ Fixed: <rdar://problem/3438716>: jpg and gif images copied from Safari and placed in mail are sent as tiff
Reviewed by john.
@@ -5867,8 +5850,7 @@ non-nil is returned.
2003-10-28 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3465383>: REGRESSION: Text field progress bar goes to 100% after error or stop
-
+ Fixed: <rdar://problem/3465383>: REGRESSION: Text field progress bar goes to 100% after error or stop
Reviewed by john.
* WebView.subproj/WebFrame.m:
@@ -5881,25 +5863,25 @@ nishedNotification notification.
Reviewed by Darin.
- - fixed 3083264 - frame names changed by JavaScript are not reflected in WebFrame at the WebKit level
+ - fixed 3083264 - frame names changed by JavaScript are not reflected in WebFrame at the WebKit level
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge didSetName:]): Tell the WebFrame about its new name.
2003-10-28 John Sullivan <sullivan at apple.com>
- - fixed 3465613 -- REGRESSION (111): Crash creating nib that
- contains WebView
+ - fixed 3465613 -- REGRESSION (111): Crash creating nib that
+ contains WebView
Reviewed by Chris.
* WebView.subproj/WebView.m:
(-[WebView mainFrame]):
- check for nil _private before dereferencing.
+ check for nil _private before dereferencing.
2003-10-28 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3465591>: Security: Netscape plug-ins can execute JavaScript in other frames
+ Fixed: <rdar://problem/3465591>: Security: Netscape plug-ins can execute JavaScript in other frames
Reviewed by mjs.
@@ -5910,7 +5892,7 @@ nishedNotification notification.
2003-10-28 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3437959>: javascript: URLs don't work from Java (and other Cocoa plugins, if any)
+ Fixed: <rdar://problem/3437959>: javascript: URLs don't work from Java (and other Cocoa plugins, if any)
Reviewed by mjs.
@@ -5931,7 +5913,7 @@ nishedNotification notification.
2003-10-27 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3462523>: Safari Sometimes Destroys Applets When Going "Back"
+ Fixed: <rdar://problem/3462523>: Safari Sometimes Destroys Applets When Going "Back"
Reviewed by darin.
@@ -5940,7 +5922,7 @@ nishedNotification notification.
2003-10-27 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3463144>: assertion failure when viewing jpeg with SoundPix installed
+ Fixed: <rdar://problem/3463144>: assertion failure when viewing jpeg with SoundPix installed
Reviewed by john.
@@ -5949,10 +5931,10 @@ nishedNotification notification.
2003-10-24 Chris Blumenberg <cblu at apple.com>
- Fixed:
- <rdar://problem/3462977>: ER: Nice if images dragged from web pages didn't redownload
- <rdar://problem/3031582>: Dragging an image to the desktop doesn't leave the file where I dropped it
- <rdar://problem/3061371>: "CFURLGetFSRef failed" log when dragging image to Finder
+ Fixed:
+ <rdar://problem/3462977>: ER: Nice if images dragged from web pages didn't redownload
+ <rdar://problem/3031582>: Dragging an image to the desktop doesn't leave the file where I dropped it
+ <rdar://problem/3061371>: "CFURLGetFSRef failed" log when dragging image to Finder
Reviewed by john.
@@ -5968,8 +5950,8 @@ nishedNotification notification.
2003-10-24 Richard Williamson <rjw at apple.com>
- Fixed 3425358. Don't try to create page cache for pages that
- have a nil view().
+ Fixed 3425358. Don't try to create page cache for pages that
+ have a nil view().
Reviewed by Hyatt.
@@ -5978,8 +5960,7 @@ nishedNotification notification.
(-[WebFrame _setState:]):
2003-10-24 Chris Blumenberg <cblu at apple.com>
-
- Fixed: <rdar://problem/3424039>: standalone plug-in content occasionaly redirects to blank page
+ Fixed: <rdar://problem/3424039>: standalone plug-in content occasionaly redirects to blank page
Reviewed by john.
@@ -5988,19 +5969,19 @@ nishedNotification notification.
2003-10-24 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3462256>: REGRESSION: Plain text is downloaded
+ Fixed: <rdar://problem/3462256>: REGRESSION: Plain text is downloaded
Reviewed by john.
* WebView.subproj/WebView.m:
- (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): use _web_objectForMIMEType when getting an object for a MIME. Removed unnecessary code that checked for the document classes after loading the plug-in DB since it is not an optimization because
+ (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): use _web_objectForMIMEType when getting an object for a MIME. Removed unnecessary code that checked for the document classes after loading the plug-in DB since it is not an optimization because
the plug-in DB calls _viewTypesAllowImageTypeOmission:NO.
2003-10-23 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3364036>: ER: Allow plug-ins to override built-in types such as image/jpeg
+ Fixed: <rdar://problem/3364036>: ER: Allow plug-ins to override built-in types such as image/jpeg
Reviewed by john.
@@ -6017,7 +5998,7 @@ nishedNotification notification.
(-[WebFrameView _makeDocumentViewForDataSource:]): tweak
(+[WebFrameView _viewClassForMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:]
* WebView.subproj/WebView.m:
- (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): new, central place for mapping from a MIME to the document classes. We now load the plug-in DB when a non-HTML MIME type is encountered instead of loading the plug-in DB when the class for the
+ (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): new, central place for mapping from a MIME to the document classes. We now load the plug-in DB when a non-HTML MIME type is encountered instead of loading the plug-in DB when the class for the
MIME type is not found. This is required to fully fix 3364036.
@@ -6027,64 +6008,64 @@ MIME type is not found. This is required to fully fix 3364036.
2003-10-23 John Sullivan <sullivan at apple.com>
- - fixed 3459272 -- Can't set up keyboard loop inside a
- WebDocumentView without subclassing views
- - fixed 3179062 -- can't tab back to address bar from image-only
- page
- - fixed 3252009 -- tabbing from address bar to content area does
- not work with WebTextView
- - fixed 3461398 -- Can't click on a standalone image to focus it
- (for later keyboard scrolling)
+ - fixed 3459272 -- Can't set up keyboard loop inside a
+ WebDocumentView without subclassing views
+ - fixed 3179062 -- can't tab back to address bar from image-only
+ page
+ - fixed 3252009 -- tabbing from address bar to content area does
+ not work with WebTextView
+ - fixed 3461398 -- Can't click on a standalone image to focus it
+ (for later keyboard scrolling)
- I redid the way WebView and WebFrameView splice themselves into
- the keyview loop in a way very similar to what NSScrollView and
- NSClipView do. This means that contained and sibling views won't
- need to do anything special to put themselves into the key loop.
+ I redid the way WebView and WebFrameView splice themselves into
+ the keyview loop in a way very similar to what NSScrollView and
+ NSClipView do. This means that contained and sibling views won't
+ need to do anything special to put themselves into the key loop.
Reviewed by Chris.
* WebView.subproj/WebFrameView.m:
(-[WebFrameView _scrollView]):
- check for nil pointer before dereferencing; this can happen
- during [super dealloc]'s keyview-loop-fixup code
- (-[WebFrameView initWithFrame:]):
- wire our nextKeyView link to the contained scrollview (so
- previousKeyView will work correctly from scrollview)
+ check for nil pointer before dereferencing; this can happen
+ during [super dealloc]'s keyview-loop-fixup code
+ (-[WebFrameView initWithFrame:]):
+ wire our nextKeyView link to the contained scrollview (so
+ previousKeyView will work correctly from scrollview)
(-[WebFrameView acceptsFirstResponder]):
- return what the contained scrollview says
+ return what the contained scrollview says
(-[WebFrameView becomeFirstResponder]):
- in previous direction, use previousValidKeyView (follows normal
- NSView keyview links); in forward direction, hand first
- responder-ness to contained scrollview (which will in turn hand
- it down to clipview, which will in turn hand it down to document)
+ in previous direction, use previousValidKeyView (follows normal
+ NSView keyview links); in forward direction, hand first
+ responder-ness to contained scrollview (which will in turn hand
+ it down to clipview, which will in turn hand it down to document)
(-[WebFrameView setNextKeyView:]):
- wire up scrollview instead of self, if it exists
+ wire up scrollview instead of self, if it exists
* WebView.subproj/WebImageView.m:
(-[WebImageView acceptsFirstResponder]):
- overridden to return YES; this fixes 3461398 and puts the finishing
- touches on 3179062
+ overridden to return YES; this fixes 3461398 and puts the finishing
+ touches on 3179062
* WebView.subproj/WebView.m:
(-[WebView _commonInitializationWithFrameName:groupName:]):
- wire our nextKeyView link to the contained webframeview (so
- previousKeyView will work correctly from webframeview). Also,
- if there's a nextKeyView already set (in a nib, e.g.), wire
- it to our contained webframeview.
+ wire our nextKeyView link to the contained webframeview (so
+ previousKeyView will work correctly from webframeview). Also,
+ if there's a nextKeyView already set (in a nib, e.g.), wire
+ it to our contained webframeview.
(-[WebView acceptsFirstResponder]):
- return what the contained webframeview says
+ return what the contained webframeview says
(-[WebView becomeFirstResponder]):
- in previous direction, use previousValidKeyView (follows normal
- NSView keyview links); in forward direction, hand first
- responder-ness to contained webframeview (which will in turn hand
- it down to scrollview, etc.)
+ in previous direction, use previousValidKeyView (follows normal
+ NSView keyview links); in forward direction, hand first
+ responder-ness to contained webframeview (which will in turn hand
+ it down to scrollview, etc.)
(-[WebView setNextKeyView:]):
- wire up webframeview instead of self, if it exists
+ wire up webframeview instead of self, if it exists
2003-10-22 Richard Williamson <rjw at apple.com>
- Match WebCore's notion of distributing linegap between top and bottom of
- line. WebKit used to put it all at the bottom of the line.
+ Match WebCore's notion of distributing linegap between top and bottom of
+ line. WebKit used to put it all at the bottom of the line.
Reviewed by Hyatt.
@@ -6097,20 +6078,20 @@ MIME type is not found. This is required to fully fix 3364036.
Reviewed by Dave.
- Finished exception blocking changes, so now I can finally say:
-
- - fixed 3137084 - Many non-reproducible crashers in ContextImp::mark / ScopeChain::mark
- - fixed 3308848 - nil-deref in KHTMLView::topLevelWidget
- - fixed 3311511 - nil deref inside KJS::Screen
- - fixed 3397422 - 7B51: Safari crashed in KJS::ObjectImp::mark()
- - fixed 3408373 - Panther7B58 : Safari Crashed in KJS::ObjectImp::mark
- - fixed 3409307 - 7B55: safari crashed in KJS::Interpreter::globalExec() (idle, nothing particular going on)
- - fixed 3410160 - 7B60 Safari crashed in KHTMLPart::parentPart called from JS while in the background
- - fixed 3413224 - unrepro crash in KJS::Window::mark
- - fixed 3419940 - unrepro crash in KJS::Collector::allocate trying to access http://www.lindyinthepalms.com
- - fixed 3420123 - Panther7B66: Safari crashed while going to http://www.tangents.co.uk/index2.html
- - fixed 3423225 - Safari crash in vtable for KWQMapImpl (vtable for KWQMapImpl + 8).
- - fixed 3437190 - nil-deref on quit in calling marked() from ScopeChain::mark()
+ Finished exception blocking changes, so now I can finally say:
+
+ - fixed 3137084 - Many non-reproducible crashers in ContextImp::mark / ScopeChain::mark
+ - fixed 3308848 - nil-deref in KHTMLView::topLevelWidget
+ - fixed 3311511 - nil deref inside KJS::Screen
+ - fixed 3397422 - 7B51: Safari crashed in KJS::ObjectImp::mark()
+ - fixed 3408373 - Panther7B58 : Safari Crashed in KJS::ObjectImp::mark
+ - fixed 3409307 - 7B55: safari crashed in KJS::Interpreter::globalExec() (idle, nothing particular going on)
+ - fixed 3410160 - 7B60 Safari crashed in KHTMLPart::parentPart called from JS while in the background
+ - fixed 3413224 - unrepro crash in KJS::Window::mark
+ - fixed 3419940 - unrepro crash in KJS::Collector::allocate trying to access http://www.lindyinthepalms.com
+ - fixed 3420123 - Panther7B66: Safari crashed while going to http://www.tangents.co.uk/index2.html
+ - fixed 3423225 - Safari crash in vtable for KWQMapImpl (vtable for KWQMapImpl + 8).
+ - fixed 3437190 - nil-deref on quit in calling marked() from ScopeChain::mark()
* WebCoreSupport.subproj/WebTextRenderer.m:
(-[WebTextRenderer ascent]):
@@ -6128,7 +6109,7 @@ MIME type is not found. This is required to fully fix 3364036.
2003-10-22 Richard Williamson <rjw at apple.com>
- Fixed 3458715. Reset to 0, not .1 when done.
+ Fixed 3458715. Reset to 0, not .1 when done.
Reviewed by Chris.
@@ -6138,8 +6119,8 @@ MIME type is not found. This is required to fully fix 3364036.
2003-10-21 Richard Williamson <rjw at apple.com>
- Don't use small caps font for characters that don't have an
- uppercase counterpart (i.e. punctuation marks).
+ Don't use small caps font for characters that don't have an
+ uppercase counterpart (i.e. punctuation marks).
Reviewed by Hyatt.
@@ -6148,8 +6129,7 @@ MIME type is not found. This is required to fully fix 3364036.
2003-10-21 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled
-
+ Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled
Reviewed by rjw.
* Plugins.subproj/WebPluginDatabase.m:
@@ -6158,14 +6138,14 @@ MIME type is not found. This is required to fully fix 3364036.
o MIME type is specified.
* WebCoreSupport.subproj/WebBridge.m:
- (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): If the passed MIME is empty, nil it out so that clients only need to check for nil. This avoids error sheets complaining about "" MIME types.
+ (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): If the passed MIME is empty, nil it out so that clients only need to check for nil. This avoids error sheets complaining about "" MIME types.
(-[WebBridge frameRequiredForMIMEType:URL:]): Renamed to include URL. If no MIME is specified, only create a plug-in view if we can map from the extension.
2003-10-20 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3457627>: empty Flash plugin at tvguide.com
- Fixed issues with plug-in stream error handling.
- Improved plug-in logging.
+ Fixed: <rdar://problem/3457627>: empty Flash plugin at tvguide.com
+ Fixed issues with plug-in stream error handling.
+ Improved plug-in logging.
Reviewed by kocienda.
@@ -6205,8 +6185,8 @@ o MIME type is specified.
2003-10-20 Richard Williamson <rjw at apple.com>
- Conditionally excluded fix for 3446192. We'll enable the fix once 3446669
- has been fixed. This patch switches to the new UTI typing API for pasteboard types.
+ Conditionally excluded fix for 3446192. We'll enable the fix once 3446669
+ has been fixed. This patch switches to the new UTI typing API for pasteboard types.
Reviewed by Ken.
@@ -6215,16 +6195,16 @@ o MIME type is specified.
2003-10-20 Richard Williamson <rjw at apple.com>
- Fixed 3456103. Don't assert, just check for inappropriate state.
- Reviewed by Hyatt
+ Fixed 3456103. Don't assert, just check for inappropriate state.
+ Reviewed by Hyatt
- Add a debug menu item to always use ATSU text drawing. This will be helpful
- to the ATSU folks in performance tuning there API. Right now I see approx.
- 2X slowdown using ATSU.
+ Add a debug menu item to always use ATSU text drawing. This will be helpful
+ to the ATSU folks in performance tuning there API. Right now I see approx.
+ 2X slowdown using ATSU.
- Also did some shuffling around of inline related stuff.
+ Also did some shuffling around of inline related stuff.
- Reviewed by Chris.
+ Reviewed by Chris.
* WebCoreSupport.subproj/WebTextRenderer.h:
* WebCoreSupport.subproj/WebTextRenderer.m:
@@ -6245,7 +6225,7 @@ o MIME type is specified.
2003-10-19 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3442218>: crash due to infinite recursion trying to load standalone plug-in content
+ Fixed: <rdar://problem/3442218>: crash due to infinite recursion trying to load standalone plug-in content
Reviewed by darin.
@@ -6264,13 +6244,13 @@ o MIME type is specified.
2003-10-18 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3229530>: Dragging standalone image to desktop should save it, not re-download it
+ Fixed: <rdar://problem/3229530>: Dragging standalone image to desktop should save it, not re-download it
Reviewed by darin.
- * English.lproj/Localizable.strings:
+ * English.lproj/Localizable.strings:
* WebKit.pbproj/project.pbxproj:
- * WebView.subproj/WebDocumentPrivate.h: Added.
+ * WebView.subproj/WebDocumentPrivate.h: Added.
* WebView.subproj/WebImageRepresentation.h:
* WebView.subproj/WebImageRepresentation.m:
(-[WebImageRepresentation dealloc]): release new filename and data ivars
@@ -6282,11 +6262,11 @@ o MIME type is specified.
(-[WebImageRepresentation filename]): new
* WebView.subproj/WebImageView.m:
(-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): just save the image, don't download it
- (-[WebImageView image]): new
+ (-[WebImageView image]): new
2003-10-17 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3456176>: Assertion failure when loading atomfilms.com
+ Fixed: <rdar://problem/3456176>: Assertion failure when loading atomfilms.com
Reviewed by kocienda.
@@ -6297,7 +6277,7 @@ o MIME type is specified.
2003-10-16 Richard Williamson <rjw at apple.com>
- Fixed 3455306. Ensure that progress is correctly ended when a load is interupted (i.e. becomes a download).
+ Fixed 3455306. Ensure that progress is correctly ended when a load is interupted (i.e. becomes a download).
Reviewed by mjs.
@@ -6306,7 +6286,7 @@ o MIME type is specified.
2003-10-16 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3455176>: Assertion failure when loading non-existant plug-in content
+ Fixed: <rdar://problem/3455176>: Assertion failure when loading non-existant plug-in content
Reviewed by rjw.
@@ -6316,8 +6296,8 @@ o MIME type is specified.
2003-10-16 Richard Williamson <rjw at apple.com>
- Fixed 3453991. We weren't setting the array cursor correctly after changing
- capacity.
+ Fixed 3453991. We weren't setting the array cursor correctly after changing
+ capacity.
Reviewed by John.
@@ -6329,8 +6309,8 @@ o MIME type is specified.
2003-10-16 Richard Williamson <rjw at apple.com>
- Tweaked the progress behavior and factored cleanup of progress
- related ivars.
+ Tweaked the progress behavior and factored cleanup of progress
+ related ivars.
Reviewed by Hyatt.
@@ -6369,28 +6349,28 @@ o MIME type is specified.
Reviewed by Darin
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3450449>: assertion failure in WebBridge
- _retrieveKeyboardUIModeFromPreferences
+ <rdar://problem/3450449>: assertion failure in WebBridge
+ _retrieveKeyboardUIModeFromPreferences
- Can't assert that the preference always exists and is valid as I
- thought you could. This could just mean that the a preference for full
- keyboard access has not been specified by the user yet. If this is so,
- just return the default keyboard access mode.
+ Can't assert that the preference always exists and is valid as I
+ thought you could. This could just mean that the a preference for full
+ keyboard access has not been specified by the user yet. If this is so,
+ just return the default keyboard access mode.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge _retrieveKeyboardUIModeFromPreferences:])
2003-10-13 Richard Williamson <rjw at apple.com>
- Added support for small-caps.
+ Added support for small-caps.
- Reworked drawing and measuring to use new iterators. Position checking was already using
- the new iterator code, but I was reluctant to switch the mainline drawing and measuring
- code over to the new approach until now.
+ Reworked drawing and measuring to use new iterators. Position checking was already using
+ the new iterator code, but I was reluctant to switch the mainline drawing and measuring
+ code over to the new approach until now.
- Lots of other code cleanup.
+ Lots of other code cleanup.
Reviewed by John.
@@ -6463,12 +6443,11 @@ o MIME type is specified.
2003-10-10 Maciej Stachowiak <mjs at apple.com>
* English.lproj/StringsNotToBeLocalized.txt: Fixed for Private
- change from a while back.
+ change from a while back.
2003-10-10 David Hyatt <hyatt at apple.com>
- Patch to move widgets during layout instead of waiting until paint time.
-
+ Patch to move widgets during layout instead of waiting until paint time.
Reviewed by darin
* WebView.subproj/WebDataSource.m:
@@ -6480,7 +6459,7 @@ o MIME type is specified.
2003-10-09 Richard Williamson <rjw at apple.com>
- Ensure that the autoscroll timer is always stopped if a mouse up event is lost.
+ Ensure that the autoscroll timer is always stopped if a mouse up event is lost.
Reviewed by John.
@@ -6494,7 +6473,7 @@ o MIME type is specified.
2003-10-09 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3333897>: should support navigator.plugins.refresh as a way to add a plugin without restarting Safari
+ Fixed: <rdar://problem/3333897>: should support navigator.plugins.refresh as a way to add a plugin without restarting Safari
Reviewed by rjw.
@@ -6533,9 +6512,9 @@ o MIME type is specified.
2003-10-03 Richard Williamson <rjw at apple.com>
- Fix part of 3438071. Creating an instance of WebPreferences using init
- will do the expected thing: that is, create a new instance! We used to
- always return standardPreferences.
+ Fix part of 3438071. Creating an instance of WebPreferences using init
+ will do the expected thing: that is, create a new instance! We used to
+ always return standardPreferences.
Reviewed by Chris.
@@ -6545,9 +6524,8 @@ o MIME type is specified.
2003-10-03 David Hyatt <hyatt at apple.com>
- Fix for numerous regressions caused by an inadvertent renaming of the recursiveDisplay
- override method.
-
+ Fix for numerous regressions caused by an inadvertent renaming of the recursiveDisplay
+ override method.
Reviewed by darin
* WebView.subproj/WebHTMLView.m:
@@ -6555,7 +6533,7 @@ o MIME type is specified.
2003-10-03 Richard Williamson (Home0 <rjw at apple.com>
- Fixed some edge case issue (control characters after end of word) with our rounding hack.
+ Fixed some edge case issue (control characters after end of word) with our rounding hack.
Reviewed by Darin.
@@ -6566,24 +6544,24 @@ o MIME type is specified.
Reviewed by Darin, with much help from Maciej and Hyatt
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3441321>: Form buttons do not respond to key events when focused
+ <rdar://problem/3441321>: Form buttons do not respond to key events when focused
* WebView.subproj/WebFrameView.m:
(-[WebFrameView _firstResponderIsControl]): Added to tell if the focus
- is on a form control.
+ is on a form control.
(-[WebFrameView keyDown:]): Call new _firstResponderIsControl method to see
- whether space bar key events should propagate. Adding this check keeps us
- from blocking the event here and allows AppKit to handle it.
+ whether space bar key events should propagate. Adding this check keeps us
+ from blocking the event here and allows AppKit to handle it.
* WebView.subproj/WebFrameViewPrivate.h: Add new _firstResponderIsControl
- method.
+ method.
2003-10-02 Maciej Stachowiak <mjs at apple.com>
Folded Private implementation files into the regular ones as the
- first step towards pulling in our SPI exposure and other code
- cleanup.
+ first step towards pulling in our SPI exposure and other code
+ cleanup.
* History.subproj/WebHistory.m:
* History.subproj/WebHistoryPrivate.m: Removed.
@@ -6602,7 +6580,7 @@ o MIME type is specified.
2003-10-02 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3440063>: Safari 1.1 won't load new pages after visiting adultswim.com, assertion failure on debug build
+ Fixed: <rdar://problem/3440063>: Safari 1.1 won't load new pages after visiting adultswim.com, assertion failure on debug build
Reviewed by rjw.
@@ -6619,8 +6597,7 @@ o MIME type is specified.
Reviewed by Darin.
- - fixed 3441466 - REGRESSION: http://www.meyerweb.com/eric/css/edge/complexspiral/glassy.html broken on scroll
-
+ - fixed 3441466 - REGRESSION: http://www.meyerweb.com/eric/css/edge/complexspiral/glassy.html broken on scroll
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _setState:]): Don't turn on scroll-blitting here when the page is done...
(-[WebFrame _transitionToCommitted:]): Instead do it here, when the page is committed.
@@ -6653,9 +6630,8 @@ o MIME type is specified.
2003-10-02 David Hyatt <hyatt at apple.com>
- Work on exposing elements to the Acc API. This patch gets us to the point where text
- under the mouse is voiced.
-
+ Work on exposing elements to the Acc API. This patch gets us to the point where text
+ under the mouse is voiced.
Reviewed by darin
* WebView.subproj/WebHTMLView.m:
@@ -6668,24 +6644,24 @@ o MIME type is specified.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView viewDidMoveToSuperview]):
- skip some work when when we've been removed. This wasn't
- causing any trouble before, but was at least conceptually
- inefficient.
+ skip some work when when we've been removed. This wasn't
+ causing any trouble before, but was at least conceptually
+ inefficient.
2003-10-01 John Sullivan <sullivan at apple.com>
- - fixed 3441372: REGRESSION (107+): Plain text document is
- initially drawn with proportional font
+ - fixed 3441372: REGRESSION (107+): Plain text document is
+ initially drawn with proportional font
Reviewed by Hyatt
* WebView.subproj/WebTextView.m:
(-[WebTextView setDataSource:]):
- Changed a != to an ==
+ Changed a != to an ==
2003-10-01 Richard Williamson <rjw at apple.com>
- Fixed 3438441. If a load is triggered by a onload handling, don't add an entry for it into the b/f or history. The new Google ads use this technique.
+ Fixed 3438441. If a load is triggered by a onload handling, don't add an entry for it into the b/f or history. The new Google ads use this technique.
Reviewed by Ken.
@@ -6711,21 +6687,20 @@ o MIME type is specified.
2003-10-01 David Hyatt <hyatt at apple.com>
- Fix for 3440804, broken scrollbars in downloads window. Make Auto be the default
- value in the enum, so that all scrollviews will be automatically initialized to be
- auto.
-
+ Fix for 3440804, broken scrollbars in downloads window. Make Auto be the default
+ value in the enum, so that all scrollviews will be automatically initialized to be
+ auto.
Reviewed by cblu
* WebView.subproj/WebDynamicScrollBarsView.m:
2003-09-30 Richard Williamson <rjw at apple.com>
- Attempt to find a reasonable font using a simple string matching heuristic if
- none of the fonts actually specified are found. In particular we will use
- Geeza Pro if "arabic", "urdu", or "pashto" is contained (case-insensitive) in
- any of the requested font family names. Geeza Pro is a much better fallback
- font for Arabic (and variant languages) than Helvetica.
+ Attempt to find a reasonable font using a simple string matching heuristic if
+ none of the fonts actually specified are found. In particular we will use
+ Geeza Pro if "arabic", "urdu", or "pashto" is contained (case-insensitive) in
+ any of the requested font family names. Geeza Pro is a much better fallback
+ font for Arabic (and variant languages) than Helvetica.
Reviewed by Chris.
@@ -6744,8 +6719,8 @@ o MIME type is specified.
Reviewed by NOBODY (OOPS!).
* WebView.subproj/WebDocumentInternal.h: Added.
- New header file, holds definition of
- _web_WebDocumentTextSizing protocol.
+ New header file, holds definition of
+ _web_WebDocumentTextSizing protocol.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _textSizeMultiplierChanged]):
@@ -6765,7 +6740,7 @@ o MIME type is specified.
(-[WebTextRepresentation receivedData:withDataSource:]):
* WebView.subproj/WebTextView.h:
- now implements _web_WebDocumentTextSizing protocol;
+ now implements _web_WebDocumentTextSizing protocol;
new ivar for holding local copy of text size multiplier;
new public method appendReceivedData:fromDataSource:
@@ -6808,7 +6783,7 @@ o MIME type is specified.
2003-09-30 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3428262>: Plugin loads for static files, but not PHP scripts
+ Fixed: <rdar://problem/3428262>: Plugin loads for static files, but not PHP scripts
Reviewed by rjw.
@@ -6817,7 +6792,7 @@ o MIME type is specified.
2003-09-30 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3006869>: show image dimensions in title bar when single image is loaded
+ Fixed: <rdar://problem/3006869>: show image dimensions in title bar when single image is loaded
Reviewed by rjw.
@@ -6827,7 +6802,7 @@ o MIME type is specified.
2003-09-30 Richard Williamson <rjw at apple.com>
- Fixed 3420396. If a frame targets _top and a URL that contains a fragment (very unusual, it's meaningless for a frameset to contain a named anchor point) the frameset won't be reloaded. Our normal path is to just scroll to the anchor point. This is on
+ Fixed 3420396. If a frame targets _top and a URL that contains a fragment (very unusual, it's meaningless for a frameset to contain a named anchor point) the frameset won't be reloaded. Our normal path is to just scroll to the anchor point. This is on
ly important because our Help folks oddly depend on the behavior.
@@ -6858,10 +6833,10 @@ ly important because our Help folks oddly depend on the behavior.
Reviewed by Ken.
- - fixed 3375281 - Keyboard event handlers not fired if focus not in form field
- - fixed 3242927 - KeyPressed Event in Javascript don't work
- - fixed 3375353 - keyboard event.target not updated when blurring from form items
- - fixed 3183754 - returning false from key press handlers does not prevent typing or form submission
+ - fixed 3375281 - Keyboard event handlers not fired if focus not in form field
+ - fixed 3242927 - KeyPressed Event in Javascript don't work
+ - fixed 3375353 - keyboard event.target not updated when blurring from form items
+ - fixed 3183754 - returning false from key press handlers does not prevent typing or form submission
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView keyDown:]): Ask the bridge before passing the event along.
@@ -6871,7 +6846,7 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-30 Richard Williamson <rjw at apple.com>
- Fixed 3422138. We weren't sending a didChange call for isLoading until the load was complete! Also [WebView isLoading] wasn't accounting for provisional datasources.
+ Fixed 3422138. We weren't sending a didChange call for isLoading until the load was complete! Also [WebView isLoading] wasn't accounting for provisional datasources.
Reviewed by Chris.
@@ -6887,9 +6862,8 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-30 David Hyatt <hyatt at apple.com>
- Improvements to scrolling and layout. Also fixing 3264346, body overflow should
- apply to document's scrollbars.
-
+ Improvements to scrolling and layout. Also fixing 3264346, body overflow should
+ apply to document's scrollbars.
Reviewed by darin
* WebView.subproj/WebDynamicScrollBarsView.h:
@@ -6912,7 +6886,7 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-29 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3422739>: Plug-in streams not cancelled when plug-in returns error from NPP_NewStream
+ Fixed: <rdar://problem/3422739>: Plug-in streams not cancelled when plug-in returns error from NPP_NewStream
Reviewed by mjs.
@@ -6923,7 +6897,7 @@ ly important because our Help folks oddly depend on the behavior.
(-[WebBaseNetscapePluginStream finishedLoadingWithData:]): tweak
* Plugins.subproj/WebNetscapePluginRepresentation.m:
(-[WebNetscapePluginRepresentation receivedError:withDataSource:]): call renamed cancelWithReason
- (-[WebNetscapePluginRepresentation cancelWithReason:]): new override, stop load then call super
+ (-[WebNetscapePluginRepresentation cancelWithReason:]): new override, stop load then call super
* Plugins.subproj/WebNetscapePluginStream.m:
(-[WebNetscapePluginStream cancelWithReason:]): new override, stop load then call super
(-[WebNetscapePluginStream stop]): call cancelWithReason
@@ -6932,15 +6906,13 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-25 Maciej Stachowiak <mjs at apple.com>
- Roll out build system change since it did not actually work. :-(
-
+ Roll out build system change since it did not actually work. :-(
* WebKit.pbproj/project.pbxproj:
2003-09-25 David Hyatt <hyatt at apple.com>
- Change layout so that it is called from the private _recursive functions instead of
- inside drawRect.
-
+ Change layout so that it is called from the private _recursive functions instead of
+ inside drawRect.
Reviewed by kocienda
* WebView.subproj/WebHTMLView.m:
@@ -6958,7 +6930,7 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-25 Richard Williamson <rjw at apple.com>
- Fixed 3433802. Written by Ed. Carbon WebView doesn't detach native view when removed.
+ Fixed 3433802. Written by Ed. Carbon WebView doesn't detach native view when removed.
Reviewed by Richard.
@@ -6967,7 +6939,7 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-25 Richard Williamson <rjw at apple.com>
- Fixed 3433488. Written by Ed. WebKit doesn't sync window visibility when new webview added to visible window.
+ Fixed 3433488. Written by Ed. WebKit doesn't sync window visibility when new webview added to visible window.
Reviewed by Richard.
@@ -6976,7 +6948,7 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-25 Richard Williamson <rjw at apple.com>
- Fixed 3434854. Written by Ed. Correctly handle window modality in carbon.
+ Fixed 3434854. Written by Ed. Correctly handle window modality in carbon.
Reviewed by Richard.
@@ -6987,10 +6959,9 @@ ly important because our Help folks oddly depend on the behavior.
Reviewed by Darin.
- Updated setup for engineering builds. Don't embed the framework
- into Safari or hack the install name. However, do copy WebCore and
- JavaScriptCore into the proper sub-umbrella locations.
-
+ Updated setup for engineering builds. Don't embed the framework
+ into Safari or hack the install name. However, do copy WebCore and
+ JavaScriptCore into the proper sub-umbrella locations.
* WebKit.pbproj/project.pbxproj:
* embed-frameworks.sh: Added.
@@ -7019,8 +6990,8 @@ ly important because our Help folks oddly depend on the behavior.
behave like other views. This check also heads off an infinite recursion
through -[WebBridge nextKeyViewOutsideWebFrameViews].
- Also did some cleanup of some code that was marked for removal "some day".
- That "some day" is today.
+ Also did some cleanup of some code that was marked for removal "some day".
+ That "some day" is today.
2003-09-25 Darin Adler <darin at apple.com>
@@ -7041,9 +7012,9 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-24 Richard Williamson <rjw at apple.com>
- Fixed 3420736. Clear renderer caches when get an ATS font changed notification. This fix may be moot depending on progress toward fixing 2695906. Also 3428451 needs to should be resolved.
+ Fixed 3420736. Clear renderer caches when get an ATS font changed notification. This fix may be moot depending on progress toward fixing 2695906. Also 3428451 needs to should be resolved.
- Also added code to get and log entry point for the function used to get a Java class from plugins. That class is used for LiveConnect support.
+ Also added code to get and log entry point for the function used to get a Java class from plugins. That class is used for LiveConnect support.
Reviewed by John.
@@ -7148,7 +7119,7 @@ ly important because our Help folks oddly depend on the behavior.
Reviewed by Darin.
- Roll out old fix for 3410980.
+ Roll out old fix for 3410980.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge goBackOrForward:]):
@@ -7170,7 +7141,7 @@ ly important because our Help folks oddly depend on the behavior.
Reviewed by Darin.
- - fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes
+ - fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge backOrForwardItemWithDistance:]): Factored out from goBackOrForward.
@@ -7179,28 +7150,27 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-17 John Sullivan <sullivan at apple.com>
- - WebKit part of fix for 3157018 -- Would like option to
- not print backgrounds
-
+ - WebKit part of fix for 3157018 -- Would like option to
+ not print backgrounds
Reviewed by Darin
* WebView.subproj/WebPreferences.h:
- new accessor methods for new shouldPrintBackgrounds preference
+ new accessor methods for new shouldPrintBackgrounds preference
* WebView.subproj/WebPreferences.m:
(+[WebPreferences initialize]):
- set initial value for WebKitShouldPrintBackgroundsPreferenceKey
- to NO
+ set initial value for WebKitShouldPrintBackgroundsPreferenceKey
+ to NO
(-[WebPreferences shouldPrintBackgrounds]):
- new method, read NSUserDefaults value
+ new method, read NSUserDefaults value
(-[WebPreferences setShouldPrintBackgrounds:]):
- new method, write NSUserDefault value
+ new method, write NSUserDefault value
* WebView.subproj/WebViewPrivate.m:
(-[WebView _updateWebCoreSettingsFromPreferences:]):
- tell WebCore about value of shouldPrintBackgrounds
+ tell WebCore about value of shouldPrintBackgrounds
* English.lproj/StringsNotToBeLocalized.txt:
- Updated for these and other recent changes
+ Updated for these and other recent changes
2003-09-17 Darin Adler <darin at apple.com>
@@ -7225,9 +7195,9 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-16 Richard Williamson <rjw at apple.com>
- Backed out fix to 3412062 to resolve 3424197.
+ Backed out fix to 3412062 to resolve 3424197.
- Many sites use a technique of posting forms the same URL to generate content server side. The fix to 3412062 broke those sites.
+ Many sites use a technique of posting forms the same URL to generate content server side. The fix to 3412062 broke those sites.
Reviewed by Darin.
@@ -7240,7 +7210,7 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-12 Richard Williamson <rjw at apple.com>
- Fixed 3420097. If redirects are cancelled during a pending load don't reset the quickRedirect flag.
+ Fixed 3420097. If redirects are cancelled during a pending load don't reset the quickRedirect flag.
Reviewed by Darin.
@@ -7257,7 +7227,7 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-12 Richard Williamson <rjw at apple.com>
- Fixed 3412062. Don't allow pages with the same URL as the current URL to enter b/f or history.
+ Fixed 3412062. Don't allow pages with the same URL as the current URL to enter b/f or history.
Reviewed by Maciej.
@@ -7268,14 +7238,13 @@ ly important because our Help folks oddly depend on the behavior.
Reviewed by Darin.
- - fixed 3413463 - QuickTime plug-in content doesn't load in Safari (NPP_Write not called)
-
+ - fixed 3413463 - QuickTime plug-in content doesn't load in Safari (NPP_Write not called)
* Plugins.subproj/npapi.h: Fix erroneous function pointer
- declarations that led to an int16/int32 mismatch.
+ declarations that led to an int16/int32 mismatch.
2003-09-12 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3420112>: Reproducible Safari crash in in -[WebBaseNetscapePluginView sendEvent:]
+ Fixed: <rdar://problem/3420112>: Reproducible Safari crash in in -[WebBaseNetscapePluginView sendEvent:]
Reviewed by darin.
@@ -7289,16 +7258,16 @@ ly important because our Help folks oddly depend on the behavior.
Reviewed by Ken.
- - fixed 3417486 - after logging off from secure Etrade website, going back returns you to secure page
+ - fixed 3417486 - after logging off from secure Etrade website, going back returns you to secure page
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _loadItem:withLoadType:]): Don't request stale data
- for https pages, as this could be a security risk.
+ for https pages, as this could be a security risk.
2003-09-11 Richard Williamson <rjw at apple.com>
- Fixed 3406671. Added a private method for Mail to get selection
- rect.
+ Fixed 3406671. Added a private method for Mail to get selection
+ rect.
Reviewed by Darin Adler.
@@ -7312,9 +7281,9 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-10 Richard Williamson <rjw at apple.com>
- Fixed 3231031. Use the normal methodology for displaying each frame of a GIF. That is,
- just call setNeedsDisplayInRect, rather than drawing directly. Drawing directly violates
- layering/clipping.
+ Fixed 3231031. Use the normal methodology for displaying each frame of a GIF. That is,
+ just call setNeedsDisplayInRect, rather than drawing directly. Drawing directly violates
+ layering/clipping.
Reviewed by Dave Hyatt.
@@ -7325,18 +7294,18 @@ ly important because our Help folks oddly depend on the behavior.
2003-09-09 Richard Williamson <rjw at apple.com>
- Fixed 3414988. Don't store absolute path to home directory.
- Reviewed by Chris Blumenberg.
+ Fixed 3414988. Don't store absolute path to home directory.
+ Reviewed by Chris Blumenberg.
- Fixed 3414319. Send correct WebView back as parameter to webViewShow:
- Review by Darin.
+ Fixed 3414319. Send correct WebView back as parameter to webViewShow:
+ Review by Darin.
- Fixed 3095029. Draw a frame's border in WebFrameView, instead of WebHTMLView, and correctly inset the frame's scrollview to account for the border. Mostly written by Darin.
+ Fixed 3095029. Draw a frame's border in WebFrameView, instead of WebHTMLView, and correctly inset the frame's scrollview to account for the border. Mostly written by Darin.
Reviewed by Darin (and Richard).
* Misc.subproj/WebIconDatabase.m:
(-[WebIconDatabase _createFileDatabase]):
- Store @"~/Library/Icon" instead of absolute path, and always try to tilde expand stored path.
+ Store @"~/Library/Icon" instead of absolute path, and always try to tilde expand stored path.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge setHasBorder:]):
@@ -7352,17 +7321,17 @@ ly important because our Help folks oddly depend on the behavior.
(-[WebFrameView _setHasBorder:]):
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView drawRect:]):
- Changes to correct draw border in WebFrameView instead of WebHTMLView.
+ Changes to correct draw border in WebFrameView instead of WebHTMLView.
* WebView.subproj/WebViewPrivate.m:
(-[WebView _openNewWindowWithRequest:]):
- Send correct parameter (returned from webView:createWebViewWithRequest:), rather than self, to webViewShow:.
+ Send correct parameter (returned from webView:createWebViewWithRequest:), rather than self, to webViewShow:.
2003-09-09 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3412380>: REGRESSION (85-98): www.minoltan.com is decoded incorrectly on Japanese system
+ Fixed: <rdar://problem/3412380>: REGRESSION (85-98): www.minoltan.com is decoded incorrectly on Japanese system
- The default encoding that Safari uses is latin1 regardless of the current system encoding. This is how it's always been. The problem is that the UI is displaying shift JIS for the default text encoding instead of latin1. This is happening because WebKit
+ The default encoding that Safari uses is latin1 regardless of the current system encoding. This is how it's always been. The problem is that the UI is displaying shift JIS for the default text encoding instead of latin1. This is happening because WebKit
is using "latin1" instead of "ISO-8859-1" for the default text encoding name. "ISO-8859-1" is the IANA character set name for latin1 and this is what the WebKitDefaultTextEncodingNamePreferenceKey preference expects. This ends up confusing Safari, so Saf
@@ -7421,15 +7390,15 @@ ari just ends up displaying the first item in the pop-up menu which is shift JIS
Reviewed by Darin
- Incorporate releaseGState fix that Darin developed for
- textareas and list boxes in WebCore. It turns out that
- we this workaround in WebClipView as well to get proper
- drawing of subframes.
+ Incorporate releaseGState fix that Darin developed for
+ textareas and list boxes in WebCore. It turns out that
+ we this workaround in WebClipView as well to get proper
+ drawing of subframes.
- In addition, removed some tests that which performed
- runtime checks for code in AppKit. AppKit will have
- the checked-for code in all versions that will be used
- with the version of WebKit.
+ In addition, removed some tests that which performed
+ runtime checks for code in AppKit. AppKit will have
+ the checked-for code in all versions that will be used
+ with the version of WebKit.
* WebView.subproj/WebClipView.m:
(-[WebClipView initWithFrame:])
@@ -7438,30 +7407,29 @@ ari just ends up displaying the first item in the pop-up menu which is shift JIS
2003-09-04 John Sullivan <sullivan at apple.com>
- - fixed 3409011 -- the graphics views palette does not open
+ - fixed 3409011 -- the graphics views palette does not open
Reviewed by Maciej
* WebView.subproj/WebPreferences.m:
(+[WebPreferences _removeReferenceForIdentifier:]):
- special-case nil, which is a magic initial identifier already
- special-cased in the other mutator
+ special-case nil, which is a magic initial identifier already
+ special-cased in the other mutator
2003-09-05 Maciej Stachowiak <mjs at apple.com>
Reviewed by Darin.
- - fixed 3406140 - REGRESSION (7B52-7B55): time spent in NSFont makes Safari 50% slower in Five Apps test
-
+ - fixed 3406140 - REGRESSION (7B52-7B55): time spent in NSFont makes Safari 50% slower in Five Apps test
* WebCoreSupport.subproj/WebTextRendererFactory.m:
(-[WebTextRendererFactory fontWithFamily:traits:size:]): Make font
- using the font name we found, not the one we were looking
- for. Since the compare is case-insensitive, it makes a
- difference. Also, don't make the font twice.
+ using the font name we found, not the one we were looking
+ for. Since the compare is case-insensitive, it makes a
+ difference. Also, don't make the font twice.
2003-09-04 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3316704>: Shockwave: getnetText steam is not functioning correctly
+ Fixed: <rdar://problem/3316704>: Shockwave: getnetText steam is not functioning correctly
Reviewed by mjs.
@@ -7470,7 +7438,7 @@ ari just ends up displaying the first item in the pop-up menu which is shift JIS
2003-09-04 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3286922>: Shockwave: Using HTTP to stream .mp3 or .swa files fails at ~50%
+ Fixed: <rdar://problem/3286922>: Shockwave: Using HTTP to stream .mp3 or .swa files fails at ~50%
Reviewed by mjs.
@@ -7495,7 +7463,7 @@ ari just ends up displaying the first item in the pop-up menu which is shift JIS
2003-09-04 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3407328>: request headers at the start of the file passed to NPN_PostURL don't work for Acrobat plug-in?
+ Fixed: <rdar://problem/3407328>: request headers at the start of the file passed to NPN_PostURL don't work for Acrobat plug-in?
Reviewed by john.
@@ -7506,55 +7474,54 @@ ari just ends up displaying the first item in the pop-up menu which is shift JIS
2003-09-03 John Sullivan <sullivan at apple.com>
- - fixed 3406411 -- infoseek.co.jp: many console errors about
- attempting to set non-screen font (HiraMinPro-W3)
+ - fixed 3406411 -- infoseek.co.jp: many console errors about
+ attempting to set non-screen font (HiraMinPro-W3)
Reviewed by Ken
* WebCoreSupport.subproj/WebTextRenderer.m:
(_drawGlyphs):
- use ERROR instead of NSLog for the printing-font-used-on-screen
- case, so it doesn't flood the world's console logs. We need to
- investigate why this is happening also, but that can probably
- be post-Panther.
+ use ERROR instead of NSLog for the printing-font-used-on-screen
+ case, so it doesn't flood the world's console logs. We need to
+ investigate why this is happening also, but that can probably
+ be post-Panther.
2003-09-01 John Sullivan <sullivan at apple.com>
- - WebKit part of fix for 3402489 -- REGRESSION (7B48-7B55): Some printed web pages are too small (width is half a page)
+ - WebKit part of fix for 3402489 -- REGRESSION (7B48-7B55): Some printed web pages are too small (width is half a page)
- This was a regression caused by the fix for 3378810.
+ This was a regression caused by the fix for 3378810.
Reviewed by Maciej
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView layoutToPageWidth:adjustingViewSize:]):
- now takes adjustViewSize flag, and passes it down to
- one of bridge's forceLayout calls.
+ now takes adjustViewSize flag, and passes it down to
+ one of bridge's forceLayout calls.
(-[WebHTMLView layout]):
- pass NO for adjustViewSize flag in this case
+ pass NO for adjustViewSize flag in this case
(-[WebHTMLView _setPrinting:pageWidth:adjustViewSize:]):
- pass adjustViewSize flag down to layoutToPageWidth instead
- of using it directly here; this is the wrong level to use
- it directly since the bridge is no longer set up for
- printing after the layoutToPageWidth call completes.
+ pass adjustViewSize flag down to layoutToPageWidth instead
+ of using it directly here; this is the wrong level to use
+ it directly since the bridge is no longer set up for
+ printing after the layoutToPageWidth call completes.
2003-08-30 Maciej Stachowiak <mjs at apple.com>
Reviewed by John.
- - fixed 3401709 - [WebView searchFor:] with wrap:NO hangs if the search fails
-
+ - fixed 3401709 - [WebView searchFor:] with wrap:NO hangs if the search fails
* WebView.subproj/WebView.m:
(-[WebView searchFor:direction:caseSensitive:wrap:]): Fix for
- wrap:NO case as suggested by Darin.
+ wrap:NO case as suggested by Darin.
=== Safari-96 ===
2003-08-29 Richard Williamson <rjw at apple.com>
- Fixed 3401334. Use IB document key when checking for reference removal on instances of WebPreferences.
+ Fixed 3401334. Use IB document key when checking for reference removal on instances of WebPreferences.
- Also removed _userDefaultsKeysForIB, no longer needed by IB.
+ Also removed _userDefaultsKeysForIB, no longer needed by IB.
Reviewed by John.
@@ -7565,7 +7532,7 @@ ari just ends up displaying the first item in the pop-up menu which is shift JIS
2003-08-29 Richard Williamson <rjw at apple.com>
- Fixed 3400807. Don't release state associated with the current b/f item. We shouldn't normally have page cache state associated with the current item (3401376). This fix guarantees that we won't prematurely release the page cache state for the current
+ Fixed 3400807. Don't release state associated with the current b/f item. We shouldn't normally have page cache state associated with the current item (3401376). This fix guarantees that we won't prematurely release the page cache state for the current
item.
@@ -7577,14 +7544,14 @@ ari just ends up displaying the first item in the pop-up menu which is shift JIS
2003-08-28 Richard Williamson <rjw at apple.com>
- Fixed 3399736. Fixed several problems with WebView/WebPreferences
- interaction.
+ Fixed 3399736. Fixed several problems with WebView/WebPreferences
+ interaction.
Reviewed by Eric Seymour.
* Misc.subproj/WebKitLogging.h:
* Misc.subproj/WebKitLogging.m:
- Added debug logging.
+ Added debug logging.
* WebCoreSupport.subproj/WebTextRenderer.m:
(_drawGlyphs): Checkin for 3398229 below.
@@ -7604,7 +7571,7 @@ ari just ends up displaying the first item in the pop-up menu which is shift JIS
2003-08-27 Richard Williamson <rjw at apple.com>
- Fixed 3398229. When we request a font from NSFont by name we should use a case specific name. We do case insensitve comparsion, but once a match is found we should use the actual font name, not the requested name. Two layout tests are still failing, b
+ Fixed 3398229. When we request a font from NSFont by name we should use a case specific name. We do case insensitve comparsion, but once a match is found we should use the actual font name, not the requested name. Two layout tests are still failing, b
ut I don't think the failures are font related.
@@ -7618,7 +7585,7 @@ ut I don't think the failures are font related.
2003-08-27 Richard Williamson <rjw at apple.com>
- Fixed 3397235. WebView wasn't archiving useBackForwardList.
+ Fixed 3397235. WebView wasn't archiving useBackForwardList.
Reviewed by Eric Seymour.
@@ -7628,9 +7595,9 @@ ut I don't think the failures are font related.
2003-08-26 Richard Williamson <rjw at apple.com>
- Fixed 3385478. Look for an exact match for font names (using PS names) before matching on family names.
+ Fixed 3385478. Look for an exact match for font names (using PS names) before matching on family names.
- Also added logging to help debug now resolved binding problem.
+ Also added logging to help debug now resolved binding problem.
Reviewed by Maciej.
@@ -7694,9 +7661,9 @@ ut I don't think the failures are font related.
2003-08-25 Richard Williamson <rjw at apple.com>
- Fix for 3391609. Our rounding hack wasn't correctly reflected in the selection point
- code. Piggy-backed on this fix are fixes for selection of letter-spacing, word-spacing
- and justified text.
+ Fix for 3391609. Our rounding hack wasn't correctly reflected in the selection point
+ code. Piggy-backed on this fix are fixes for selection of letter-spacing, word-spacing
+ and justified text.
Reviewed by Hyatt.
@@ -7708,29 +7675,29 @@ ut I don't think the failures are font related.
2003-08-25 John Sullivan <sullivan at apple.com>
- - fixed 3391264 -- REGRESSION (Panther): Back/Forward buttons not
- updating immediately after page load
+ - fixed 3391264 -- REGRESSION (Panther): Back/Forward buttons not
+ updating immediately after page load
- The buttons are updated in response to window update notifications.
- Jaguar was sending so many extra bogus notifications that it
- masked the fact that we weren't ensuring that these notifications
- were sent at all in the case of non-event-based interesting
- changes that might affect menu items/toolbar items/etc.
+ The buttons are updated in response to window update notifications.
+ Jaguar was sending so many extra bogus notifications that it
+ masked the fact that we weren't ensuring that these notifications
+ were sent at all in the case of non-event-based interesting
+ changes that might affect menu items/toolbar items/etc.
Reviewed by Richard
* WebView.subproj/WebViewPrivate.m:
(-[WebView _didStartProvisionalLoadForFrame:]):
- call -[NSApp setWindowsNeedUpdate:YES] so window update notices
- will be sent
+ call -[NSApp setWindowsNeedUpdate:YES] so window update notices
+ will be sent
(-[WebView _didCommitLoadForFrame:]):
- ditto
+ ditto
(-[WebView _didFinishLoadForFrame:]):
- ditto
+ ditto
(-[WebView _didFailLoadWithError:forFrame:]):
- ditto
+ ditto
(-[WebView _didFailProvisionalLoadWithError:forFrame:]):
- ditto
+ ditto
2003-08-24 Darin Adler <darin at apple.com>
@@ -7748,34 +7715,33 @@ ut I don't think the failures are font related.
The code does assume that it's flipped.
2003-08-22 John Sullivan <sullivan at apple.com>
-
- - fixed 3385837 -- REGRESSION: can't paste link from Safari into
- Keynote (paste at top level, not into text)
+ - fixed 3385837 -- REGRESSION: can't paste link from Safari into
+ Keynote (paste at top level, not into text)
Reviewed by Darin
- The problem was that we were using a single list of pasteboard
- types for both "types we can read" and "types we can write", but
- NSFilenamesPBoardType wasn't being written to, creating a bad
- pasteboard. The fix is to split this list in two. We could do
- this a little more elegantly if we weren't paranoid about
- last-minute SPI changes breaking compatibility with Sherlock or
- some other internal client.
+ The problem was that we were using a single list of pasteboard
+ types for both "types we can read" and "types we can write", but
+ NSFilenamesPBoardType wasn't being written to, creating a bad
+ pasteboard. The fix is to split this list in two. We could do
+ this a little more elegantly if we weren't paranoid about
+ last-minute SPI changes breaking compatibility with Sherlock or
+ some other internal client.
* Misc.subproj/WebNSPasteboardExtras.h:
- add new _web_writableDragTypesForURL, commented various methods
- better.
+ add new _web_writableDragTypesForURL, commented various methods
+ better.
* Misc.subproj/WebNSPasteboardExtras.m:
(+[NSPasteboard _web_writableDragTypesForURL]):
- implement _web_writableDragTypesForURL; it's just like
- _web_dragTypesForURL but without the NSFilenamesPBoardType
+ implement _web_writableDragTypesForURL; it's just like
+ _web_dragTypesForURL but without the NSFilenamesPBoardType
(-[NSPasteboard _web_writeURL:andTitle:withOwner:]):
- use _web_writableDragTypesForURL
+ use _web_writableDragTypesForURL
* Misc.subproj/WebNSViewExtras.m:
(-[NSView _web_dragPromisedImage:rect:URL:title:event:]):
- use _web_writableDragTypesForURL
+ use _web_writableDragTypesForURL
2003-08-22 Darin Adler <darin at apple.com>
@@ -7797,7 +7763,7 @@ ut I don't think the failures are font related.
2003-08-21 Richard Williamson <rjw at apple.com>
- Fixed 3378810. Avoid resizing frame from drawRect: when printing. This will corrupt the graphics context.
+ Fixed 3378810. Avoid resizing frame from drawRect: when printing. This will corrupt the graphics context.
Reviewed by Hyatt.
@@ -7812,28 +7778,28 @@ ut I don't think the failures are font related.
2003-08-21 John Sullivan <sullivan at apple.com>
- - fixed 3387950 -- REGRESSION (85-89): Standalone image in Safari prints much
- smaller than in Jaguar
+ - fixed 3387950 -- REGRESSION (85-89): Standalone image in Safari prints much
+ smaller than in Jaguar
Reviewed by Chris.
* WebView.subproj/WebImageView.m:
(-[WebImageView adjustFrameSize]):
- renamed from setFrameSizeUsingImage; now sets the frame size to exactly
- the image size (as it did in Jaguar always) when we're not drawing to
- the screen.
+ renamed from setFrameSizeUsingImage; now sets the frame size to exactly
+ the image size (as it did in Jaguar always) when we're not drawing to
+ the screen.
(-[WebImageView setFrameSize:]):
- updated for name change
+ updated for name change
(-[WebImageView layout]):
- ditto
+ ditto
(-[WebImageView beginDocument]):
- adjust frame size (before printing)
+ adjust frame size (before printing)
(-[WebImageView endDocument]):
- adjust frame size (after printing)
+ adjust frame size (after printing)
2003-08-19 Richard Williamson <rjw at apple.com>
- Fixed 3383623 (and 3384896). Remove our unbeknownst work-around for an NSImage bug that incorrectly flipped y coordinate when drawing a partial rect within the image. This has been fixed in Panther, making our work-around no longer necessary.
+ Fixed 3383623 (and 3384896). Remove our unbeknownst work-around for an NSImage bug that incorrectly flipped y coordinate when drawing a partial rect within the image. This has been fixed in Panther, making our work-around no longer necessary.
Reviewed by Darin.
@@ -7843,8 +7809,8 @@ ut I don't think the failures are font related.
2003-08-18 Richard Williamson <rjw at apple.com>
- Fixed 3140065. Bidi neutrals in RTL runs are now handled correctly. Still have
- problem with bidi neutrals at directional boundaries 3382926.
+ Fixed 3140065. Bidi neutrals in RTL runs are now handled correctly. Still have
+ problem with bidi neutrals at directional boundaries 3382926.
Reviewed by Maciej.
@@ -7868,7 +7834,7 @@ ut I don't think the failures are font related.
2003-08-18 Richard Williamson <rjw at apple.com>
- Fix build problem from last checkin.
+ Fix build problem from last checkin.
Reviewed by Darin.
@@ -7895,8 +7861,8 @@ ut I don't think the failures are font related.
2003-08-15 Richard Williamson <rjw at apple.com>
- Fixed 3378530. Ensure that line is always drawn within bounds
- of element.
+ Fixed 3378530. Ensure that line is always drawn within bounds
+ of element.
Reviewed by Chris.
@@ -7905,7 +7871,7 @@ ut I don't think the failures are font related.
2003-08-15 Richard Williamson <rjw at apple.com>
- Fixed 3379439. Remove checks for CG symbols. No longer needed.
+ Fixed 3379439. Remove checks for CG symbols. No longer needed.
Reviewed by Darin.
@@ -7948,10 +7914,10 @@ ut I don't think the failures are font related.
Reviewed by Darin
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3375042>: Change usages of NSURL absoluteString in WebKit
- to use improved variants
+ <rdar://problem/3375042>: Change usages of NSURL absoluteString in WebKit
+ to use improved variants
* History.subproj/WebHistoryItem.m:
(-[WebHistoryItem initWithURL:title:]): Use data-as-string.
@@ -7971,9 +7937,9 @@ ut I don't think the failures are font related.
(-[WebIconLoader connectionDidFinishLoading:]): Use data-as-string.
* Misc.subproj/WebKitErrors.m:
(+[NSError _webKitErrorWithDomain:code:URL:]): Added new convenience that takes
- a URL instead of a URL string.
+ a URL instead of a URL string.
(-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):
- Added new convenience that takes URLs instead of a URL stringis.
+ Added new convenience that takes URLs instead of a URL stringis.
* Misc.subproj/WebKitErrorsPrivate.h: Declared new conveniences.
* Misc.subproj/WebNSPasteboardExtras.m:
(-[NSPasteboard _web_writeURL:andTitle:withOwner:types:]): Use visible-string.
@@ -8028,18 +7994,17 @@ ut I don't think the failures are font related.
Reviewed by Ken.
- - fixed 3365242 - non-repro abort in HTMLTokenizer at ajc.com
-
+ - fixed 3365242 - non-repro abort in HTMLTokenizer at ajc.com
* WebView.subproj/WebDataSourcePrivate.m:
(-[WebDataSource _receivedData:]): ref the data source around
- processing the data and afterwards, to avoid crashing if a script
- in this chunk of data made the frame go away.
+ processing the data and afterwards, to avoid crashing if a script
+ in this chunk of data made the frame go away.
2003-08-13 Richard Williamson <rjw at apple.com>
- Fixed 3376077. Override automaticallyNotifiesObserversForKey: to
- prevent unnecessary additional notifications from being sent. Also
- added development-only logging (bulk of the change).
+ Fixed 3376077. Override automaticallyNotifiesObserversForKey: to
+ prevent unnecessary additional notifications from being sent. Also
+ added development-only logging (bulk of the change).
Reviewed by Chris.
@@ -8066,7 +8031,7 @@ ut I don't think the failures are font related.
2003-08-13 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3347134>: After first successful POST in Flash, Safari does not repeat POST and gives cached reply
+ Fixed: <rdar://problem/3347134>: After first successful POST in Flash, Safari does not repeat POST and gives cached reply
Reviewed by kocienda.
@@ -8077,17 +8042,17 @@ ut I don't think the failures are font related.
Reviewed by Darin
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3366441>: URL strings with UTF-8 characters
- processed improperly for display by WebKit
+ <rdar://problem/3366441>: URL strings with UTF-8 characters
+ processed improperly for display by WebKit
* Misc.subproj/WebNSURLExtras.h:
* Misc.subproj/WebNSURLExtras.m:
(isHexDigit): Added
(hexDigitValue): Added
(-[NSURL _web_userVisibleString]): Added. Produces a string that
- is suitable for display to a user in the UI.
+ is suitable for display to a user in the UI.
(-[NSURL _web_isEmpty]): Convenience to check for an empty URL
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge requestedURLString]): Now calls _web_userVisibleString
@@ -8098,8 +8063,8 @@ ut I don't think the failures are font related.
Fix for this bug:
- <rdar://problem/3374458>: Choose UTF-8 for encoding when calling
- CFURLCreateAbsoluteURLWithBytes in WebKit
+ <rdar://problem/3374458>: Choose UTF-8 for encoding when calling
+ CFURLCreateAbsoluteURLWithBytes in WebKit
Calling CFURLCreateAbsoluteURLWithBytes with ISO Latin 1 string
encoding results in some issues when trying to decode a URL path in
@@ -8122,40 +8087,40 @@ ut I don't think the failures are font related.
Fix for this bug:
<rdar://problem/3374487>: URLs with UTF-8 escape sequences can't be accessed
- when typed in the Safari location bar
+ when typed in the Safari location bar
* Misc.subproj/WebNSPasteboardExtras.m:
(-[NSPasteboard _web_bestURL]): Call _web_URLWithUserTypedString: to make a
- URL from this type of string.
+ URL from this type of string.
* Misc.subproj/WebNSURLExtras.h:
* Misc.subproj/WebNSURLExtras.m:
(hexDigit): Added.
(+[NSURL _web_URLWithUserTypedString:]): Added. Creates a URL from a string
- that is typed in a user, for example, in the Safari location bar.
+ that is typed in a user, for example, in the Safari location bar.
2003-08-12 John Sullivan <sullivan at apple.com>
- - fixed 3369505 -- leaks of NSCFTimer after running through the
- cvs-base test suite
+ - fixed 3369505 -- leaks of NSCFTimer after running through the
+ cvs-base test suite
Reviewed by Richard
* WebView.subproj/WebFrame.m:
(-[WebFrame stopLoading]):
- release timer before nil'ing it out
+ release timer before nil'ing it out
2003-08-12 Ed Voas <voas at apple.com>
Reviewed by Richard.
- Make sure to override the standard behavior for ordering windows to do nothing for Carbon stuff.
+ Make sure to override the standard behavior for ordering windows to do nothing for Carbon stuff.
* Carbon.subproj/CarbonWindowAdapter.m:
(-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2003-08-11 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3163589>: Macromedia Flash 6 cannot take Asian text entry in Safari
+ Fixed: <rdar://problem/3163589>: Macromedia Flash 6 cannot take Asian text entry in Safari
Revidewed by darin.
@@ -8170,14 +8135,13 @@ ut I don't think the failures are font related.
(-[WebBaseNetscapePluginView stop]): call removeKeyEventHandler because resignFirstResponder may not get called
2003-08-08 Richard Williamson <rjw at apple.com>
-
- Lots of healthy cleanup. Introduced width and shaping iterators
- to simplify code and remove allocations for large text runs. Should
- go further and make more use of these in the future (post panther).
+ Lots of healthy cleanup. Introduced width and shaping iterators
+ to simplify code and remove allocations for large text runs. Should
+ go further and make more use of these in the future (post panther).
- Fixed 3369608. Crash in -[WebTextRenderer _CG_drawRun:style:atPoint:] at lovepucca.net
- Fixed 3118050. Crash selecting text at http://www.faqs.org/rfcs/rfc2849.html (SELECTION)
- Fixed 3371115. Can't correctly select text that contains surrogate pairs
+ Fixed 3369608. Crash in -[WebTextRenderer _CG_drawRun:style:atPoint:] at lovepucca.net
+ Fixed 3118050. Crash selecting text at http://www.faqs.org/rfcs/rfc2849.html (SELECTION)
+ Fixed 3371115. Can't correctly select text that contains surrogate pairs
Reviewed by darin.
@@ -8200,7 +8164,7 @@ ut I don't think the failures are font related.
(-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):
(-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]):
- Just formatting changed here
+ Just formatting changed here
* WebView.subproj/WebHTMLViewPrivate.m:
(-[WebHTMLView _dragImageForLinkElement:]):
@@ -8221,7 +8185,7 @@ ut I don't think the failures are font related.
2003-08-07 Richard Williamson <rjw at apple.com>
- Fixed 3362939. Checked flippyness of view and adjust y coord accordingly.
+ Fixed 3362939. Checked flippyness of view and adjust y coord accordingly.
Reviewed by John.
@@ -8229,7 +8193,7 @@ ut I don't think the failures are font related.
2003-08-07 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3330742>: 1.0 Safari fails to send NPP_URLNotify with the error of NPRES_NETWORK_ERR to Flash
+ Fixed: <rdar://problem/3330742>: 1.0 Safari fails to send NPP_URLNotify with the error of NPRES_NETWORK_ERR to Flash
Reviewed by darin.
@@ -8240,14 +8204,13 @@ ut I don't think the failures are font related.
2003-08-07 Ken Kocienda <kocienda at apple.com>
Reviewed by Darin
-
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3368552>: Fix inappropriate use of NSURL creation methods in WebKit
+ <rdar://problem/3368552>: Fix inappropriate use of NSURL creation methods in WebKit
- Change calls to URLWithString: or URLWithString:relativeToURL to
- _web_URLWithDataAsString: and _web_URLWithDataAsString:relativeToURL,
- respectively.
+ Change calls to URLWithString: or URLWithString:relativeToURL to
+ _web_URLWithDataAsString: and _web_URLWithDataAsString:relativeToURL,
+ respectively.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _loadItem:withLoadType:]):
@@ -8270,7 +8233,7 @@ ut I don't think the failures are font related.
2003-08-06 Richard Williamson <rjw at apple.com>
- Fixed 3365378. Edge case text run > 1024 hit by JS generated string. We weren't correctly checking size of string length. Used /2 instead of *2.
+ Fixed 3365378. Edge case text run > 1024 hit by JS generated string. We weren't correctly checking size of string length. Used /2 instead of *2.
Reviewed by Vicki (and Dan!).
@@ -8280,7 +8243,7 @@ ut I don't think the failures are font related.
2003-08-06 Richard Williamson <rjw at apple.com>
- Fixed 3348630. Pick up about 1% by moving implementation of _unicodeDirection to WebCore and inlining.
+ Fixed 3348630. Pick up about 1% by moving implementation of _unicodeDirection to WebCore and inlining.
Reviewed by Ken.
@@ -8294,17 +8257,17 @@ ut I don't think the failures are font related.
2003-08-06 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3161102>: Avoid retain cycles by destroying plug-ins in the page cache before dealloc
+ Fixed: <rdar://problem/3161102>: Avoid retain cycles by destroying plug-ins in the page cache before dealloc
Reviewed by rjw.
- * History.subproj/WebHistoryItemPrivate.h: added declaration for [WebBackForwardList _clearPageCache]
+ * History.subproj/WebHistoryItemPrivate.h: added declaration for [WebBackForwardList _clearPageCache]
* WebView.subproj/WebViewPrivate.m:
(-[WebView _close]): clear the page cache when we are closing the web view so we call destroy on all the plug-ins on the page cache to break any retain cycles.
2003-08-04 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3106525>: Results of JavaScript requests are not returned to plug-ins
+ Fixed: <rdar://problem/3106525>: Results of JavaScript requests are not returned to plug-ins
Reviewed by darin.
@@ -8330,10 +8293,10 @@ ut I don't think the failures are font related.
Reviewed by Richard
- Plugins in WebKit need to store URLs in the form of "C-style" strings.
- Create and use a new, improved method to make these strings, and do
- not traverse through the NSURL absoluteString method, since that can i
- introduce errors.
+ Plugins in WebKit need to store URLs in the form of "C-style" strings.
+ Create and use a new, improved method to make these strings, and do
+ not traverse through the NSURL absoluteString method, since that can i
+ introduce errors.
* Misc.subproj/WebNSURLExtras.h: Added _web_URLCString method.
* Misc.subproj/WebNSURLExtras.m:
@@ -8349,25 +8312,25 @@ ut I don't think the failures are font related.
Reviewed by John
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3365035>: Modify WebNSURLExtras to call improved NSURL creation API
+ <rdar://problem/3365035>: Modify WebNSURLExtras to call improved NSURL creation API
* Misc.subproj/WebNSURLExtras.m:
(+[NSURL _web_URLWithDataAsString:]): Call through to _web_URLWithDataAsString:relativeToURL:.
(+[NSURL _web_URLWithDataAsString:relativeToURL:]): Call through to _web_URLWithData:relativeToURL:.
(+[NSURL _web_URLWithData:]): Ditto.
(+[NSURL _web_URLWithData:relativeToURL:]): Call CFURLCreateAbsoluteURLWithBytes API in
- CoreFoundation.
+ CoreFoundation.
(-[NSURL _web_originalData]): Use CFURLGetBytes API in CoreFoundation. Also make sure
- that a relative URL is resolved against its base.
+ that a relative URL is resolved against its base.
(-[NSURL _web_displayableString]): Call _web_originalData to get bytes to use
- to create the string.
+ to create the string.
(-[NSURL _web_URLStringLength]): Use CFURLGetBytes API in CoreFoundation.
2003-08-04 Richard Williamson <rjw at apple.com>
- Fixed 3363011. Pass b/f related key down events to super if b/f is disabled.
+ Fixed 3363011. Pass b/f related key down events to super if b/f is disabled.
Reviewed by Chris.
@@ -8375,9 +8338,9 @@ ut I don't think the failures are font related.
(-[WebFrameView keyDown:]):
- Fixed 3363345. Retain static array used by IB to present WebView's bindable keys.
+ Fixed 3363345. Retain static array used by IB to present WebView's bindable keys.
- Review by Maciej
+ Review by Maciej
* WebView.subproj/WebViewPrivate.m:
(-[WebView _declaredKeys]):
@@ -8386,13 +8349,13 @@ ut I don't think the failures are font related.
Reviewed by Darin
- Fix for this bug:
+ Fix for this bug:
- <rdar://problem/3363318>: REGRESSION: Plug-in content doesn't show up, animate etc
+ <rdar://problem/3363318>: REGRESSION: Plug-in content doesn't show up, animate etc
- WebNetscapePluginConnectionDelegate must implement this method:
+ WebNetscapePluginConnectionDelegate must implement this method:
- - (void)connection:(NSURLConnection *)con didReceiveData:(NSData *)data lengthReceived:(long long)lengthReceived
+ - (void)connection:(NSURLConnection *)con didReceiveData:(NSData *)data lengthReceived:(long long)lengthReceived
* Plugins.subproj/WebNetscapePluginStream.m:
(-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:])
@@ -8410,7 +8373,7 @@ ut I don't think the failures are font related.
2003-08-04 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3360977>: REGRESSION (7B28-7B29): main webview rejects drop of doc icon from BBEdit
+ Fixed: <rdar://problem/3360977>: REGRESSION (7B28-7B29): main webview rejects drop of doc icon from BBEdit
Reviewed by darin.
@@ -8420,7 +8383,7 @@ ut I don't think the failures are font related.
2003-08-04 Richard Williamson <rjw at apple.com>
- Fixed 3223989. Pass key down events to super if scrolling is disabled.
+ Fixed 3223989. Pass key down events to super if scrolling is disabled.
Reviewed by Chris (Welcome back!).
@@ -8429,13 +8392,13 @@ ut I don't think the failures are font related.
2003-08-01 Richard Williamson <rjw at apple.com>
- Fixed 3095376. Implemented correct selection behavior for rtl scripts.
- We still use our Arabic and Hebrew layout scheme.
+ Fixed 3095376. Implemented correct selection behavior for rtl scripts.
+ We still use our Arabic and Hebrew layout scheme.
- Fixed 3360487. Implemented selection of ATSU rendered code.
+ Fixed 3360487. Implemented selection of ATSU rendered code.
- Fixed 3360242. Return nil from _bodyBackgroundColor when no
- background color specified. This was requested by Doug D.
+ Fixed 3360242. Return nil from _bodyBackgroundColor when no
+ background color specified. This was requested by Doug D.
Reviewed by Maciej.
@@ -8455,17 +8418,17 @@ ut I don't think the failures are font related.
Reviewed by Darin.
- - fixed 3339255 - REGRESSION (73-85): javascript failure at gia.apple.com
+ - fixed 3339255 - REGRESSION (73-85): javascript failure at gia.apple.com
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _setState:]): When going to provisional state, tell the bridge that
- a provisional load started, so it can cancel any pending redirects.
+ a provisional load started, so it can cancel any pending redirects.
=== Safari-91 ===
2003-07-31 Richard Williamson <rjw at apple.com>
- Make sure width is initialized for monospace optimizations.
+ Make sure width is initialized for monospace optimizations.
Reviewed by Vicki.
* WebCoreSupport.subproj/WebTextRenderer.m:
@@ -8473,7 +8436,7 @@ ut I don't think the failures are font related.
2003-07-31 Richard Williamson <rjw at apple.com>
- Fixed 3359152. SPI to get the background color for a frame.
+ Fixed 3359152. SPI to get the background color for a frame.
Reviewed by hyatt.
@@ -8485,8 +8448,8 @@ ut I don't think the failures are font related.
2003-07-31 Richard Williamson <rjw at apple.com>
- Fixed 3358870. Fall back on 'user defaults' values when a value
- in a custom instance of WebPreferences hasn't been overriden.
+ Fixed 3358870. Fall back on 'user defaults' values when a value
+ in a custom instance of WebPreferences hasn't been overriden.
Reviewed by Eric Seymour.
@@ -8497,7 +8460,7 @@ ut I don't think the failures are font related.
2003-07-30 Richard Williamson <rjw at apple.com>
- Preparation for 3095376.
+ Preparation for 3095376.
Reviewed by Maciej.
@@ -8524,8 +8487,8 @@ ut I don't think the failures are font related.
2003-07-30 Richard Williamson <rjw at apple.com>
- Fixed 3356518. Added private method called by IB to ensure
- that autoresizeSubviews flag is turned on correctly.
+ Fixed 3356518. Added private method called by IB to ensure
+ that autoresizeSubviews flag is turned on correctly.
Reviewed by mjs.
@@ -8534,8 +8497,8 @@ ut I don't think the failures are font related.
2003-07-28 Richard Williamson <rjw at apple.com>
- Fixed 3323866. Provide SPI to IB to enable scoping of preferences
- values on a document-by-document basis.
+ Fixed 3323866. Provide SPI to IB to enable scoping of preferences
+ values on a document-by-document basis.
Reviewed by Maciej.
@@ -8561,12 +8524,12 @@ ut I don't think the failures are font related.
2003-07-28 Richard Williamson <rjw at apple.com>
- Fixed 3341859.
- Check that the WebHTMLView is initialized in viewWillMoveToWindow: and
- viewDidMoveToWindow. Don't do anything if we aren't initialized. This
- happens when decoding a WebView. When WebViews are decoded their subviews
- are created by initWithCoder: and so won't be normally initialized. The
- stub views are discarded by WebView.
+ Fixed 3341859.
+ Check that the WebHTMLView is initialized in viewWillMoveToWindow: and
+ viewDidMoveToWindow. Don't do anything if we aren't initialized. This
+ happens when decoding a WebView. When WebViews are decoded their subviews
+ are created by initWithCoder: and so won't be normally initialized. The
+ stub views are discarded by WebView.
Reviewed by John.
@@ -8594,9 +8557,8 @@ ut I don't think the failures are font related.
<rdar://problem/3336933>: REGRESSION (Panther): Mozilla build downloaded
with wrong extension, bad file size (gzip)
- Use new delegate methods that allow for the correct reporting
- of progress in cases where Foundation-level content decoding
- has been performed on data received
+ Use new delegate methods that allow for the correct reporting
+ of progress in cases where Foundation-level content decoding has been performed on data received
* WebCoreSupport.subproj/WebSubresourceClient.m:
(-[WebSubresourceClient connection:didReceiveData:lengthReceived:]):
@@ -8618,18 +8580,18 @@ ut I don't think the failures are font related.
2003-07-28 John Sullivan <sullivan at apple.com>
- - fixed 3236815 -- bitmap TIFFs at > 72 dpi are scaled incorrectly
- in Safari when viewed standalone (uspto.gov)
+ - fixed 3236815 -- bitmap TIFFs at > 72 dpi are scaled incorrectly
+ in Safari when viewed standalone (uspto.gov)
Reviewed by Darin
* WebCoreSupport.subproj/WebImageRenderer.m:
(-[WebImageRenderer _adjustSizeToPixelDimensions]):
- call setScalesWhenResized:YES
+ call setScalesWhenResized:YES
2003-07-25 Richard Williamson <rjw at apple.com>
- Fixed 3344519. Prevent infinite recursion attempting font substitution.
+ Fixed 3344519. Prevent infinite recursion attempting font substitution.
Reviewed by Darin.
@@ -8640,17 +8602,17 @@ ut I don't think the failures are font related.
Reviewed by John.
- - fixed 3280582 - REGRESSION (74-85): authentication sheet doesn't state that previous login was incorrect
+ - fixed 3280582 - REGRESSION (74-85): authentication sheet doesn't state that previous login was incorrect
* Panels.subproj/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForChallenge:]): Use chall, the
- parameter, not challenge, the not-yet-set ivar so we get the right
- failure count &c.
+ parameter, not challenge, the not-yet-set ivar so we get the right
+ failure count &c.
2003-07-25 Richard Williamson <rjw at apple.com>
- Use 11 point bold, instead of 12 point bold to draw dragged link
- labels. This matches the text drawn in the bookmarks bar.
+ Use 11 point bold, instead of 12 point bold to draw dragged link
+ labels. This matches the text drawn in the bookmarks bar.
Reviewed by John.
@@ -8659,9 +8621,9 @@ ut I don't think the failures are font related.
2003-07-24 Richard Williamson <rjw at apple.com>
- Fixed 3279910. Change the way we draw dragged link to use
- WebKit's measurement and drawing. Also made the look match
- the bookmarks bar text.
+ Fixed 3279910. Change the way we draw dragged link to use
+ WebKit's measurement and drawing. Also made the look match
+ the bookmarks bar text.
Reviewed by Maciej.
@@ -8675,15 +8637,14 @@ ut I don't think the failures are font related.
2003-07-24 Richard Williamson <rjw at apple.com>
- Removed unnecessary log.
+ Removed unnecessary log.
Reviewed by John.
* WebCoreSupport.subproj/WebImageRendererFactory.m:
(-[WebImageRendererFactory imageRendererWithData:MIMEType:]):
-
- Add another check to use ATSU for Limbu (Unicode 4.0) script.
- Also made shouldUseATSU inline.
+ Add another check to use ATSU for Limbu (Unicode 4.0) script.
+ Also made shouldUseATSU inline.
* WebCoreSupport.subproj/WebTextRenderer.m:
(shouldUseATSU):
@@ -8692,10 +8653,8 @@ ut I don't think the failures are font related.
2003-07-23 Maciej Stachowiak <mjs at apple.com>
- Build breakage fix:
-
- Fix WebKit to build with the latest Foundation.
-
+ Build breakage fix:
+ Fix WebKit to build with the latest Foundation.
* Misc.subproj/WebNSURLExtras.h:
* Misc.subproj/WebNSURLExtras.m:
(-[NSURL _webkit_isJavaScriptURL]):
@@ -8705,9 +8664,9 @@ ut I don't think the failures are font related.
2003-07-23 Richard Williamson <rjw at apple.com>
- Fixed 3311725: Added support for key/value binding.
- (As a side effect also made icon loading work! In 1.0
- it doesn't work unless a secret preference value is set.)
+ Fixed 3311725: Added support for key/value binding.
+ (As a side effect also made icon loading work! In 1.0
+ it doesn't work unless a secret preference value is set.)
Reviewed by Ken.
@@ -8745,7 +8704,7 @@ ut I don't think the failures are font related.
2003-07-23 Richard Williamson <rjw at apple.com>
- Fixed 3341119: Crash when content contains nil (0x0) characters.
+ Fixed 3341119: Crash when content contains nil (0x0) characters.
Reviewed by Ken.
@@ -8764,13 +8723,13 @@ ut I don't think the failures are font related.
2003-07-23 Richard Williamson <rjw at apple.com>
- Fixed for 3259840. Use ATSU for scripts we don't handle internally,
- i.e.: Syriac, Thaana, Devanagari, Bengali, Gurmukhi, Gujarati, Oriya, Tamil, Telugu, Kannada, Malayalam, Sinhala, Thai, Lao, Tibetan, Myanmar, Hangul Jamo, Khmer, Mongolian
+ Fixed for 3259840. Use ATSU for scripts we don't handle internally,
+ i.e.: Syriac, Thaana, Devanagari, Bengali, Gurmukhi, Gujarati, Oriya, Tamil, Telugu, Kannada, Malayalam, Sinhala, Thai, Lao, Tibetan, Myanmar, Hangul Jamo, Khmer, Mongolian
- Also fixed issues with our rendering of Arabic.
+ Also fixed issues with our rendering of Arabic.
- Changed the internal API to take WebCoreTextRun and WebCoreTextStyle
- parameters instead of scads on individual parameters. Much cleaner.
+ Changed the internal API to take WebCoreTextRun and WebCoreTextStyle
+ parameters instead of scads on individual parameters. Much cleaner.
Reviewed by Maciej.
@@ -8802,18 +8761,17 @@ ut I don't think the failures are font related.
2003-07-23 Ken Kocienda <kocienda at apple.com>
Reviewed by Darin
-
- Removed dependency on Foundation NSURL_NSURLExtras file.
- Copied the required methods from that file to WebNSURLExtras,
- temporarily renaming the methods that are now in both
- places to have a _webkit_ prefix. The names will be changed
- back once every one is living on a Foundation version that
- no longer contains these methods.
-
- The files below were changed in one of three ways:
- 1. Rename _web_URLWithString: to _web_URLWithDataAsString:
- 2. Tweak headers to depend on WebNSURLExtras instead of NSURL_NSURLExtras.
- 3. At call sites, tweak names of methods that moved to WebKit (_web_ -> _webkit_).
+ Removed dependency on Foundation NSURL_NSURLExtras file.
+ Copied the required methods from that file to WebNSURLExtras,
+ temporarily renaming the methods that are now in both
+ places to have a _webkit_ prefix. The names will be changed
+ back once every one is living on a Foundation version that
+ no longer contains these methods.
+
+ The files below were changed in one of three ways:
+ 1. Rename _web_URLWithString: to _web_URLWithDataAsString:
+ 2. Tweak headers to depend on WebNSURLExtras instead of NSURL_NSURLExtras.
+ 3. At call sites, tweak names of methods that moved to WebKit (_web_ -> _webkit_).
* History.subproj/WebHistory.m:
* History.subproj/WebHistoryItem.m:
@@ -8882,34 +8840,34 @@ ut I don't think the failures are font related.
2003-07-21 Ken Kocienda <kocienda at apple.com>
- Fixed build breaker.
+ Fixed build breaker.
- Removed glyphCountFromFont function. It was used only in an
- ERROR function, which does not compile in on deployment
- builds, causing a "defined, but not used warning".
+ Removed glyphCountFromFont function. It was used only in an
+ ERROR function, which does not compile in on deployment
+ builds, causing a "defined, but not used warning".
- As this function is only a one-liner call into ATS, I
- replaced the usage in the ERROR call with a call to the
- ATS function directly.
+ As this function is only a one-liner call into ATS, I
+ replaced the usage in the ERROR call with a call to the
+ ATS function directly.
* WebCoreSupport.subproj/WebTextRenderer.m:
(-[WebTextRenderer initWithFont:usingPrinterFont:])
2003-07-18 Richard Williamson <rjw at apple.com>
- Fixed 3283594. "Times RO" appears to have a corrupt regular variant. Added
- additional bullet proofing to catch corrupt fonts. Also added a special case
- hack to map "Times RO" to "Time New Roman" if the variant doesn't have valid
- glyphs.
+ Fixed 3283594. "Times RO" appears to have a corrupt regular variant. Added
+ additional bullet proofing to catch corrupt fonts. Also added a special case
+ hack to map "Times RO" to "Time New Roman" if the variant doesn't have valid
+ glyphs.
- Fixed 3319846. The page mentioned in this bug required > 10 substitute fonts for
- the same base font. This triggered some buggy code that hasn't been exercise before.
- Specifically the code that resizes the substitute fonts array was incorrect.
+ Fixed 3319846. The page mentioned in this bug required > 10 substitute fonts for
+ the same base font. This triggered some buggy code that hasn't been exercise before.
+ Specifically the code that resizes the substitute fonts array was incorrect.
Reviewed by mjs.
* Misc.subproj/WebAssertions.h: Added FATAL_ALWAYS macro that logs and CRASHES
- even in deployment builds.
+ even in deployment builds.
* WebCoreSupport.subproj/WebTextRenderer.m:
(mapForSubstituteFont):
@@ -8948,7 +8906,7 @@ ut I don't think the failures are font related.
(-[WebBridge startLoadingResource:withURL:]): Now uses NSURL instead of NSString
(-[WebBridge objectLoadedFromCacheWithURL:response:size:]): Ditto
(-[WebBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
- Ditto
+ Ditto
(-[WebBridge setIconURL:]): Ditto
(-[WebBridge setIconURL:withType:]): Ditto
(-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Ditto
@@ -8965,7 +8923,7 @@ ut I don't think the failures are font related.
* Misc.subproj/WebNSURLExtras.m:
(-[NSURL _web_URLStringLength]): Fix premature use of new CFURL API.
- New code is ifdef'ed out for now until everyone has revved.
+ New code is ifdef'ed out for now until everyone has revved.
2003-07-17 Ken Kocienda <kocienda at apple.com>
@@ -8981,9 +8939,8 @@ ut I don't think the failures are font related.
2003-07-15 Richard Williamson <rjw at apple.com>
- Fixed 3315952: Add support for <IMG> in attributed string conversion.
-
- Added RTFD pasteboard type.
+ Fixed 3315952: Add support for <IMG> in attributed string conversion.
+ Added RTFD pasteboard type.
Reviewed by John.
@@ -9019,20 +8976,18 @@ ut I don't think the failures are font related.
2003-07-14 Maciej Stachowiak <mjs at apple.com>
- Rolled in fix from Safari-89-branch
-
+ Rolled in fix from Safari-89-branch
2003-07-12 Maciej Stachowiak <mjs at apple.com>
- Try to fix OS build by making the Frameworks link in both SYMROOT
- and DSTROOT, and at both build time and install time.
+ Try to fix OS build by making the Frameworks link in both SYMROOT
+ and DSTROOT, and at both build time and install time.
* WebKit.pbproj/project.pbxproj:
2003-07-14 Dave Hyatt <hyatt at apple.com>
- Roll this change out. It was a bad change that I only made
- because I was using the opacity APIs wrong.
-
+ Roll this change out. It was a bad change that I only made
+ because I was using the opacity APIs wrong.
Reviewed by (nobody, just a straight backout of a previous checkin)
* WebCoreSupport.subproj/WebImageRenderer.m:
@@ -9058,20 +9013,19 @@ ut I don't think the failures are font related.
2003-07-12 Maciej Stachowiak <mjs at apple.com>
- Try to fix OS build by making the Frameworks link in both SYMROOT
- and DSTROOT, and at both build time and install time.
+ Try to fix OS build by making the Frameworks link in both SYMROOT
+ and DSTROOT, and at both build time and install time.
* WebKit.pbproj/project.pbxproj:
2003-07-11 Dave Hyatt <hyatt at apple.com>
- Make sure image compositing obeys the current global alpha that
- is in effect, e.g., if someone has set an opacity within the
- current layer.
+ Make sure image compositing obeys the current global alpha that
+ is in effect, e.g., if someone has set an opacity within the
+ current layer.
- It's worth noting that I'm not even sure *why* this patch works,
- but it does, even with nested opacity layers.
-
+ It's worth noting that I'm not even sure *why* this patch works,
+ but it does, even with nested opacity layers.
Reviewed by darin
* WebCoreSupport.subproj/WebImageRenderer.m:
@@ -9081,7 +9035,7 @@ ut I don't think the failures are font related.
2003-07-10 Richard Williamson <rjw at apple.com>
- Fixed 3298153. Force use of printer font when printing.
+ Fixed 3298153. Force use of printer font when printing.
Reviewed by Chris.
@@ -9090,9 +9044,9 @@ ut I don't think the failures are font related.
2003-07-10 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3161102>: Avoid retain cycles by destroying plug-ins in the page cache before dealloc
- Fixed: <rdar://problem/3320624>: WebElementImageAltStringKey is not exported :-(
- Unspoof freebsd since we now handle gzip'd content.
+ Fixed: <rdar://problem/3161102>: Avoid retain cycles by destroying plug-ins in the page cache before dealloc
+ Fixed: <rdar://problem/3320624>: WebElementImageAltStringKey is not exported :-(
+ Unspoof freebsd since we now handle gzip'd content.
Reviewed by rjw.
@@ -9111,12 +9065,12 @@ ut I don't think the failures are font related.
* WebCoreSupport.subproj/WebImageRenderer.m:
(-[WebImageRenderer incrementalLoadWithBytes:length:complete:]):
- fixed copy/paste error in comment that I stumbled across
+ fixed copy/paste error in comment that I stumbled across
2003-07-09 Richard Williamson <rjw at apple.com>
- Fixed 3141257. Animate multiple copies of the same
- image on the same page.
+ Fixed 3141257. Animate multiple copies of the same
+ image on the same page.
Reviewed by hyatt.
@@ -9138,7 +9092,7 @@ ut I don't think the failures are font related.
2003-07-09 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3229364>: user stylesheet path should be stored relative to home directory
+ Fixed: <rdar://problem/3229364>: user stylesheet path should be stored relative to home directory
Reviewed by john.
@@ -9183,8 +9137,8 @@ ut I don't think the failures are font related.
2003-07-08 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3134494>: no progressive loading for standalone images
- Fixed: <rdar://problem/3280633>: exception raised (attempt to create array with nil element) when dragging image out of HTML
+ Fixed: <rdar://problem/3134494>: no progressive loading for standalone images
+ Fixed: <rdar://problem/3280633>: exception raised (attempt to create array with nil element) when dragging image out of HTML
Reviewed by rjw.
@@ -9227,11 +9181,10 @@ ut I don't think the failures are font related.
2003-07-08 Dave Hyatt <hyatt at apple.com>
- Change minimum font size pref value back to 9. This change
- has been made in conjunction with associated WebCore changes
- that allow us to institute a minimum font size safely without
- the need for a visible GUI pref.
-
+ Change minimum font size pref value back to 9. This change
+ has been made in conjunction with associated WebCore changes
+ that allow us to institute a minimum font size safely without
+ the need for a visible GUI pref.
Reviewed by darin
* WebView.subproj/WebPreferences.m:
@@ -9241,7 +9194,7 @@ ut I don't think the failures are font related.
Reviewed by John.
- - fixed 3295916 - b/c JavaScriptCore and WebCore are installing in wrong location, private headers are public
+ - fixed 3295916 - b/c JavaScriptCore and WebCore are installing in wrong location, private headers are public
* WebKit.pbproj/project.pbxproj: Make a link from Frameworks to Versions/A/Frameworks.
@@ -9273,7 +9226,7 @@ ut I don't think the failures are font related.
2003-07-03 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3206011>: Don't accepts drags when showing dialogs or sheets
+ Fixed: <rdar://problem/3206011>: Don't accepts drags when showing dialogs or sheets
Reviewed by john.
@@ -9282,7 +9235,7 @@ ut I don't think the failures are font related.
2003-07-03 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3291566>: Aborting standalone image load makes image directory page unusable
+ Fixed: <rdar://problem/3291566>: Aborting standalone image load makes image directory page unusable
Reviewed by john.
@@ -9297,13 +9250,13 @@ ut I don't think the failures are font related.
Reviewed by Ken.
- - fixed 3304992 - REGRESSION: Every GET on an authenticated site requires a login (genentech)
+ - fixed 3304992 - REGRESSION: Every GET on an authenticated site requires a login (genentech)
- I fixed this by adding a per-window queue of waiting
- authentication requests. Before going to a later item in the
- queue, the auth handler checks if there's already a credential
- available to handle it, and if so uses that as the answer instead of
- prompting.
+ I fixed this by adding a per-window queue of waiting
+ authentication requests. Before going to a later item in the
+ queue, the auth handler checks if there's already a credential
+ available to handle it, and if so uses that as the answer instead of
+ prompting.
* Panels.subproj/WebPanelAuthenticationHandler.h:
* Panels.subproj/WebPanelAuthenticationHandler.m:
@@ -9317,18 +9270,18 @@ ut I don't think the failures are font related.
2003-06-30 John Sullivan <sullivan at apple.com>
- - fixed 3310716 -- Authentication dialog could be tweaked to
- better match guidelines
+ - fixed 3310716 -- Authentication dialog could be tweaked to
+ better match guidelines
Reviewed by Chris
* Panels.subproj/English.lproj/WebAuthenticationPanel.nib:
- left-aligned "Name:" and "Password:" labels; slightly tweaked
- layout at right edge of sheet
+ left-aligned "Name:" and "Password:" labels; slightly tweaked
+ layout at right edge of sheet
2003-06-26 Chris Blumenberg <cblu at apple.com>
- Changes to make WebKit compile with gcc 3.3.
+ Changes to make WebKit compile with gcc 3.3.
Reviewed by darin.
@@ -9350,7 +9303,7 @@ ut I don't think the failures are font related.
2003-06-24 Chris Blumenberg <cblu at apple.com>
- Renamed the context menu item Download Image To Disk" to "Download Image to Disk".
+ Renamed the context menu item Download Image To Disk" to "Download Image to Disk".
Reviewed by john.
@@ -9360,7 +9313,7 @@ ut I don't think the failures are font related.
2003-06-19 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3294803>: HTTP error sent as content instead of error to plug-ins
+ Fixed: <rdar://problem/3294803>: HTTP error sent as content instead of error to plug-ins
Reviewed by john.
@@ -9382,7 +9335,7 @@ ut I don't think the failures are font related.
Reviewed by Darin (Richard wrote the first cut), then Don and Dave.
- - fixed 3291467 -- CARBON: context menus are broken when using WebKit from Carbon
+ - fixed 3291467 -- CARBON: context menus are broken when using WebKit from Carbon
* Carbon.subproj/HIWebView.m: (ContextMenuClick): Rewrite method to create a fake
right mouse up event, and pass that to menuForEvent: and _popUpMenuWithEvent.
@@ -9404,10 +9357,9 @@ ut I don't think the failures are font related.
2003-06-13 David Hyatt <hyatt at apple.com>
- Fix for 3291319, scrolling is much worse since 79. The problem
- was a fix for resize events that needed to use the scrollview size
- and not the document view size inside the scrollview.
-
+ Fix for 3291319, scrolling is much worse since 79. The problem
+ was a fix for resize events that needed to use the scrollview size
+ and not the document view size inside the scrollview.
Reviewed by darin
* WebView.subproj/WebHTMLView.m:
@@ -9416,13 +9368,13 @@ ut I don't think the failures are font related.
2003-06-13 Chris Blumenberg <cblu at apple.com>
- Fixed previous " Reviewed by" string.
+ Fixed previous " Reviewed by" string.
* ChangeLog:
2003-06-13 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3291502>: REGRESSION (80-81): freebsd.org is giving us gzipped content (because we stopped spoofing)
+ Fixed: <rdar://problem/3291502>: REGRESSION (80-81): freebsd.org is giving us gzipped content (because we stopped spoofing)
Reviewed by john.
@@ -9433,11 +9385,11 @@ ut I don't think the failures are font related.
2003-06-12 Richard Williamson <rjw at apple.com>
- Restoring fix for 3221078 that I earlier backed out in a
- panic about performance. In careful performance testing
- I now see no performance regression, and maybe a tiny improvement.
- The earlier performance regression Vicki saw was entirely
- due to the incorrect checkin for the fix to 3288532.
+ Restoring fix for 3221078 that I earlier backed out in a
+ panic about performance. In careful performance testing
+ I now see no performance regression, and maybe a tiny improvement.
+ The earlier performance regression Vicki saw was entirely
+ due to the incorrect checkin for the fix to 3288532.
Reviewed by Chris & Gramps.
@@ -9446,7 +9398,7 @@ ut I don't think the failures are font related.
2003-06-12 Richard Williamson <rjw at apple.com>
- Correct fix for 3288532 again. This time will feeling!
+ Correct fix for 3288532 again. This time will feeling!
Reviewed by Gramps.
@@ -9455,23 +9407,23 @@ ut I don't think the failures are font related.
2003-06-12 Don Melton <gramps at apple.com>
- Since Richard didn't actually correct the fix for 3288532 in
- WebBackForwardList.m, I've backed out out his original fix entirely.
+ Since Richard didn't actually correct the fix for 3288532 in
+ WebBackForwardList.m, I've backed out out his original fix entirely.
* History.subproj/WebBackForwardList.m:
(-[WebBackForwardList setCapacity:]):
2003-06-12 Richard Williamson <rjw at apple.com>
- Correct fix for 3288532.
+ Correct fix for 3288532.
* History.subproj/WebBackForwardList.m:
2003-06-12 Richard Williamson <rjw at apple.com>
- Fixed 3288532. When setCapacity: shrinks capacity, trim
- the back/forward list. Setting to zero will effectively
- flush the list.
+ Fixed 3288532. When setCapacity: shrinks capacity, trim
+ the back/forward list. Setting to zero will effectively
+ flush the list.
Reviewed by John.
@@ -9479,9 +9431,9 @@ ut I don't think the failures are font related.
2003-06-12 Richard Williamson <rjw at apple.com>
- Fixed 3221078. Maintain a seperate width map
- for substitute fonts to avoid collision of glyph
- codes.
+ Fixed 3221078. Maintain a seperate width map
+ for substitute fonts to avoid collision of glyph
+ codes.
Reviewed by Chris & Gramps.
@@ -9494,7 +9446,7 @@ ut I don't think the failures are font related.
Fixed by Richard, reviewed by me.
- - fixed 3289047 -- REGRESSION: can't go back after using form at attwireless.com
+ - fixed 3289047 -- REGRESSION: can't go back after using form at attwireless.com
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
@@ -9508,7 +9460,7 @@ ut I don't think the failures are font related.
2003-06-11 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3289577>: Reenable Carbon Java plug-ins when in Carbon app
+ Fixed: <rdar://problem/3289577>: Reenable Carbon Java plug-ins when in Carbon app
Reviewed by gramps.
@@ -9517,7 +9469,7 @@ ut I don't think the failures are font related.
2003-06-11 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3289380>: REGRESSION: policyDataSource == nil assertion failure after closing particular window
+ Fixed: <rdar://problem/3289380>: REGRESSION: policyDataSource == nil assertion failure after closing particular window
Reviewed by john.
@@ -9528,7 +9480,7 @@ ut I don't think the failures are font related.
2003-06-11 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3288097>: REGRESSION: assertion failure after hitting back while loading page after fragment scroll
+ Fixed: <rdar://problem/3288097>: REGRESSION: assertion failure after hitting back while loading page after fragment scroll
Fixed by darin, reviewed by me.
@@ -9539,7 +9491,7 @@ ut I don't think the failures are font related.
Reviewed by John.
- - fixed 3285808 -- repro world leak when replacing div that contains iframe (at www.kbs.co.kr)
+ - fixed 3285808 -- repro world leak when replacing div that contains iframe (at www.kbs.co.kr)
* WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameDetached]):
Add a call to _detachFromParent.
@@ -9548,10 +9500,10 @@ ut I don't think the failures are font related.
2003-06-10 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3288076>: REGRESSION: Fragment scroll stops page load
+ Fixed: <rdar://problem/3288076>: REGRESSION: Fragment scroll stops page load
- We do policy navigation checks for the regular load case, fragment scroll and redirects.
- We only want to stop the load, change the provisional data source etc in the regular load case.
+ We do policy navigation checks for the regular load case, fragment scroll and redirects.
+ We only want to stop the load, change the provisional data source etc in the regular load case.
Reviewed by darin.
@@ -9570,11 +9522,11 @@ Source::
2003-06-10 Richard Williamson <rjw at apple.com>
- Back out incorrect fix to 3287862.
+ Back out incorrect fix to 3287862.
2003-06-10 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3156169>: cmd-click opens new win but stops loading in prev win
+ Fixed: <rdar://problem/3156169>: cmd-click opens new win but stops loading in prev win
Reviewed by rjw.
@@ -9603,8 +9555,8 @@ Source::
2003-06-10 Richard Williamson <rjw at apple.com>
- Fixed 3287862. Don't override resize flags
- when decoding WebView.
+ Fixed 3287862. Don't override resize flags
+ when decoding WebView.
Reviewed by Chris.
@@ -9613,7 +9565,7 @@ Source::
2003-06-10 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3286006>: Carbon Java plug-in problems may require workaround in WebKit
+ Fixed: <rdar://problem/3286006>: Carbon Java plug-in problems may require workaround in WebKit
Reviewed by john.
@@ -9634,7 +9586,7 @@ Source::
2003-06-09 Chris Blumenberg <cblu at apple.com>
- <rdar://problem/3283359>: don't load Cocoa Java plug-in if in Carbon app
+ <rdar://problem/3283359>: don't load Cocoa Java plug-in if in Carbon app
Reviewed by darin.
@@ -9645,9 +9597,9 @@ Source::
2003-06-09 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3284848>: REGRESSION: repro crash in Flash handling null event, going back to Japanese Disney page
+ Fixed: <rdar://problem/3284848>: REGRESSION: repro crash in Flash handling null event, going back to Japanese Disney page
- When restarting plug-ins from the BF cache, we were not calling NPP_SetWindow.
+ When restarting plug-ins from the BF cache, we were not calling NPP_SetWindow.
Reviewed by darin.
@@ -9674,8 +9626,8 @@ Source::
2003-06-06 Richard Williamson <rjw at apple.com>
- Fixed 3283236. Remove use of forward declarations in public header because
- CodeWarrior pukes on 'em.
+ Fixed 3283236. Remove use of forward declarations in public header because
+ CodeWarrior pukes on 'em.
Reviewed by Chris.
@@ -9683,7 +9635,7 @@ Source::
2003-06-06 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3156169>: cmd-click opens new win but stops loading in prev win
+ Fixed: <rdar://problem/3156169>: cmd-click opens new win but stops loading in prev win
Reviewed by darin.
@@ -9702,7 +9654,7 @@ Source::
2003-06-06 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3282881>: Java plugin fails in carbon WebKit apps
+ Fixed: <rdar://problem/3282881>: Java plugin fails in carbon WebKit apps
Fixed by Mike Hay, reviewed by me.
@@ -9713,61 +9665,61 @@ Source::
2003-06-05 John Sullivan <sullivan at apple.com>
- - fixed 3266216 -- repro crash in
- -[WebBaseResourceHandleDelegate connection:didReceiveData:]
- in GIA Application
+ - fixed 3266216 -- repro crash in
+ -[WebBaseResourceHandleDelegate connection:didReceiveData:]
+ in GIA Application
- The problem was that an NSURLConnection delegate object (in this
- case a WebMainResourceClient) was being dealloc'ed during one of
- its connection delegate methods. To prevent this kind of problem,
- I added [self retain]/[self release] guards around the meat of
- all of the connection delegate methods in which arbitrary code
- could be run. Another approach would be to do this retain/release
- pair in NSURLConnection, but Darin deemed it wiser not to muck with
- Foundation at this point for this issue.
+ The problem was that an NSURLConnection delegate object (in this
+ case a WebMainResourceClient) was being dealloc'ed during one of
+ its connection delegate methods. To prevent this kind of problem,
+ I added [self retain]/[self release] guards around the meat of
+ all of the connection delegate methods in which arbitrary code
+ could be run. Another approach would be to do this retain/release
+ pair in NSURLConnection, but Darin deemed it wiser not to muck with
+ Foundation at this point for this issue.
Reviewed by Darin
* Plugins.subproj/WebNetscapePluginStream.m:
(-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]):
- guard with [self retain]/[self release]
+ guard with [self retain]/[self release]
(-[WebNetscapePluginConnectionDelegate connection:didReceiveData:]):
- ditto
+ ditto
(-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]):
- ditto
+ ditto
* WebCoreSupport.subproj/WebSubresourceClient.m:
(-[WebSubresourceClient connection:didReceiveResponse:]):
- ditto
+ ditto
(-[WebSubresourceClient connection:didReceiveData:]):
- ditto
+ ditto
* WebView.subproj/WebBaseResourceHandleDelegate.m:
(-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]):
- ditto
+ ditto
(-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]):
- ditto
+ ditto
(-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]):
- ditto
+ ditto
(-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
- ditto
+ ditto
(-[WebBaseResourceHandleDelegate connection:didReceiveData:]):
- ditto. Also, commented out two assertions that fire illegitimately in the steps in
- this bug report.
+ ditto. Also, commented out two assertions that fire illegitimately in the steps in
+ this bug report.
(-[WebBaseResourceHandleDelegate connection:didFailWithError:]):
- ditto
+ ditto
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient connection:willSendRequest:redirectResponse:]):
- ditto
+ ditto
(-[WebMainResourceClient connection:didReceiveResponse:]):
- ditto
+ ditto
(-[WebMainResourceClient connection:didReceiveData:]):
- ditto
+ ditto
2003-06-04 Richard Williamson <rjw at apple.com>
- Fixed 3277775. Send less notifications. Notifcations suck!
+ Fixed 3277775. Send less notifications. Notifcations suck!
Reviewed by David.
@@ -9801,7 +9753,7 @@ Source::
2003-06-03 Chris Blumenberg <cblu at apple.com>
- Fixed: 3278496 - <rdar://problem/3278496>: NSURLDownload: initWithSource and source should be renamed to initWithRequest and request
+ Fixed: 3278496 - <rdar://problem/3278496>: NSURLDownload: initWithSource and source should be renamed to initWithRequest and request
Reviewed by rjw.
@@ -9814,26 +9766,24 @@ Source::
(-[WebView _downloadURL:toDirectory:]):
2003-06-03 Richard Williamson <rjw at apple.com>
-
- Fixed 3263188, 3274636.
-
+ Fixed 3263188, 3274636.
Written by Ed Voas. Reviewed by Richard.
* Carbon.subproj/CarbonUtils.m:
(WebInitForCarbon):
- Ensure the process info is correctly initialized so the correct
- "flavour" (carbon) is detected.
+ Ensure the process info is correctly initialized so the correct
+ "flavour" (carbon) is detected.
* Carbon.subproj/HIWebView.m:
(Draw):
- Always draw the growbox after drawing the web view,
- assuming overlap.
+ Always draw the growbox after drawing the web view,
+ assuming overlap.
=== Safari-82 ===
2003-06-03 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3167792>: hang in _web_dragPromisedImage dragging 4 MB image
+ Fixed: <rdar://problem/3167792>: hang in _web_dragPromisedImage dragging 4 MB image
Reviewed by john.
@@ -9842,29 +9792,29 @@ Source::
2003-06-02 Richard Williamson <rjw at apple.com>
- Fix for 3250352.
+ Fix for 3250352.
Reviewed by Chris.
* WebView.subproj/WebDataSourcePrivate.m:
(-[WebDataSource _startLoading:]):
- Check respondsToSelector: before calling.
+ Check respondsToSelector: before calling.
* WebView.subproj/WebResourceLoadDelegate.h:
* WebView.subproj/WebUIDelegate.h:
- Headerdoc tweaks.
+ Headerdoc tweaks.
=== Safari-81 ===
2003-06-02 Chris Blumenberg <cblu at apple.com>
- Fixed: <rdar://problem/3154910>: No video when viewing QT plug-in content at some pages but audio works
+ Fixed: <rdar://problem/3154910>: No video when viewing QT plug-in content at some pages but audio works
- This fix works around QT plug-in bug 3275755, but I think the fix is logical and worth keeping even after 3275755 is fixed.
+ This fix works around QT plug-in bug 3275755, but I think the fix is logical and worth keeping even after 3275755 is fixed.
- Eric Carlson:
- The problem happens when you call NPP_SetWindow with a 0 width or height more than once. The first call to NPP_SetWindow always seems to have width and height set to 0, but the next call sometimes has it set to the correct values (those in the EMBED tag)
+ Eric Carlson:
+ The problem happens when you call NPP_SetWindow with a 0 width or height more than once. The first call to NPP_SetWindow always seems to have width and height set to 0, but the next call sometimes has it set to the correct values (those in the EMBED tag)
@@ -9888,10 +9838,10 @@ Source::
2003-05-30 Richard Williamson <rjw at apple.com>
- Fixed 3272516. Items are now expired from the
- b/f cache if they are older than 30 minutes. This
- number was pulled out of our #!$es. Also did
- some cleanup of the b/f cache code.
+ Fixed 3272516. Items are now expired from the
+ b/f cache if they are older than 30 minutes. This
+ number was pulled out of our #!$es. Also did
+ some cleanup of the b/f cache code.
Reviewed by Ken.
@@ -9912,13 +9862,12 @@ Source::
* WebView.subproj/WebView.h:
* WebView.subproj/WebPreferences.h: Cleaned up some headerdoc
- comments.
-
+ comments.
2003-05-29 Richard Williamson <rjw at apple.com>
- Implemented 'estimatedProgress' method on WebView. This should
- eventually replace the broken algorithm on WebBrowser. Maybe
- for panther.
+ Implemented 'estimatedProgress' method on WebView. This should
+ eventually replace the broken algorithm on WebBrowser. Maybe
+ for panther.
Reviewed by Chris.
@@ -9947,8 +9896,8 @@ Source::
(-[WebView _incrementProgressForConnection:data:]):
(-[WebView _completeProgressForConnection:]):
- Code cleanup. Moved variable initialization into block that
- check for non-nil self.
+ Code cleanup. Moved variable initialization into block that
+ check for non-nil self.
* WebCoreSupport.subproj/WebImageRenderer.m:
(-[WebImageRenderer initWithMIMEType:]):
@@ -9957,8 +9906,8 @@ Source::
2003-05-29 Richard Williamson <rjw at apple.com>
- Fixed 3272226. The shared image factory was being released
- when any renderer had 0 reps!
+ Fixed 3272226. The shared image factory was being released
+ when any renderer had 0 reps!
Reviewed by John.
@@ -9967,8 +9916,7 @@ Source::
2003-05-29 Chris Blumenberg <cblu at apple.com>
- Fixed: 3151216 - Safari crashes on Drag&Drop if plugin dialog is open
-
+ Fixed: 3151216 - Safari crashes on Drag&Drop if plugin dialog is open
Reviewed by rjw.
* Misc.subproj/WebNSViewExtras.m:
@@ -9978,15 +9926,14 @@ Source::
2003-05-29 Chris Blumenberg <cblu at apple.com>
- Fixed: 3273109 - leak from functionPointerForTVector in -[WebNetscapePluginPackage load]
+ Fixed: 3273109 - leak from functionPointerForTVector in -[WebNetscapePluginPackage load]
* Plugins.subproj/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage load]): free the main function after using it
2003-05-29 Richard Williamson <rjw at apple.com>
-
- Fixed 3273115. Always use pixel dimensions,
- not absolute dimensions.
+ Fixed 3273115. Always use pixel dimensions,
+ not absolute dimensions.
Reviewed by Ken.
@@ -9995,8 +9942,8 @@ Source::
2003-05-29 Richard Williamson <rjw at apple.com>
- Fix 3272292. Ensure that loadStatus is always
- initialized to NSImageRepLoadStatusUnknownType.
+ Fix 3272292. Ensure that loadStatus is always
+ initialized to NSImageRepLoadStatusUnknownType.
Reviewed by Chris.
@@ -10009,17 +9956,17 @@ Source::
Reviewed by Richard
- Fix for this bug:
+ Fix for this bug:
- Radar 3260323 (Some links at nike.com cause assertion failure
- (connectionDidFinishLoading sent after cancel))
+ Radar 3260323 (Some links at nike.com cause assertion failure
+ (connectionDidFinishLoading sent after cancel))
- Added a flag which is set when a load is cancelled. This flag prevents
- bad behvior when loads that finish cause the load itself to be
- cancelled (which could happen with a javascript that changes the
- window location). This is used to prevent both the body of
- cancelWithError: and the body of connectionDidFinishLoading: running
- for a single delegate. Cancelling wins.
+ Added a flag which is set when a load is cancelled. This flag prevents
+ bad behvior when loads that finish cause the load itself to be
+ cancelled (which could happen with a javascript that changes the
+ window location). This is used to prevent both the body of
+ cancelWithError: and the body of connectionDidFinishLoading: running
+ for a single delegate. Cancelling wins.
* WebView.subproj/WebBaseResourceHandleDelegate.h:
* WebView.subproj/WebBaseResourceHandleDelegate.m:
@@ -10028,7 +9975,7 @@ Source::
2003-05-28 Chris Blumenberg <cblu at apple.com>
- Fixed: 3270576 - RealPlayer plug-in fails to load
+ Fixed: 3270576 - RealPlayer plug-in fails to load
Reviewed by darin.
@@ -10038,16 +9985,16 @@ Source::
2003-05-28 Richard Williamson <rjw at apple.com>
- Fixed 3165631 (and other similar).
- Fixed 3262592.
+ Fixed 3165631 (and other similar).
+ Fixed 3262592.
- We now set NSImage's cache mode to NSImageCacheNever during
- progressive loads. It gets reset to NSImageCacheDefault when
- loads complete.
+ We now set NSImage's cache mode to NSImageCacheNever during
+ progressive loads. It gets reset to NSImageCacheDefault when
+ loads complete.
- If an image is scaled, NSImage appears to create a NSCacheImageRep
- with the wrong size during progessive image loading. Specifically
- it appears to create a cached rep with the original size.
+ If an image is scaled, NSImage appears to create a NSCacheImageRep
+ with the wrong size during progessive image loading. Specifically
+ it appears to create a cached rep with the original size.
Reviewed by Chris.
@@ -10058,11 +10005,11 @@ Source::
(-[WebImageRendererFactory imageRendererWithMIMEType:]):
* WebView.subproj/WebPreferences.h:
- Updated headerdoc comments.
+ Updated headerdoc comments.
2003-05-27 Chris Blumenberg <cblu at apple.com>
- Fixed: 3233442 - Crash in -[WebNetscapePluginPackage load] at http://www.adultswim.com/
+ Fixed: 3233442 - Crash in -[WebNetscapePluginPackage load] at http://www.adultswim.com/
Reviewed by mjs.
@@ -10071,7 +10018,7 @@ Source::
2003-05-27 Chris Blumenberg <cblu at apple.com>
- Don't load and save icons if the icon DB directory default is not set.
+ Don't load and save icons if the icon DB directory default is not set.
Reviewed by darin.
@@ -10084,28 +10031,27 @@ Source::
2003-05-27 Maciej Stachowiak <mjs at apple.com>
- Rolled in fix from Safari-80~1-branch
-
+ Rolled in fix from Safari-80~1-branch
2003-05-27 Maciej Stachowiak <mjs at apple.com>
- Reviewed by Darin.
+ Reviewed by Darin.
* WebKit.pbproj/project.pbxproj: Removed no longer needed and harmful flag.
2003-05-27 Richard Williamson <rjw at apple.com>
- Fix for IB.
+ Fix for IB.
Reviewed by Eric Seymour.
* WebView.subproj/WebPreferences.m:
(-[WebPreferences initWithIdentifier:]):
- Added retain to uniqued instance. (As we did recently
- for initWithCoder:).
+ Added retain to uniqued instance. (As we did recently
+ for initWithCoder:).
2003-05-27 Chris Blumenberg <cblu at apple.com>
- Fixed: 3270013 - Exception raised when visiting http://www.shutterfly.com/favicon.ico
+ Fixed: 3270013 - Exception raised when visiting http://www.shutterfly.com/favicon.ico
Reviewed by john.
@@ -10123,26 +10069,26 @@ Source::
2003-05-27 Richard Williamson <rjw at apple.com>
- Fixes for IB.
+ Fixes for IB.
Reviewed by Eric Seymour.
* WebView.subproj/WebPreferences.m:
(-[WebPreferences initWithCoder:]):
- Added retain to uniqued instance
+ Added retain to uniqued instance
* WebView.subproj/WebView.m:
(-[WebView initWithCoder:]):
(-[WebView setPreferences:]):
- Added release check to global uniquing dictionary.
+ Added release check to global uniquing dictionary.
2003-05-23 Richard Williamson <rjw at apple.com>
- Tweaks for IB.
- Updated WebView and WebPreferences to use
- keyed archiving.
- Added private method to export settable user
- defaults keys.
+ Tweaks for IB.
+ Updated WebView and WebPreferences to use
+ keyed archiving.
+ Added private method to export settable user
+ defaults keys.
Reviewed by Ken.
@@ -10155,13 +10101,13 @@ Source::
2003-05-23 Richard Williamson <rjw at apple.com>
- Added export of _WebHistoryItemChangedNotification.
+ Added export of _WebHistoryItemChangedNotification.
* WebKit.exp:
2003-05-23 Chris Blumenberg <cblu at apple.com>
- Fixed: 3259426 - Can't copy mailto links to clipboard
+ Fixed: 3259426 - Can't copy mailto links to clipboard
Reviewed by john.
@@ -10170,11 +10116,11 @@ Source::
2003-05-22 Richard Williamson <rjw at apple.com>
- *** Public API change ***
- 100% compatible. Added notification when history items
- change values.
+ *** Public API change ***
+ 100% compatible. Added notification when history items
+ change values.
- Fixed 3265672
+ Fixed 3265672
Reviewed by John.
* History.subproj/WebHistoryItem.h:
@@ -10187,8 +10133,8 @@ Source::
2003-05-22 Richard Williamson <rjw at apple.com>
- Fixed 3266464. Build problem on panther caused by overly
- pedantic gcc.
+ Fixed 3266464. Build problem on panther caused by overly
+ pedantic gcc.
Reviewed by John.
@@ -10199,9 +10145,9 @@ Source::
2003-05-22 Richard Williamson <rjw at apple.com>
- Add _web to method in category name.
+ Add _web to method in category name.
- Fixed 3266102. @selector missing ":".
+ Fixed 3266102. @selector missing ":".
Reviewed by Darin.
@@ -10302,35 +10248,33 @@ Source::
Reviewed by John.
- - fixed 3254473 - REGRESSION: nike help page reloads on mouseovers, triggered by onresize function
+ - fixed 3254473 - REGRESSION: nike help page reloads on mouseovers, triggered by onresize function
- REGRESSION: reload loop due to onresize handler (fortune.com, flipdog.com, stanford.edu)
+ REGRESSION: reload loop due to onresize handler (fortune.com, flipdog.com, stanford.edu)
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView layoutToPageWidth:]): Go back to checking for at least one
- layout instead of last layout event time. Measure size in a way that ignores
- whether the scrollbares are there or not.
+ layout instead of last layout event time. Measure size in a way that ignores
+ whether the scrollbares are there or not.
* WebView.subproj/WebHTMLViewPrivate.h: Remove last layout event time and
- add back laid out at least once boolean.
+ add back laid out at least once boolean.
2003-05-21 Chris Blumenberg <cblu at apple.com>
- These problems:
- 3184359 - icon exception closing window while typing
- 3245476 - Safari-78 crashes or hangs after IMDB Find and using the history menu to go back ...
- are not or are no longer reproducible. They were caused by an exception raised in WebKit.
- Since we don't use exceptions in WebKit, I've replaced the exception with an assert.
-
- Reviewed by john.
+ These problems:
+ 3184359 - icon exception closing window while typing
+ 3245476 - Safari-78 crashes or hangs after IMDB Find and using the history menu to go back ...
+ are not or are no longer reproducible. They were caused by an exception raised in WebKit.
+ Since we don't use exceptions in WebKit, I've replaced the exception with an assert.
+ Reviewed by john.
* Misc.subproj/WebIconDatabase.m:
(-[WebIconDatabase _releaseFutureIconForURL:]): assert instead of exception if failure
2003-05-21 Ed Voas <voas at apple.com>
- - fixed 3262868: Update Carbon WebKit API prefixes
- - fixed 3264980: Carbon support in WebKit needs to route mouse events properly
-
+ - fixed 3262868: Update Carbon WebKit API prefixes
+ - fixed 3264980: Carbon support in WebKit needs to route mouse events properly
Reviewed by Richard.
* Carbon.subproj/CarbonUtils.h:
@@ -10348,21 +10292,21 @@ Source::
2003-05-21 Vicki Murley <vicki at apple.com>
Reviewed by john
- - fixed 3234553: Safari and its frameworks should link using order files
+ - fixed 3234553: Safari and its frameworks should link using order files
* WebKit.order: Added.
* WebKit.pbproj/project.pbxproj: set SECTORDER_FLAGS = -sectorder __TEXT __text WebKit.order;
2003-05-20 Richard Williamson <rjw at apple.com>
- Fixed 3262825.
- Fixed 3245625.
- Fixed 3262547.
+ Fixed 3262825.
+ Fixed 3245625.
+ Fixed 3262547.
- Recursively check items when going back/forward to ensure all
- frame URLs are correct.
+ Recursively check items when going back/forward to ensure all
+ frame URLs are correct.
- Added some logging to help diagnose back/forward problems.
+ Added some logging to help diagnose back/forward problems.
Reviewed by John.
@@ -10385,9 +10329,9 @@ Source::
Reviewed by Darin
- Due to some header file changes in Foundation on Panther,
- Tweaked some includes so that WebKit builds on Jaguar
- and Panther.
+ Due to some header file changes in Foundation on Panther,
+ Tweaked some includes so that WebKit builds on Jaguar
+ and Panther.
* Carbon.subproj/CarbonWindowFrame.m:
* Plugins.subproj/WebNetscapePluginPackage.m:
@@ -10398,7 +10342,7 @@ Source::
- fixed 3261096 - Make WebKit an umbrella framework
* WebKit.pbproj/project.pbxproj: Build WebKit as a public umbrella
- framework when doing a B&I build.
+ framework when doing a B&I build.
2003-05-19 Ken Kocienda <kocienda at apple.com>
@@ -10476,22 +10420,22 @@ Source::
Reviewed by John.
- - fixed 3255088 - repro crash in WebCredentialStorage remembering password from onlinetrafficsafety.com
+ - fixed 3255088 - repro crash in WebCredentialStorage remembering password from onlinetrafficsafety.com
* WebView.subproj/WebFormDelegate.h:
* WebView.subproj/WebFormDelegate.m:
(-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]): Expect sourceFrame
- argument.
+ argument.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Include
- source frame in form state.
+ source frame in form state.
(-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
- Include source frame in form state. Post directly to the target
- frame if it exists, since we want the form state to contain the
- right source frame.
+ Include source frame in form state. Post directly to the target
+ frame if it exists, since we want the form state to contain the
+ right source frame.
(-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Pass source frame to form
- delegate.
- (-[WebFormState initWithForm:values:sourceFrame:]): New sourceFrame argument.
+ delegate.
+ (-[WebFormState initWithForm:values:sourceFrame:]): New sourceFrame argument.
(-[WebFormState dealloc]): release sourceFrame.
(-[WebFormState sourceFrame]): New method.
@@ -10499,11 +10443,11 @@ Source::
Reviewed by Gramps
- Moved in WebDatabase and WebFileDatabase files from WebFoundation.
+ Moved in WebDatabase and WebFileDatabase files from WebFoundation.
- Copied NSLRUFileList from WebFoundation and renamed to WebLRUFileList.
+ Copied NSLRUFileList from WebFoundation and renamed to WebLRUFileList.
- Updated StringsNotToBeLocalized.txt.
+ Updated StringsNotToBeLocalized.txt.
* English.lproj/StringsNotToBeLocalized.txt:
* Misc.subproj/WebDatabase.h:
@@ -10559,7 +10503,7 @@ Source::
2003-05-15 Chris Blumenberg <cblu at apple.com>
- Fixed: 3199310 - No user agent included in favicon.ico requests
+ Fixed: 3199310 - No user agent included in favicon.ico requests
Reviewed by kocienda.
@@ -10575,7 +10519,7 @@ Source::
2003-05-15 Chris Blumenberg <cblu at apple.com>
- Fixed: 3155760 - Plug-in MIME and extension mapping should be case-insensitive
+ Fixed: 3155760 - Plug-in MIME and extension mapping should be case-insensitive
Reviewed by john.
@@ -10594,7 +10538,7 @@ Source::
Reviewed by John
- Updated for recent changes.
+ Updated for recent changes.
* English.lproj/StringsNotToBeLocalized.txt:
@@ -10605,15 +10549,15 @@ Source::
Changed the names of some extras files in WebFoundation:
Updated imports and usages in this project.
- WebNSCalendarDateExtras -> NSCalendarDate_NSURLExtras
- WebNSDataExtras -> NSData_NSURLExtras
- WebNSDictionaryExtras -> NSDictionary_NSURLExtras
- WebNSErrorExtras -> NSError_NSURLExtras
- WebNSFileManagerExtras -> NSFileManager_NSURLExtras
- WebNSObjectExtras -> NSObject_NSURLExtras
- WebNSStringExtras -> NSString_NSURLExtras
- WebNSURLExtras -> NSURL_NSURLExtras
- WebNSUserDefaultsExtras -> NSUserDefaults_NSURLExtras
+ WebNSCalendarDateExtras -> NSCalendarDate_NSURLExtras
+ WebNSDataExtras -> NSData_NSURLExtras
+ WebNSDictionaryExtras -> NSDictionary_NSURLExtras
+ WebNSErrorExtras -> NSError_NSURLExtras
+ WebNSFileManagerExtras -> NSFileManager_NSURLExtras
+ WebNSObjectExtras -> NSObject_NSURLExtras
+ WebNSStringExtras -> NSString_NSURLExtras
+ WebNSURLExtras -> NSURL_NSURLExtras
+ WebNSUserDefaultsExtras -> NSUserDefaults_NSURLExtras
* History.subproj/WebHistory.m:
* History.subproj/WebHistoryItem.m:
@@ -10668,9 +10612,9 @@ Source::
Reviewed by David
- File and class renaming in WebFoundation:
+ File and class renaming in WebFoundation:
- WebFileTypeMappings -> NSURLFileTypeMappings
+ WebFileTypeMappings -> NSURLFileTypeMappings
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge MIMETypeForPath:]):
@@ -10707,33 +10651,32 @@ Source::
Reviewed by Don.
- - fixed 3257307 - REGRESSION: crash using onFocus="this.blur()"
-
+ - fixed 3257307 - REGRESSION: crash using onFocus="this.blur()"
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge makeFirstResponder:]): Let the WebView know that
- this is a programmatic focus.
+ this is a programmatic focus.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView becomeFirstResponder]): Check if this is a programmatic
- focus from WebCore - if so, treat it like a direct focus, even if there
- is a selection direction set.
+ focus from WebCore - if so, treat it like a direct focus, even if there
+ is a selection direction set.
* WebView.subproj/WebViewPrivate.h:
* WebView.subproj/WebViewPrivate.m:
(-[WebView _pushPerformingProgrammaticFocus]): New method to indicate
- upcoming programmatic focus.
+ upcoming programmatic focus.
(-[WebView _popPerformingProgrammaticFocus]): New method to indicate
- end of programmatic focus. Needs to nest with the previous.
+ end of programmatic focus. Needs to nest with the previous.
(-[WebView _isPerformingProgrammaticFocus]): Check if we are handling
- a programmatic focus from WebCore.
+ a programmatic focus from WebCore.
2003-05-14 Ken Kocienda <kocienda at apple.com>
Reviewed by John
- Copied WebAssertions.[hm] from WebFoundation to WebKit
+ Copied WebAssertions.[hm] from WebFoundation to WebKit
- Updated all imports.
+ Updated all imports.
- Added logging exported symbols to exports file.
+ Added logging exported symbols to exports file.
* History.subproj/WebBackForwardList.m:
* History.subproj/WebHistory.m:
@@ -10781,11 +10724,11 @@ Source::
2003-05-13 Richard Williamson <rjw at apple.com>
- Fixed 3014661. We now display (a lame Lemay) image
- when an image fails to load. We also display the
- alt text if it fits within the image container
- above the missing image icon. Alt text is also
- now shown if image loading is disabled.
+ Fixed 3014661. We now display (a lame Lemay) image
+ when an image fails to load. We also display the
+ alt text if it fits within the image container
+ above the missing image icon. Alt text is also
+ now shown if image loading is disabled.
Reviewed by John.
@@ -10806,7 +10749,7 @@ Source::
Reviewed by Chris and Richard.
- - fixed 3257296 -- REGRESSION: crash in WebImageRendererFactory (movietickets.com)
+ - fixed 3257296 -- REGRESSION: crash in WebImageRendererFactory (movietickets.com)
* WebCoreSupport.subproj/WebImageRenderer.m:
(-[WebImageRenderer initWithMIMEType:]): Check for nil.
@@ -10817,7 +10760,7 @@ Source::
Reviewed by Darin.
- - fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu
+ - fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu
* Misc.subproj/WebCoreStatistics.h:
* Misc.subproj/WebCoreStatistics.m:
@@ -10828,7 +10771,7 @@ Source::
Reviewed by Ken.
- - fixed 3120355 -- importing IE favorites garbles non-ASCII characters (esp. bad for non-Roman languages)
+ - fixed 3120355 -- importing IE favorites garbles non-ASCII characters (esp. bad for non-Roman languages)
* WebView.subproj/WebViewPrivate.h: Added _decodeData:.
* WebView.subproj/WebViewPrivate.m: (+[WebView _decodeData:]): Added. Calls through to WebCore.
@@ -10837,21 +10780,21 @@ Source::
Reviewed by Darin.
- - renamed NSErrorFailingURLKey to NSErrorFailingURLStringKey
+ - renamed NSErrorFailingURLKey to NSErrorFailingURLStringKey
* Misc.subproj/WebKitErrors.m:
(-[NSError _initWithPluginErrorCode:contentURLString:pluginPageURLString:pluginName:MIMEType:]):
2003-05-13 John Sullivan <sullivan at apple.com>
- fixed build break
+ fixed build break
Reviewed by Darin
* WebCoreSupport.subproj/WebImageRenderer.m:
(-[WebImageRenderer initWithData:MIMEType:]):
- move #ifdefs; two required methods were being #ifdeffed
- out on Panther
+ move #ifdefs; two required methods were being #ifdeffed
+ out on Panther
2003-05-12 Richard Williamson <rjw at apple.com>
@@ -10886,35 +10829,35 @@ Source::
2003-05-12 John Sullivan <sullivan at apple.com>
- - addition to Darin's previous patch; when checking whether a request can
- be handled, take into account the schemes that were registered without
- an NSURLProtocol getting involved.
+ - addition to Darin's previous patch; when checking whether a request can
+ be handled, take into account the schemes that were registered without
+ an NSURLProtocol getting involved.
Reviewed by Darin
* WebView.subproj/WebViewPrivate.h:
* WebView.subproj/WebViewPrivate.m:
(+[WebView _canHandleRequest:]):
- like NSURLConnection canHandleRequest, but also takes into account the
- schemes that were registered without an NSURLProtocol
+ like NSURLConnection canHandleRequest, but also takes into account the
+ schemes that were registered without an NSURLProtocol
* Plugins.subproj/WebNetscapePluginStream.m:
(-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):
- use +[WebView _canHandleRequest] instead of +[NSURLConnection canHandleRequest]
+ use +[WebView _canHandleRequest] instead of +[NSURLConnection canHandleRequest]
* WebView.subproj/WebDefaultContextMenuDelegate.m:
(-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
- ditto
+ ditto
* WebView.subproj/WebDefaultPolicyDelegate.m:
(-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- ditto
+ ditto
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _continueAfterNavigationPolicy:]):
- ditto
+ ditto
2003-05-12 Darin Adler <darin at apple.com>
Reviewed by John.
- - fixed 3254576 -- REGRESSION: visiting bookmarks view sometimes waits for other tabs to load first
+ - fixed 3254576 -- REGRESSION: visiting bookmarks view sometimes waits for other tabs to load first
* WebView.subproj/WebViewPrivate.h: Added new SPI for registering view and represenation classes by
scheme rather than MIME type.
@@ -10941,7 +10884,7 @@ Source::
Reviewed by John.
- - fixed 3254473 - REGRESSION: reload loop due to onresize handler (fortune.com, flipdog.com, stanford.edu)
+ - fixed 3254473 - REGRESSION: reload loop due to onresize handler (fortune.com, flipdog.com, stanford.edu)
* WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): Don't send out a resize event any
time during the first event that results in a layout. The old check was merely for the first layout,
@@ -10954,7 +10897,7 @@ Source::
Reviewed by Maciej.
- - fixed 3250119 -- REGRESSION: WebFrame leaked after showing pop-up menu
+ - fixed 3250119 -- REGRESSION: WebFrame leaked after showing pop-up menu
The leak was caused by various code storing the "element" dictionary that describes where
a click took place.
@@ -10988,7 +10931,7 @@ Source::
Reviewed by Darin.
- Updated for NSURLResponse API changes.
+ Updated for NSURLResponse API changes.
* WebView.subproj/WebBaseResourceHandleDelegate.m:
(-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
@@ -11001,9 +10944,8 @@ Source::
Reviewed by Darin.
- - removed WebAuthenticationChallenge
- - adjusted everything for removal of NSURLAuthenticationChallenge subclasses.
-
+ - removed WebAuthenticationChallenge
+ - adjusted everything for removal of NSURLAuthenticationChallenge subclasses.
* Misc.subproj/WebDownload.m:
(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
(-[WebDownloadInternal download:didCancelAuthenticationChallenge:]):
@@ -11031,12 +10973,11 @@ Source::
2003-05-09 David Hyatt <hyatt at apple.com>
- Change the minfontsize to 1, i.e., to have no minimum. This
- matches other browsers while still retaining the pref control
- in WebKit.
+ Change the minfontsize to 1, i.e., to have no minimum. This
+ matches other browsers while still retaining the pref control
+ in WebKit.
- Fixes www.gamespot.com. The bug is 3254489.
-
+ Fixes www.gamespot.com. The bug is 3254489.
Reviewed by darin
* WebView.subproj/WebPreferences.m:
@@ -11046,9 +10987,9 @@ Source::
Reviewed by John.
- Rename connection:didFailLoadingWithError: to
- connection:didFailWithError: to match NSURLDownload and
- NSURLProtocol.
+ Rename connection:didFailLoadingWithError: to
+ connection:didFailWithError: to match NSURLDownload and
+ NSURLProtocol.
* Misc.subproj/WebIconLoader.m:
(-[WebIconLoader connection:didFailWithError:]):
@@ -11075,13 +11016,13 @@ Source::
Reviewed by John
- Removed unneeded import of WebFoundation/WebQueue.h.
+ Removed unneeded import of WebFoundation/WebQueue.h.
* WebCoreSupport.subproj/WebTextRendererFactory.h
2003-05-08 Richard Williamson <rjw at apple.com>
- Fixed 3146161. Use the AppKit to render complex
+ Fixed 3146161. Use the AppKit to render complex
text in the simple string drawing method.
Reviewed by John.
@@ -11134,8 +11075,8 @@ Source::
2003-05-08 John Sullivan <sullivan at apple.com>
- Closed up all gaps in WebKit between "ASSERT" and "(" to
- make Darin's day a little brighter.
+ Closed up all gaps in WebKit between "ASSERT" and "(" to
+ make Darin's day a little brighter.
Reviewed by Darin
@@ -11155,49 +11096,49 @@ Source::
2003-05-08 John Sullivan <sullivan at apple.com>
- - fixed 3252632 -- Registering a WebDocumentView too
- early breaks built-in image viewing
+ - fixed 3252632 -- Registering a WebDocumentView too
+ early breaks built-in image viewing
- A startup-performance optimization was breaking the case
- where clients registered WebDocumentView types before the
- first WebFrameView had been created. The fix is to allow
- registering WebDocumentView types without retrieving the
- built-in image types.
+ A startup-performance optimization was breaking the case
+ where clients registered WebDocumentView types before the
+ first WebFrameView had been created. The fix is to allow
+ registering WebDocumentView types without retrieving the
+ built-in image types.
Reviewed by Darin
* WebView.subproj/WebFrameViewPrivate.h:
- remove _viewTypes; expose _viewTypesAllowImageTypeOmission.
- All callers have to specify the boolean now.
+ remove _viewTypes; expose _viewTypesAllowImageTypeOmission.
+ All callers have to specify the boolean now.
* WebView.subproj/WebFrameViewPrivate.m:
(+[WebFrameView _viewTypesAllowImageTypeOmission:]):
- assert that the list of image types isn't nil before inserting
- them; insert each image type only if not already present.
+ assert that the list of image types isn't nil before inserting
+ them; insert each image type only if not already present.
(+[WebFrameView _viewClassForMIMEType:]):
- replace _viewTypes with _viewTypesAllowImageTypeOmission
+ replace _viewTypes with _viewTypesAllowImageTypeOmission
* Plugins.subproj/WebPluginDatabase.m:
(-[WebPluginDatabase init]):
- replace _viewTypes with _viewTypesAllowImageTypeOmission
+ replace _viewTypes with _viewTypesAllowImageTypeOmission
* WebView.subproj/WebDataSourcePrivate.h:
- remove _repTypes; expose _repTypesAllowImageTypeOmission.
- All callers have to specify the boolean now.
+ remove _repTypes; expose _repTypesAllowImageTypeOmission.
+ All callers have to specify the boolean now.
* WebView.subproj/WebDataSourcePrivate.m:
(+[WebDataSource _representationClassForMIMEType:]):
- replace _repTypes with _repTypesAllowImageTypeOmission
+ replace _repTypes with _repTypesAllowImageTypeOmission
* WebView.subproj/WebView.m:
(+[WebView registerViewClass:representationClass:forMIMEType:]):
- replace _viewTypes with _viewTypesAllowImageTypeOmission, and
- replace _repTypes with _repTypesAllowImageTypeOmission
+ replace _viewTypes with _viewTypesAllowImageTypeOmission, and
+ replace _repTypes with _repTypesAllowImageTypeOmission
2003-05-08 Darin Adler <darin at apple.com>
Reviewed by Richard.
- - fixed 3242414 -- REGRESSION: PLT times reported 10% slower after emptying cache with B/F cache enabled
+ - fixed 3242414 -- REGRESSION: PLT times reported 10% slower after emptying cache with B/F cache enabled
- made it only compute the page cache size once
* History.subproj/WebBackForwardList.m:
@@ -11218,7 +11159,7 @@ Source::
Reviewed by John.
- - fixed 3127927 -- web view should not use primary selection color when it's not first responder
+ - fixed 3127927 -- web view should not use primary selection color when it's not first responder
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView updateTextBackgroundColor]): Added. Sets the usesInactiveTextBackgroundColor flag
@@ -11246,7 +11187,7 @@ Source::
Reviewed by darin.
- - modify the Mixed build style to build optimized with symbols
+ - modify the Mixed build style to build optimized with symbols
* WebKit.pbproj/project.pbxproj: removed OPTIMIZATION_CGLAGS
@@ -11287,7 +11228,7 @@ Source::
2003-05-06 Darin Adler <darin at apple.com>
- - fixed 3249211 -- WebTextRenderer.h should not use "AttributeGroup" type for styleGroup
+ - fixed 3249211 -- WebTextRenderer.h should not use "AttributeGroup" type for styleGroup
* WebCoreSupport.subproj/WebTextRenderer.h: Update to use ATSStyleGroupPtr.
@@ -11325,8 +11266,8 @@ Source::
Reviewed by Richard.
- Fix build by separating mutating data protocol methods into
- category on NSMutableURLRequest. Also, formatting fixes.
+ Fix build by separating mutating data protocol methods into
+ category on NSMutableURLRequest. Also, formatting fixes.
* WebView.subproj/WebDataProtocol.h:
* WebView.subproj/WebDataProtocol.m:
@@ -11349,9 +11290,8 @@ Source::
2003-05-03 David Hyatt <hyatt at apple.com>
- Add smallCaps boolean to the string measuring and drawing
- methods. Not actually supported yet.
-
+ Add smallCaps boolean to the string measuring and drawing
+ methods. Not actually supported yet.
Reviewed by darin
* Misc.subproj/WebKitNSStringExtras.m:
@@ -11386,9 +11326,9 @@ Source::
Reviewed by Richard.
- - reformatted method prototypes to match AppKit style
- - remove "Public header file" from headers that are not public
- - fix header doc @method names to match actual method names
+ - reformatted method prototypes to match AppKit style
+ - remove "Public header file" from headers that are not public
+ - fix header doc @method names to match actual method names
* Carbon.subproj/CarbonWindowAdapter.h:
* Carbon.subproj/HIViewAdapter.h:
@@ -11436,13 +11376,12 @@ Source::
Reviewed by Darin.
- - fixed 2936175 - MALLORY: please implement onResize
+ - fixed 2936175 - MALLORY: please implement onResize
* WebView.subproj/WebHTMLViewPrivate.h:
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView layoutToPageWidth:]): If we just resized and we're
- not printing, make sure to send a resize event after the layout.
-
+ not printing, make sure to send a resize event after the layout.
2003-05-02 Darin Adler <darin at apple.com>
@@ -11463,7 +11402,7 @@ Source::
Reviewed by John.
- - first step in fixing 3236383 -- http://www.xy.com/ exception, crash loading main page
+ - first step in fixing 3236383 -- http://www.xy.com/ exception, crash loading main page
Changed WebFrame to explicitly detach from the bridge so we don't have a stale pointer;
also cleaned up WebBridge initialization.
@@ -11507,15 +11446,15 @@ Source::
2003-05-01 John Sullivan <sullivan at apple.com>
- - fixed 3246045 -- History items without a valid date in
- History.plist show up with unexpected dates in UI
+ - fixed 3246045 -- History items without a valid date in
+ History.plist show up with unexpected dates in UI
Reviewed by Darin.
* History.subproj/WebHistoryItem.m:
(-[WebHistoryItem initFromDictionaryRepresentation:]):
- don't set lastVisitedTimeInterval to [nil doubleValue],
- since this is random
+ don't set lastVisitedTimeInterval to [nil doubleValue],
+ since this is random
* English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
@@ -11548,20 +11487,20 @@ Source::
2003-05-01 John Sullivan <sullivan at apple.com>
- - fixed 3245793 -- Launching Safari-75 after tip of tree
- erases all history
+ - fixed 3245793 -- Launching Safari-75 after tip of tree
+ erases all history
Reviewed by Chris, Don
* History.subproj/WebHistoryItem.m:
- keep using "lastVisitedDate" as the dictionary key, since old
- Safaris otherwise can't read the History file.
+ keep using "lastVisitedDate" as the dictionary key, since old
+ Safaris otherwise can't read the History file.
(-[WebHistoryItem dictionaryRepresentation]):
- keep storing the time interval as a string, since old Safaris
- otherwise can't read the History file
+ keep storing the time interval as a string, since old Safaris
+ otherwise can't read the History file
(-[WebHistoryItem initFromDictionaryRepresentation:]):
- read the stored date as a string and convert to a double,
- as we did before.
+ read the stored date as a string and convert to a double,
+ as we did before.
2003-05-01 Darin Adler <darin at apple.com>
@@ -11619,7 +11558,7 @@ Source::
Reviewed by Richard
- Use NSURLResponse new SPI methods to set instance variables.
+ Use NSURLResponse new SPI methods to set instance variables.
* WebView.subproj/WebBaseResourceHandleDelegate.m:
(-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
@@ -11632,8 +11571,7 @@ Source::
Reviewed by Richard.
- Moved NSURLProtectionSpace over to officially blessed API.
-
+ Moved NSURLProtectionSpace over to officially blessed API.
* Panels.subproj/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForChallenge:]):
@@ -11684,7 +11622,7 @@ Source::
Reviewed by Ken.
- Minor header tweaks.
+ Minor header tweaks.
* Misc.subproj/WebDownload.h: Fix copyright notice.
* Panels.subproj/WebAuthenticationPanel.h: Added 2003 to copyright.
@@ -11695,7 +11633,7 @@ Source::
Reviewed by Ken.
- Minor header tweaks.
+ Minor header tweaks.
* Misc.subproj/WebDownload.h: Fix copyright notice.
* Panels.subproj/WebAuthenticationPanel.h: Added 2003 to copyright.
@@ -11706,7 +11644,7 @@ Source::
Reviewed by Darin.
- Fixed imports and @class directives for WebFoundation changes.
+ Fixed imports and @class directives for WebFoundation changes.
* Panels.subproj/WebAuthenticationPanel.h:
* Panels.subproj/WebAuthenticationPanel.m:
@@ -11721,10 +11659,10 @@ Source::
Reviewed by Darin.
- Some simple renames:
+ Some simple renames:
- sharedURLCredentialStorage --> sharedCredentialStorage
- URLCredentialWithUser:password:persistence: --> credentialWithUser:password:persistence:
+ sharedURLCredentialStorage --> sharedCredentialStorage
+ URLCredentialWithUser:password:persistence: --> credentialWithUser:password:persistence:
* Panels.subproj/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
@@ -11734,8 +11672,8 @@ Source::
Reviewed by Darin.
- Changed things to use WebAuthenticationChallenge for
- WebResoureceLoadDelegate auth callbacks.
+ Changed things to use WebAuthenticationChallenge for
+ WebResoureceLoadDelegate auth callbacks.
* Panels.subproj/WebPanelAuthenticationHandler.m:
(-[WebPanelAuthenticationHandler startAuthentication:window:]):
@@ -11767,10 +11705,9 @@ Source::
2003-04-30 Maciej Stachowiak <mjs at apple.com>
Reviewed by Darin.
-
- Converted download code to use an
- NSURLDownloadAuthenticationChallenge rather than a vanilla
- NSURLAuthenticationChallenge.
+ Converted download code to use an
+ NSURLDownloadAuthenticationChallenge rather than a vanilla
+ NSURLAuthenticationChallenge.
* Misc.subproj/WebDownload.m:
(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
@@ -11850,45 +11787,43 @@ Source::
Reviewed by Darin.
- - Adjusted for authentication API change - now we expect
- authentication via the connection delegate, not a separate global
- authentication handler
+ - Adjusted for authentication API change - now we expect
+ authentication via the connection delegate, not a separate global
+ authentication handler
* Misc.subproj/WebKit.h: Include WebDownload.h
* Misc.subproj/WebDownload.h: Added.
* Misc.subproj/WebDownload.m: Added - this new class is just like NSURLDownload
- but if the standard auth delegate methods are not implemented, it prompts using
- the standard AppKit sheet.
+ but if the standard auth delegate methods are not implemented, it prompts using
+ the standard AppKit sheet.
* Panels.subproj/WebPanelAuthenticationHandler.h:
* Panels.subproj/WebPanelAuthenticationHandler.m:
(+[WebPanelAuthenticationHandler sharedHandler]): New method to get a shared
- handler, since we no logner register an instance with WebFoundation.
+ handler, since we no logner register an instance with WebFoundation.
(-[WebPanelAuthenticationHandler startAuthentication:window:]): Do things
- using the new API.
+ using the new API.
(-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]):
- Likewise.
+ Likewise.
* WebKit.exp: Export WebDownload.
* WebKit.pbproj/project.pbxproj: Add new files to build.
- - Removed WebStandardPanels - this is removed from the API.
+ - Removed WebStandardPanels - this is removed from the API.
- * Panels.subproj/WebStandardPanels.h: Removed.
+ * Panels.subproj/WebStandardPanels.h: Removed.
* Panels.subproj/WebStandardPanels.m: Removed.
* Panels.subproj/WebStandardPanelsPrivate.h: Removed.
* Panels.subproj/WebAuthenticationPanel.m: Remove WebStandardPanels.h import.
- - Added new resource load delegate auth methods:
-
- * WebView.subproj/WebResourceLoadDelegate.h:
+ - Added new resource load delegate auth methods:
+ * WebView.subproj/WebResourceLoadDelegate.h:
- - Use WebDownload where appropriate, and remove use of WebStandardPanels:
-
+ - Use WebDownload where appropriate, and remove use of WebStandardPanels:
* WebView.subproj/WebBaseResourceHandleDelegate.h:
* WebView.subproj/WebBaseResourceHandleDelegate.m:
(-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]):
- Pass to resource load delegate.
- (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]):
- Likewise.
+ Pass to resource load delegate.
+ (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]):
+ Likewise.
(-[WebBaseResourceHandleDelegate dealloc]): Don't track currentURL any more.
(-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Likewise.
(-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Likewise.
@@ -11896,15 +11831,15 @@ Source::
(-[WebBaseResourceHandleDelegate cancelWithError:]): Likewise.
* WebView.subproj/WebDefaultResourceLoadDelegate.m:
(-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
- Prompt using the standard panel.
+ Prompt using the standard panel.
(-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
- Cancel prompting using the standard panel.
+ Cancel prompting using the standard panel.
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient continueAfterContentPolicy:response:]): Use WebDownload instead
- of NSURLDownload.
- * WebView.subproj/WebView.h: Remove unneeded @class directives,
- and mention WebDownload instead of NSURLDownload.
+ of NSURLDownload.
+ * WebView.subproj/WebView.h: Remove unneeded @class directives,
+ and mention WebDownload instead of NSURLDownload.
* WebView.subproj/WebViewPrivate.h:
* WebView.subproj/WebViewPrivate.m:
(-[WebView _downloadURL:toDirectory:]): Use WebDownload instead of NSURLDownload.
@@ -11931,7 +11866,7 @@ Source::
Reviewed by Darin
Changed file names for these classes. The contents
- of the files themselves remain unchanged.
+ of the files themselves remain unchanged.
WebCookie -> NSHTTPCookie.
WebCookieManager -> NSHTTPCookieStorage.
@@ -11968,7 +11903,6 @@ Source::
2003-04-29 Chris Blumenberg <cblu at apple.com>
Updated to use the new NSURLDownload API.
-
Reviewed by rjw.
* WebView.subproj/WebDataSourcePrivate.h:
@@ -12006,41 +11940,41 @@ Source::
2003-04-28 Don Melton <gramps at apple.com>
- Fixed 3225050 -- Default font size should be 16px
- Fixed 3241813 -- No longer spoof as WinIE for abcnews.go.com when
- default font size becomes 16px
+ Fixed 3225050 -- Default font size should be 16px
+ Fixed 3241813 -- No longer spoof as WinIE for abcnews.go.com when
+ default font size becomes 16px
Reviewed by Darin and Maciej.
* English.lproj/StringsNotToBeLocalized.txt:
- Updated.
+ Updated.
* WebCoreSupport.subproj/WebTextRenderer.m:
(-[WebTextRenderer initWithFont:usingPrinterFont:]):
- We need to adjust Times, Helvetica, and Courier to closely match the
+ We need to adjust Times, Helvetica, and Courier to closely match the
vertical metrics of their Microsoft counterparts that are the de facto
web standard. The AppKit adjustment of 20% is too big and is
- incorrectly added to line spacing, so we use a 15% adjustment instead
- and add it to the ascent.
+ incorrectly added to line spacing, so we use a 15% adjustment instead
+ and add it to the ascent.
* WebView.subproj/WebPreferences.m:
(+[WebPreferences initialize]):
- Changed default font size from 14 to 16 pixels and default fixed font
- size from 14 to 13 pixels. Changed standard font from Lucida Grande to
- Times, serif font from Times New Roman to Times, and sans serif font
- from Lucida Grande to Helvetica. Also replaced some stray tabs with
- spaces and made a few other anal-retentive formatting changes.
+ Changed default font size from 14 to 16 pixels and default fixed font
+ size from 14 to 13 pixels. Changed standard font from Lucida Grande to
+ Times, serif font from Times New Roman to Times, and sans serif font
+ from Lucida Grande to Helvetica. Also replaced some stray tabs with
+ spaces and made a few other anal-retentive formatting changes.
* WebView.subproj/WebUserAgentSpoofTable.c:
(hash):
(_web_findSpoofTableEntry):
* WebView.subproj/WebUserAgentSpoofTable.gperf:
- No longer spoof as Windows MSIE for abcnews.go.com since we've also
- changed the default font size.
+ No longer spoof as Windows MSIE for abcnews.go.com since we've also
+ changed the default font size.
2003-04-28 Richard Williamson <rjw at apple.com>
@@ -12077,22 +12011,21 @@ Source::
* Plugins.subproj/WebBaseNetscapePluginStream.m:
(-[WebBaseNetscapePluginStream setResponse:]): _lastModifiedDate on
- NSURLResponse is now SPI.
+ NSURLResponse is now SPI.
* WebView.subproj/WebDataSourcePrivate.m:
(-[WebDataSource _commitIfReady:]): Ditto.
2003-04-27 Chris Blumenberg <cblu at apple.com>
- Improved headerdoc comments.
-
+ Improved headerdoc comments.
* Misc.subproj/WebKitErrors.h:
* WebView.subproj/WebFrameLoadDelegate.h:
2003-04-25 Don Melton <gramps at apple.com>
- Backed out Richard's (hopefully) accidental checkin of our experiments
- from earlier today. Otherwise many layout tests are hosed. But this
- change, or something like it, will arrive soon.
+ Backed out Richard's (hopefully) accidental checkin of our experiments
+ from earlier today. Otherwise many layout tests are hosed. But this
+ change, or something like it, will arrive soon.
* WebCoreSupport.subproj/WebTextRenderer.m:
(-[WebTextRenderer initWithFont:usingPrinterFont:]):
@@ -12263,13 +12196,13 @@ Source::
2003-04-25 Chris Blumenberg <cblu at apple.com>
- Don't do "@class WebDataSource" as that class isn't mentioned in this file.
+ Don't do "@class WebDataSource" as that class isn't mentioned in this file.
* WebView.subproj/WebFrameLoadDelegate.h:
2003-04-25 Chris Blumenberg <cblu at apple.com>
- Turned WebLocationChangeDelegate into WebFrameLoadDelegate. Renamed WebFrameLoadDelegate all methods to pass a frame instead of the data source.
+ Turned WebLocationChangeDelegate into WebFrameLoadDelegate. Renamed WebFrameLoadDelegate all methods to pass a frame instead of the data source.
Reviewed by rjw.
@@ -12327,23 +12260,22 @@ Source::
2003-04-25 John Sullivan <sullivan at apple.com>
- - fixed 3240676 -- REGRESSION: Using old Safari then new one
- erases history
+ - fixed 3240676 -- REGRESSION: Using old Safari then new one
+ erases history
Reviewed by Darin.
* History.subproj/WebHistoryPrivate.m:
(-[WebHistoryPrivate _loadHistoryGuts:URL:error:]):
- The new code to use a synchronous NSURLConnection to read the
- property list file did not take into account the two possible
- formats of the file (NSArray or NSDictionary), so reading
- old-style history files was completely broken. While in here,
- I distributed the variable declarations to first use.
+ The new code to use a synchronous NSURLConnection to read the
+ property list file did not take into account the two possible
+ formats of the file (NSArray or NSDictionary), so reading
+ old-style history files was completely broken. While in here,
+ I distributed the variable declarations to first use.
2003-04-24 Maciej Stachowiak <mjs at apple.com>
- Fixed build.
-
+ Fixed build.
* Panels.subproj/WebStandardPanels.m:
(-[WebStandardPanels setUsesStandardAuthenticationPanel:]):
@@ -12351,8 +12283,7 @@ Source::
Reviewed by Ken.
- Updated for auth API changes.
-
+ Updated for auth API changes.
* Panels.subproj/WebStandardPanels.m:
(-[WebStandardPanels setUsesStandardAuthenticationPanel:]):
@@ -12501,7 +12432,7 @@ Source::
2003-04-24 Chris Blumenberg <cblu at apple.com>
- Removed WebPluginError and instead added fields to the userInfo of NSError for plug-in specific errors.
+ Removed WebPluginError and instead added fields to the userInfo of NSError for plug-in specific errors.
Reviewed by rjw.
@@ -12542,7 +12473,7 @@ Source::
Reviewed by Darin
- Changed WebError to NSError
+ Changed WebError to NSError
* Downloads.subproj/WebDownload.h:
* Downloads.subproj/WebDownload.m:
@@ -12639,19 +12570,18 @@ Source::
Reviewed by Ken and Darin.
- Fixed an authentication crashing bug that crept into the last few
- changes, plus a typo.
-
+ Fixed an authentication crashing bug that crept into the last few
+ changes, plus a typo.
* Panels.subproj/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForChallenge:]): Remove extra space.
(-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]): Store
- the challenge properly.
+ the challenge properly.
2003-04-22 Maciej Stachowiak <mjs at apple.com>
Reviewed by Darin.
- Adjusted for NSURLCredential changes.
+ Adjusted for NSURLCredential changes.
* Panels.subproj/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
@@ -12665,7 +12595,7 @@ Source::
2003-04-23 Chris Blumenberg <cblu at apple.com>
- Fixed: 3161374 - safari windows don't allow text/URL dragging on the first click
+ Fixed: 3161374 - safari windows don't allow text/URL dragging on the first click
Reviewed by john.
@@ -12676,7 +12606,7 @@ Source::
2003-04-23 Chris Blumenberg <cblu at apple.com>
- Renamed the policy delegate methods.
+ Renamed the policy delegate methods.
Reviewed by john.
@@ -12696,8 +12626,8 @@ Source::
Reviewed by Darin
- Updated to use API-approved methods for accessing
- protocol-specific URL request data.
+ Updated to use API-approved methods for accessing
+ protocol-specific URL request data.
* WebView.subproj/WebDataProtocol.m:
(-[NSURLRequest _webDataRequestParametersForReading]):
@@ -12707,8 +12637,7 @@ Source::
Reviewed by Darin.
- Renamed classes to match API document.
-
+ Renamed classes to match API document.
* Panels.subproj/WebAuthenticationPanel.h:
* Panels.subproj/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForChallenge:]):
@@ -12735,7 +12664,7 @@ Source::
+canHandleURL: becomes +canInitWithRequest:
+canonicalURLForURL: becomes +canonicalRequestForRequest:
- Added new _webIsDataProtocolURL: helper method.
+ Added new _webIsDataProtocolURL: helper method.
* WebView.subproj/WebBaseResourceHandleDelegate.m:
(-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
@@ -12756,24 +12685,23 @@ Source::
Reviewed by Richard.
- Updated for file renames.
+ Updated for file renames.
* Panels.subproj/WebAuthenticationPanel.h:
* Panels.subproj/WebPanelAuthenticationHandler.h:
* Panels.subproj/WebStandardPanels.m:
2003-04-21 Chris Blumenberg <cblu at apple.com>
-
- Fixed previous "Reviewed by".
+ Fixed previous "Reviewed by".
* ChangeLog:
2003-04-21 Chris Blumenberg <cblu at apple.com>
- Fixed: 3140990 - Safari: Error attempting to load movie from Rhino records
- Renamed plug-in view methods to mention that they take URL strings.
+ Fixed: 3140990 - Safari: Error attempting to load movie from Rhino records
+ Renamed plug-in view methods to mention that they take URL strings.
- Reviewed by john.
+ Reviewed by john.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge viewForPluginWithURLString:attributes:baseURLString:MIMEType:]): renamed, try to find the plug-in using the extension of the SRC URL if the plug-in isn't found using the MIME type.
@@ -12781,7 +12709,7 @@ Source::
2003-04-18 Chris Blumenberg <cblu at apple.com>
- Fixed: 3139385 - don't accept drags from other frames in the same WebView
+ Fixed: 3139385 - don't accept drags from other frames in the same WebView
Reviewed by john.
@@ -12810,13 +12738,13 @@ Source::
* History.subproj/WebHistoryPrivate.m:
(-[WebHistoryPrivate _loadHistoryGuts:]):
- if we can't load the file as a dictionary, try loading it
- the old-fashioned array way. This makes the history file
- format change forward-compatible.
+ if we can't load the file as a dictionary, try loading it
+ the old-fashioned array way. This makes the history file
+ format change forward-compatible.
2003-04-17 Chris Blumenberg <cblu at apple.com>
- Fixed: 3160751 - Can't use non-'.txt' file extension for text files?
+ Fixed: 3160751 - Can't use non-'.txt' file extension for text files?
Reviewed by mjs.
@@ -12826,26 +12754,26 @@ Source::
2003-04-17 John Sullivan <sullivan at apple.com>
- - fixed 3232332 -- History file should be versioned since
- we might change it in the future
- - fixed 3220355 -- Console error message at launch when
- there's no history file
+ - fixed 3232332 -- History file should be versioned since
+ we might change it in the future
+ - fixed 3220355 -- Console error message at launch when
+ there's no history file
- Note: a downside of this change is that the history formats
- before and after this change are not compatible. You will
- get no history each time you cross that boundary by running
- different Safaris.
+ Note: a downside of this change is that the history formats
+ before and after this change are not compatible. You will
+ get no history each time you cross that boundary by running
+ different Safaris.
Reviewed by Maciej.
* History.subproj/WebHistoryPrivate.m:
(-[WebHistoryPrivate _loadHistoryGuts:]):
- check for file-doesn't-exist case before complaining about
- being unable to read existing file; expect to read dictionary
- rather than array, and check version in dictionary.
+ check for file-doesn't-exist case before complaining about
+ being unable to read existing file; expect to read dictionary
+ rather than array, and check version in dictionary.
(-[WebHistoryPrivate _saveHistoryGuts:]):
- save dictionary that includes version as well as array of
- items by date.
+ save dictionary that includes version as well as array of
+ items by date.
2003-04-17 Richard Williamson <rjw at apple.com>
@@ -12877,17 +12805,17 @@ Source::
Reviewed by Darin
- Fixed call to load synchronous URL. Now conforms to new API
- which allows callers to access error object associated with
- the load.
+ Fixed call to load synchronous URL. Now conforms to new API
+ which allows callers to access error object associated with
+ the load.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _loadItem:withLoadType:]):
2003-04-16 Chris Blumenberg <cblu at apple.com>
- - Progressively load plain text in our text view.
- - Fixed: 3177603 - vCards appear in browser, not downloaded
+ - Progressively load plain text in our text view.
+ - Fixed: 3177603 - vCards appear in browser, not downloaded
Reviewed by darin.
@@ -12911,7 +12839,7 @@ Source::
2003-04-16 Ken Kocienda <kocienda at apple.com>
- Fix deployment build breaker caused by uninitialized variable.
+ Fix deployment build breaker caused by uninitialized variable.
* WebView.subproj/WebViewPrivate.m:
(-[WebView _loadBackForwardListFromOtherView:]):
@@ -12920,7 +12848,7 @@ Source::
Reviewed by John.
- - fixed 3226281 -- REGRESSION: crash in WebHTMLView removeMouseMovedObserver closing gist.com
+ - fixed 3226281 -- REGRESSION: crash in WebHTMLView removeMouseMovedObserver closing gist.com
* Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]):
Use _webView instead of _controller.
@@ -12983,10 +12911,10 @@ Source::
2003-04-15 Trey Matteson <trey at apple.com>
- 3227514 Open window in "Same Page" should copy entire back/forward list
+ 3227514 Open window in "Same Page" should copy entire back/forward list
- New support to load a new view by copying the whole backforward
- list and driving the new view to the current item.
+ New support to load a new view by copying the whole backforward
+ list and driving the new view to the current item.
Reviewed by John.
@@ -13021,27 +12949,25 @@ Source::
2003-04-14 Trey Matteson <trey at apple.com>
- 3009051 - Find on Page stops (once) at end of page, should wrap automatically WebKit
- 3051546 - Find on Page doesn't work for frameset pages
- 3058437 - can have a selection in two frames at the same time (problem for finding in frames)
- 3097498 - Find Previous continues to "Find Next" until end of paragraph
- 3097507 - Find Next searches from previous find hit instead of current selection
- Primary changes here: I added a wrap flag to the searchFor method, which is needed to
- control how we search as we traverse the frame tree. A new method is added to WebView
- that knows about traversing the frame tree as we search. HTMLView and TextView both
- clear their selections when they lose first responder (see 3228554 for possible
- improvements to that change).
+ 3009051 - Find on Page stops (once) at end of page, should wrap automatically WebKit
+ 3051546 - Find on Page doesn't work for frameset pages
+ 3058437 - can have a selection in two frames at the same time (problem for finding in frames)
+ 3097498 - Find Previous continues to "Find Next" until end of paragraph 3097507 - Find Next searches from previous find hit instead of current selection Primary changes here: I added a wrap flag to the searchFor method, which is needed to
+ control how we search as we traverse the frame tree. A new method is added to WebView
+ that knows about traversing the frame tree as we search. HTMLView and TextView both
+ clear their selections when they lose first responder (see 3228554 for possible
+ improvements to that change).
Reviewed by Maciej.
* Misc.subproj/WebSearchableTextView.m:
- Added wrap flag, pass on to TextView.
- Ensure we do some searching when we would previous get a zero range to search in.
+ Added wrap flag, pass on to TextView.
+ Ensure we do some searching when we would previous get a zero range to search in.
* WebView.subproj/WebDocument.h:
* WebView.subproj/WebFramePrivate.h:
* WebView.subproj/WebFramePrivate.m:
- These are all basic methods to support forwards and backwards traversal of
- the frame tree. Modeled after same methods we have for traversing the DOM.
+ These are all basic methods to support forwards and backwards traversal of
+ the frame tree. Modeled after same methods we have for traversing the DOM.
(-[WebFrame _nextSibling]):
(-[WebFrame _previousSibling]):
(-[WebFrame _lastChild]):
@@ -13049,19 +12975,19 @@ Source::
(-[WebFrame _previousFrameWithWrap:]):
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView searchFor:direction:caseSensitive:wrap:]): Added wrap flag,
- pass it to bridge.
+ pass it to bridge.
(-[WebHTMLView resignFirstResponder]): Clear selection when we lose firstResp.
* WebView.subproj/WebTextView.m:
(-[WebTextView resignFirstResponder]): Clear selection when we lose firstResp.
* WebView.subproj/WebView.m:
(-[WebView _currentFrame]): Return the frame holding the first responder.
(-[WebView _searchFor:direction:caseSensitive:wrap:]): Main work: traverse the
- frame tree and drive the overall find.
+ frame tree and drive the overall find.
* WebView.subproj/WebViewPrivate.h:
2003-04-14 Chris Blumenberg <cblu at apple.com>
- Log time spent loading each plug-in.
+ Log time spent loading each plug-in.
Reviewed by mjs.
@@ -13077,20 +13003,20 @@ Source::
2003-04-13 Trey Matteson <trey at apple.com>
- 3150693 - open new window on "same page" doesn't give me the same frame content
+ 3150693 - open new window on "same page" doesn't give me the same frame content
- The core is a new support method that loads a WebView given a HistoryItem, which
- thus restores all frames of that item, and optionally the form and scroll state.
+ The core is a new support method that loads a WebView given a HistoryItem, which
+ thus restores all frames of that item, and optionally the form and scroll state.
* History.subproj/WebHistoryItem.m:
(-[WebHistoryItem copyWithZone:]): Copy the docState, scrollPosition, isTargetItem.
- No good reason to have left these out when I wrote this method.
+ No good reason to have left these out when I wrote this method.
* WebView.subproj/WebFramePrivate.h:
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _saveDocumentAndScrollState]): New method to run the frame tree and
- save all form/scroll state to the current item.
+ save all form/scroll state to the current item.
* WebView.subproj/WebView.m:
- _goToItem:withLoadType: moved to WebViewPrivate.m
+ _goToItem:withLoadType: moved to WebViewPrivate.m
* WebView.subproj/WebViewPrivate.h:
* WebView.subproj/WebViewPrivate.m:
(-[WebView _goToItem:withLoadType:]): Moved from WebView.m, no change.
@@ -13098,7 +13024,7 @@ Source::
2003-04-12 Chris Blumenberg <cblu at apple.com>
- Fixed: 3162338 - Embedding SVG with <object type="image/svg+xml"> doesn't work
+ Fixed: 3162338 - Embedding SVG with <object type="image/svg+xml"> doesn't work
Reviewed by dave.
@@ -13112,12 +13038,12 @@ Source::
Reviewed by Trey.
* WebView.subproj/WebDefaultWindowOperationsDelegate.m:
- (-[WebDefaultWindowOperationsDelegate webView:setContentRect:]):
- Implemented in terms of webView:setFrame: to save clients work.
+ (-[WebDefaultWindowOperationsDelegate webView:setContentRect:]):
+ Implemented in terms of webView:setFrame: to save clients work.
2003-04-11 Chris Blumenberg <cblu at apple.com>
- Removed WebKitErrorResourceLoadInterruptedByPolicyChange error because it isn't used.
+ Removed WebKitErrorResourceLoadInterruptedByPolicyChange error because it isn't used.
Reviewed by john.
@@ -13128,40 +13054,40 @@ Source::
2003-04-11 Trey Matteson <trey at apple.com>
- 3148002 - printing shouldn't depend on the size of the window
+ 3148002 - printing shouldn't depend on the size of the window
- The basic strategy is copied from khtmlview's print method: We reset the width
- of the document to the paper width minus margins, and relayout before paginating
- and printing.
+ The basic strategy is copied from khtmlview's print method: We reset the width
+ of the document to the paper width minus margins, and relayout before paginating
+ and printing.
Reviewed by Richard.
* WebKit.pbproj/project.pbxproj: Someone is using an old version...
* WebView.subproj/WebDynamicScrollBarsView.m:
(-[WebDynamicScrollBarsView reflectScrolledClipView:]): Don't do the dynamic
- scrollbar update magic when printing.
+ scrollbar update magic when printing.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView layoutToPageWidth:]): New routine, basically the old layout
- method with a new parameter. If we're given an width, we call a different
- bridge method.
+ method with a new parameter. If we're given an width, we call a different
+ bridge method.
(-[WebHTMLView layout]): Just call above method with width==0
(-[WebHTMLView drawRect:]): Protect setting/resetting of graphics context and
- additional clip with a DURING/HANDLER. I saw an assertion failure that could
- be explained by this, so this is mostly a beartrap for that problem.
+ additional clip with a DURING/HANDLER. I saw an assertion failure that could
+ be explained by this, so this is mostly a beartrap for that problem.
(-[WebHTMLView _setPrinting:pageWidth:]): Pass page width through to others.
(-[WebHTMLView beginDocument]): If we are not in a frame set, do a layout
- using the page width.
+ using the page width.
(-[WebHTMLView endDocument]): Pass 0 to new pageWidth: arg.
2003-04-08 Trey Matteson <trey at apple.com>
- 3220349 - assertion failure in [WebFrame _recursiveGoToItem:...] hitting Back while loading movie
+ 3220349 - assertion failure in [WebFrame _recursiveGoToItem:...] hitting Back while loading movie
- The problem was that when we go back we call stopLoading on the top frame, but
- that has a bogus optimization to not do any work if state=Completed. That is a
- bogus test if a subframe is doing a load. The fix is to just always tell the
- dataSources to stopLoading. They already bail quickly when they are not loading,
- so there is no significant additional cost.
+ The problem was that when we go back we call stopLoading on the top frame, but
+ that has a bogus optimization to not do any work if state=Completed. That is a
+ bogus test if a subframe is doing a load. The fix is to just always tell the
+ dataSources to stopLoading. They already bail quickly when they are not loading,
+ so there is no significant additional cost.
Reviewed by Richard.
@@ -13187,7 +13113,7 @@ Source::
Reviewed by Maciej.
- - fixed 3225042 - MallocDebug shows "access after deallocated" problem in WebFrameView
+ - fixed 3225042 - MallocDebug shows "access after deallocated" problem in WebFrameView
* WebView.subproj/WebFrameView.m:
(-[WebFrameView dealloc]): Nil out _private.
@@ -13210,9 +13136,9 @@ Source::
2003-04-10 Trey Matteson <trey at apple.com>
- 3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields
+ 3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields
- Just glue for calling a new WC function.
+ Just glue for calling a new WC function.
Reviewed by Darin.
@@ -13226,7 +13152,7 @@ Source::
Reviewed by Chris.
- - fixed 3224690 - REGRESSION: Download related errors aren't preserved across launches
+ - fixed 3224690 - REGRESSION: Download related errors aren't preserved across launches
* WebKit.pbproj/project.pbxproj: Install WebKitErrorsPrivate.h as SPI.
@@ -13234,7 +13160,7 @@ Source::
Reviewed by Trey.
- - fixed 3224622 -- REGRESSION: in an empty window, repeated tabs don't cycle back to location field
+ - fixed 3224622 -- REGRESSION: in an empty window, repeated tabs don't cycle back to location field
Added logic to WebFrameView's next/previous that matches the logic in WebHTMLView.
Looking for a better solution some day to the whole nextKeyView thing.
@@ -13252,20 +13178,20 @@ Source::
Reviewed by Darin.
- Another launch time speedup - don't load the WebKit WebError
- strings until we actually make a WebKit error. This prevents the
- WebKit localized strings file from being loaded during normal startup.
+ Another launch time speedup - don't load the WebKit WebError
+ strings until we actually make a WebKit error. This prevents the
+ WebKit localized strings file from being loaded during normal startup.
* Downloads.subproj/WebDownload.m:
(+[WebDownloadPrivate initialize]): Don't register WebKit errors.
(-[WebDownload _errorWithCode:]): Use _webKitErrorWithCode:failingURL:
* Misc.subproj/WebKitErrors.m:
(+[WebError _webKitErrorWithCode:failingURL:]): Wrapper that registers the
- WebKit error codes first.
+ WebKit error codes first.
* Misc.subproj/WebKitErrorsPrivate.h:
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]): Use
- _webKitErrorWithCode:failingURL:
+ _webKitErrorWithCode:failingURL:
(-[WebFrame _loadItem:withLoadType:]): Use _webKitErrorWithCode:failingURL:
* WebView.subproj/WebFrameView.m:
* WebView.subproj/WebMainResourceClient.m:
@@ -13273,7 +13199,7 @@ Source::
2003-04-10 Chris Blumenberg <cblu at apple.com>
- Fixed: 3222896 - REGRESSION: sound plays after closing a window with a RealPlayer plug-in in it
+ Fixed: 3222896 - REGRESSION: sound plays after closing a window with a RealPlayer plug-in in it
Reviewed by darin.
@@ -13312,15 +13238,15 @@ Source::
2003-04-09 Trey Matteson <trey at apple.com>
- 3223413 - crash in [CompletionController controlTextDidChange] at travelocity.com
+ 3223413 - crash in [CompletionController controlTextDidChange] at travelocity.com
- This was a great one to get steps for repro - it has shown up at least twice before.
+ This was a great one to get steps for repro - it has shown up at least twice before.
- The problem is that when there is a focused TextField within a frame, the proper
- FormDelegate messages were not being sent on refresh or b/f. The cause was that
- the FirstResponder would be reset in the middle of detaching the frame, at which point
- our object graph was already half taken apart. Fix is to detect that case before
- doing the detach work, and endEditing explicitly.
+ The problem is that when there is a focused TextField within a frame, the proper
+ FormDelegate messages were not being sent on refresh or b/f. The cause was that
+ the FirstResponder would be reset in the middle of detaching the frame, at which point
+ our object graph was already half taken apart. Fix is to detect that case before
+ doing the detach work, and endEditing explicitly.
Reviewed by Darin.
@@ -13328,7 +13254,7 @@ Source::
* Misc.subproj/WebKitLogging.h:
* Misc.subproj/WebKitLogging.m: New FormDelegate logging category.
* WebCoreSupport.subproj/WebBridge.m:
- All changes in here are just calling LOG for the new category.
+ All changes in here are just calling LOG for the new category.
(-[WebBridge controlTextDidBeginEditing:]):
(-[WebBridge controlTextDidEndEditing:]):
(-[WebBridge controlTextDidChange:]):
@@ -13362,21 +13288,20 @@ Source::
Reviewed by Chris, Trey, Darin and Don.
- - fixed 3223568 - site icons lost when moving from older Safari to 71
+ - fixed 3223568 - site icons lost when moving from older Safari to 71
* Misc.subproj/WebIconDatabase.m:
(-[WebIconDatabase _createFileDatabase]): Rename old database containing directory to
- new, so we carry over old databases. The format is forward but not backward compatible.
+ new, so we carry over old databases. The format is forward but not backward compatible.
(-[WebIconDatabase _loadIconDictionaries]): Treat no version at all as version 1, so we
- can load old-style databases.
+ can load old-style databases.
- Reviewed by Trey.
+ Reviewed by Trey.
- * English.lproj/StringsNotToBeLocalized.txt: Updated.
-
+ * English.lproj/StringsNotToBeLocalized.txt: Updated.
2003-04-09 Chris Blumenberg <cblu at apple.com>
- Fixed: 3223022 - Plug-in content bleeds onto frontmost tab
+ Fixed: 3223022 - Plug-in content bleeds onto frontmost tab
Reviewed by darin.
@@ -13385,10 +13310,10 @@ Source::
2003-04-08 Trey Matteson <trey at apple.com>
- 3221355 document is numb to clicks after going back
+ 3221355 document is numb to clicks after going back
- The layoutTimer now does a layout if the doc is in state Completed,
- in addition to LayoutAcceptable.
+ The layoutTimer now does a layout if the doc is in state Completed,
+ in addition to LayoutAcceptable.
Reviewed by Richard.
@@ -13397,10 +13322,10 @@ Source::
2003-04-08 Chris Blumenberg <cblu at apple.com>
- Fixed: 3221128 - Double grey lines on macromedia.com home page
+ Fixed: 3221128 - Double grey lines on macromedia.com home page
- Flash relies on the ordering of attributes in the EMBED tag (which is really stupid). salign must come after scale.
- Changed our plug-in API's to preserve orderings using arrays rather than lose orderings when using dictionaries.
+ Flash relies on the ordering of attributes in the EMBED tag (which is really stupid). salign must come after scale.
+ Changed our plug-in API's to preserve orderings using arrays rather than lose orderings when using dictionaries.
Reviewed by trey.
@@ -13415,7 +13340,7 @@ Source::
2003-04-08 Chris Blumenberg <cblu at apple.com>
- Fixed: 3220463 - REGRESSION: PDF viewer plug-in does not display (worked in 69 and previous)
+ Fixed: 3220463 - REGRESSION: PDF viewer plug-in does not display (worked in 69 and previous)
Reviewed by darin.
@@ -13428,9 +13353,9 @@ Source::
2003-04-07 Chris Blumenberg <cblu at apple.com>
- Fixed: 3206018 - REGRESSION: Clicks on the BBC news ticker applet don't open story in new window
+ Fixed: 3206018 - REGRESSION: Clicks on the BBC news ticker applet don't open story in new window
- MSIE and Netscape for Windows treat a nil target as _top. Since this is usually the target audience of applet developers, we will mimic this. This makes 3206018 behave as expected.
+ MSIE and Netscape for Windows treat a nil target as _top. Since this is usually the target audience of applet developers, we will mimic this. This makes 3206018 behave as expected.
Reviewed by gramps.
@@ -13471,11 +13396,11 @@ Source::
Reviewed by Richard.
- - fixed 3219584 - REGRESSION: launch times appear slower in v71
+ - fixed 3219584 - REGRESSION: launch times appear slower in v71
* WebView.subproj/WebView.m:
(+[WebView canShowMIMEType:]): Avoid loading plugin database if we
- can find a view without doing so.
+ can find a view without doing so.
2003-04-07 Darin Adler <darin at apple.com>
@@ -13503,17 +13428,16 @@ Source::
Reviewed by Trey.
- - fixed 3188914 - loop checking for Flash at http://www.scottsmind.com/celebrity_defacer/index.php
-
+ - fixed 3188914 - loop checking for Flash at http://www.scottsmind.com/celebrity_defacer/index.php
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Take a mutable request,
- and make sure to set referrer to the frame URL (as other browsers do).
+ and make sure to set referrer to the frame URL (as other browsers do).
(-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): pass an NSMutableURLRequest.
(-[WebBaseNetscapePluginView getURL:target:]): Likewise.
(-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
- If the plug-in passes a Content-Length header, take it out of the
- headers and truncate the content appropriately to make
- WebFoundation happy.
+ If the plug-in passes a Content-Length header, take it out of the
+ headers and truncate the content appropriately to make
+ WebFoundation happy.
2003-04-03 Richard Williamson <rjw at apple.com>
@@ -13528,9 +13452,9 @@ Source::
2003-04-03 Trey Matteson <trey at apple.com>
- 3218212 REGRESSION: page on screen draws ugly while printing is happening
+ 3218212 REGRESSION: page on screen draws ugly while printing is happening
- Turn autodisplay of the window off while we print.
+ Turn autodisplay of the window off while we print.
Reviewed by Darin.
@@ -13542,22 +13466,21 @@ Source::
Reviewed by Trey.
- - removed no-longer forwarding of become/resignFirstResponder
-
+ - removed no-longer forwarding of become/resignFirstResponder
* WebView.subproj/WebHTMLViewPrivate.m: Removed
- become/resignFirstResponder poses for WebNSTextView.
+ become/resignFirstResponder poses for WebNSTextView.
2003-04-03 Maciej Stachowiak <mjs at apple.com>
Reviewed by Richard and Don.
- - fixed 3218262 - REGRESSION: Page address becomes about:blank when command-clicking bookmark to load tab
+ - fixed 3218262 - REGRESSION: Page address becomes about:blank when command-clicking bookmark to load tab
* WebView.subproj/WebDataProtocol.m:
- (-[NSURLRequest _webDataRequestParametersForWriting]): Renamed
- from _webDataRequestParameters.
+ (-[NSURLRequest _webDataRequestParametersForWriting]): Renamed
+ from _webDataRequestParameters.
(-[NSURLRequest _webDataRequestParametersForReading]): Like the
- above, but make sure nto to create the part if it does not exist.
+ above, but make sure nto to create the part if it does not exist.
(-[NSURLRequest _webDataRequestData]): Use _webDataRequestParametersForReading.
(-[NSURLRequest _webDataRequestEncoding]): Likewise.
(-[NSURLRequest _webDataRequestBaseURL]): Likewise.
@@ -13586,14 +13509,14 @@ Source::
2003-04-03 Trey Matteson <trey at apple.com>
- 3067928 - printing should not break lines in half
+ 3067928 - printing should not break lines in half
- This is just glue to call the right piece in WebCore.
+ This is just glue to call the right piece in WebCore.
Reviewed by Darin.
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
- Defer to WebCore to set pagination boundary.
+ Defer to WebCore to set pagination boundary.
2003-04-03 Richard Williamson <rjw at apple.com>
@@ -13629,11 +13552,11 @@ Source::
Reviewed by Trey.
- - fixed 3213556 - VIP: parent.mainFrameWidth=undefined on page refresh results in missing content
+ - fixed 3213556 - VIP: parent.mainFrameWidth=undefined on page refresh results in missing content
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _loadItem:withLoadType:]): When reload or going back/forward,
- make sure to load the original URL of the item, not it's most recent URL.
+ make sure to load the original URL of the item, not it's most recent URL.
(-[WebFrame _loadURL:intoChild:]): Likewise.
2003-04-02 Richard Williamson <rjw at apple.com>
@@ -13712,10 +13635,10 @@ Source::
Reviewed by Ken.
- - fixed 3177183 - disneyland.com says "500 Internal Server Error"
+ - fixed 3177183 - disneyland.com says "500 Internal Server Error"
* WebView.subproj/WebUserAgentSpoofTable.gperf: Spoof as Mac IE
- for disney.go.com
+ for disney.go.com
* WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.
2003-04-02 Richard Williamson <rjw at apple.com>
@@ -13745,38 +13668,38 @@ Source::
2003-04-01 Trey Matteson <trey at apple.com>
- 3174227 - aggressive caching of generated pages causes problems with WIKI
+ 3174227 - aggressive caching of generated pages causes problems with WIKI
- We decided to fix half the observed behavior, as all the bad behavior is
- arguably due to a mis-configured server (that sets a max-age=60 on
- all its pages).
+ We decided to fix half the observed behavior, as all the bad behavior is
+ arguably due to a mis-configured server (that sets a max-age=60 on
+ all its pages).
- The fix is that when a redirect comes in response to a POST we force a
- load from origin, since this is a common technique sites do to prevent
- a post from ending up in the b/f list, and it is very likely you are
- on your way back to look at data that you believe you just edited.
+ The fix is that when a redirect comes in response to a POST we force a
+ load from origin, since this is a common technique sites do to prevent
+ a post from ending up in the b/f list, and it is very likely you are
+ on your way back to look at data that you believe you just edited.
Reviewed by Ken.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _loadItem:withLoadType:]): Nit cleanup. Remove unused arg.
(-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
- Same nit cleanup.
+ Same nit cleanup.
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient connection:willSendRequest:redirectResponse:]):
- Force loadFromOrigin if we have a redirect in response to a POST.
+ Force loadFromOrigin if we have a redirect in response to a POST.
* WebView.subproj/WebResourceLoadDelegate.h:
- Add headerdoc comment for redirectResponse param.
+ Add headerdoc comment for redirectResponse param.
2003-04-01 Maciej Stachowiak <mjs at apple.com>
Reviewed by Richard.
- - fixed 3214748 - REGRESSION: After using latest Safari for awhile, can't launch older Safaris (icon db problem)
+ - fixed 3214748 - REGRESSION: After using latest Safari for awhile, can't launch older Safaris (icon db problem)
* Misc.subproj/WebIconDatabase.m:
- Changed icon cache path, since we are breaking compatibility and the old version
- does not support versioning.
+ Changed icon cache path, since we are breaking compatibility and the old version
+ does not support versioning.
(-[WebIconDatabase _loadIconDictionaries]): Check version.
(-[WebIconDatabase _updateFileDatabase]): Save version.
@@ -13810,8 +13733,8 @@ Source::
Reviewed by John.
- - fixed 3213918 -- REGRESSION: printing Mapquest directions, screen font is used, causing exception, crashes
- - fixed 3144287 -- CSS with media=print not used when printing
+ - fixed 3213918 -- REGRESSION: printing Mapquest directions, screen font is used, causing exception, crashes
+ - fixed 3144287 -- CSS with media=print not used when printing
* WebView.subproj/WebFramePrivate.m: (-[WebFrame _opened]): Don't call the reapplyStyles
method directly here, use setNeedsToApplyStyles instead.
@@ -13871,14 +13794,14 @@ Source::
2003-03-31 Trey Matteson <trey at apple.com>
- 3212724 - bookmarks and history items have screwed up designated inits
+ 3212724 - bookmarks and history items have screwed up designated inits
- and support code for:
- 3116315 - autocomplete needs some prioritization magic
+ and support code for:
+ 3116315 - autocomplete needs some prioritization magic
- The main changes are adding and maintaining a visitCount to the HistoryItem,
- cleaning up the init methods of HistoryItem. Also lastVisitedDate is now
- set explicitly instead of automatically getting the current date.
+ The main changes are adding and maintaining a visitCount to the HistoryItem,
+ cleaning up the init methods of HistoryItem. Also lastVisitedDate is now
+ set explicitly instead of automatically getting the current date.
Reviewed by John.
@@ -13891,12 +13814,12 @@ Source::
(-[WebHistoryItem copyWithZone:]): New.
(-[WebHistoryItem initWithURL:title:]): Call the designated initializer.
(-[WebHistoryItem initWithURL:target:parent:title:]): Call the designated initializer.
- Don't blindly init lastVisitedDate.
+ Don't blindly init lastVisitedDate.
(-[WebHistoryItem setLastVisitedDate:]): Update visitCount too.
(-[WebHistoryItem visitCount]): New getter.
(-[WebHistoryItem setVisitCount:]): New setter.
(-[WebHistoryItem _mergeAutoCompleteHints:]): Combine autocomplete info
- of two items. Used when one item replaces another in the history.
+ of two items. Used when one item replaces another in the history.
(-[WebHistoryItem dictionaryRepresentation]): Write visitCount.
(-[WebHistoryItem initFromDictionaryRepresentation:]): Read visitCount.
* History.subproj/WebHistoryItemPrivate.h:
@@ -13910,7 +13833,7 @@ Source::
(-[WebHistoryPrivate _loadHistoryGuts:]): Skip history items without visitDate.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _transitionToCommitted:]): Update last visitTime when we revisit
- the same URL (since no new history item is created).
+ the same URL (since no new history item is created).
2003-03-31 Richard Williamson <rjw at apple.com>
@@ -13926,13 +13849,12 @@ Source::
Reviewed by Chris.
- - fixed 3210813 - REGRESSION: full size stock chart on etrade shows up empty after viewing mini stock chart
+ - fixed 3210813 - REGRESSION: full size stock chart on etrade shows up empty after viewing mini stock chart
- I fixed this by adding a "negative cache" of icon URLs that loaded
- something but failed to yield an icon. This prevents us from
- asking for the site icon over and over, which was messing up the
- session cookie.
-
+ I fixed this by adding a "negative cache" of icon URLs that loaded
+ something but failed to yield an icon. This prevents us from
+ asking for the site icon over and over, which was messing up the
+ session cookie.
* Misc.subproj/WebIconDatabase.m:
(-[WebIconDatabase init]):
(-[WebIconDatabase iconForURL:withSize:cache:]):
@@ -14002,10 +13924,10 @@ Source::
2003-03-29 Chris Blumenberg <cblu at apple.com>
- Fixed: 3178058 - Plug-ins are stopped/reloaded when switching tabs
- Made the "Enable plug-ins" preference toggle in real-time again.
+ Fixed: 3178058 - Plug-ins are stopped/reloaded when switching tabs
+ Made the "Enable plug-ins" preference toggle in real-time again.
- No events including null events are sent when a plug-in is in a non-frontmost tab. This causes Flash movies to pause (which is nice) and QT movies to continue to play.
+ No events including null events are sent when a plug-in is in a non-frontmost tab. This causes Flash movies to pause (which is nice) and QT movies to continue to play.
Reviewed by darin.
@@ -14104,16 +14026,16 @@ Source::
Reviewed by Darin.
- - fixed 3204257 - CNN's 'war on iraq' ticker stops on mouseover
+ - fixed 3204257 - CNN's 'war on iraq' ticker stops on mouseover
* WebView.subproj/WebHTMLViewPrivate.h:
* WebView.subproj/WebHTMLViewPrivate.m:
(-[WebHTMLView _updateMouseoverWithEvent:]): When leaving an HTML
- view, tell it that the mouse moved outside everything in the view,
- even accounting for scrolled off portions (otherwise khtml gets
- confused). This makes cross-frame mouse enter/leave work properly.
+ view, tell it that the mouse moved outside everything in the view,
+ even accounting for scrolled off portions (otherwise khtml gets
+ confused). This makes cross-frame mouse enter/leave work properly.
(-[WebHTMLView _clearLastHitViewIfSelf]): Method to clear last hit view,
- so we don't need to retain it.
+ so we don't need to retain it.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView dealloc]): Call _clearLastHitViewIfSelf.
@@ -14127,8 +14049,8 @@ Source::
Reviewed by John
- Imports NSURLConnection private header to access NSURLConnection code
- that did not make the API cut.
+ Imports NSURLConnection private header to access NSURLConnection code
+ that did not make the API cut.
* WebView.subproj/WebBaseResourceHandleDelegate.m:
* WebView.subproj/WebMainResourceClient.m:
@@ -14142,8 +14064,8 @@ Source::
Moved to API-approved model for synchronous loads.
Removed fixme I put in yesterday having to do with
- reposting form data. The feature is fully functional
- again.
+ reposting form data. The feature is fully functional
+ again.
* Plugins.subproj/WebNetscapePluginStream.m:
(-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):
@@ -14163,9 +14085,9 @@ Source::
name have been changed to 'connection'. Some other changes
related to this cosmetic cleanup were done as well.
- As part of this change, I needed to change some 'connection'
- method arguments to 'con' to avoid the name conflict now
- that instance variables are named .connection'.
+ As part of this change, I needed to change some 'connection'
+ method arguments to 'con' to avoid the name conflict now
+ that instance variables are named .connection'.
* Downloads.subproj/WebDownload.m:
(-[WebDownloadPrivate dealloc]):
@@ -14272,14 +14194,14 @@ Source::
Left out a "!" in my last check-in.
- * Plugins.subproj/WebNetscapePluginPackage.m:
+ * Plugins.subproj/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage load]):
2003-03-27 Chris Blumenberg <cblu at apple.com>
- - Allow Netscape plug-ins that don't have resource files to load in Safari.
- - Added more error handling when loading plug-ins.
+ - Allow Netscape plug-ins that don't have resource files to load in Safari.
+ - Added more error handling when loading plug-ins.
Reviewed by darin.
@@ -14290,14 +14212,13 @@ Source::
Reviewed by Darin.
- - fixed 3192344 - nil-deref in KWin::info scrolling amazon while other shopping tabs load
- - fixed 3098365 - Default window size changes as a result of popup windows
- - fixed 3189291 - javascript window.close() closes window, not just originating tab
-
+ - fixed 3192344 - nil-deref in KWin::info scrolling amazon while other shopping tabs load
+ - fixed 3098365 - Default window size changes as a result of popup windows
+ - fixed 3189291 - javascript window.close() closes window, not just originating tab
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge setWindowIsResizable:]): New bridge method, implemented
- by calling window operations delegate.
+ by calling window operations delegate.
(-[WebBridge windowIsResizable]): Likewise.
(-[WebBridge firstResponder]): Likewise.
(-[WebBridge makeFirstResponder:]): Likewise.
@@ -14416,7 +14337,7 @@ Source::
Reviewed by Trey
- Moved to final NSURLResponse and NSHTTPURLResponse API.
+ Moved to final NSURLResponse and NSHTTPURLResponse API.
* Downloads.subproj/WebDownload.m:
* Misc.subproj/WebNSURLResponseExtras.m:
@@ -14625,7 +14546,7 @@ Source::
Reviewed by Trey.
- - fixed 3209091 -- REGRESSION: WebFrameView leak (world leak)
+ - fixed 3209091 -- REGRESSION: WebFrameView leak (world leak)
* WebView.subproj/WebView.m:
(-[WebView _commonInitialization:frameName:groupName:]): Use copy, not retain,
@@ -14641,7 +14562,7 @@ Source::
2003-03-26 Chris Blumenberg <cblu at apple.com>
- Use the private _cfBundle method on NSBundle so we only create 1 bundle per plug-in package class.
+ Use the private _cfBundle method on NSBundle so we only create 1 bundle per plug-in package class.
Reviewed by trey.
@@ -14725,7 +14646,7 @@ Source::
2003-03-25 Chris Blumenberg <cblu at apple.com>
- Fixed: 3135385 - many file types don't work with the QuickTime plugin in Safari
+ Fixed: 3135385 - many file types don't work with the QuickTime plugin in Safari
Reviewed by trey.
@@ -14761,27 +14682,27 @@ Source::
2003-03-25 John Sullivan <sullivan at apple.com>
- - WebKit part of fix for 3141794 -- No scroll bar for the
- "collections" column of the bookmarks window
+ - WebKit part of fix for 3141794 -- No scroll bar for the
+ "collections" column of the bookmarks window
Reviewed by Darin.
* WebView.subproj/WebDynamicScrollBarsView.h:
- replaced disallowsScrolling boolean ivar with separate booleans for
- disallowHorizontalScrolling and disallowVerticalScrolling
+ replaced disallowsScrolling boolean ivar with separate booleans for
+ disallowHorizontalScrolling and disallowVerticalScrolling
* WebView.subproj/WebDynamicScrollBarsView.m:
(-[WebDynamicScrollBarsView updateScrollers]):
- take the two disallow booleans into account separately
+ take the two disallow booleans into account separately
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]),
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]),
(-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]),
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
- new methods, do the obvious
+ new methods, do the obvious
(-[WebDynamicScrollBarsView setAllowsScrolling:]):
- changed to set both ivars
+ changed to set both ivars
(-[WebDynamicScrollBarsView allowsScrolling]):
- changed to return YES if scrolling is allowed in either direction
+ changed to return YES if scrolling is allowed in either direction
* WebKit.exp: exported symbol for WebDynamicScrollBarsView class name
@@ -14789,40 +14710,40 @@ Source::
Reviewed by Richard
- Fixed a bug that could occur in the new immutable/mutable
- request scheme. When opening a javascript window, it was
- possible for a request passed as a method argument to be
- released during the course of a method, particularly
- after that request was passed to willSendRequest:.
- The solution is to ask the data source for its current
- request rather than using the one stored in the method
- argument.
+ Fixed a bug that could occur in the new immutable/mutable
+ request scheme. When opening a javascript window, it was
+ possible for a request passed as a method argument to be
+ released during the course of a method, particularly
+ after that request was passed to willSendRequest:.
+ The solution is to ask the data source for its current
+ request rather than using the one stored in the method
+ argument.
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient startLoading:]):
2003-03-24 Trey Matteson <trey at apple.com>
- Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
- SYMROOT actually work for symbol resolution because they will have the correct
- prebinding address. It also fixes obscure B&I problems with prebinding
- reported by Matt Reda.
+ Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
+ SYMROOT actually work for symbol resolution because they will have the correct
+ prebinding address. It also fixes obscure B&I problems with prebinding
+ reported by Matt Reda.
- Note the reason all this is tricky for our projects is that we have a different
- install location for Jaguar and Panther. The purpose of this arg is to declare
- at link time our eventual location, which allows the prebinding address to be
- found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
- expression within OTHER_LDFLAGS to get a conditional value depending on the
- build train we are in.
+ Note the reason all this is tricky for our projects is that we have a different
+ install location for Jaguar and Panther. The purpose of this arg is to declare
+ at link time our eventual location, which allows the prebinding address to be
+ found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
+ expression within OTHER_LDFLAGS to get a conditional value depending on the
+ build train we are in.
- This can all go away once we only build on Panther and don't embed the
- frameworks inside the Safari.app wrapper.
+ This can all go away once we only build on Panther and don't embed the
+ frameworks inside the Safari.app wrapper.
- In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
- additive instead of overriding, so we have the args we used for B&I in force
- when building outside of B&I.
+ In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
+ additive instead of overriding, so we have the args we used for B&I in force
+ when building outside of B&I.
- Reviewed by Maciej.
+ Reviewed by Maciej.
* WebKit.pbproj/project.pbxproj:
@@ -14830,7 +14751,7 @@ Source::
Reviewed by Darin
- Updated to use NSMutableURLRequest where appropriate.
+ Updated to use NSMutableURLRequest where appropriate.
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView requestWithURLCString:]):
@@ -14871,7 +14792,7 @@ Source::
Reviewed by Dave.
- - fixed 3206803 -- REGRESSION: Lucida Handwriting font doesn't work
+ - fixed 3206803 -- REGRESSION: Lucida Handwriting font doesn't work
* WebCoreSupport.subproj/WebTextRendererFactory.m:
(acceptableChoice): Added. Returns NO if the weight/traits are no good.
@@ -14879,7 +14800,7 @@ Source::
(-[WebTextRendererFactory fontWithFamily:traits:size:]): Use the new functions to judge which
font is good enough. Now it will accept an italic font if that's all we have.
- - fixed 3206904 -- use "Lucida Handwriting" for "cursive" so it works on systems without Classic
+ - fixed 3206904 -- use "Lucida Handwriting" for "cursive" so it works on systems without Classic
* WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):
Change default from "Apple Chancery" to "Lucida Handwriting".
@@ -14890,28 +14811,27 @@ Source::
Reviewed by Richard.
- - made API (actually doc-only) changes needed for 3087535 -
- bugzilla queries come back as downloaded files
+ - made API (actually doc-only) changes needed for 3087535 -
+ bugzilla queries come back as downloaded files
- * Downloads.subproj/WebDownload.h: Documented that
- download:didReceiveResponse: may be sent more than once.
+ * Downloads.subproj/WebDownload.h: Documented that
+ download:didReceiveResponse: may be sent more than once.
* WebView.subproj/WebLocationChangeDelegate.h: Documented that
- locationChangeCommittedForDataSource: may be sent more than once.
- * WebView.subproj/WebPolicyDelegate.h: Documented that
- decideContentPolicyForMIMEType:andRequest:inFrame: may be sent
- more than once.
+ locationChangeCommittedForDataSource: may be sent more than once.
+ * WebView.subproj/WebPolicyDelegate.h: Documented that
+ decideContentPolicyForMIMEType:andRequest:inFrame: may be sent
+ more than once.
* WebView.subproj/WebResourceLoadDelegate.h: Documented that
- resource:didReceiveResponse:fromDataSource: may be sent more than
- once.
+ resource:didReceiveResponse:fromDataSource: may be sent more than
+ once.
2003-03-24 Maciej Stachowiak <mjs at apple.com>
Reviewed by Richard.
- - fixed 3083339 - significant top and side margin appended to new windows
+ - fixed 3083339 - significant top and side margin appended to new windows
- Part of the fix involves adding new window operation delegate methods.
-
+ Part of the fix involves adding new window operation delegate methods.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge setWindowFrame:]): Tweaked code a bit.
(-[WebBridge windowFrame]): Added.
@@ -14924,8 +14844,8 @@ Source::
2003-03-24 Chris Blumenberg <cblu at apple.com>
- Fixed: 3155489 - Seed: PostScript files display instead of downloading, often as a blank page
- Fixed: 3106251 - quicken file not downloaded, can't save manually
+ Fixed: 3155489 - Seed: PostScript files display instead of downloading, often as a blank page
+ Fixed: 3106251 - quicken file not downloaded, can't save manually
Reviewed by trey.
@@ -15169,8 +15089,8 @@ Source::
2003-03-21 Chris Blumenberg <cblu at apple.com>
- Fixed: 3081681 - text/calendar should be downloaded instead of displayed
- Fixed: 3177603 - vCards appear in browser, not downloaded
+ Fixed: 3081681 - text/calendar should be downloaded instead of displayed
+ Fixed: 3177603 - vCards appear in browser, not downloaded
Reviewed by darin.
@@ -15268,7 +15188,7 @@ Source::
2003-03-20 Chris Blumenberg <cblu at apple.com>
- Properly handle file URL directory errors.
+ Properly handle file URL directory errors.
Reviewed by trey.
@@ -15279,7 +15199,7 @@ Source::
2003-03-20 Vicki Murley <vicki at apple.com>
- don't include WebFoundation.h
+ don't include WebFoundation.h
Reviewed by cblu.
@@ -15297,7 +15217,7 @@ Source::
Reviewed by Richard.
- React to WebView API changes. Redo HIWebView API.
+ React to WebView API changes. Redo HIWebView API.
* Carbon.subproj/HIWebView.h:
* Carbon.subproj/HIWebView.m:
@@ -15379,20 +15299,20 @@ Source::
Reviewed by Trey.
- - fixed 3127431 - bring the window with the named frame to the front
+ - fixed 3127431 - bring the window with the named frame to the front
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge focusWindow]): Tell the window operations delegate to focus.
(-[WebBridge loadURL:referrer:reload:target:triggeringEvent:form:formValues:]):
- If this navigation is meant for a different frame, focus its window.
+ If this navigation is meant for a different frame, focus its window.
(-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
- Likewise.
+ Likewise.
2003-03-18 Trey Matteson <trey at apple.com>
- 3077223 full keyboard UI navigation fails in authentication sheet
+ 3077223 full keyboard UI navigation fails in authentication sheet
- Hook up the views in this panel into a useful nextKeyView cycle.
+ Hook up the views in this panel into a useful nextKeyView cycle.
Reviewed by Maciej.
@@ -15400,35 +15320,35 @@ Source::
2003-03-17 Trey Matteson <trey at apple.com>
- Support for saving passwords on forms-based logins. Biggest change is that
- the willSubmitForm: message is async to allow a sheet to be presented.
+ Support for saving passwords on forms-based logins. Biggest change is that
+ the willSubmitForm: message is async to allow a sheet to be presented.
- Also fixed @interface.*{ so prepare-change-log can swallow WebFramePrivate.m.
+ Also fixed @interface.*{ so prepare-change-log can swallow WebFramePrivate.m.
Reviewed by Maciej.
* WebView.subproj/WebControllerPolicyDelegate.m:
(-[WebPolicyDecisionListener continue]): The decision listener also
- implements WebFormSubmissionListener, to share some other impl.
+ implements WebFormSubmissionListener, to share some other impl.
* WebView.subproj/WebControllerPolicyDelegatePrivate.h:
* WebView.subproj/WebFormDelegate.h:
* WebView.subproj/WebFormDelegate.m:
(-[WebFormDelegate frame:willSubmitForm:withValues:submissionListener:]):
- Take listener param for async API.
+ Take listener param for async API.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
- Latent bug. Don't call willSubmitForm if no values are being submitted.
+ Latent bug. Don't call willSubmitForm if no values are being submitted.
(-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
- Latent bug. Don't call willSubmitForm if no values are being submitted.
+ Latent bug. Don't call willSubmitForm if no values are being submitted.
(-[WebFrame _continueAfterWillSubmitForm:]):
- Continuation code for after FormDelegate is done with willSubmitForm.
+ Continuation code for after FormDelegate is done with willSubmitForm.
(-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
- Pass new listener arg to willSubmitForm.
+ Pass new listener arg to willSubmitForm.
* WebView.subproj/WebHTMLRepresentation.h:
* WebView.subproj/WebHTMLRepresentation.m:
- Nuke deadwood formIsLoginForm.
+ Nuke deadwood formIsLoginForm.
(-[WebHTMLRepresentation elementIsPassword:]): Just pass through glue
- over the bridge.
+ over the bridge.
2003-03-18 Richard Williamson <rjw at apple.com>
@@ -15713,7 +15633,7 @@ Source::
Reviewed by Richard.
- - fixed 3194756 -- REGRESSION: Geneva bold yields Geneva plain, used to yield Helvetica bold (apple.com)
+ - fixed 3194756 -- REGRESSION: Geneva bold yields Geneva plain, used to yield Helvetica bold (apple.com)
* WebCoreSupport.subproj/WebTextRendererFactory.m:
(-[WebTextRendererFactory fontWithFamily:traits:size:]):
@@ -15722,8 +15642,7 @@ Source::
2003-03-17 Chris Blumenberg <cblu at apple.com>
- Fixed: 3200647 - File I/O related download errors just says "error"
-
+ Fixed: 3200647 - File I/O related download errors just says "error"
Reviewed by darin.
* Downloads.subproj/WebDownload.m:
@@ -15753,7 +15672,7 @@ Source::
2003-03-17 Chris Blumenberg <cblu at apple.com>
- Made data categories use the "_web_" prefix.
+ Made data categories use the "_web_" prefix.
Reviewed by darin.
@@ -15764,8 +15683,8 @@ Source::
2003-03-17 Chris Blumenberg <cblu at apple.com>
- Fixed: 3199105 - Accept carbon-style file URLs from plug-in POST requests
- Fixed: 3148767 - POST (aka Flash Remoting) doesn't work from Flash
+ Fixed: 3199105 - Accept carbon-style file URLs from plug-in POST requests
+ Fixed: 3148767 - POST (aka Flash Remoting) doesn't work from Flash
Reviewed by kocienda.
@@ -15780,18 +15699,18 @@ Source::
Reviewed by Darin.
- - fixed 3200259 - REGRESSION: Clicking on Flash links at homestarrunner.com creates blank windows
+ - fixed 3200259 - REGRESSION: Clicking on Flash links at homestarrunner.com creates blank windows
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView loadPluginRequest:]): Don't always
- make the window, only do it if the frame doesn't already
- exist. Duh.
+ make the window, only do it if the frame doesn't already
+ exist. Duh.
2003-03-17 Darin Adler <darin at apple.com>
Reviewed by Trey and Maciej.
- - fixed 3199154 -- REGRESSION: world leaks on any page load test
+ - fixed 3199154 -- REGRESSION: world leaks on any page load test
* WebView.subproj/WebController.m: (-[WebController initWithView:frameName:groupName:]):
Call through to initWithFrame, the designated initializer, not init. Calling [super init] results
@@ -15801,8 +15720,7 @@ Source::
Reviewed by Trey.
- Adjusted for WebFoundation API changes.
-
+ Adjusted for WebFoundation API changes.
* Panels.subproj/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForRequest:]):
@@ -15812,9 +15730,9 @@ Source::
2003-03-17 Chris Blumenberg <cblu at apple.com>
- Fixed: 3199951 - Standalone plug-in content that is cancelled doesn't restart when switching tabs
+ Fixed: 3199951 - Standalone plug-in content that is cancelled doesn't restart when switching tabs
- Instead of creating and managing resourceData in WebMainResourceClient then passing the ownership to WebDataSource, just manage it in WebDataSource. We had the prior behavior because we didn't buffer downloads. Now, we always buffer. The fix for the bug
+ Instead of creating and managing resourceData in WebMainResourceClient then passing the ownership to WebDataSource, just manage it in WebDataSource. We had the prior behavior because we didn't buffer downloads. Now, we always buffer. The fix for the bug
@@ -15840,11 +15758,11 @@ is to retain the incomplete data even though the load ends in error.
2003-03-16 Trey Matteson <trey at apple.com>
- 3198135 - need to fix our projects so SYMROOT is not stripped
+ 3198135 - need to fix our projects so SYMROOT is not stripped
- Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
- Deployment build still does.
- We strip manually as part of the install that we do ourselves.
+ Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
+ Deployment build still does.
+ We strip manually as part of the install that we do ourselves.
Reviewed by Maciej.
@@ -15852,7 +15770,7 @@ is to retain the incomplete data even though the load ends in error.
2003-03-14 Chris Blumenberg <cblu at apple.com>
- Backed out changes to WebBaseNetscapePluginView. Unintentional commit.
+ Backed out changes to WebBaseNetscapePluginView. Unintentional commit.
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]):
@@ -15860,7 +15778,7 @@ is to retain the incomplete data even though the load ends in error.
2003-03-14 Chris Blumenberg <cblu at apple.com>
- Fixed: 3198961 - REGRESSION: Stopping load of plug-in content is not reflected in UI
+ Fixed: 3198961 - REGRESSION: Stopping load of plug-in content is not reflected in UI
Reviewed by mjs.
@@ -15871,17 +15789,16 @@ is to retain the incomplete data even though the load ends in error.
Reviewed by Don.
- - revert premature controller --> webView renaming, it's causing
- problems with window opening and such.
-
+ - revert premature controller --> webView renaming, it's causing
+ problems with window opening and such.
* WebView.subproj/WebDefaultWindowOperationsDelegate.m:
2003-03-14 Chris Blumenberg <cblu at apple.com>
- Fixed: 3197872 - Standalone plug-in content isn't restarted when switching tabs
- Fixed: 3189675 - assertion in plug-in code fails (nil window) with .swf page displaying standalone in a tab
+ Fixed: 3197872 - Standalone plug-in content isn't restarted when switching tabs
+ Fixed: 3189675 - assertion in plug-in code fails (nil window) with .swf page displaying standalone in a tab
- We start plug-ins when they are added to the window and stop them when they are removed. To restart a plug-in, the data stream must be redelivered. This works in the embedded plug-in case, but in the standalone plug-in case, the stream is delivered by th
+ We start plug-ins when they are added to the window and stop them when they are removed. To restart a plug-in, the data stream must be redelivered. This works in the embedded plug-in case, but in the standalone plug-in case, the stream is delivered by th
@@ -15916,13 +15833,13 @@ e machinery in WebKit. The stream is only delivered once. This fix addresses tha
Reviewed by Trey.
- - fixed 3188209 - REGRESSION: onmouseup handlers not running for most form elements
+ - fixed 3188209 - REGRESSION: onmouseup handlers not running for most form elements
* WebCoreSupport.subproj/WebFileButton.m:
(-[WebFileButton chooseButtonPressed:]): Send appropriate NSNotification.
* WebView.subproj/WebHTMLViewPrivate.m:
(-[WebNSTextView mouseDown:]): Call fieldEditorDidMouseDown: on
- delegate, if implemented, after calling super.
+ delegate, if implemented, after calling super.
2003-03-13 Richard Williamson <rjw at apple.com>
@@ -16074,13 +15991,13 @@ e machinery in WebKit. The stream is only delivered once. This fix addresses tha
Reviewed by Trey.
* English.lproj/StringsNotToBeLocalized.txt:
- Removed all the bookmarks-related strings that I forgot
- to remove in my previous checkin.
+ Removed all the bookmarks-related strings that I forgot
+ to remove in my previous checkin.
2003-03-13 John Sullivan <sullivan at apple.com>
- Removed all the bookmarks code from WebKit; put it
- in WebBrowser instead.
+ Removed all the bookmarks code from WebKit; put it
+ in WebBrowser instead.
Reviewed by Darin
@@ -16099,16 +16016,16 @@ e machinery in WebKit. The stream is only delivered once. This fix addresses tha
* Bookmarks.subproj/WebBookmarkProxy.h: Removed.
* Bookmarks.subproj/WebBookmarkProxy.m: Removed.
* WebKit.exp:
- removed all bookmark-related symbols
+ removed all bookmark-related symbols
* WebKit.pbproj/project.pbxproj:
- updated for removed files
+ updated for removed files
=== Safari-67 ===
2003-03-12 Chris Blumenberg <cblu at apple.com>
- 3196673 - REGRESSION: Assertion failure when download fails to create file
- - Retain the download delegate because it will live longer than the WebController which it is an instance of.
+ 3196673 - REGRESSION: Assertion failure when download fails to create file
+ - Retain the download delegate because it will live longer than the WebController which it is an instance of.
Reviewed by rjw.
@@ -16158,11 +16075,11 @@ e machinery in WebKit. The stream is only delivered once. This fix addresses tha
Reviewed by Trey
* English.lproj/StringsNotToBeLocalized.txt:
- updated for recent changes
+ updated for recent changes
2003-03-11 Chris Blumenberg <cblu at apple.com>
- Fixed deployment build failure.
+ Fixed deployment build failure.
* WebView.subproj/WebFramePrivate.m:
@@ -16255,12 +16172,11 @@ e machinery in WebKit. The stream is only delivered once. This fix addresses tha
Reviewed by Richard.
- Final policy API changes:
+ Final policy API changes:
- - changed WebPolicyDecisionListener to protocol in public API
- - replaced policy enum with separate methods
- - made content policy handling async
-
+ - changed WebPolicyDecisionListener to protocol in public API
+ - replaced policy enum with separate methods
+ - made content policy handling async
* WebKit.pbproj/project.pbxproj:
* WebView.subproj/WebControllerPolicyDelegate.h:
* WebView.subproj/WebControllerPolicyDelegate.m:
@@ -16320,12 +16236,11 @@ e machinery in WebKit. The stream is only delivered once. This fix addresses tha
Reviewed by Dave.
- - fixed 3194221 - REGRESSION: search results loaded in wrong frame at directory.apple.com
+ - fixed 3194221 - REGRESSION: search results loaded in wrong frame at directory.apple.com
* WebView.subproj/WebFramePrivate.m:
(_postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:):
- Deliver targetted form posts correctly.
-
+ Deliver targetted form posts correctly.
2003-03-10 Darin Adler <darin at apple.com>
Reviewed by Maciej.
@@ -16343,7 +16258,7 @@ e machinery in WebKit. The stream is only delivered once. This fix addresses tha
2003-03-10 Chris Blumenberg <cblu at apple.com>
- Fixed some download-related leaks. Primarily, we were leaking the data source that started the download. The data source is now immediately released when it becomes a download.
+ Fixed some download-related leaks. Primarily, we were leaking the data source that started the download. The data source is now immediately released when it becomes a download.
Reviewed by darin.
@@ -16380,14 +16295,13 @@ t leak when we cancel a download.
Reviewed by Richard.
- - fixed 3127705 - don't open new window on opt-click even if the link requests it
- - fixed 3143971 - cmd-click should override the target="_blank" and target="_new" (important for tabs)
+ - fixed 3127705 - don't open new window on opt-click even if the link requests it
+ - fixed 3143971 - cmd-click should override the target="_blank" and target="_new" (important for tabs)
- - removed open new window and open new window behind policies
- - removed [WebFrame findOrCreateFrameNamed:] from API
- - remved showWindowBehind from window operations delegate
- - added decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener: delegate method
-
+ - removed open new window and open new window behind policies
+ - removed [WebFrame findOrCreateFrameNamed:] from API
+ - remved showWindowBehind from window operations delegate
+ - added decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener: delegate method
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView loadPluginRequest:]):
(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
@@ -16416,7 +16330,7 @@ t leak when we cancel a download.
2003-03-07 Chris Blumenberg <cblu at apple.com>
- Updated header doc comments.
+ Updated header doc comments.
* Downloads.subproj/WebDownload.h:
@@ -16444,36 +16358,36 @@ t leak when we cancel a download.
2003-03-07 John Sullivan <sullivan at apple.com>
- WebKit part of fixes to these two synching-related bugs:
+ WebKit part of fixes to these two synching-related bugs:
- 3190844 -- Bookmarks Bar and Menu collections need to be
- marked specially in Bookmarks file
+ 3190844 -- Bookmarks Bar and Menu collections need to be
+ marked specially in Bookmarks file
- 3192197 -- Safari should write out UUID-full Bookmarks
- file after reading UUID-free one
+ 3192197 -- Safari should write out UUID-full Bookmarks
+ file after reading UUID-free one
Reviewed by Trey
* Bookmarks.subproj/WebBookmark.h:
* Bookmarks.subproj/WebBookmark.m:
(-[WebBookmark setUUID:]):
- Removed the leading underscore, made this method public.
- Removed unnecessary constraint that new or old UUID had
- to be nil; now short-circuits the no-change case.
+ Removed the leading underscore, made this method public.
+ Removed unnecessary constraint that new or old UUID had
+ to be nil; now short-circuits the no-change case.
(-[WebBookmark copyWithZone:]):
- updated for name change
+ updated for name change
(-[WebBookmark initFromDictionaryRepresentation:withGroup:]):
- ditto
+ ditto
* Bookmarks.subproj/WebBookmarkGroup.h:
* Bookmarks.subproj/WebBookmarkGroup.m:
(-[WebBookmarkGroup bookmarkForUUID:]):
- new public method to find a bookmark from a UUID.
+ new public method to find a bookmark from a UUID.
(-[WebBookmarkGroup _addBookmark:]):
- updated for name change
+ updated for name change
* Bookmarks.subproj/WebBookmarkPrivate.h:
- removed declaration for old _setUUID
+ removed declaration for old _setUUID
2003-03-07 Darin Adler <darin at apple.com>
@@ -16486,8 +16400,8 @@ t leak when we cancel a download.
2003-03-07 Chris Blumenberg <cblu at apple.com>
- Fixed: 3191052 - Predetermined downloads should not be started from the browser window
- - Stripped the rest of WebKit of download related code.
+ Fixed: 3191052 - Predetermined downloads should not be started from the browser window
+ - Stripped the rest of WebKit of download related code.
Reviewed by trey.
@@ -16530,9 +16444,8 @@ l.
Reviewed by Trey.
- Step towards policy API changes. Remove WebPolicyNone,
- WebPolicyRevealInFinder, WebPolicyOpenURL and WebPolicyShow.
-
+ Step towards policy API changes. Remove WebPolicyNone,
+ WebPolicyRevealInFinder, WebPolicyOpenURL and WebPolicyShow.
* WebView.subproj/WebControllerPolicyDelegate.h:
* WebView.subproj/WebDefaultPolicyDelegate.m:
(-[WebDefaultPolicyDelegate decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
@@ -16580,10 +16493,10 @@ l.
2003-03-06 Chris Blumenberg <cblu at apple.com>
- Implemented WebDownload API.
+ Implemented WebDownload API.
- Fixed: 3118355 - Download mechanism that doesn't involve WebDataSource, WebFrame, WebController etc
- Fixed: 3110173 - add per-request disabling of download decoding, use to turn off when "Open Safe Files" is off
+ Fixed: 3118355 - Download mechanism that doesn't involve WebDataSource, WebFrame, WebController etc
+ Fixed: 3110173 - add per-request disabling of download decoding, use to turn off when "Open Safe Files" is off
Reviewed by trey, rjw, mjs.
@@ -16784,9 +16697,8 @@ l.
Reviewed by John.
- Step towards policy API chantes - removed unneeded policy and URL
- arguments from unableToImplementPolicy:
-
+ Step towards policy API chantes - removed unneeded policy and URL
+ arguments from unableToImplementPolicy:
* WebView.subproj/WebControllerPolicyDelegate.h:
* WebView.subproj/WebFramePrivate.h:
* WebView.subproj/WebFramePrivate.m:
@@ -16967,18 +16879,17 @@ l.
* WebView.subproj/WebFramePrivate.m:
(_recursiveGoToItem:fromItem:withLoadType:): Account for
- possibility of nil target.
+ possibility of nil target.
2003-03-05 Maciej Stachowiak <mjs at apple.com>
Reviewed by Darin.
- - fixed crash when going back due to frame name of nil since we
- don't force the name "_top" any more.
-
+ - fixed crash when going back due to frame name of nil since we
+ don't force the name "_top" any more.
* WebView.subproj/WebController.m:
(-[WebController _goToItem:withLoadType:]): Handle nil target
- properly.
+ properly.
2003-03-05 Darin Adler <darin at apple.com>
@@ -16991,54 +16902,51 @@ l.
2003-03-04 Trey Matteson <trey at apple.com>
- Support for autofill. These are just two new glue routines
- that call down through the bridge. They allow regexp driven
- binding of AB data to form elements.
+ Support for autofill. These are just two new glue routines
+ that call down through the bridge. They allow regexp driven
+ binding of AB data to form elements.
Reviewed by Maciej.
* WebView.subproj/WebHTMLRepresentation.h:
* WebView.subproj/WebHTMLRepresentation.m:
(-[WebHTMLRepresentation searchForLabels:beforeElement:]):
- Call straight to bridge.
+ Call straight to bridge.
(-[WebHTMLRepresentation matchLabels:againstElement:]):
- Call straight to bridge.
+ Call straight to bridge.
2003-03-04 Maciej Stachowiak <mjs at apple.com>
- Reinstate missing part of last checking.
-
+ Reinstate missing part of last checking.
* WebView.subproj/WebFramePrivate.m:
2003-03-04 Maciej Stachowiak <mjs at apple.com>
Reviewed by Trey.
- Added the ability to set the top-level frame name via the
- WebController initializer. Also made [[controller mainFrame]
- frameName] return the true top-level frame name instead of "_top",
- since that is already special-cased anywhere it needs to be.
-
+ Added the ability to set the top-level frame name via the
+ WebController initializer. Also made [[controller mainFrame]
+ frameName] return the true top-level frame name instead of "_top",
+ since that is already special-cased anywhere it needs to be.
* WebView.subproj/WebController.h:
* WebView.subproj/WebController.m:
(-[WebController init]): Update for change to designated initializer.
(-[WebController initWithView:]): New convenience initializer.
(-[WebController initWithView:frameName:setName:]): Added ability to set
- top-level frame name.
+ top-level frame name.
* WebView.subproj/WebControllerPrivate.h:
* WebView.subproj/WebControllerPrivate.m:
(-[WebControllerPrivate dealloc]): Remove topLevelFrameNAme field.
(-[WebController _setTopLevelFrameName:]): Actually set it
- on the top level frame, no point to keeping it here.
+ on the top level frame, no point to keeping it here.
(-[WebController _findFrameInThisWindowNamed:]): No more need to
- special-case top-level frame name.
+ special-case top-level frame name.
* WebView.subproj/WebFrame.m:
(-[WebFrame initWithName:webView:controller:]): call [self _setName:] instead
- of [_private setName:]
+ of [_private setName:]
* WebView.subproj/WebFramePrivate.h:
* WebView.subproj/WebFramePrivate.m:
- (-[WebFrame _setName:]): Don't let the name get set to _blank.
-
+ (-[WebFrame _setName:]): Don't let the name get set to _blank.
2003-03-04 John Sullivan <sullivan at apple.com>
Reviewed by Darin
@@ -17046,9 +16954,9 @@ l.
* Misc.subproj/WebKitNSStringExtras.h:
* Misc.subproj/WebKitNSStringExtras.m:
(-[NSString _web_widthWithFont:]):
- (-[NSString _web_drawAtPoint:font:textColor:):
- removed the unnecessary string parameter from these two
- NSString methods.
+ (-[NSString _web_drawAtPoint:font:textColor:):
+ removed the unnecessary string parameter from these two
+ NSString methods.
2003-03-04 Darin Adler <darin at apple.com>
@@ -17225,23 +17133,23 @@ l.
Reviewed by Darin.
- - fixed 3163855 - Need control over certain potential dialogs/sheets
+ - fixed 3163855 - Need control over certain potential dialogs/sheets
* WebCoreSupport.subproj/WebBridge.h:
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge runJavaScriptAlertPanelWithMessage:]): Moved here from
- view factory. Call the bridge instead of popping up the dialog.
+ view factory. Call the bridge instead of popping up the dialog.
(-[WebBridge runJavaScriptConfirmPanelWithMessage:]): Likewise.
(-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]):
- Likewise.
- (-[WebBridge fileButton]): Moved here from view factory, so we can
- pass the bridge to the button.
+ Likewise.
+ (-[WebBridge fileButton]): Moved here from view factory, so we can
+ pass the bridge to the button.
(-[WebBridge runOpenPanelForFileButtonWithResultListener:]): Call the delegate.
* WebCoreSupport.subproj/WebFileButton.h:
* WebCoreSupport.subproj/WebFileButton.m:
(-[WebFileButton initWithBridge:]): New method so this object knows about the bridge.
(-[WebFileButton beginSheet]): Instead of popping up the sheet directly,
- call the bridge (which will call the delegate).
+ call the bridge (which will call the delegate).
(-[WebFileButton chooseFilename:]): Update for the new filename.
(-[WebFileButton cancel]): Do nothing.
* WebCoreSupport.subproj/WebViewFactory.m: Removed some methods.
@@ -17274,22 +17182,22 @@ l.
7003-02-28 Trey Matteson <trey at apple.com>
- Various support for autofill/autocomplete.
+ Various support for autofill/autocomplete.
- We receive a form along with the formValues from WC on submit, which we
- just pass along to the FormDelegate. As part of this we store the values
- and the form together in a new private WebFormState class. Lots of glue
- for passing this around instead of just the values dict.
+ We receive a form along with the formValues from WC on submit, which we
+ just pass along to the FormDelegate. As part of this we store the values
+ and the form together in a new private WebFormState class. Lots of glue
+ for passing this around instead of just the values dict.
- Send willCloseLocationForDataSource when we are finally through with a page.
+ Send willCloseLocationForDataSource when we are finally through with a page.
Reviewed by Darin.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge loadURL:reload:triggeringEvent:form:formValues:]):
- Pass along form along with values
+ Pass along form along with values
(-[WebBridge postWithURL:data:contentType:triggeringEvent:form:formValues:]):
- Pass along form along with values
+ Pass along form along with values
* WebView.subproj/WebDataSourcePrivate.m:
(-[WebDataSource _commitIfReady:]): Call frame to send willCloseLocationForDataSource.
* WebView.subproj/WebFormDelegate.h:
@@ -17301,9 +17209,9 @@ l.
* WebView.subproj/WebFramePrivate.h:
* WebView.subproj/WebFramePrivate.m:
<<prepare-ChangeLog flailed on this file>>
- Lots of routines were we pass FormState instead of the form values dict
- -([WebFrame _closeOldDataSources]): New, sends willCloseLocation for whole frame tree.
- New, trivial, WebFormState class.
+ Lots of routines were we pass FormState instead of the form values dict
+ -([WebFrame _closeOldDataSources]): New, sends willCloseLocation for whole frame tree.
+ New, trivial, WebFormState class.
* WebView.subproj/WebHTMLRepresentation.h:
* WebView.subproj/WebHTMLRepresentation.m:
(-[WebHTMLRepresentation formIsLoginForm:]): Changed to take form instead of form field.
@@ -17314,37 +17222,36 @@ l.
(-[WebLocationChangeDelegate willCloseLocationForDataSource:]): Default impl.
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient continueAfterNavigationPolicy:formState:]):
- Pass FormState instead of just values.
+ Pass FormState instead of just values.
(-[WebMainResourceClient resource:willSendRequest:]):
- Pass FormState instead of just values.
+ Pass FormState instead of just values.
2003-02-28 Maciej Stachowiak <mjs at apple.com>
Reviewed by Trey.
- - fixed 3180170 - filepile.com does not work correctly
+ - fixed 3180170 - filepile.com does not work correctly
- I fixed this by making referrer work correctly for targetted
- cross-frame and cross-window links. It is still not working right
- for JavaScript window.open though.
-
+ I fixed this by making referrer work correctly for targetted
+ cross-frame and cross-window links. It is still not working right
+ for JavaScript window.open though.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge createWindowWithURL:frameName:]): Set referrer.
(-[WebBridge loadURL:referrer:reload:triggeringEvent:formValues:]): Pass referrer
- along to frame.
+ along to frame.
(-[WebBridge postWithURL:referrer:data:contentType:triggeringEvent:formValues:]):
- Likewise.
+ Likewise.
* WebView.subproj/WebFramePrivate.h:
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _loadItem:fromItem:withLoadType:]): Pass referrer.
- (-[WebFrame
- _loadURL:referrer:loadType:triggeringEvent:formValues:]): Use
- passed-in referrer (link could have been clicked in another
- frame).
+ (-[WebFrame
+ _loadURL:referrer:loadType:triggeringEvent:formValues:]): Use
+ passed-in referrer (link could have been clicked in another
+ frame).
(-[WebFrame _loadURL:intoChild:]): Pass referrer.
(-[WebFrame
- _postWithURL:referrer:data:contentType:triggeringEvent:formValues:]):
- Use passed-in referrer.
+ _postWithURL:referrer:data:contentType:triggeringEvent:formValues:]):
+ Use passed-in referrer.
2003-02-28 Darin Adler <darin at apple.com>
@@ -17371,8 +17278,7 @@ l.
(-[WebBridge window]): Avoid calling removed call.
* WebView.subproj/WebView.m: Remove override of window method.
* WebView.subproj/WebWindowOperationsDelegate.h:
- Adjust for new API.
-
+ Adjust for new API.
=== Safari-64 ===
=== Safari-63 ===
@@ -17381,12 +17287,11 @@ l.
Reviewed by Dave.
- - fixed reproducible hang at http://asp.eltonsoft.dk/cast/get.asp?cat=Quicktime
+ - fixed reproducible hang at http://asp.eltonsoft.dk/cast/get.asp?cat=Quicktime
- WebKit's processing time was O(N^3) in the number of
- frames. Improved it to O(N^2) by storing frame pointer directly in
- WebDataSource instead of linear scan. Could still be improved more.
-
+ WebKit's processing time was O(N^3) in the number of
+ frames. Improved it to O(N^2) by storing frame pointer directly in
+ WebDataSource instead of linear scan. Could still be improved more.
* WebView.subproj/WebDataSource.m:
(-[WebDataSource webFrame]):
* WebView.subproj/WebDataSourcePrivate.h:
@@ -17424,43 +17329,42 @@ l.
2003-02-25 David Hyatt <hyatt at apple.com>
- Fix for bug #3181249. Ensure the padding argument gets passed
- through properly (instead of just passing 0).
-
+ Fix for bug #3181249. Ensure the padding argument gets passed
+ through properly (instead of just passing 0).
Reviewed by darin
* WebCoreSupport.subproj/WebTextRenderer.m:
2003-02-25 John Sullivan <sullivan at apple.com>
- WebKit part of fix for 3181290 -- need call to reload all bookmarks from disk,
- for synching's sake.
+ WebKit part of fix for 3181290 -- need call to reload all bookmarks from disk,
+ for synching's sake.
- I ended up not adding a new call, but making the existing loadBookmarkGroup
- work better when called after the initial load. It wasn't doing anything wrong
- before; it just wasn't passing along enough information to clients to enable
- them to do the right thing.
+ I ended up not adding a new call, but making the existing loadBookmarkGroup
+ work better when called after the initial load. It wasn't doing anything wrong
+ before; it just wasn't passing along enough information to clients to enable
+ them to do the right thing.
Reviewed by Trey
* Bookmarks.subproj/WebBookmarkGroup.h:
- new extern NSStrings WebBookmarksWillBeReloadedNotification and
- WebBookmarksWereReloadedNotification
+ new extern NSStrings WebBookmarksWillBeReloadedNotification and
+ WebBookmarksWereReloadedNotification
* Bookmarks.subproj/WebBookmarkGroup.m:
(-[WebBookmarkGroup _sendNotification:forBookmark:children:]):
- soften assert so it doesn't fire on the new cases.
+ soften assert so it doesn't fire on the new cases.
(-[WebBookmarkGroup _bookmarksWillBeReloaded]):
- send WebBookmarksWillBeReloadedNotification
+ send WebBookmarksWillBeReloadedNotification
(-[WebBookmarkGroup _bookmarksWereReloaded]):
- send WebBookmarksWereReloadedNotification
+ send WebBookmarksWereReloadedNotification
(-[WebBookmarkGroup _loadBookmarkGroupGuts]):
- bracket the load with the new notification-sending calls
+ bracket the load with the new notification-sending calls
* WebKit.exp:
- add the two new extern NSStrings
+ add the two new extern NSStrings
2003-02-25 Darin Adler <darin at apple.com>
@@ -17473,7 +17377,7 @@ l.
2003-02-20 Chris Blumenberg <cblu at apple.com>
- Added _web_superviewOfClass:stoppingAtClass:. Climbs up hierarchy and returns nil when stoppingAtClass is hit.
+ Added _web_superviewOfClass:stoppingAtClass:. Climbs up hierarchy and returns nil when stoppingAtClass is hit.
Reviewed by darin.
@@ -17643,10 +17547,8 @@ l.
2003-02-18 Maciej Stachowiak <mjs at ap0101m-dhcp138.apple.com>
- Reviewed by Chris.
-
- Merged changes from Safari-58-1-branch.
-
+ Reviewed by Chris.
+ Merged changes from Safari-58-1-branch.
2003-02-11 Richard Williamson <rjw at apple.com>
Add import of CGFontCache.h, which is no longer
@@ -17661,8 +17563,7 @@ l.
Reviewed by Darin.
* WebCoreSupport.subproj/WebTextRenderer.m: Change (void **) cast
- to (void *) for compatibility with the latest Panther.
-
+ to (void *) for compatibility with the latest Panther.
2003-02-11 Maciej Stachowiak <mjs at apple.com>
Reviewed by Trey.
@@ -17675,7 +17576,7 @@ l.
Reviewed by Trey
- Rolled in documentation changes from Peter Kelly, our tech writer.
+ Rolled in documentation changes from Peter Kelly, our tech writer.
* History.subproj/WebBackForwardList.h
* History.subproj/WebHistory.h
@@ -17697,8 +17598,7 @@ l.
2003-02-13 Trey Matteson <trey at apple.com>
- 2943514 hide the cursor when using the arrow keys to scroll
-
+ 2943514 hide the cursor when using the arrow keys to scroll
Reviewed by Darin
* WebView.subproj/WebView.m:
@@ -17706,7 +17606,7 @@ l.
2003-02-16 Chris Blumenberg <cblu at apple.com>
- Added debug method that can be used inside of gdb to examine an image. Needed this many times.
+ Added debug method that can be used inside of gdb to examine an image. Needed this many times.
Reviewed by darin.
@@ -17720,25 +17620,24 @@ l.
2003-02-14 David Hyatt <hyatt at apple.com>
- Patch to the drawLine function for the inline box model landing.
-
+ Patch to the drawLine function for the inline box model landing.
Reviewed by kocienda
* WebCoreSupport.subproj/WebTextRenderer.m:
2003-02-13 Trey Matteson <trey at apple.com>
- First checkin for working forms autocomplete.
+ First checkin for working forms autocomplete.
- This level mostly just has glue to go from app to WC through the bridge.
- WebHTMLReo exports some new SPI to get the element of a view, and then to get
- some HTML-level properties of that element.
+ This level mostly just has glue to go from app to WC through the bridge.
+ WebHTMLReo exports some new SPI to get the element of a view, and then to get
+ some HTML-level properties of that element.
Reviewed by Chris
* Bookmarks.subproj/WebBookmarkGroup.m:
(-[WebBookmarkGroup _saveBookmarkGroupGuts]): Don't dump entire bookmark
- dict in the log.
+ dict in the log.
* WebKit.exp: New class used by app, objc_class_name_WebHTMLRepresentation.
* WebView.subproj/WebHTMLRepresentation.h:
* WebView.subproj/WebHTMLRepresentation.m:
@@ -17748,7 +17647,7 @@ l.
2003-02-13 Chris Blumenberg <cblu at apple.com>
- Fixed WebKit typos found by Peter Wilson.
+ Fixed WebKit typos found by Peter Wilson.
Reviewed by darin.
@@ -17778,8 +17677,8 @@ l.
2003-02-12 Chris Blumenberg <cblu at apple.com>
- - Moved the WebKit error registration out of WebView because apps that use WebKit but not WebView might need to use WebKit errors (like my test app for WebDownload).
- - Added file close and file move errors (needed for WebDownload).
+ - Moved the WebKit error registration out of WebView because apps that use WebKit but not WebView might need to use WebKit errors (like my test app for WebDownload).
+ - Added file close and file move errors (needed for WebDownload).
Reviewed by kocienda.
@@ -17799,7 +17698,7 @@ l.
* WebView.subproj/WebDataSourcePrivate.h: Added _receivedError:complete: method.
* WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedError:complete:]):
- Added, parallel to _receivedData and _finishedLoading. Calls the new bridge method
+ Added, parallel to _receivedData and _finishedLoading. Calls the new bridge method
didNotOpenURL: for cases where we fail before committing (which calls openURL).
Note that we can't use our own _bridge method because it asserts that we have committed
to prevent accidental misuse. Also make the call on the controller that used to be done
@@ -17821,7 +17720,7 @@ l.
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):
- Don't assume that the Cocoa concept of the content view matches up with the Carbon
+ Don't assume that the Cocoa concept of the content view matches up with the Carbon
concept of where the port is positioned. Instead, convert coordinates to border
view coordinates, then back to Carbon content coordinates by using the delta between
the port bounds and the port's pixmap bounds. Bug 3160710 was caused by an older version
@@ -17829,10 +17728,10 @@ l.
2003-02-11 Trey Matteson <trey at apple.com>
- Set -seg1addr in our build styles, but not for the B&I build.
- This makes our SYMROOTS from B&I usable to determine symbols from crash
- logs from the field.
- Also nuked DeploymentFat build style.
+ Set -seg1addr in our build styles, but not for the B&I build.
+ This makes our SYMROOTS from B&I usable to determine symbols from crash
+ logs from the field.
+ Also nuked DeploymentFat build style.
Reviewed by Ken.
@@ -17840,7 +17739,7 @@ l.
2003-02-10 Chris Blumenberg <cblu at apple.com>
- Added HeaderDoc comments for WebDownload and WebPluginError.
+ Added HeaderDoc comments for WebDownload and WebPluginError.
Reviewed by rjw.
@@ -17849,12 +17748,12 @@ l.
2003-02-10 Trey Matteson <trey at apple.com>
- Following the recent fix for ensuring that we always have a FormDelegate,
- when we need a default policy delegate we use a shared one instead of allocing
- a new one each time, which then would leak.
+ Following the recent fix for ensuring that we always have a FormDelegate,
+ when we need a default policy delegate we use a shared one instead of allocing
+ a new one each time, which then would leak.
- This included getting rid of the initWithWebController: method in the
- WebDefaultPolicyDelegate API. The arg was not used.
+ This included getting rid of the initWithWebController: method in the
+ WebDefaultPolicyDelegate API. The arg was not used.
Reviewed by Richard
@@ -17876,7 +17775,7 @@ l.
2003-02-10 Chris Blumenberg <cblu at apple.com>
- Fixed: 3168888 - REGRESSION: many downloads fail (due to -36 error from write)
+ Fixed: 3168888 - REGRESSION: many downloads fail (due to -36 error from write)
Reviewed by darin.
@@ -17885,9 +17784,9 @@ l.
2003-02-10 Trey Matteson <trey at apple.com>
- Make sure we have a FormsDelegate installed with NOP behavior if our client
- does not set one. Editing forms was broken for Ed by the introduction
- of the new FormDelegate.
+ Make sure we have a FormsDelegate installed with NOP behavior if our client
+ does not set one. Editing forms was broken for Ed by the introduction
+ of the new FormDelegate.
Reviewed by Darin.
@@ -17898,7 +17797,7 @@ l.
* WebView.subproj/WebFormDelegate.h: Nit cleanup.
* WebView.subproj/WebFormDelegate.m:
(+[WebFormDelegate _sharedWebFormDelegate]): New method to return a shared
- NOP implementation.
+ NOP implementation.
2003-02-07 Richard Williamson <rjw at apple.com>
@@ -17978,10 +17877,10 @@ l.
2003-02-06 Chris Blumenberg <cblu at apple.com>
- - Made WebDownload.h a public header.
- - Added stubs for the new methods.
- - Moved all private methods to the WebPrivate category.
- - Added FIXMEs for things that needed to be removed or implemented.
+ - Made WebDownload.h a public header.
+ - Added stubs for the new methods.
+ - Moved all private methods to the WebPrivate category.
+ - Added FIXMEs for things that needed to be removed or implemented.
Reviewed by rjw.
@@ -18007,8 +17906,8 @@ l.
2003-02-06 Chris Blumenberg <cblu at apple.com>
- Renamed WebDownloadHandler to WebDownload.
- Made ivars of WebDownload private.
+ Renamed WebDownloadHandler to WebDownload.
+ Made ivars of WebDownload private.
Reviewed by kocienda.
@@ -18063,8 +17962,7 @@ l.
2003-02-06 Chris Blumenberg <cblu at apple.com>
- Fixed: 3125067 - Investigate performance implications of writing download file data
-
+ Fixed: 3125067 - Investigate performance implications of writing download file data
Reviewed by trey, rjw, darin.
* Downloads.subproj/WebDownloadHandler.h:
@@ -18090,11 +17988,10 @@ l.
2003-02-06 Trey Matteson <trey at apple.com>
- 3137647 - ad frames get their own history entries at channels.netscape.com
- 3133844 - 2 items in back list at http://www.kiup-bank.com/personal/main01.html
+ 3137647 - ad frames get their own history entries at channels.netscape.com 3133844 - 2 items in back list at http://www.kiup-bank.com/personal/main01.html
- Move logic for deciding on "quick redirect" down to WebCore, where we really know
- what case we're in instead of having to guess from the params we were receiving.
+ Move logic for deciding on "quick redirect" down to WebCore, where we really know
+ what case we're in instead of having to guess from the params we were receiving.
Reviewed by Maciej, Darin.
@@ -18106,8 +18003,8 @@ l.
(-[WebFrame _transitionToCommitted:]): Nuke Completing state.
(-[WebFrame _isLoadComplete]): Nuke Completing state.
(-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:]):
- Just obey lockHistory param when deciding whether we are doing a "client redirect"
- instead of previous guesswork.
+ Just obey lockHistory param when deciding whether we are doing a "client redirect"
+ instead of previous guesswork.
2003-02-06 Richard Williamson <rjw at apple.com>
@@ -18147,10 +18044,10 @@ l.
2003-02-05 Chris Blumenberg <cblu at apple.com>
- WebKit API clean-up:
- - Added enum to WebContextMenuDelegate that is the menu item tag of the menu items passed in the default menu item array.
- - WebPluginError should return URL strings.
- - Made WebPluginError constructors private.
+ WebKit API clean-up:
+ - Added enum to WebContextMenuDelegate that is the menu item tag of the menu items passed in the default menu item array.
+ - WebPluginError should return URL strings.
+ - Made WebPluginError constructors private.
Reviewed by rjw.
@@ -18171,20 +18068,20 @@ l.
2003-02-04 Trey Matteson <trey at apple.com>
- WC now tells us the form values being submitted with a get/post.
- We forward this info to a new WebFormDelegate method. Most of this
- change is just glue passing the formValues through all our layers.
+ WC now tells us the form values being submitted with a get/post.
+ We forward this info to a new WebFormDelegate method. Most of this
+ change is just glue passing the formValues through all our layers.
Reviewed by Maciej
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge loadURL:reload:triggeringEvent:formValues:])
- Pass along formValues.
+ Pass along formValues.
(-[WebBridge postWithURL:data:contentType:triggeringEvent:formValues:]):
- Pass along formValues.
+ Pass along formValues.
* WebKit.pbproj/project.pbxproj: Reorder previously added files.
* WebView.subproj/WebControllerPolicyDelegate.m: Fix latent copy/paste error
- where two keys had the same underlying string value!
+ where two keys had the same underlying string value!
* WebView.subproj/WebFormDelegate.h: Declare new delegate method.
* WebView.subproj/WebFormDelegate.m:
(-[WebFormDelegate frame:willSubmitFormWithValues:]): NOP impl of new method.
@@ -18192,38 +18089,38 @@ l.
(-[WebFrame loadRequest:]): Pass nil formValues.
(-[WebFrame reload]): Pass nil formValues.
* WebView.subproj/WebFramePrivate.h: New ivar to hold form values
- while waiting for the policy delegate response.
+ while waiting for the policy delegate response.
* WebView.subproj/WebFramePrivate.m:
(-[WebFramePrivate dealloc]): ASSERT new ivar is nil.
(-[WebFrame _loadItem:fromItem:withLoadType:]): Pass nil formValues.
(-[WebFrame _loadRequest:triggeringAction:loadType:formValues:]):
- Pass along formValues.
- (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]):
- Pass nil formValues to continuation method.
+ Pass along formValues.
+ (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]):
+ Pass nil formValues to continuation method.
(-[WebFrame _checkNavigationPolicyForRequest:dataSource:formValues:andCall:withSelector:]):
- Stash formValues before calling policy delegate.
+ Stash formValues before calling policy delegate.
(-[WebFrame _continueAfterNavigationPolicy:]):
- Resurrect formValues after calling policy delegate, pass to continuation method.
+ Resurrect formValues after calling policy delegate, pass to continuation method.
(-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formValues:]):
- Bail on nil request instead of shouldContinue=NO
+ Bail on nil request instead of shouldContinue=NO
(-[WebFrame _loadURL:loadType:triggeringEvent:formValues:]):
- Pass formValues along.
+ Pass formValues along.
(-[WebFrame _loadURL:intoChild:]): Pass nil formValues.
(-[WebFrame _postWithURL:data:contentType:triggeringEvent:formValues:]):
- Pass formValues along.
+ Pass formValues along.
(-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):
- Pass nil formValues.
+ Pass nil formValues.
(-[WebFrame _continueLoadRequestAfterNavigationPolicy:formValues:]):
- Bail on nil request instead of shouldContinue=NO. Call new FormDelegate method.
+ Bail on nil request instead of shouldContinue=NO. Call new FormDelegate method.
(-[WebFrame _loadDataSource:withLoadType:formValues:]):
- Pass formValues along.
+ Pass formValues along.
(-[WebFrame _downloadRequest:toDirectory:]):
- Pass nil formValues.
+ Pass nil formValues.
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient continueAfterNavigationPolicy:formValues:]):
- Bail on nil request instead of shouldContinue=NO
+ Bail on nil request instead of shouldContinue=NO
(-[WebMainResourceClient handle:willSendRequest:]):
- Pass nil formValues.
+ Pass nil formValues.
2003-02-05 Richard Williamson <rjw at apple.com>
@@ -18286,11 +18183,11 @@ l.
Reviewed by Darin.
* WebKit.pbproj/project.pbxproj: Updated to build the framework
- standalone instead of embedded when doing a B&I build for Panther.
+ standalone instead of embedded when doing a B&I build for Panther.
2003-02-04 Chris Blumenberg <cblu at apple.com>
- Fixed: 3163879 - receivedPageIcon:forDataSource: always sends nil image
+ Fixed: 3163879 - receivedPageIcon:forDataSource: always sends nil image
Reviewed by rjw.
@@ -18371,7 +18268,7 @@ l.
2003-02-03 Chris Blumenberg <cblu at apple.com>
- Fixed: 3163073 - SECURITY: Need to check if filename in encoded download is safe
+ Fixed: 3163073 - SECURITY: Need to check if filename in encoded download is safe
Reviewed by kocienda, darin, mjs.
@@ -18382,21 +18279,20 @@ l.
Reviewed by Darin and Ken.
- - fixed 3162581 - 56 debug: Assertion failure displaying pop-up menu while downloading
-
+ - fixed 3162581 - 56 debug: Assertion failure displaying pop-up menu while downloading
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient handle:didReceiveResponse:]): No need to assert that the controller is
- not deferred if this is a handle being used for a download.
+ not deferred if this is a handle being used for a download.
(-[WebMainResourceClient handle:didReceiveData:]): Likewise.
(-[WebMainResourceClient handleDidFinishLoading:]): Likewise.
(-[WebMainResourceClient handle:didFailLoadingWithError:]): Likewise.
2003-01-31 Trey Matteson <trey at apple.com>
- New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
- messages from our form widgets. Should result in no behavior change.
+ New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
+ messages from our form widgets. Should result in no behavior change.
- New private API is exposed for the app to set a WebFormDelegate.
+ New private API is exposed for the app to set a WebFormDelegate.
Reviewed by Richard
@@ -18419,7 +18315,7 @@ l.
(-[WebController _formDelegate]): simple getter
* WebView.subproj/WebFormDelegate.h: Added.
* WebView.subproj/WebFormDelegate.m: Added.
- NOP impls for all these delegate methods.
+ NOP impls for all these delegate methods.
(-[WebFormDelegate controlTextDidBeginEditing:inFrame:]):
(-[WebFormDelegate controlTextDidEndEditing:inFrame:]):
(-[WebFormDelegate controlTextDidChange:inFrame:]):
@@ -18437,7 +18333,7 @@ l.
2003-01-31 Chris Blumenberg <cblu at apple.com>
- Fixed : 3155148 - image shown when dragging gets size from image file, not size as used on page
+ Fixed : 3155148 - image shown when dragging gets size from image file, not size as used on page
Reviewed by darin.
@@ -18457,7 +18353,7 @@ l.
2003-01-30 Chris Blumenberg <cblu at apple.com>
- Backed out my fix for 3161102. Richard and I found problems the fix. 3161102 turns out to not be an issue.
+ Backed out my fix for 3161102. Richard and I found problems the fix. 3161102 turns out to not be an issue.
Reviewed by rjw.
@@ -18468,7 +18364,7 @@ l.
2003-01-30 Chris Blumenberg <cblu at apple.com>
- Fixed: 3161102 - Avoid retain cycles by destroying plug-ins in the page cache before dealloc
+ Fixed: 3161102 - Avoid retain cycles by destroying plug-ins in the page cache before dealloc
Reviewed by rjw.
@@ -18479,9 +18375,9 @@ l.
2003-01-30 Chris Blumenberg <cblu at apple.com>
- Fixed: 3160464 - Slideback sometimes happens twice
+ Fixed: 3160464 - Slideback sometimes happens twice
- Because we start drags in mouseDragged (which AppKit says we shouldn't), we get mouseDragged events
+ Because we start drags in mouseDragged (which AppKit says we shouldn't), we get mouseDragged events
after a drag (image, link, text etc) has ended. We also get mouseDragged events after we've sent the
fake mouseUp to WebCore. That is probably bad for unknown reasons.
@@ -18510,28 +18406,28 @@ l.
Reviewed by John.
- - fixed 3158624 -- crash reentering WebBaseNetscapePluginView removeTrackingRect closing window
+ - fixed 3158624 -- crash reentering WebBaseNetscapePluginView removeTrackingRect closing window
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView removeTrackingRect]):
- Set tracking tag to 0 before releasing the window to prevent reentering.
+ Set tracking tag to 0 before releasing the window to prevent reentering.
2003-01-29 Ken Kocienda <kocienda at apple.com>
Reviewed by Darin.
- Fix for this bug:
+ Fix for this bug:
- Radar 3142818 (Downloading many items quickly can cause future page loads to fail)
+ Radar 3142818 (Downloading many items quickly can cause future page loads to fail)
- The issue was with a mismatch between different object's idea about
- whether callbacks were being deferred. I have simplified the code in this
- area somewhat, and I have added some asserts to make sure that callbacks
- are not sent when deferalls are on.
+ The issue was with a mismatch between different object's idea about
+ whether callbacks were being deferred. I have simplified the code in this
+ area somewhat, and I have added some asserts to make sure that callbacks
+ are not sent when deferalls are on.
- More work will need to be done in callback deferral-land, however. This change
- fixes the bug, but it may not be a good long-term fix. I will file a bug on
- the need for this additonal work.
+ More work will need to be done in callback deferral-land, however. This change
+ fixes the bug, but it may not be a good long-term fix. I will file a bug on
+ the need for this additonal work.
* WebView.subproj/WebBaseResourceHandleDelegate.h:
* WebView.subproj/WebBaseResourceHandleDelegate.m:
@@ -18539,36 +18435,36 @@ l.
* WebView.subproj/WebMainResourceClient.h: Removed unneeded defersBeforeCheckingPolicy flag.
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient continueAfterNavigationPolicy:request:]): Unconditionally set
- callback deferrals to NO.
+ callback deferrals to NO.
(-[WebMainResourceClient handle:willSendRequest:]): Remove all callback deferral code here.
(-[WebMainResourceClient continueAfterContentPolicy:response:]): Unconditionally set
callback deferrals to NO.
(-[WebMainResourceClient handle:didReceiveResponse:]): Assert that the handle argument
- to this method, the client (self), and the data source's controller all are not
- deferring callbacks.
- Unconditionally set callback deferrals to YES.
+ to this method, the client (self), and the data source's controller all are not
+ deferring callbacks.
+ Unconditionally set callback deferrals to YES.
(-[WebMainResourceClient handle:didReceiveData:]): Ditto
(-[WebMainResourceClient handleDidFinishLoading:]): Ditto
(-[WebMainResourceClient handle:didFailLoadingWithError:]): Ditto
2003-01-29 John Sullivan <sullivan at apple.com>
- - fixed 3160116 -- REGRESSION:leak in WebBookmarkLeaf at startup
+ - fixed 3160116 -- REGRESSION:leak in WebBookmarkLeaf at startup
Reviewed by Darin
* Bookmarks.subproj/WebBookmarkLeaf.m:
(-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]):
- don't leak the _entry that was created in initWithURLString:title:group:
+ don't leak the _entry that was created in initWithURLString:title:group:
2003-01-29 Trey Matteson <trey at apple.com>
- 3159750 - REGRESSION: cursor is I-beam when over a standalone image
+ 3159750 - REGRESSION: cursor is I-beam when over a standalone image
- We now reset the cursor to arrow before switching doc views.
+ We now reset the cursor to arrow before switching doc views.
- Also, made various replacements of "id <WebDocumentView>" with "NSView < WebDocumentView> *"
- to get better compile time checking.
+ Also, made various replacements of "id <WebDocumentView>" with "NSView < WebDocumentView> *"
+ to get better compile time checking.
Reviewed by Darin.
@@ -18582,7 +18478,7 @@ l.
2003-01-29 Chris Blumenberg <cblu at apple.com>
- 3159529 - REGRESSION: URLs with no path are saved as "-.html"
+ 3159529 - REGRESSION: URLs with no path are saved as "-.html"
Reviewed by darin, trey, kocienda.
@@ -18591,18 +18487,18 @@ l.
2003-01-28 Trey Matteson <trey at apple.com>
- Removing ERROR() that isn't an error, left over from the Safari-48 download firedrill.
+ Removing ERROR() that isn't an error, left over from the Safari-48 download firedrill.
Reviewed by Chris.
* Downloads.subproj/WebDownloadHandler.m:
(-[WebDownloadHandler cleanUpAfterFailure]): Don't ERROR if we are asked to cleanup
- a file and there is nothing to cleanup. This can happen in the rare case of the
- download being canceled before the first byte arrives, and we deal properly, no ERROR.
+ a file and there is nothing to cleanup. This can happen in the rare case of the
+ download being canceled before the first byte arrives, and we deal properly, no ERROR.
2003-01-28 Chris Blumenberg <cblu at apple.com>
- Fixed: 3150856 - crash with full-size plugins in frame or iframe
+ Fixed: 3150856 - crash with full-size plugins in frame or iframe
Reviewed by darin.
@@ -18617,7 +18513,7 @@ l.
2003-01-28 Chris Blumenberg <cblu at apple.com>
- Fixed: 3156172 - No filename correction when downloading images via drag & drop
+ Fixed: 3156172 - No filename correction when downloading images via drag & drop
Reviewed by mjs, john, trey.
@@ -18642,15 +18538,15 @@ l.
2003-01-28 Trey Matteson <trey at apple.com>
- 2940179 - Arrow cursor should change to link cursor after click of link in non-frontmost window
- 3158240 - cursor does not track when switching from panels to safari windows
+ 2940179 - Arrow cursor should change to link cursor after click of link in non-frontmost window
+ 3158240 - cursor does not track when switching from panels to safari windows
- Two changes here: First, we post fake mousemoved events to get the cursor fixed up
- without checking if the mouse is down (WC deals with that now). That fixes 2940179,
- because the button is down when we get notified of becoming key.
+ Two changes here: First, we post fake mousemoved events to get the cursor fixed up
+ without checking if the mouse is down (WC deals with that now). That fixes 2940179,
+ because the button is down when we get notified of becoming key.
- Second, we observe key window instead of main window notifications everywhere, so we
- update the cursor when clicking between a panel and our doc windows.
+ Second, we observe key window instead of main window notifications everywhere, so we
+ update the cursor when clicking between a panel and our doc windows.
Reviewed by Darin.
@@ -18665,35 +18561,35 @@ l.
2003-01-28 John Sullivan <sullivan at apple.com>
- - fixed 3158304 -- Assertion failure cancelling "Add Bookmark"
- or deleting newly-created bookmarks
+ - fixed 3158304 -- Assertion failure cancelling "Add Bookmark"
+ or deleting newly-created bookmarks
Reviewed by Darin
* Bookmarks.subproj/WebBookmarkGroup.m:
(-[WebBookmarkGroup _bookmark:changedUUIDFrom:to:]):
- new method that notifies group when a bookmark that's already
- in a group changes its UUID -- the UUID to bookmark dictionary
- updates for this change.
+ new method that notifies group when a bookmark that's already
+ in a group changes its UUID -- the UUID to bookmark dictionary
+ updates for this change.
* Bookmarks.subproj/WebBookmarkGroupPrivate.h:
- private declaration for this method
+ private declaration for this method
* Bookmarks.subproj/WebBookmark.m:
(-[WebBookmark _setUUID:]):
- notify group when UUID changes
+ notify group when UUID changes
(-[WebBookmark UUID]):
- ditto
+ ditto
2003-01-28 Darin Adler <darin at apple.com>
Reviewed by Ken.
- - fixed 3156197 -- leak in -[WebBookmarkList initFromDictionaryRepresentation:withGroup:]
+ - fixed 3156197 -- leak in -[WebBookmarkList initFromDictionaryRepresentation:withGroup:]
* Bookmarks.subproj/WebBookmarkList.m:
(-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]):
- Fixed storage leak by not allocating the list here, because [self init] will
+ Fixed storage leak by not allocating the list here, because [self init] will
be called and that will allocate the list.
2003-01-26 Maciej Stachowiak <mjs at apple.com>
@@ -18704,7 +18600,7 @@ l.
2003-01-27 Chris Blumenberg <cblu at apple.com>
- Fixed: 3156230 - REGRESSION: Java 141: Safari Does Not Stop Applets When Browser Window Closes
+ Fixed: 3156230 - REGRESSION: Java 141: Safari Does Not Stop Applets When Browser Window Closes
Reviewed by dave.
@@ -18737,9 +18633,9 @@ l.
2003-01-27 Trey Matteson <trey at apple.com>
- 3157104 - reproducible assert in _continueFragmentScrollAfterNavigationPolicy
+ 3157104 - reproducible assert in _continueFragmentScrollAfterNavigationPolicy
- Remove assertion, and it turns out the existing code will handle the case.
+ Remove assertion, and it turns out the existing code will handle the case.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]):
@@ -18757,7 +18653,7 @@ l.
2003-01-27 Chris Blumenberg <cblu at apple.com>
- Fixed: 3156235 - change throttle for plug-in null events to 50 frames per second (when frontmost)
+ Fixed: 3156235 - change throttle for plug-in null events to 50 frames per second (when frontmost)
Reviewed by dave.
@@ -18779,16 +18675,16 @@ l.
2003-01-27 John Sullivan <sullivan at apple.com>
- - fixed 3156744 -- REGRESSION: Renaming bookmarks dragged
- into bookmark bar does not work at first
+ - fixed 3156744 -- REGRESSION: Renaming bookmarks dragged
+ into bookmark bar does not work at first
Reviewed by Darin
* Bookmarks.subproj/WebBookmarkList.m:
(-[WebBookmarkList insertChild:atIndex:]):
- was adding self to its own group (a no-op), instead of adding
- the new child to self's group. This was a typo from the
- refactoring to fix 3152427.
+ was adding self to its own group (a no-op), instead of adding
+ the new child to self's group. This was a typo from the
+ refactoring to fix 3152427.
2003-01-27 Chris Blumenberg <cblu at apple.com>
@@ -18796,7 +18692,7 @@ l.
2003-01-26 Chris Blumenberg <cblu at apple.com>
- Fixed: 3156725 - Partially selected links show extra underlining when dragged
+ Fixed: 3156725 - Partially selected links show extra underlining when dragged
Reviewed by darin.
@@ -18807,9 +18703,9 @@ l.
Reviewed by Maciej.
- - fixed 3126211 -- "go back" buttons that use "history.go(-1)" doesn't work (verizonwireless.com is an example)
+ - fixed 3126211 -- "go back" buttons that use "history.go(-1)" doesn't work (verizonwireless.com is an example)
- Implemented new bridge functions for use by the history object.
+ Implemented new bridge functions for use by the history object.
* History.subproj/WebBackForwardList.h: Added backListCount and entryAtIndex:.
* History.subproj/WebBackForwardList.m:
@@ -18821,7 +18717,7 @@ l.
2003-01-25 Chris Blumenberg <cblu at apple.com>
- Fixed: 3153605 - Drag image when dragging text should be the actual text
+ Fixed: 3153605 - Drag image when dragging text should be the actual text
Reviewed by darin.
@@ -18852,26 +18748,26 @@ l.
2003-01-24 Trey Matteson <trey at apple.com>
- Chris pointed out a FIXME that led to a more contained way to make sure the cursor
- is correct during and after image/text/URL dragging.
+ Chris pointed out a FIXME that led to a more contained way to make sure the cursor
+ is correct during and after image/text/URL dragging.
Reviewed by Chris.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView draggedImage:endedAt:operation:]): No need to reset the cursor at
- the end of dragging. WC deals with it.
+ the end of dragging. WC deals with it.
* WebView.subproj/WebHTMLViewPrivate.m:
(-[WebHTMLView _handleMouseDragged:]): No need to set the cursor to arrow, WC
- deals with it.
+ deals with it.
2003-01-24 Darin Adler <darin at apple.com>
Reviewed by Dave.
- - fixed 3142852 -- frame content repeatedly requested
+ - fixed 3142852 -- frame content repeatedly requested
* WebCoreSupport.subproj/WebBridge.m: (-[WebBridge incomingReferrer]):
- Added a way to get the referrer across the bridge, needed for bug fix.
+ Added a way to get the referrer across the bridge, needed for bug fix.
2003-01-24 Ed Voas <voas at apple.com>
@@ -18886,21 +18782,20 @@ l.
2003-01-23 Trey Matteson <trey at apple.com>
- 3155162 - cursor changes to I-beam after dragging image
- 3154468 - no mouseup event comes through after text snippet drag
+ 3155162 - cursor changes to I-beam after dragging image 3154468 - no mouseup event comes through after text snippet drag
- During AK dragging the system takes over the event stream and we never get any mouse
- move or up events. It also changes the cursor behind out back. When done
- cached state that thinks it knows the current cursor is wrong.
+ During AK dragging the system takes over the event stream and we never get any mouse
+ move or up events. It also changes the cursor behind out back. When done
+ cached state that thinks it knows the current cursor is wrong.
- The fix is that after the drag we reset the cursor and synthesize a mouseup event,
- which then sets the cursor based on what we're really over.
+ The fix is that after the drag we reset the cursor and synthesize a mouseup event,
+ which then sets the cursor based on what we're really over.
Reviewed by Darin.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView draggedImage:endedAt:operation:]): After the drag,
- reset the cursor, fake up a mouseup event.
+ reset the cursor, fake up a mouseup event.
2003-01-24 John Sullivan <sullivan at apple.com>
@@ -18908,7 +18803,7 @@ l.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView takeFindStringFromSelection:]):
- Now uses new _web_setFindPasteboardString:withOwner: to share code.
+ Now uses new _web_setFindPasteboardString:withOwner: to share code.
2003-01-24 John Sullivan <sullivan at apple.com>
@@ -18917,19 +18812,19 @@ l.
* Misc.subproj/WebNSPasteboardExtras.h:
* Misc.subproj/WebNSPasteboardExtras.m:
(+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
- New method to put text on the Find pasteboard.
+ New method to put text on the Find pasteboard.
2003-01-23 Maciej Stachowiak <mjs at apple.com>
Reviewed by Trey.
* WebView.subproj/WebController.h: Remove unneeded declaration in
- sample code.
+ sample code.
2003-01-23 Chris Blumenberg <cblu at apple.com>
- Made WebTextView use the same format for context menus as the rest of WebKit.
- Implemented "Copy" context menu.
+ Made WebTextView use the same format for context menus as the rest of WebKit.
+ Implemented "Copy" context menu.
Reviewed by john.
@@ -18955,8 +18850,8 @@ l.
* Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder fileAttributes]):
* Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder fileAttributes]):
- Use "FinderFlags" instead of "FinderInfo" as appropriate, since these are
- just the Finder flags, not all the Finder info.
+ Use "FinderFlags" instead of "FinderInfo" as appropriate, since these are
+ just the Finder flags, not all the Finder info.
* Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]):
* Misc.subproj/WebNSWorkspaceExtras.m: (-[NSWorkspace _web_noteFileChangedAtPath:]):
@@ -18964,8 +18859,8 @@ l.
(-[WebNetscapePluginPackage openResourceFile]):
(-[WebNetscapePluginPackage pathByResolvingSymlinksAndAliasesInPath:]):
(-[WebNetscapePluginPackage load]):
- Use fileSystemRepresentation instead of fileSystemRepresentationWithPath:
- because it's simpler and there's no good reason to use the other one.
+ Use fileSystemRepresentation instead of fileSystemRepresentationWithPath:
+ because it's simpler and there's no good reason to use the other one.
* WebView.subproj/WebUserAgentSpoofTable.gperf: Improved one of the motivating comments.
@@ -18975,17 +18870,17 @@ l.
2003-01-22 Chris Blumenberg <cblu at apple.com>
- Fixed problem where we weren't stopping the Java plug-in. This problem was introduced on Jan. 1
+ Fixed problem where we weren't stopping the Java plug-in. This problem was introduced on Jan. 1
when the ownership of the WebPluginController was moved from WebFrame to WebDataSource. This
change moves the WebPluginController to the WebHTMLView. Why this change?
- - The state of the plug-ins (currently only the Java plug-in) completely relies on the state of
+ - The state of the plug-ins (currently only the Java plug-in) completely relies on the state of
the WebHTMLView, not on the state of the WebDataSource.
- - WebHTMLView and WebDataSource are usually coupled via WebView and WebFrame, but not always.
+ - WebHTMLView and WebDataSource are usually coupled via WebView and WebFrame, but not always.
In a transitional state, the WebHTMLView may not be up to date with the WebDataSource.
- - WebPluginController controls an array of views. It makes more sense for this object to be
+ - WebPluginController controls an array of views. It makes more sense for this object to be
owned by a view (WebHTMLView) not a model.
Reviewed by darin.
@@ -19014,134 +18909,134 @@ l.
2003-01-22 John Sullivan <sullivan at apple.com>
- - fixed 3152427 -- Need unique IDs for bookmarks, for
- synching's sake
+ - fixed 3152427 -- Need unique IDs for bookmarks, for
+ synching's sake
- Bookmarks now have a UUID string so that each can maintain its identity
- even in the face of multi-machine synching. One known loose end is written
- up in 3153832 (unique IDs in bookmarks aren't preserved correctly after copy/paste).
- This should be good enough now for the iSynch folks to start implementing
- the bookmarks-synching conduit.
+ Bookmarks now have a UUID string so that each can maintain its identity
+ even in the face of multi-machine synching. One known loose end is written
+ up in 3153832 (unique IDs in bookmarks aren't preserved correctly after copy/paste).
+ This should be good enough now for the iSynch folks to start implementing
+ the bookmarks-synching conduit.
- I also did some cleanup in this area to share more code and handle
- init methods more cleanly, inspired by earlier feedback from Trey and Darin.
+ I also did some cleanup in this area to share more code and handle
+ init methods more cleanly, inspired by earlier feedback from Trey and Darin.
Reviewed by Trey and Darin
* Bookmarks.subproj/WebBookmark.h:
- new _UUID ivar, UUID declaration
+ new _UUID ivar, UUID declaration
* Bookmarks.subproj/WebBookmarkPrivate.h:
- new _setUUID and _hasUUID declarations
+ new _setUUID and _hasUUID declarations
* Bookmarks.subproj/WebBookmark.m:
(-[WebBookmark dealloc]):
- assert that group is nil here; release _UUID
+ assert that group is nil here; release _UUID
(-[WebBookmark copyWithZone:]):
- implement the code shared by each subclass; formerly had no implementation.
+ implement the code shared by each subclass; formerly had no implementation.
(-[WebBookmark _setUUID:]):
- private method to set the UUID
+ private method to set the UUID
(-[WebBookmark UUID]):
- public method to get the UUID; this lazily creates the UUID.
+ public method to get the UUID; this lazily creates the UUID.
(-[WebBookmark _hasUUID]):
- private method to check whether there's a UUID without creating
- one by side effect (as calling -[WebBookmark UUID] would)
+ private method to check whether there's a UUID without creating
+ one by side effect (as calling -[WebBookmark UUID] would)
(-[WebBookmark initFromDictionaryRepresentation:withGroup:]):
- implement the code shared by each subclass; formerly had no implementation.
+ implement the code shared by each subclass; formerly had no implementation.
(-[WebBookmark dictionaryRepresentation]):
- implement the code shared by each subclass; formerly had no implementation.
+ implement the code shared by each subclass; formerly had no implementation.
* Bookmarks.subproj/WebBookmarkGroup.h:
- new _bookmarksByUUID ivar
+ new _bookmarksByUUID ivar
* Bookmarks.subproj/WebBookmarkGroupPrivate.h:
- declarations for new methods _addBookmark: and _removeBookmark:
+ declarations for new methods _addBookmark: and _removeBookmark:
* Bookmarks.subproj/WebBookmarkGroup.m:
(-[WebBookmarkGroup init]):
- new method, just complains that you should have called initWithFile: instead.
+ new method, just complains that you should have called initWithFile: instead.
(-[WebBookmarkGroup initWithFile:]):
- create _bookmarksByUUID
+ create _bookmarksByUUID
(-[WebBookmarkGroup dealloc]):
- release _bookmarksByUUID
+ release _bookmarksByUUID
(-[WebBookmarkGroup _addBookmark:]):
- new method, if bookmark has UUID, adds it to table, and recursively
- processes children the same way
+ new method, if bookmark has UUID, adds it to table, and recursively
+ processes children the same way
(-[WebBookmarkGroup _removeBookmark:]):
- new method, if bookmark has UUID, removes it from table, and recursively
- processes children the same way
+ new method, if bookmark has UUID, removes it from table, and recursively
+ processes children the same way
(-[WebBookmarkGroup _setTopBookmark:]):
- replace [bookmark setGroup:group] with [group _addBookmark:bookmark]
- so it runs through the UUID code
+ replace [bookmark setGroup:group] with [group _addBookmark:bookmark]
+ so it runs through the UUID code
(-[WebBookmarkGroup _bookmarkChildren:wereRemovedFromParent:]):
- retitled this from "wereRemovedToParent"
+ retitled this from "wereRemovedToParent"
* Bookmarks.subproj/WebBookmarkLeaf.m:
(-[WebBookmarkLeaf init]):
- now calls initWithURLString:title:group with nil parameters so that
- there's a designated initializer
+ now calls initWithURLString:title:group with nil parameters so that
+ there's a designated initializer
(-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]):
- rewritten to do only the subclasses' part now
+ rewritten to do only the subclasses' part now
(-[WebBookmarkLeaf dictionaryRepresentation]):
- rewritten to do only the subclasses' part now
+ rewritten to do only the subclasses' part now
(-[WebBookmarkLeaf copyWithZone:]):
- rewritten to do only the subclasses' part now
+ rewritten to do only the subclasses' part now
* Bookmarks.subproj/WebBookmarkList.m:
(-[WebBookmarkList init]):
- now calls initWithTitle:group with nil parameters so that
- there's a designated initializer
+ now calls initWithTitle:group with nil parameters so that
+ there's a designated initializer
(-[WebBookmarkList initWithTitle:group:]):
- replace [bookmark setGroup:group] with [group _addBookmark:bookmark]
- so it runs through the UUID code
+ replace [bookmark setGroup:group] with [group _addBookmark:bookmark]
+ so it runs through the UUID code
(-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]):
- rewritten to do only the subclasses' part now
+ rewritten to do only the subclasses' part now
(-[WebBookmarkList dictionaryRepresentation]):
- rewritten to do only the subclasses' part now
+ rewritten to do only the subclasses' part now
(-[WebBookmarkList copyWithZone:]):
- rewritten to do only the subclasses' part now
+ rewritten to do only the subclasses' part now
(-[WebBookmarkList _setGroup:]):
- removed this override, which used to do the recursion to set the group
- of children; this recursion is now done by -[WebBookmarkGroup _addBookmark:]
- and _removeBookmark:
+ removed this override, which used to do the recursion to set the group
+ of children; this recursion is now done by -[WebBookmarkGroup _addBookmark:]
+ and _removeBookmark:
(-[WebBookmarkList removeChild:]):
- wereRemovedToParent -> wereRemovedFromParent
+ wereRemovedToParent -> wereRemovedFromParent
(-[WebBookmarkList insertChild:atIndex:]):
- replace [bookmark setGroup:group] with [group _addBookmark:bookmark]
- so it runs through the UUID code
+ replace [bookmark setGroup:group] with [group _addBookmark:bookmark]
+ so it runs through the UUID code
* Bookmarks.subproj/WebBookmarkProxy.m:
(-[WebBookmarkProxy init]):
- now calls initWithTitle:group with nil parameters so that
- there's a designated initializer
+ now calls initWithTitle:group with nil parameters so that
+ there's a designated initializer
(-[WebBookmarkProxy initWithTitle:group:]):
- replace [bookmark setGroup:group] with [group _addBookmark:bookmark]
- so it runs through the UUID code
+ replace [bookmark setGroup:group] with [group _addBookmark:bookmark]
+ so it runs through the UUID code
(-[WebBookmarkProxy initFromDictionaryRepresentation:withGroup:]):
- rewritten to do only the subclasses' part now
+ rewritten to do only the subclasses' part now
(-[WebBookmarkProxy dictionaryRepresentation]):
- rewritten to do only the subclasses' part now
+ rewritten to do only the subclasses' part now
(-[WebBookmarkProxy copyWithZone:]):
- rewritten to do only the subclasses' part now
+ rewritten to do only the subclasses' part now
2003-01-22 Darin Adler <darin at apple.com>
Reviewed by Maciej.
- - fixed 3153673 -- spoof as MacIE to get into http://www.mazdausa.com
- - fixed 3153678 -- spoof as MacIE for http://wap.sonyericsson.com/
+ - fixed 3153673 -- spoof as MacIE to get into http://www.mazdausa.com
+ - fixed 3153678 -- spoof as MacIE for http://wap.sonyericsson.com/
* WebView.subproj/WebUserAgentSpoofTable.gperf: Add the two new entries.
- Also reorganize existing entries a bit.
+ Also reorganize existing entries a bit.
2003-01-22 Chris Blumenberg <cblu at apple.com>
- Removed comment that I added by mistake.
+ Removed comment that I added by mistake.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView draggingSourceOperationMaskForLocal:]):
2003-01-22 Chris Blumenberg <cblu at apple.com>
- Fixed: 3153651 - text dragging does not work to Terminal
+ Fixed: 3153651 - text dragging does not work to Terminal
Reviewed by trey.
@@ -19150,7 +19045,7 @@ l.
2003-01-21 Chris Blumenberg <cblu at apple.com>
- Added support for text dragging.
+ Added support for text dragging.
Reviewed by dave.
@@ -19170,17 +19065,16 @@ l.
Reviewed by Trey.
- - fixed 3132120 - onchange handler not firing on mac.com webmail
-
+ - fixed 3132120 - onchange handler not firing on mac.com webmail
* WebView.subproj/WebHTMLViewPrivate.m:
(-[WebNSTextView resignFirstResponder]): If we really resign first responder, and
- our delegate responds to filedWillBecomeFirstResponder, then call that method.
+ our delegate responds to filedWillBecomeFirstResponder, then call that method.
(-[WebNSTextView becomeFirstResponder]): If we really become first responder, and
- our delegate responds to filedWillBecomeFirstResponder, then call that method.
+ our delegate responds to filedWillBecomeFirstResponder, then call that method.
2003-01-20 Trey Matteson <trey at apple.com>
- Nit fix to remove a dead "cursor" ivar found while grepping.
+ Nit fix to remove a dead "cursor" ivar found while grepping.
Reviewed by Richard.
@@ -19191,18 +19085,18 @@ l.
Reviewed by John.
- - fixed 3123041 - VIP: Spewage at bottom of oregonlive.com and other similar pages
+ - fixed 3123041 - VIP: Spewage at bottom of oregonlive.com and other similar pages
* WebView.subproj/WebUserAgentSpoofTable.gperf: Added nj.com to spoof list
- below oregonlive.com (which was already in there). Added comment explaining the
- need to spoof a bit more.
+ below oregonlive.com (which was already in there). Added comment explaining the
+ need to spoof a bit more.
* WebView.subproj/WebUserAgentSpoofTable.c:
(hash):
(_web_findSpoofTableEntry): Regenerated.
2003-01-17 Chris Blumenberg <cblu at apple.com>
- Fixed: 3143656 - crash in MIMETypeForFile when a large QT movie is dragged over window
+ Fixed: 3143656 - crash in MIMETypeForFile when a large QT movie is dragged over window
Reviewed by darin.
@@ -19211,7 +19105,7 @@ l.
2003-01-17 Darin Adler <darin at apple.com>
- - compressed all our non-compressed TIFF files
+ - compressed all our non-compressed TIFF files
* Resources/nullplugin.tiff:
* Resources/url_icon.tiff:
@@ -19222,15 +19116,15 @@ l.
2003-01-16 Chris Blumenberg <cblu at apple.com>
- Fixed comment.
+ Fixed comment.
* Plugins.subproj/WebBaseNetscapePluginView.m:
2003-01-16 Chris Blumenberg <cblu at apple.com>
- Fixed: 3125743 - right-click doesn't count as ctrl-click in Flash
+ Fixed: 3125743 - right-click doesn't count as ctrl-click in Flash
- AppKit doesn't call mouseDown or mouseUp on right-click. Simulate control-click mouseDown and mouseUp so plug-ins get the right-click event as they do in Carbon
+ AppKit doesn't call mouseDown or mouseUp on right-click. Simulate control-click mouseDown and mouseUp so plug-ins get the right-click event as they do in Carbon
Reviewed by darin.
@@ -19242,22 +19136,22 @@ l.
Reviewed by John.
- - added an API for dumping the external representation of the render tree for testing
+ - added an API for dumping the external representation of the render tree for testing
* Misc.subproj/WebCoreStatistics.h: Added renderTreeAsExternalRepresentation.
* Misc.subproj/WebCoreStatistics.m: (-[WebFrame renderTreeAsExternalRepresentation]): Added.
- - removed remnants of an earlier more-naive cut at this same sort of thing
+ - removed remnants of an earlier more-naive cut at this same sort of thing
* Misc.subproj/WebTestController.h: Removed.
* Misc.subproj/WebTestController.m: Removed.
* WebKit.exp: Removed WebTestController.
* WebKit.pbproj/project.pbxproj: Removed WebTestController.
- - other changes
+ - other changes
* WebCoreSupport.subproj/WebBridge.m: Had added new copyright date to touch a file.
- That's not needed any more, but the date should be updated anyway.
+ That's not needed any more, but the date should be updated anyway.
=== Safari-52 ===
@@ -19265,22 +19159,22 @@ l.
Reviewed by Darin.
- - fixed 3143418 - controller assert in WebStandardPanels _didStartLoadingURL
- - fixed 3141212 - crash in kjs garbage collection (contextimp mark)
+ - fixed 3143418 - controller assert in WebStandardPanels _didStartLoadingURL
+ - fixed 3141212 - crash in kjs garbage collection (contextimp mark)
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge startLoadingResource:withURL:]): If the data source
- doesn't have a controller, then block the load.
+ doesn't have a controller, then block the load.
2003-01-15 Darin Adler <darin at apple.com>
Reviewed by Ken.
- - fixed problem where Content-Type was going into WebCore with suffixes like "charset"
+ - fixed problem where Content-Type was going into WebCore with suffixes like "charset"
* WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]):
- Pass in contentType from the response, rather than the "Content-Type" header.
- Also pass in the refresh header separately.
+ Pass in contentType from the response, rather than the "Content-Type" header.
+ Also pass in the refresh header separately.
* English.lproj/StringsNotToBeLocalized.txt: Updated for above change.
@@ -19288,44 +19182,44 @@ l.
Reviewed by Darin, Dave and Trey, and given the seal of approval by Don.
- Use new safer file removal call that does not handle directories.
+ Use new safer file removal call that does not handle directories.
* Downloads.subproj/WebDownloadHandler.m:
- (-[WebDownloadHandler cleanUpAfterFailure]): Use
- _web_removeFileOnlyAtPath:
+ (-[WebDownloadHandler cleanUpAfterFailure]): Use
+ _web_removeFileOnlyAtPath:
* Plugins.subproj/WebBaseNetscapePluginStream.m:
(-[WebBaseNetscapePluginStream dealloc]): Use _web_removeFileOnlyAtPath:
(-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Use _web_removeFileOnlyAtPath:
2003-01-14 Darin Adler <darin at apple.com>
- Reviewed by Dave.
+ Reviewed by Dave.
* Plugins.subproj/WebBaseNetscapePluginStream.m:
(-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
- Fixed uninitialized variable warning so builds work again.
+ Fixed uninitialized variable warning so builds work again.
* WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]): Added "application/xml".
* WebView.subproj/WebViewPrivate.m: (+[WebView _viewTypes]): Added "application/xml".
- * English.lproj/Localizable.strings: Regenerated.
- * English.lproj/StringsNotToBeLocalized.txt: Updated for above change.
+ * English.lproj/Localizable.strings: Regenerated.
+ * English.lproj/StringsNotToBeLocalized.txt: Updated for above change.
2003-01-13 Darin Adler <darin at apple.com>
Reviewed by Trey, John, and Maciej, and given the seal of approval by Don.
- - fixed 3143317 -- plug-in supplied URLs cause correspondingly named files in /tmp to be deleted
- - fixed 3143330 -- plug-in supplied URLs can overwrite files used in other windows by same plug-in
+ - fixed 3143317 -- plug-in supplied URLs cause correspondingly named files in /tmp to be deleted
+ - fixed 3143330 -- plug-in supplied URLs can overwrite files used in other windows by same plug-in
* Plugins.subproj/WebBaseNetscapePluginStream.h: Make path be a char * rather than an NSString.
* Plugins.subproj/WebBaseNetscapePluginStream.m:
(-[WebBaseNetscapePluginStream dealloc]): Use unlink() to delete the temporary file we made.
- Since we created the file, we know it doesn't have any fancy stuff like a resource fork.
+ Since we created the file, we know it doesn't have any fancy stuff like a resource fork.
(-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Create the file with mkstemp instead of
- trying to come up with our own filename. This eliminates the need to delete an old file (because we
- are guaranteed the file is new) and also mkstemp opens the file for us, so we just need to write
- the contents.
+ trying to come up with our own filename. This eliminates the need to delete an old file (because we
+ are guaranteed the file is new) and also mkstemp opens the file for us, so we just need to write
+ the contents.
* English.lproj/StringsNotToBeLocalized.txt: Updated for above changes.
@@ -19335,7 +19229,7 @@ l.
2003-01-12 Chris Blumenberg <cblu at apple.com>
- Fix for checking and creating proper download filenames.
+ Fix for checking and creating proper download filenames.
Reviewed by mjs, kocienda, trey.
@@ -19350,33 +19244,33 @@ l.
Reviewed by John.
- - fixed 3144882 -- pretend to be WinIE for abcnews.com
+ - fixed 3144882 -- pretend to be WinIE for abcnews.com
* WebView.subproj/WebControllerPrivate.h: Add an enum, UserAgentStringType, with values
- Safari, MacIE, and WinIE. Also add NumUserAgentStringTypes and turn the userAgent and
- userAgentWhenPretendingToBeMacIE strings into an array indexed by type.
+ Safari, MacIE, and WinIE. Also add NumUserAgentStringTypes and turn the userAgent and
+ userAgentWhenPretendingToBeMacIE strings into an array indexed by type.
* WebView.subproj/WebController.m:
(-[WebController setApplicationNameForUserAgent:]): Use a loop to discard the user agent
- strings, since we have an array now.
+ strings, since we have an array now.
(-[WebController userAgentForURL:]): Change user agent algorithm to check two strings rather
- than once against the spoof table, allowing two dots in the "domain name", which is needed
- for "abcnews.go.com". Get a user agent string type from the table rather than just a boolean
- "pretend to be MacIE". Store a string per type rather than one for normalcy and one for MacIE.
- Add a case for WinIE to the user agent computations.
+ than once against the spoof table, allowing two dots in the "domain name", which is needed
+ for "abcnews.go.com". Get a user agent string type from the table rather than just a boolean
+ "pretend to be MacIE". Store a string per type rather than one for normalcy and one for MacIE.
+ Add a case for WinIE to the user agent computations.
- * English.lproj/StringsNotToBeLocalized.txt: Update for change above.
+ * English.lproj/StringsNotToBeLocalized.txt: Update for change above.
* WebView.subproj/WebControllerPrivate.m:
(-[WebControllerPrivate dealloc]): Use a loop to discard the user agent strings, since we have
- an array now.
+ an array now.
(-[WebController _defaultsDidChange]): Ditto.
* WebView.subproj/WebUserAgentSpoofTable.gperf: Add a UserAgentStringType field to the struct.
- Add MacIE to each existing table entry, and add a new one that says WinIE for abcnews.go.com.
+ Add MacIE to each existing table entry, and add a new one that says WinIE for abcnews.go.com.
* Makefile.am: Pass "-F ,0" to gperf so that we don't get warnings compiling empty entries
- in the hash table.
+ in the hash table.
* WebView.subproj/WebUserAgentSpoofTable.c: Re-generated.
@@ -19388,18 +19282,18 @@ l.
Reviewed by John.
- - fixed 3144479 -- put TITLE from links in status bar
+ - fixed 3144479 -- put TITLE from links in status bar
* WebKit.exp: Add _WebElementLinkTitleKey and also sort this file.
* WebCoreSupport.subproj/WebImageRenderer.m: Need to touch a file to get the above
- to have any effect, so update the copyright date here.
+ to have any effect, so update the copyright date here.
2003-01-09 Darin Adler <darin at apple.com>
* WebKit.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
- bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
- remove CFHumanReadableCopyright, remove NSPrincipalClass.
+ bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
+ remove CFHumanReadableCopyright, remove NSPrincipalClass.
* English.lproj/InfoPlist.strings: Updated to match above changes.
@@ -19424,11 +19318,11 @@ l.
Reviewed by Chris.
- - second pass on 3143332 - we still need a test case to be sure this is right
+ - second pass on 3143332 - we still need a test case to be sure this is right
* Plugins.subproj/WebBaseNetscapePluginStream.m:
(-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
- Check for "/". Also report the failure instead of just hanging on forever.
+ Check for "/". Also report the failure instead of just hanging on forever.
2003-01-09 Darin Adler <darin at apple.com>
@@ -19442,39 +19336,38 @@ l.
2003-01-09 Trey Matteson <trey at apple.com>
- 3143294 - need short-term bulletproofing of download code against bad filenames
+ 3143294 - need short-term bulletproofing of download code against bad filenames
- We protect against a download location that is not an absolute path.
+ We protect against a download location that is not an absolute path.
Reviewed by Darin
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient continueAfterContentPolicy:response:]):
- Bail on download if we don't have a abs path to write to.
+ Bail on download if we don't have a abs path to write to.
2003-01-08 Trey Matteson <trey at apple.com>
- 3142201 - home directory nuked during power download session
+ 3142201 - home directory nuked during power download session
- We add checks for various error cases that could combine to cause this problem. While we
- never got a reproducible case, we are confident that this is the only file removal done
- in the download code, and its ability to wreak havoc has been clipped.
-
+ We add checks for various error cases that could combine to cause this problem. While we
+ never got a reproducible case, we are confident that this is the only file removal done
+ in the download code, and its ability to wreak havoc has been clipped.
Reviewed by Richard.
* Downloads.subproj/WebDownloadHandler.m:
(-[WebDownloadHandler cleanUpAfterFailure]): Only nuke the partial download if in fact we created
- a new download file. Never nuke a directory.
+ a new download file. Never nuke a directory.
(-[WebDownloadHandler createFileIfNecessary]): Don't add "." to the foo-1 filenames we generate
- if the original filename doesn't have any extension.
+ if the original filename doesn't have any extension.
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient continueAfterContentPolicy:response:]):
- If the policyDelegate gives us a nil filename, just stop the whole load, instead of trying to
- overwrite the user's home directory.
+ If the policyDelegate gives us a nil filename, just stop the whole load, instead of trying to
+ overwrite the user's home directory.
2003-01-08 Chris Blumenberg <cblu at apple.com>
- Fixed: 3111432 - Support OBJECT tags with type text/plain or text/html
+ Fixed: 3111432 - Support OBJECT tags with type text/plain or text/html
Reviewed by dave.
@@ -19483,7 +19376,7 @@ l.
2003-01-08 Chris Blumenberg <cblu at apple.com>
- FIXED: 3128098 - flash performance weak!!!
+ FIXED: 3128098 - flash performance weak!!!
Reviewed by darin.
@@ -19518,11 +19411,11 @@ l.
Reviewed by Chris.
- - fixed leak of WebIconLoader observed using leaks tool
+ - fixed leak of WebIconLoader observed using leaks tool
* WebView.subproj/WebDataSourcePrivate.m:
(-[WebDataSourcePrivate dealloc]): Tell the icon loader to stop loading.
- Add a FIXME asking why we had to do this to fix the leak.
+ Add a FIXME asking why we had to do this to fix the leak.
(-[WebDataSource _loadIcon]): Add an assertion.
2003-01-03 Richard Williamson <rjw at apple.com>
@@ -19571,33 +19464,33 @@ l.
Reviewed by John and Don.
- - fixed 3137661 -- REGRESSION: autoscroll selection is broken
+ - fixed 3137661 -- REGRESSION: autoscroll selection is broken
- The new logic in WebCore is slightly pickier, and can't abide a mouse-moved event
- coming in during a drag. Unfortunately, we were sending a fake mouse-moved event
- during a drag, so lets not do that.
+ The new logic in WebCore is slightly pickier, and can't abide a mouse-moved event
+ coming in during a drag. Unfortunately, we were sending a fake mouse-moved event
+ during a drag, so lets not do that.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView mouseDown:]): Cancel any scheduled fake mouse-moved event.
(-[WebHTMLView mouseUp:]): Send a fake mouse-moved event because we didn't update during the drag.
* WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frameOrBoundsChanged]):
- Don't schedule a fake mouse-moved event if the mouse is down, because that means we are in the
+ Don't schedule a fake mouse-moved event if the mouse is down, because that means we are in the
middle of a drag.
2003-01-02 Darin Adler <darin at apple.com>
Reviewed by John and Ken.
- - fixed 3135548 -- exception in Internet Explorer bookmark import code at first startup
+ - fixed 3135548 -- exception in Internet Explorer bookmark import code at first startup
* Bookmarks.subproj/WebBookmarkImporter.m:
(_breakStringIntoLines): Break lines before a <DT> or </DL>.
(_HREFTextFromSpec): Rewrite to simplify, search in a case-insensitive manner.
(-[WebBookmarkImporter initWithPath:]): Change prefix checks to be case-insensitive.
- Don't discard folders altogether if the name can't be parsed as that would mess up
- nesting w.r.t the next </DL>. Make the </DL> handling robust so we misparse, but don't
- crash the whole application by raising an exception.
+ Don't discard folders altogether if the name can't be parsed as that would mess up
+ nesting w.r.t the next </DL>. Make the </DL> handling robust so we misparse, but don't
+ crash the whole application by raising an exception.
* English.lproj/StringsNotToBeLocalized.txt: Updated for this change and recent changes.
@@ -19611,10 +19504,10 @@ l.
2002-12-31 Maciej Stachowiak <mjs at apple.com>
- Reviewed by Darin.
+ Reviewed by Darin.
- - fixed 3130831 - HOMEPAGE: JavaScript that tries to intercept onmousedown fails, image gets dragged instead
- - fixed 3125554 - while dragging to select text in a nested frame, you can start dragging a link or image
+ - fixed 3130831 - HOMEPAGE: JavaScript that tries to intercept onmousedown fails, image gets dragged instead
+ - fixed 3125554 - while dragging to select text in a nested frame, you can start dragging a link or image
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge handleMouseDragged:]): New method; call through the WebHTMLView.
@@ -19622,22 +19515,22 @@ l.
(-[WebBridge handleAutoscrollForMouseDragged:]): Likewise.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView mouseDragged:]): Instead of doing drag handling
- here, just pass the event to WebCore.
- (-[WebHTMLView draggedImage:endedAt:operation:]): Send a fake
- mousemove event instead of sending the current event (likely a
- mouse up as if it were a mouse move).
+ here, just pass the event to WebCore.
+ (-[WebHTMLView draggedImage:endedAt:operation:]): Send a fake
+ mousemove event instead of sending the current event (likely a
+ mouse up as if it were a mouse move).
* WebView.subproj/WebHTMLViewPrivate.h:
* WebView.subproj/WebHTMLViewPrivate.m:
(-[WebHTMLViewPrivate dealloc]): Release drag element if any.
(-[WebHTMLView _dragImageForElement:]): New method. Split out the
- code to make the special drag image for links.
- (-[WebHTMLView _handleMouseDragged:]): Move all the drag handling
- here. This method will get called only if WebCore hasn't blocked
- default drag handling.
+ code to make the special drag image for links.
+ (-[WebHTMLView _handleMouseDragged:]): Move all the drag handling
+ here. This method will get called only if WebCore hasn't blocked
+ default drag handling.
(-[WebHTMLView _handleAutoscrollForMouseDragged:]): Do
- autoscroll. Autoscroll is still lame, we need a timer.
+ autoscroll. Autoscroll is still lame, we need a timer.
(-[WebHTMLView _mayStartDragWithMouseDown:]): Determine if the element
- is a link or image and so may be dragged; remember the drag element.
+ is a link or image and so may be dragged; remember the drag element.
2003-01-01 Richard Williamson <rjw at apple.com>
@@ -19673,35 +19566,35 @@ l.
Reviewed by Trey.
- - fixed 3137287 -- REGRESSION: Java applets don't work when you go back to them (Java 1.4.1 plug-in)
+ - fixed 3137287 -- REGRESSION: Java applets don't work when you go back to them (Java 1.4.1 plug-in)
- By attaching the plug-in controller to the frame, we run into trouble.
- It really needs to be attached to the data source, which has the right lifetime
- and is kept around in the page cache.
+ By attaching the plug-in controller to the frame, we run into trouble.
+ It really needs to be attached to the data source, which has the right lifetime
+ and is kept around in the page cache.
* Plugins.subproj/WebPluginController.h: Keep a reference to a data source, not a frame.
- Add a new _started variable. Rename addPluginView: to addPlugin:, get rid of didAddPluginView:,
- replace destroyAllPlugins with dataSourceWillBeDeallocated, add startAllPlugins and stopAllPlugins.
+ Add a new _started variable. Rename addPluginView: to addPlugin:, get rid of didAddPluginView:,
+ replace destroyAllPlugins with dataSourceWillBeDeallocated, add startAllPlugins and stopAllPlugins.
* Plugins.subproj/WebPluginController.m:
(-[WebPluginController initWithDataSource:]): Store a data source reference, not a frame reference.
- Don't bother registering for the window will close notification, WebHTMLView handles that fine.
+ Don't bother registering for the window will close notification, WebHTMLView handles that fine.
(-[WebPluginController startAllPlugins]): Do nothing if they are already started, call pluginStart on each otherwise.
(-[WebPluginController stopAllPlugins]): Do nothing if they are not started, call pluginStop on each otherwise.
(-[WebPluginController addPlugin:]): Initialize the plugin if it's not already in our list. Also start
- it if we are in "started" mode.
+ it if we are in "started" mode.
(-[WebPluginController dataSourceWillBeDeallocated]): Stop all the plugins, then destroy them.
- Also nil out the fields of the object. This is always called before the controller is released so we
- don't need to override dealloc.
+ Also nil out the fields of the object. This is always called before the controller is released so we
+ don't need to override dealloc.
(-[WebPluginController showURL:inFrame:]): Added error checking and changed now that we start with a data source.
(-[WebPluginController showStatus:]): Ditto.
* WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributes:baseURL:]):
- Use the data source, not the view. Don't add the plugin here, wait until we are ready to start.
+ Use the data source, not the view. Don't add the plugin here, wait until we are ready to start.
* WebView.subproj/WebDataSourcePrivate.h: Store a pointer to the plug-in controller here.
* WebView.subproj/WebDataSourcePrivate.m:
(-[WebDataSourcePrivate dealloc]): Tell the plug-in controller to go away.
- (-[WebDataSource _makeHandleDelegates:deferCallbacks:]): Remove unused empty method.
+ (-[WebDataSource _makeHandleDelegates:deferCallbacks:]): Remove unused empty method.
(-[WebDataSource _pluginController]): Create a plug-in controller if needed.
* WebView.subproj/WebFramePrivate.h: Remove plug-in controller code.
@@ -19712,7 +19605,7 @@ l.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView viewWillMoveToWindow:]): Stop plug-ins when view moves out of a window.
- This includes the case when the window is being destroyed.
+ This includes the case when the window is being destroyed.
(-[WebHTMLView viewDidMoveToWindow]): Start plug-ins when view moves into a window.
(-[WebHTMLView addSubview:]): Add plug-ins to the controller as they are added to us.
@@ -19727,12 +19620,12 @@ l.
2002-12-30 Trey Matteson <trey at apple.com>
- 3137110 - REGRESSION: calls from 2nd and subsequent instances of Java 1.4.1 plug-in seem to be ignored
+ 3137110 - REGRESSION: calls from 2nd and subsequent instances of Java 1.4.1 plug-in seem to be ignored
- We had previously made changes to "numb" a plugin controller after its frame
- was tossed or changed content. We now finish the job by making sure a new
- controller is created when we go to a new page with plugins. To so this we
- release the old controller whenever we flush the plugins from a page.
+ We had previously made changes to "numb" a plugin controller after its frame
+ was tossed or changed content. We now finish the job by making sure a new
+ controller is created when we go to a new page with plugins. To so this we
+ release the old controller whenever we flush the plugins from a page.
Reviewed by Maciej.
@@ -19743,71 +19636,69 @@ l.
2002-12-30 Trey Matteson <trey at apple.com>
- 3135025 - Assertion failure in _transitionToCommitted on espn nba scoreboard
+ 3135025 - Assertion failure in _transitionToCommitted on espn nba scoreboard
- For blank pages we decided that there would be no b/f entry. This means that
- subframes within such pages (created via doc.write()), should not try to make
- WebHistoryItems, since they have no parent items to attach them to.
+ For blank pages we decided that there would be no b/f entry. This means that
+ subframes within such pages (created via doc.write()), should not try to make
+ WebHistoryItems, since they have no parent items to attach them to.
Reviewed by Darin.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _transitionToCommitted:]): Don't make a history item for a subframe
- it the parent frame has no item.
+ it the parent frame has no item.
2002-12-30 Trey Matteson <trey at apple.com>
- 3135779 - REGRESSION: reproducible assertion failure, going back from ~orubin to the main spies.com page
- 3136218 - REGRESSION: Assertion failure in _restoreScrollPosition running browser buster
-
- Both were caused by subtle interactions between new code for short-circuiting loading of
- blank pages, and the WebHistoryItem manipulations we do for b/f and reload of child frames.
+ 3135779 - REGRESSION: reproducible assertion failure, going back from ~orubin to the main spies.com page 3136218 - REGRESSION: Assertion failure in _restoreScrollPosition running browser buster
+ Both were caused by subtle interactions between new code for short-circuiting loading of
+ blank pages, and the WebHistoryItem manipulations we do for b/f and reload of child frames.
Reviewed by Maciej
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _loadURL:intoChild:]): Setup provisional or current item before jumping into
- the real work of loading the URL.
+ the real work of loading the URL.
(-[WebFrame _restoreScrollPosition]): Tweaked to make the assertion message clearer.
2002-12-30 Darin Adler <darin at apple.com>
Reviewed by Don and Ken.
- - fixed 3136797 -- crash when Adobe SVG Viewer plug-in puts up modal dialog
+ - fixed 3136797 -- crash when Adobe SVG Viewer plug-in puts up modal dialog
* Plugins.subproj/WebBaseNetscapePluginView.h: Add inSetWindow boolean.
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView sendEvent:]): Don't send any events to a plug-in while it's
- inside NPP_SetWindow. We don't want to implement more general reentrancy protection, because
- it could cause trouble for plugins that can handle it correctly, but it's unlikely that any
- legitimate use would require reentrant calls while inside NPP_SetWindow, and that's the case
- that crashes for the SVG viewer plug-in when it presents its registration dialog.
+ inside NPP_SetWindow. We don't want to implement more general reentrancy protection, because
+ it could cause trouble for plugins that can handle it correctly, but it's unlikely that any
+ legitimate use would require reentrant calls while inside NPP_SetWindow, and that's the case
+ that crashes for the SVG viewer plug-in when it presents its registration dialog.
(-[WebBaseNetscapePluginView setWindow]): Set boolean.
2002-12-29 Darin Adler <darin at apple.com>
Reviewed by Don.
- - fixed 3103287 -- body of page not rendered (page uses JavaScript trick to be both a frameset and a frame)
+ - fixed 3103287 -- body of page not rendered (page uses JavaScript trick to be both a frameset and a frame)
- Our self-reference checks prevented this page from working.
- I just removed the WebKit one, since it was really just working around a problem with the WebCore
- one that I fixed (didn't ignore #xxx suffixes).
+ Our self-reference checks prevented this page from working.
+ I just removed the WebKit one, since it was really just working around a problem with the WebCore
+ one that I fixed (didn't ignore #xxx suffixes).
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
- Remove self-reference check.
+ Remove self-reference check.
2002-12-29 Darin Adler <darin at apple.com>
Reviewed by Don.
- - fixed 3136801 -- scrolling a page that contains a QuickTime movie leaves garbage behind
+ - fixed 3136801 -- scrolling a page that contains a QuickTime movie leaves garbage behind
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView tellQuickTimeToChill]): Added. Calls a QuickDraw SPI
- CallDrawingNotifications to let QuickTime know it should take a nature break.
+ CallDrawingNotifications to let QuickTime know it should take a nature break.
(-[WebBaseNetscapePluginView viewWillMoveToWindow:]): Call tellQuickTimeToChill.
(-[WebBaseNetscapePluginView viewHasMoved:]): Call tellQuickTimeToChill.
@@ -19815,13 +19706,13 @@ l.
Reviewed by Don.
- - follow-on to my fix for 3125877 that fixes a crash I observed when a plug-in fails to NPP_New
+ - follow-on to my fix for 3125877 that fixes a crash I observed when a plug-in fails to NPP_New
I filed bug 3136870 about the fact that we don't do a good job reporting the error.
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView sendEvent:]): Return quietly if this is called when
- the plug-in is not started rather than asserting (and doing bad things on Deployment).
+ the plug-in is not started rather than asserting (and doing bad things on Deployment).
(-[WebBaseNetscapePluginView setWindow]): Ditto.
(-[WebBaseNetscapePluginView viewHasMoved:]): Just call setWindow since it now checks isStarted.
@@ -19829,10 +19720,10 @@ l.
Reviewed by Don.
- - fixed 3120630 -- spacebar scrolls the page as well as pausing the QuickTime movie
+ - fixed 3120630 -- spacebar scrolls the page as well as pausing the QuickTime movie
- Imitate Mozilla and OmniWeb by not propagating keyboard events after passing them to
- plug-ins regardless of what the plug-in returns, rather than imitating MacIE, which
+ Imitate Mozilla and OmniWeb by not propagating keyboard events after passing them to
+ plug-ins regardless of what the plug-in returns, rather than imitating MacIE, which
looks at the return value from NPP_HandleEvent.
* Plugins.subproj/WebBaseNetscapePluginView.m:
@@ -19843,13 +19734,13 @@ l.
Reviewed by Ken and Don.
- - fixed 3136120 -- much content missing at www.olympic.org
+ - fixed 3136120 -- much content missing at www.olympic.org
- This site gives modern CSS to "Internet Explorer" or "Netscape 6". Since we are neither of
- those, we need to pretend to be one or the other. So we add olympic.org to our MacIE spoofing list.
+ This site gives modern CSS to "Internet Explorer" or "Netscape 6". Since we are neither of
+ those, we need to pretend to be one or the other. So we add olympic.org to our MacIE spoofing list.
* WebView.subproj/WebUserAgentSpoofTable.gperf: Add olympic.org to the list of pages that give us better
- CSS if we claim to be Internet Explorer.
+ CSS if we claim to be Internet Explorer.
* WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.
=== Alexander-46 ===
@@ -19871,91 +19762,91 @@ l.
2002-12-28 Darin Adler <darin at apple.com>
Reviewed by Gramps and Ken
- Checked in by Ken
+ Checked in by Ken
- - fixed 3125877 -- RealPlayer plug-in doesn't work in Safari
+ - fixed 3125877 -- RealPlayer plug-in doesn't work in Safari
* Plugins.subproj/WebBaseNetscapePluginView.h: Remove some methods that don't have
- any need to be public, getCarbonEvent:, sendEvent:, sendUpdateEvent, setUpWindowAndPort.
- Make setWindow public.
+ any need to be public, getCarbonEvent:, sendEvent:, sendUpdateEvent, setUpWindowAndPort.
+ Make setWindow public.
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): Added. This replaces the
- old setUpWindowAndPort. Besides setting up the port and the window, it also sets up the
- port's origin, clip, visible, and update regions properly, and sets the current port.
- In the case of an update event, we have extra work to do, which was formerly done in drawRect:.
+ old setUpWindowAndPort. Besides setting up the port and the window, it also sets up the
+ port's origin, clip, visible, and update regions properly, and sets the current port.
+ In the case of an update event, we have extra work to do, which was formerly done in drawRect:.
(-[WebBaseNetscapePluginView saveAndSetPortState]): Calls saveAndSetPortStateForUpdate:NO.
(-[WebBaseNetscapePluginView restorePortState:]): Undoes the port state changes done by the
- saveAndSetPortState calls.
+ saveAndSetPortState calls.
(-[WebBaseNetscapePluginView sendEvent:]): Call saveAndSetPortStateForUpdate: before sending
- the event to the plug-in. This is the core of fixing the bug. We need to have the port set
- up properly. Specifically, RealPlayer depended on the port's origin being set and the update
- region being set. Also added a "draw green" debugging aid to builds without NDEBUG set.
+ the event to the plug-in. This is the core of fixing the bug. We need to have the port set
+ up properly. Specifically, RealPlayer depended on the port's origin being set and the update
+ region being set. Also added a "draw green" debugging aid to builds without NDEBUG set.
(-[WebBaseNetscapePluginView sendNullEvent]): Update text of a FIXME.
(-[WebBaseNetscapePluginView setWindow]): Call the new saveAndSetPortState method instead of
- the old setUpWindowAndPort method.
+ the old setUpWindowAndPort method.
(-[WebBaseNetscapePluginView drawRect:]): Remove bug workarounds that are now inside the
- saveAndSetPortStateForUpdate: method.
+ saveAndSetPortStateForUpdate: method.
(-[WebBaseNetscapePluginView viewDidMoveToWindow]): Add missing call to super.
(-[WebBaseNetscapePluginView windowBecameKey:]): Don't send an update event to the plugin directly.
- Instead mark this view as needing display so we'll get a drawRect later.
+ Instead mark this view as needing display so we'll get a drawRect later.
(-[WebBaseNetscapePluginView windowResignedKey:]): Ditto.
(-[WebBaseNetscapePluginView requestWithURLCString:]): Corrected handling of URLs. Absolute URLs
- are handled by the relative URL function, so there's no need to do an explicit check. Also use
- requestWithURL instead of doing a three-method dance that does the same thing.
+ are handled by the relative URL function, so there's no need to do an explicit check. Also use
+ requestWithURL instead of doing a three-method dance that does the same thing.
(-[WebBaseNetscapePluginView invalidateRect:]): Use setNeedsDisplayInRect: to schedule redrawing
- rather than forcing an update right away by doing a sendUpdateEvent directly.
+ rather than forcing an update right away by doing a sendUpdateEvent directly.
(-[WebBaseNetscapePluginView invalidateRegion:]): Ditto.
(-[WebBaseNetscapePluginView forceRedraw]): Use setNeedsDisplay: and displayIfNeeded to do the
- drawing through the view system instead of doing a sendUpdateEvent directly.
+ drawing through the view system instead of doing a sendUpdateEvent directly.
* Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView layout]):
- Do a setWindow rather than a setUpWindowAndPort when the size of the view changes. This matches
- what other browsers do and extends the bug fix for the Java plug-in to the resize case as well as
- the scrolling case.
+ Do a setWindow rather than a setUpWindowAndPort when the size of the view changes. This matches
+ what other browsers do and extends the bug fix for the Java plug-in to the resize case as well as
+ the scrolling case.
* Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]):
- Remove RealPlayer antibodies.
+ Remove RealPlayer antibodies.
2002-12-27 Darin Adler <darin at apple.com>
Reviewed by Don.
- - fixed 3136206 -- Can't display images in Ambrosia Software image viewer
+ - fixed 3136206 -- Can't display images in Ambrosia Software image viewer
- WebKit wasn't creating the frames correctly when they weren't HTML.
+ WebKit wasn't creating the frames correctly when they weren't HTML.
* WebView.subproj/WebFramePrivate.m: (-[WebFrame _makeDocumentView]): Added. Calls the
- WebView to make the document view and then installs the new view, as WebHTMLView used to do.
+ WebView to make the document view and then installs the new view, as WebHTMLView used to do.
(-[WebFrame _transitionToCommitted:]): Call _makeDocumentView instead of calling WebView
- directly. These are all the calls to _makeDocumentViewForDataSource:.
+ directly. These are all the calls to _makeDocumentViewForDataSource:.
* WebView.subproj/WebViewPrivate.h: Add return value to _makeDocumentViewForDataSource:.
* WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]):
- Return the newly-created view.
+ Return the newly-created view.
* WebView.subproj/WebHTMLView.m: (-[WebHTMLView setDataSource:]): Removed the code here
- since it's done by WebFrame now.
+ since it's done by WebFrame now.
2002-12-25 Darin Adler <darin at apple.com>
Reviewed by Don.
- - fixed 3133611 -- Java "ticker" applet renders badly when scrolling page
+ - fixed 3133611 -- Java "ticker" applet renders badly when scrolling page
* Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewHasMoved:]):
- Call setWindow so we make a call to the plugin each time it moves, rather than just adjusting
- the data structure we had passed to it earlier.
+ Call setWindow so we make a call to the plugin each time it moves, rather than just adjusting
+ the data structure we had passed to it earlier.
2002-12-24 Darin Adler <darin at apple.com>
Reviewed by Richard and Don.
- - fixed 3132192 -- HOMEPAGE: Quicktime plug in with AVI content brings Plug-ins not found panel
+ - fixed 3132192 -- HOMEPAGE: Quicktime plug in with AVI content brings Plug-ins not found panel
* Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
- Lower-case the key before searching for it. This is needed for both MIME types and extensions,
- since we want case insensitive comparison in both cases.
+ Lower-case the key before searching for it. This is needed for both MIME types and extensions,
+ since we want case insensitive comparison in both cases.
=== Alexander-45 ===
@@ -19963,16 +19854,16 @@ l.
Reviewed by Darin and Gramps
- Workaround for this bug:
+ Workaround for this bug:
- Radar 3134219 (MPEG-4 files don't work with the QuickTime plugin in Safari,
- work fine in Mozilla, IE)
+ Radar 3134219 (MPEG-4 files don't work with the QuickTime plugin in Safari,
+ work fine in Mozilla, IE)
- For beta 1, when getting the MIME information for the QuickTime plugin, we directly
- insert the information to handle MP4.
+ For beta 1, when getting the MIME information for the QuickTime plugin, we directly
+ insert the information to handle MP4.
- In the future, we will use the additional plugin entry points to dynamically load
- this information from the plugin itself.
+ In the future, we will use the additional plugin entry points to dynamically load
+ this information from the plugin itself.
* Plugins.subproj/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage getMIMEInformation])
@@ -19981,10 +19872,10 @@ l.
Reviewed by John and Don.
- - fixed 3134282 -- REGRESSION: text encoding setting reverts when you go to a new location
+ - fixed 3134282 -- REGRESSION: text encoding setting reverts when you go to a new location
* WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): Propagate an override encoding if there
- was an existing data source and it had an override encoding.
+ was an existing data source and it had an override encoding.
* WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadRequest:triggeringAction:loadType:]): Ditto.
=== Alexander-44 ===
@@ -19993,40 +19884,40 @@ l.
Do not add empty URLs to the back forward list.
- Reviewed by Richard, Darin
+ Reviewed by Richard, Darin
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _transitionToCommitted:]):
2002-12-20 Trey Matteson <trey at apple.com>
- 3133829 - crash leaving page with a running applet
+ 3133829 - crash leaving page with a running applet
- This fixes some holes in how we teardown plugins. An additional fix is expected
- from Mike Hay to finish the issue. (3133981)
+ This fixes some holes in how we teardown plugins. An additional fix is expected
+ from Mike Hay to finish the issue. (3133981)
Reviewed by Richard
* Plugins.subproj/WebPluginController.m:
(-[WebPluginController destroyAllPlugins]): frame=nil, so we don't do any more
- messaging back to WK after this step.
+ messaging back to WK after this step.
(-[WebPluginController showURL:inFrame:]): bail if !frame
(-[WebPluginController showStatus:]): bail if !frame
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _detachFromParent]): destroy plugins here. We were only doing it
- in the non-frame case.
+ in the non-frame case.
=== Alexander-43 ===
2002-12-20 Trey Matteson <trey at apple.com>
- 3131841 - crash when switching encodings on a page with frames
+ 3131841 - crash when switching encodings on a page with frames
Reviewed by rjw
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _transitionToCommitted:]): Create a docView in the LoadStale case, like
- every other kind of load does.
+ every other kind of load does.
2002-12-20 Richard Williamson <rjw at apple.com>
@@ -20041,8 +19932,8 @@ l.
2002-12-20 Trey Matteson <trey at apple.com>
- We now build with symbols the B&I. Deployment builds are without symbols,
- so it is easy to generate a non-huge app as a one-off.
+ We now build with symbols the B&I. Deployment builds are without symbols,
+ so it is easy to generate a non-huge app as a one-off.
Reviewed by Darin
@@ -20052,31 +19943,31 @@ l.
2002-12-19 John Sullivan <sullivan at apple.com>
- - WebKit part of fix for 3124949 -- Alexander recreates the
- default set of bookmarks every time a separate app copy is launched
+ - WebKit part of fix for 3124949 -- Alexander recreates the
+ default set of bookmarks every time a separate app copy is launched
Reviewed by Darin
* Bookmarks.subproj/WebBookmarkGroup.h:
- new _tag ivar and -tag method.
+ new _tag ivar and -tag method.
* Bookmarks.subproj/WebBookmarkGroup.m:
(-[WebBookmarkGroup dealloc]):
- release _tag
+ release _tag
(-[WebBookmarkGroup tag]):
- return _tag
+ return _tag
(-[WebBookmarkGroup _loadBookmarkGroupGuts]):
- read _tag from the dictionary in the file (or leave it at
- nil if there's no value in the file).
+ read _tag from the dictionary in the file (or leave it at
+ nil if there's no value in the file).
* English.lproj/StringsNotToBeLocalized.txt:
- kept this file up to date
+ kept this file up to date
2002-12-19 Darin Adler <darin at apple.com>
Reviewed by John.
- - corrected the name of a method that was leading to trouble elsewhere
+ - corrected the name of a method that was leading to trouble elsewhere
* WebView.subproj/WebDataSource.h: Change fileType to fileExtension for clarity.
* WebView.subproj/WebDataSource.m: (-[WebDataSource fileExtension]): Ditto.
@@ -20087,7 +19978,7 @@ l.
Reviewed by John.
- - probably fixed 3129395 -- Reproducible crash when running a javascript at www.scenespot.org
+ - probably fixed 3129395 -- Reproducible crash when running a javascript at www.scenespot.org
* WebCoreSupport.subproj/WebViewFactory.m:
(-[WebViewFactory runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]):
@@ -20104,18 +19995,18 @@ l.
(-[WebBaseNetscapePluginView sendEvent:]): Added an assert.
(-[WebBaseNetscapePluginView setWindow]): Added an assert.
(-[WebBaseNetscapePluginView stop]): Cancel perform requests, now that we are using them for
- URL navigation.
+ URL navigation.
(-[WebBaseNetscapePluginView frameStateChanged:]): Only notify if the plugin is still running.
(-[WebBaseNetscapePluginView loadPluginRequest:]): Added. Does the actual load at idle time.
- Also fixed to only notify if plugin is loaded. Added a number of FIXMEs for other problems here.
- Also send JavaScript to the appropriate frame, not always the top level.
+ Also fixed to only notify if plugin is loaded. Added a number of FIXMEs for other problems here.
+ Also send JavaScript to the appropriate frame, not always the top level.
(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Use loadPluginRequest:
- to do the request after a delay. Also remove the special cases for special frame names; they
- were trying to avoid calling a plugin that has gone away, but we do that a better way now.
+ to do the request after a delay. Also remove the special cases for special frame names; they
+ were trying to avoid calling a plugin that has gone away, but we do that a better way now.
(-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): Added logging.
(-[WebBaseNetscapePluginView status:]): Use Windows Latin-1 rather than MacRoman for messages.
- I guess we should test later to find out which is used by MacIE and conform to that, but for now
- this seems like a better default.
+ I guess we should test later to find out which is used by MacIE and conform to that, but for now
+ this seems like a better default.
(-[WebPluginRequest initWithRequest:frame:notifyData:]): Added.
(-[WebPluginRequest dealloc]): Added.
(-[WebPluginRequest request]): Added.
@@ -20126,21 +20017,21 @@ l.
Reviewed by Chris.
- - fixed fix for 3132056 -- Supply Finder bits for decoded BinHex files
+ - fixed fix for 3132056 -- Supply Finder bits for decoded BinHex files
* Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeHeader]):
- Mask off fewer Finder flag bits. Use the same mask as for MacBinary, in fact.
+ Mask off fewer Finder flag bits. Use the same mask as for MacBinary, in fact.
2002-12-18 Darin Adler <darin at apple.com>
Reviewed by Richard.
- - fixed 3127490 -- pages w/frames sometimes show up blank
+ - fixed 3127490 -- pages w/frames sometimes show up blank
* WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
- Updated the optimization where we draw the entire view if we did a layout
- so that it works properly for the case where the clip is narrower because of
- the parent WebHTMLView.
+ Updated the optimization where we draw the entire view if we did a layout
+ so that it works properly for the case where the clip is narrower because of
+ the parent WebHTMLView.
* English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
@@ -20148,25 +20039,25 @@ l.
2002-12-18 Trey Matteson <trey at apple.com>
- 3098388 - Pressing the back button goes back two levels at allmusic.com
+ 3098388 - Pressing the back button goes back two levels at allmusic.com
- I rewrote the logic we use to decide whether a given redirect should be
- treated as part of the previous navigation. We make use of WebCore's
- lockHistory setting, the delay time and the frame state.
+ I rewrote the logic we use to decide whether a given redirect should be
+ treated as part of the previous navigation. We make use of WebCore's
+ lockHistory setting, the delay time and the frame state.
Reviewed by Darin.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge reportClientRedirectToURL:delay:fireDate:lockHistory:]):
- Pass lockHistory up to the frame.
+ Pass lockHistory up to the frame.
* WebView.subproj/WebFramePrivate.h:
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:]):
- New logic. No quick summary, best to read the code.
+ New logic. No quick summary, best to read the code.
2002-12-18 Chris Blumenberg <cblu at apple.com>
- Reject the RealPlayer plug-in because we know it doesn't work.
+ Reject the RealPlayer plug-in because we know it doesn't work.
Reviewed by sullivan.
@@ -20176,10 +20067,9 @@ l.
2002-12-18 Maciej Stachowiak <mjs at apple.com>
- Reviewed by John.
+ Reviewed by John.
- - fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
-
+ - fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
* English.lproj/InfoPlist.strings:
2002-12-18 Richard Williamson <rjw at apple.com>
@@ -20196,44 +20086,44 @@ l.
Reviewed by Darin and Trey.
- - fixed 3124933 - abcnews.com leads to empty window with sheet complaining about javascript: URL
- - fixed 3091248 - picture does not show up in window from epinions
- - made "about:blank" load synchronously, which I'm told is required by some sites.
+ - fixed 3124933 - abcnews.com leads to empty window with sheet complaining about javascript: URL
+ - fixed 3091248 - picture does not show up in window from epinions
+ - made "about:blank" load synchronously, which I'm told is required by some sites.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge createWindowWithURL:frameName:]): If the URL is nil
- or empty, pass a nil request - otherwise WebBrowser will try to
- load it, resulting in an extra back/forward list entry.
+ or empty, pass a nil request - otherwise WebBrowser will try to
+ load it, resulting in an extra back/forward list entry.
(-[WebBridge loadEmptyDocumentSynchronously]): Tell the frame to
- load a request with an empty URL - this will cause a synchronous
- load of an empty html document
+ load a request with an empty URL - this will cause a synchronous
+ load of an empty html document
* WebView.subproj/WebBaseResourceHandleDelegate.h:
* WebView.subproj/WebBaseResourceHandleDelegate.m:
- (-[WebBaseResourceHandleDelegate loadWithRequest:]): Split off
- startLoading: part of method to allow behavior to be subclassed.
+ (-[WebBaseResourceHandleDelegate loadWithRequest:]): Split off
+ startLoading: part of method to allow behavior to be subclassed.
(-[WebBaseResourceHandleDelegate startLoading:]):
* WebView.subproj/WebDataSourcePrivate.m:
(-[WebDataSource _commitIfReady:]): Lie and claim the URL is
- "about:blank" if it's really empty to avoid confusing WebCore.
+ "about:blank" if it's really empty to avoid confusing WebCore.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _transitionToCommitted:]): Don't put the empty URL in
- global history.
+ global history.
(-[WebFrame
- _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
- Don't check policy if URL is empty - this is likely to confuse the
- client and we know what the right behavior here is.
+ _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
+ Don't check policy if URL is empty - this is likely to confuse the
+ client and we know what the right behavior here is.
* WebView.subproj/WebMainResourceClient.m:
- (-[WebMainResourceClient startLoading:]): Try to load
- "about:blank" and the empty URL synchronously, bypassing
- WebFoundation.
+ (-[WebMainResourceClient startLoading:]): Try to load
+ "about:blank" and the empty URL synchronously, bypassing
+ WebFoundation.
(-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto.
(-[WebMainResourceClient setDefersCallbacks:]): Ditto.
* English.lproj/StringsNotToBeLocalized.txt: Updated.
2002-12-18 Chris Blumenberg <cblu at apple.com>
- Fixed: 2862385 - need to pass browser's user agent and version to plug-ins
- Added some more error checking to the plug-in code
+ Fixed: 2862385 - need to pass browser's user agent and version to plug-ins
+ Added some more error checking to the plug-in code
Reviewed by trey.
@@ -20290,9 +20180,9 @@ l.
2002-12-18 Chris Blumenberg <cblu at apple.com>
- Fixed: 3131714 - System becomes unresponsive while downloading
+ Fixed: 3131714 - System becomes unresponsive while downloading
- While downloading a file, Safari and the Finder take up 30%-40% of the CPU each. This is happening because for every chunk of data we write to disk, we call -[NSWorkspace noteFileSystemChanged:]. noteFileSystemChanged is inefficient. It calls 2 AppleEven
+ While downloading a file, Safari and the Finder take up 30%-40% of the CPU each. This is happening because for every chunk of data we write to disk, we call -[NSWorkspace noteFileSystemChanged:]. noteFileSystemChanged is inefficient. It calls 2 AppleEven
@@ -20304,9 +20194,9 @@ l.
ts each with 60 timeouts. The event also cause the Finder to do a lot of work.
- We should:
- - Send 1 AppleEvent ourselves with no timeout since we don't care about the reply
- - Call the notification/event less often. The only benefit of sending the event for every chunk written is that the file size updates in the Finder. Not worth the performance impact.
+ We should:
+ - Send 1 AppleEvent ourselves with no timeout since we don't care about the reply
+ - Call the notification/event less often. The only benefit of sending the event for every chunk written is that the file size updates in the Finder. Not worth the performance impact.
Reviewed by kocienda.
@@ -20334,15 +20224,15 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
Reviewed by Maciej.
- - fixed 3098293 -- Shockwave plug-in doesn't work
+ - fixed 3098293 -- Shockwave plug-in doesn't work
- The problem is that the Shockwave plug-in depends on being able to do LMGetCurApRefNum
- and then do a PBGetFCBInfoSync on the result, and if it gets an error it will refuse
- to initialize.
+ The problem is that the Shockwave plug-in depends on being able to do LMGetCurApRefNum
+ and then do a PBGetFCBInfoSync on the result, and if it gets an error it will refuse
+ to initialize.
* Plugins.subproj/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage initialize]):
- Supply a bogus CurApRefNum. Do it only if CurApRefNum is -1, so we don't screw things
- up if we are used in a Carbon application.
+ Supply a bogus CurApRefNum. Do it only if CurApRefNum is -1, so we don't screw things
+ up if we are used in a Carbon application.
2002-12-17 Darin Adler <darin at apple.com>
@@ -20350,14 +20240,14 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
* WebKit.pbproj/project.pbxproj: Remove signature.
* WebView.subproj/WebController.m: Turn off inlining so we can build even on the
- compiler that warns about static data in inline functions.
+ compiler that warns about static data in inline functions.
2002-12-17 John Sullivan <sullivan at apple.com>
- - fixed 2895826 -- ICON: Need a "no plug-in" icon
+ - fixed 2895826 -- ICON: Need a "no plug-in" icon
* Resources/nullplugin.tiff:
- new plug-in icon. Blue 3-D lego with question marks.
+ new plug-in icon. Blue 3-D lego with question marks.
2002-12-17 Richard Williamson <rjw at apple.com>
@@ -20398,10 +20288,10 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
2002-12-17 Trey Matteson <trey at apple.com>
- Reworking the code to update the page icon led me to roll the WebIconDB API
- for URL to NSString. In addition, the vestigial "Site" was removed.
+ Reworking the code to update the page icon led me to roll the WebIconDB API
+ for URL to NSString. In addition, the vestigial "Site" was removed.
- Everything below is renaming, except where noted.
+ Everything below is renaming, except where noted.
Reviewed by Darin
@@ -20420,7 +20310,7 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
(-[WebIconDatabase _loadIconDictionaries]):
(-[WebIconDatabase _updateFileDatabase]):
(-[WebIconDatabase _iconForFileURL:withSize:]): Cons up a NSURL to get the path.
- Test explicitly for .htm and .html suffixes.
+ Test explicitly for .htm and .html suffixes.
(-[WebIconDatabase _setIcon:forIconURL:]):
(-[WebIconDatabase _setIconURL:forURL:]):
(-[WebIconDatabase _releaseIconForIconURLString:]):
@@ -20437,7 +20327,7 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
2002-12-17 Chris Blumenberg <cblu at apple.com>
- Fixed: 3113073 - link on http://studio.adobe.com/explore/ redirects to not found page in Alex
+ Fixed: 3113073 - link on http://studio.adobe.com/explore/ redirects to not found page in Alex
Reviewed by darin.
@@ -20448,37 +20338,37 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
2002-12-17 John Sullivan <sullivan at apple.com>
- - to help with performance of various bookmark operations,
- added a call that returns the internal array of children,
- to complement the safer call that returns a copy.
+ - to help with performance of various bookmark operations,
+ added a call that returns the internal array of children,
+ to complement the safer call that returns a copy.
Reviewed by Darin
* Bookmarks.subproj/WebBookmark.h:
- commented -children and new -rawChildren
+ commented -children and new -rawChildren
* Bookmarks.subproj/WebBookmark.m:
(-[WebBookmark rawChildren]):
- new method, returns nil at this level.
+ new method, returns nil at this level.
(-[WebBookmark contentMatches:]):
- use -rawChildren instead of -children
+ use -rawChildren instead of -children
* Bookmarks.subproj/WebBookmarkList.m:
(-[WebBookmarkList rawChildren]):
- new method, returns internal array without copying
+ new method, returns internal array without copying
2002-12-16 Darin Adler <darin at apple.com>
Reviewed by Don and Maciej.
* WebView.subproj/WebUserAgentSpoofTable.gperf: Added a couple of new domains to the list we
- spoof as Mac IE, and added comments.
+ spoof as Mac IE, and added comments.
* WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.
* WebKit.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2
2002-12-16 Chris Blumenberg <cblu at apple.com>
- Fixed: 3129503 - Crash cancelling download after closing browser window that started download
+ Fixed: 3129503 - Crash cancelling download after closing browser window that started download
Reviewed by rjw.
@@ -20498,7 +20388,7 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
Reviewed by Maciej.
- - fixed 3128858 -- Supply Finder bits for decoded BinHex files
+ - fixed 3128858 -- Supply Finder bits for decoded BinHex files
* Downloads.subproj/WebBinHexDecoder.h: Add a _finderFlags field.
* Downloads.subproj/WebBinHexDecoder.m:
@@ -20506,13 +20396,12 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
(-[WebBinHexDecoder fileAttributes]): Put Finder flags in dictionary.
* Downloads.subproj/WebMacBinaryDecoder.m: Tweaked things for no good reason.
- (It is good to always import your own header first as a check that it's self-sufficient).
+ (It is good to always import your own header first as a check that it's self-sufficient).
* WebKit.pbproj/project.pbxproj: Let Electron wipe the slate clean of pre-Electron iniquity.
2002-12-15 Chris Blumenberg <cblu at apple.com>
-
- Fixed: 3094928 - Apply Finder bits to decoded downloads
+ Fixed: 3094928 - Apply Finder bits to decoded downloads
Reviewed by darin.
@@ -20529,22 +20418,22 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
Reviewed by Darin.
- - fixed likely B&I build problem.
+ - fixed likely B&I build problem.
* WebKit.pbproj/project.pbxproj: Get at other frameworks in B&I
- build. Bump version to 37u2.
+ build. Bump version to 37u2.
2002-12-15 Darin Adler <darin at apple.com>
Reviewed by Dave.
- - implemented user-agent spoofing as described in bug 3044569
+ - implemented user-agent spoofing as described in bug 3044569
* WebView.subproj/WebController.m: (-[WebController userAgentForURL:]):
- Find the suffix of the host name that contains exactly one dot, lower-case it,
- and look it up in the user-agent spoof table. For now, anything in the table
- pretends to be MacIE. Don't fret that this table is simple. We will complicate it
- as needed. The technique is flexible, even though it may not look it now.
+ Find the suffix of the host name that contains exactly one dot, lower-case it,
+ and look it up in the user-agent spoof table. For now, anything in the table
+ pretends to be MacIE. Don't fret that this table is simple. We will complicate it
+ as needed. The technique is flexible, even though it may not look it now.
* WebView.subproj/WebControllerPrivate.h: Add userAgentWhenPretendingToBeMacIE field.
* WebView.subproj/WebControllerPrivate.m:
@@ -20557,34 +20446,34 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
* English.lproj/StringsNotToBeLocalized.txt: Update for above changes.
- - fixed a crash I saw in a simplistic way
+ - fixed a crash I saw in a simplistic way
* WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):
- Don't assert if the webFrame is nil, just return a partial dictionary.
+ Don't assert if the webFrame is nil, just return a partial dictionary.
2002-12-15 Darin Adler <darin at apple.com>
Reviewed by Trey.
- - fixed 3128260 -- REGRESSION: context menus in frames are always the generic page menu
+ - fixed 3128260 -- REGRESSION: context menus in frames are always the generic page menu
* WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView hitTest:]):
- Check the control key in the mouse down event. If it's down, then do no magic.
+ Check the control key in the mouse down event. If it's down, then do no magic.
2002-12-15 Darin Adler <darin at apple.com>
Reviewed by Dave.
- - fixed 3128651 -- REGRESSION: Mouse wheeling is busted on frames pages
+ - fixed 3128651 -- REGRESSION: Mouse wheeling is busted on frames pages
* WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView hitTest:]):
- Only do the hitTest magic for left mouse downs; the rest of the clicks end up going
- to the correct view anyway, without our help. This makes this stop making trouble for
- the scroll wheel events.
+ Only do the hitTest magic for left mouse downs; the rest of the clicks end up going
+ to the correct view anyway, without our help. This makes this stop making trouble for
+ the scroll wheel events.
2002-12-14 Don Melton <gramps at apple.com>
- Fixed 3127173 -- REGRESSION: fboweb.com renders incorrectly
+ Fixed 3127173 -- REGRESSION: fboweb.com renders incorrectly
Reviewed by darin
@@ -20592,44 +20481,44 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
* WebView.subproj/WebController.m:
(-[WebController userAgentForURL:]):
- Changed "PPC" in our user agent string to "PPC Mac OS X" in order to
- match Mozilla and make the silly server-side user agent string checking
- work at fboweb.com. Actually, just "PPC " would work fine at
- fboweb.com. Go figure.
+ Changed "PPC" in our user agent string to "PPC Mac OS X" in order to
+ match Mozilla and make the silly server-side user agent string checking
+ work at fboweb.com. Actually, just "PPC " would work fine at
+ fboweb.com. Go figure.
2002-12-13 Darin Adler <darin at apple.com>
Reviewed by Don.
* WebView.subproj/WebController.m: (-[WebController userAgentForURL:]):
- Add "(like Gecko)" string and change "WebKit" to "AppleWebKit".
+ Add "(like Gecko)" string and change "WebKit" to "AppleWebKit".
* English.lproj/StringsNotToBeLocalized.txt: Update for these changes.
* Misc.subproj/WebUnicode.h: No need for & 0xFF since we cast to unsigned char.
2002-12-13 John Sullivan <sullivan at apple.com>
- - WebKit part of fix for 3028061 -- visiting a bookmarked site
- that now has a site icon will not update bookmark's icon
+ - WebKit part of fix for 3028061 -- visiting a bookmarked site
+ that now has a site icon will not update bookmark's icon
- No longer store the icon in the WebHistoryItem, since there's no
- mechanism for keeping it fresh and telling interested clients
- when it changes. Instead, the latest icon is always returned from
- the icon database, and it's up to clients to get a fresh one when
- they notice that the icon for a URL has been updated.
+ No longer store the icon in the WebHistoryItem, since there's no
+ mechanism for keeping it fresh and telling interested clients
+ when it changes. Instead, the latest icon is always returned from
+ the icon database, and it's up to clients to get a fresh one when
+ they notice that the icon for a URL has been updated.
Reviewed by Darin
* History.subproj/WebHistoryItem.h:
- remove _icon and _loadedIcon ivars
+ remove _icon and _loadedIcon ivars
* History.subproj/WebHistoryItem.m:
(-[WebHistoryItem dealloc]):
- don't release _icon
+ don't release _icon
(-[WebHistoryItem icon]):
- just return fresh icon from database, don't store
+ just return fresh icon from database, don't store
(-[WebHistoryItem setURL:]):
- don't set _loadedIcon to NO
+ don't set _loadedIcon to NO
=== Alexander-37u1 ===
@@ -20641,24 +20530,24 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
2002-12-13 Trey Matteson <trey at apple.com>
- 3108976 - assert _private provisionalItem in -[WebFrame(WebPrivate) _transitionToCommitted
- 3108865 - frames not maintained going back at directory.apple.com
+ 3108976 - assert _private provisionalItem in -[WebFrame(WebPrivate) _transitionToCommitted
+ 3108865 - frames not maintained going back at directory.apple.com
- Both bugs are fixed by the same small change. We no longer try to inherit loadType
- across redirects. Instead we just make sure the right thing happens in _transitionToCommitted:
- for redirects in the loadType=Standard case.
+ Both bugs are fixed by the same small change. We no longer try to inherit loadType
+ across redirects. Instead we just make sure the right thing happens in _transitionToCommitted:
+ for redirects in the loadType=Standard case.
- 3122721 - History stores both original and redirected sites
+ 3122721 - History stores both original and redirected sites
- Easy fix while in the neighborhood. We just don't add to History when doing a redirect.
+ Easy fix while in the neighborhood. We just don't add to History when doing a redirect.
Reviewed by rjw
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _transitionToCommitted:]): On redirect, update the URL of the frame's current
- item, not the current item in the b/f list. Also do not add to history on redirect.
+ item, not the current item in the b/f list. Also do not add to history on redirect.
(-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Cut out funny business
- that tried to guess when to inherit loadtype across redirects.
+ that tried to guess when to inherit loadtype across redirects.
2002-12-13 Richard Williamson <rjw at apple.com>
@@ -20688,7 +20577,7 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
2002-12-13 Chris Blumenberg <cblu at apple.com>
- Fixed: 3105486 - c|net news.com site seems to have lost its favicon again
+ Fixed: 3105486 - c|net news.com site seems to have lost its favicon again
Reviewed by darin.
@@ -20697,8 +20586,7 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
2002-12-13 Chris Blumenberg <cblu at apple.com>
- Catch NULL status strings passed to NPN_Status.
-
+ Catch NULL status strings passed to NPN_Status.
Reviewed by darin.
* Plugins.subproj/WebBaseNetscapePluginView.m:
@@ -20706,17 +20594,17 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
2002-12-12 Trey Matteson <trey at apple.com>
- 3117101 - PLT slows down as history fills up
+ 3117101 - PLT slows down as history fills up
- I saw a 3% sloth effect from a huge (100k) history. This change cut that cost in half.
- I think we still have a marginally measurable cost for our worst practical case.
+ I saw a 3% sloth effect from a huge (100k) history. This change cut that cost in half.
+ I think we still have a marginally measurable cost for our worst practical case.
Reviewed by rjw
* History.subproj/WebHistoryPrivate.m:
(-[WebHistoryPrivate insertEntry:atDateIndex:]): Comment.
(-[WebHistoryPrivate removeEntryForURLString:]): Use removeIdentical
- instead of remove, since we don't need to do all the equals comparisons.
+ instead of remove, since we don't need to do all the equals comparisons.
2002-12-12 Richard Williamson <rjw at apple.com>
@@ -20769,11 +20657,11 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
2002-12-12 Trey Matteson <trey at apple.com>
- Fixed 3094525 - Need to use SPI to fix flipped drag image problem
+ Fixed 3094525 - Need to use SPI to fix flipped drag image problem
- We call the new SPI. I also had to rework the dissolve steps to get it
- to non flip the image in Panther in millions (but leave the old code for
- the Jaguar case).
+ We call the new SPI. I also had to rework the dissolve steps to get it
+ to non flip the image in Panther in millions (but leave the old code for
+ the Jaguar case).
Reviewed by cblu
@@ -20793,12 +20681,12 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
(-[WebController initWithView:controllerSetName:]): Add observer so we know when defaults change.
(-[WebController dealloc]): Remove observer.
(-[WebController setApplicationNameForUserAgent:]): Clear out computed user agent to force it
- to be recomputed later.
+ to be recomputed later.
(-[WebController applicationNameForUserAgent]): Just retain since we copied when we stored it
- so we know it's not mutable.
+ so we know it's not mutable.
(-[WebController customUserAgent]): Ditto.
(-[WebController userAgentForURL:]): Use the cached user agent if it's good. Otherwise compute
- and cache the user agent string. This means that we will almost never recompute it.
+ and cache the user agent string. This means that we will almost never recompute it.
* WebView.subproj/WebControllerPrivate.h: Add userAgent field to cache in.
* WebView.subproj/WebControllerPrivate.m:
@@ -20809,15 +20697,15 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
Reviewed by Maciej.
- - fixed 3125504 -- REGRESSION: Selection not working correctly for text area on http://glish.com/css/7.asp
+ - fixed 3125504 -- REGRESSION: Selection not working correctly for text area on http://glish.com/css/7.asp
- The problem is that the text area lost its first responder status because WebHTMLView took the click,
- and NSWindow wanted WebHTMLView to become first responder too.
+ The problem is that the text area lost its first responder status because WebHTMLView took the click,
+ and NSWindow wanted WebHTMLView to become first responder too.
* WebView.subproj/WebHTMLView.m: (-[WebHTMLView acceptsFirstResponder]):
- Don't allow the NSWindow to make this the first responder during the early part of mouseDown event
- handling. But do allow anyone else to make this the first responder, for example from keyboard events,
- or from calls back from WebCore once we begin mouse-down event handling.
+ Don't allow the NSWindow to make this the first responder during the early part of mouseDown event
+ handling. But do allow anyone else to make this the first responder, for example from keyboard events,
+ or from calls back from WebCore once we begin mouse-down event handling.
2002-12-12 Darin Adler <darin at apple.com>
@@ -20896,12 +20784,12 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
Reviewed by Richard.
- - fixed 3124837 -- Crash trying to handle weird javascript URL in page address field
+ - fixed 3124837 -- Crash trying to handle weird javascript URL in page address field
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
- Use the new _web_scriptIfJavaScriptURL to simplify the check for JavaScript URLs,
- and to use a more tolerant unescaper.
+ Use the new _web_scriptIfJavaScriptURL to simplify the check for JavaScript URLs,
+ and to use a more tolerant unescaper.
* English.lproj/StringsNotToBeLocalized.txt: Updated.
@@ -20909,51 +20797,51 @@ nds 2 apple events both with a 60 second timeout. This method returns immediatel
Reviewed by John.
- - turned on the mechanism that passes events through WebCore, now that it's working better
+ - turned on the mechanism that passes events through WebCore, now that it's working better
* WebView.subproj/WebHTMLViewPrivate.m:
(-[WebHTMLView hitTest:]): Moved this function in here. Rewrote it. It has a new feature where
- you can set a global and do a normal hit test, needed for the mouse-moved handling below. Also,
- for efficiency, it does the actual hit testing of itself, rather than calling super, which recurses,
- and ignoring the result. The sum total is that it always returns self for mouse-moved events, so
- we pass them all over the bridge at the topmost frame.
+ you can set a global and do a normal hit test, needed for the mouse-moved handling below. Also,
+ for efficiency, it does the actual hit testing of itself, rather than calling super, which recurses,
+ and ignoring the result. The sum total is that it always returns self for mouse-moved events, so
+ we pass them all over the bridge at the topmost frame.
(-[WebHTMLView _updateMouseoverWithEvent:]):
* WebView.subproj/WebHTMLView.m: Moved hitTest: out of here.
2002-12-11 John Sullivan <sullivan at apple.com>
- - fixed 3124640 -- Crash importing IE Favorites if there
- are no IE favorites
+ - fixed 3124640 -- Crash importing IE Favorites if there
+ are no IE favorites
Reviewed by Darin
* Bookmarks.subproj/WebBookmarkImporter.m:
(-[WebBookmarkImporter initWithPath:]):
- use alloc/init instead of autoreleasing constructor for error since
- it's kept around until dealloc.
+ use alloc/init instead of autoreleasing constructor for error since
+ it's kept around until dealloc.
2002-12-11 Darin Adler <darin at apple.com>
Reviewed by John.
- - fixed 3117611 -- REGRESSION: exception in mouseoverTextForElement with accented characters in status
+ - fixed 3117611 -- REGRESSION: exception in mouseoverTextForElement with accented characters in status
* WebView.subproj/WebHTMLViewPrivate.m:
(-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]):
- Remove the object from the dictionary rather than just leaving the dictionary alone if it's nil.
- This is needed since we now are reusing an already-existing dictionary.
+ Remove the object from the dictionary rather than just leaving the dictionary alone if it's nil.
+ This is needed since we now are reusing an already-existing dictionary.
* English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
2002-12-11 Chris Blumenberg <cblu at apple.com>
- Fixed: 3118430 - crash / loop trying to copy url of link to clipboard
- Fixed: 3122585 - REGRESSION: dragging links to the desktop or a Finder window does not do anything
+ Fixed: 3118430 - crash / loop trying to copy url of link to clipboard
+ Fixed: 3122585 - REGRESSION: dragging links to the desktop or a Finder window does not do anything
Reviewed by john.
- We were reusing the drag types from the previous drag pasteboard. For example, we would declare image types when dragging URLs. This would confuse the Finder, so location files weren't being created. This would occasional cause us to crash because we wer
+ We were reusing the drag types from the previous drag pasteboard. For example, we would declare image types when dragging URLs. This would confuse the Finder, so location files weren't being created. This would occasional cause us to crash because we wer
@@ -20976,12 +20864,12 @@ en't providing the declared data.
2002-12-10 Trey Matteson <trey at apple.com>
- 3092966 - going back goes to different page (can't go back to a POST page)
- 3123450 - if the user refuses a navigation, the b/f menus is wrong
+ 3092966 - going back goes to different page (can't go back to a POST page)
+ 3123450 - if the user refuses a navigation, the b/f menus is wrong
- We will rePOST data upon back/forward/refresh if our caches fail us. The policy delegate
- gets a crack at confirming this operation. Latent bugs where the policy delegate was double
- queried are fixed. A bug in the b/f cursor when a page failed to load is fixed.
+ We will rePOST data upon back/forward/refresh if our caches fail us. The policy delegate
+ gets a crack at confirming this operation. Latent bugs where the policy delegate was double
+ queried are fixed. A bug in the b/f cursor when a page failed to load is fixed.
Reviewed by Maciej.
@@ -20996,81 +20884,81 @@ en't providing the declared data.
(-[WebHistoryItem description]):
* WebView.subproj/WebController.m:
(-[WebController _goToItem:withLoadType:]): Tighten up an assert as I clarified an
- assumption as I worked through this task.
+ assumption as I worked through this task.
* WebView.subproj/WebControllerPolicyDelegate.h: New WebNavigationType's for back/forward,
- refresh, and repost.
+ refresh, and repost.
* WebView.subproj/WebFrame.m:
(-[WebFrame loadRequest:]): Eliminate extra copy of a request.
(-[WebFrame reload]): Eliminate extra copy of a request. Setup triggeringAction properly
- if we're about to rePOST.
+ if we're about to rePOST.
* WebView.subproj/WebFramePrivate.h: Started moving some private methods into the .m file.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _createItem]): Save form state with history items.
(-[WebFrame _isLoadComplete]): Fix up b/f cursor on page error before commit succeeds.
(-[WebFrame _loadItem:fromItem:withLoadType:]): Set up request to rePOST if that's what the
- HistoryItem demands. Add call to _addExtraFieldsToRequest so we don't do a double
- query of the policy delegate. Pre-flight the form post vs. WF cache to setup triggering
- action properly.
+ HistoryItem demands. Add call to _addExtraFieldsToRequest so we don't do a double
+ query of the policy delegate. Pre-flight the form post vs. WF cache to setup triggering
+ action properly.
(-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]):
- New utility method to help build action dict.
+ New utility method to help build action dict.
(-[WebFrame _continueAfterNavigationPolicy:]): Comment only.
(-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Call new utility method
- instead (just code factoring).
+ instead (just code factoring).
(-[WebFrame _postWithURL:data:contentType:triggeringEvent:]): Call new utility method
- instead (just code factoring). Add call to _addExtraFieldsToRequest so we don't do a double
- query of the policy delegate.
+ instead (just code factoring). Add call to _addExtraFieldsToRequest so we don't do a double
+ query of the policy delegate.
(-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): Whitespace only.
(-[WebFrame _resetBackForwardListToCurrent]): Utility routine to fix up b/f cursor on page error.
(-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]): Fix up b/f cursor on page
- error before commit succeeds.
+ error before commit succeeds.
2002-12-10 Darin Adler <darin at apple.com>
Reviewed by Maciej.
- - fixed 3124302 -- REGRESSION: Can't use directory.apple.com because
- frame resize bar intercepts mouse clicks
+ - fixed 3124302 -- REGRESSION: Can't use directory.apple.com because
+ frame resize bar intercepts mouse clicks
* WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]):
- Don't steal clicks for views that are inside nested WebViews.
+ Don't steal clicks for views that are inside nested WebViews.
This isn't the real fix, but it's good enough for now. The real fix will be in WebCore.
2002-12-10 Darin Adler <darin at apple.com>
- - fixed fix for 3124081 -- REGRESSION: partial progress is left in address field after download
+ - fixed fix for 3124081 -- REGRESSION: partial progress is left in address field after download
Reviewed by Chris.
- Need to move it down one line so the data source is clear before callback.
+ Need to move it down one line so the data source is clear before callback.
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]):
- Do the _clearProvisionalDataSource before the locationChangeDone: callback.
+ Do the _clearProvisionalDataSource before the locationChangeDone: callback.
2002-12-10 John Sullivan <sullivan at apple.com>
- Fixed more "Alexander"s that were lurking in places I forgot
- to look before.
+ Fixed more "Alexander"s that were lurking in places I forgot
+ to look before.
Reviewed by Darin
* Makefile.am:
- "rm -rf $(SYMROOTS)/Safari.app/Frameworks/WebKit.framework"
+ "rm -rf $(SYMROOTS)/Safari.app/Frameworks/WebKit.framework"
2002-12-10 Darin Adler <darin at apple.com>
- - fixed 3124081 -- REGRESSION: partial progress is left in address field after download
+ - fixed 3124081 -- REGRESSION: partial progress is left in address field after download
Reviewed by Chris.
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]):
- Put in code to call the locationChangeDone: method on the location change delegate if
- keepLoading is YES. Since the data source is not finished loading WebFrame won't do it.
+ Put in code to call the locationChangeDone: method on the location change delegate if
+ keepLoading is YES. Since the data source is not finished loading WebFrame won't do it.
2002-12-10 Chris Blumenberg <cblu at apple.com>
- Fixed: 3124079 - REGRESSION: Downloads never complete
+ Fixed: 3124079 - REGRESSION: Downloads never complete
Reviewed by darin.
@@ -21107,62 +20995,61 @@ en't providing the declared data.
2002-12-10 John Sullivan <sullivan at apple.com>
- - tweaked the API of WebBookmarkImporter while implementing
- real "Import IE Favorites" UI
+ - tweaked the API of WebBookmarkImporter while implementing
+ real "Import IE Favorites" UI
Reviewed by Ken
* Bookmarks.subproj/WebBookmarkImporter.h:
- fixed a typo in a constant
+ fixed a typo in a constant
* Bookmarks.subproj/WebBookmarkImporter.m:
(-[WebBookmarkImporter initWithPath:]):
- Don't pass a group here. This method now creates the topBookmark
- (as it was doing before) but does not attempt to insert it
- anywhere. It's up to the client to fetch the topBookmark and do
- something with it. Also, don't name the new folder here; leave
- that to the caller also.
+ Don't pass a group here. This method now creates the topBookmark
+ (as it was doing before) but does not attempt to insert it
+ anywhere. It's up to the client to fetch the topBookmark and do
+ something with it. Also, don't name the new folder here; leave
+ that to the caller also.
* English.lproj/Localizable.strings:
- kept this file up to date
+ kept this file up to date
2002-12-10 Darin Adler <darin at apple.com>
Reviewed by John.
- - fixed 3108912 -- onclick handlers not supported on form elements
+ - fixed 3108912 -- onclick handlers not supported on form elements
* WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]):
- Take over hit testing so that all clicks on subviews are handled by the WebHTMLView.
- WebCore now handles getting the mouse events to the subviews after passing
- the events through the DOM.
+ Take over hit testing so that all clicks on subviews are handled by the WebHTMLView.
+ WebCore now handles getting the mouse events to the subviews after passing
+ the events through the DOM.
2002-12-09 Maciej Stachowiak <mjs at apple.com>
Reviewed by Trey.
- - fixed 3123057 - SJ: DHTML doesn't always work on http://www.pixar.com/howwedoit/
-
+ - fixed 3123057 - SJ: DHTML doesn't always work on http://www.pixar.com/howwedoit/
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
- Treat a click on a link to the same URL with an anchor as a scroll
- to anchor, not a same URL load.
+ Treat a click on a link to the same URL with an anchor as a scroll
+ to anchor, not a same URL load.
(-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Avoid
- adding the same anchor URL to the back/forward list many times.
+ adding the same anchor URL to the back/forward list many times.
2002-12-09 Darin Adler <darin at apple.com>
Reviewed by Maciej.
- - fixed 3028664 -- change user agent string to include application name and version
+ - fixed 3028664 -- change user agent string to include application name and version
* WebView.subproj/WebController.m:
(-[WebController setApplicationNameForUserAgent:]): Remove locking, unneeded since we changed
- how WebFoundation handles user agent.
+ how WebFoundation handles user agent.
(-[WebController setCustomUserAgent:]): Ditto.
(-[WebController resetUserAgent]): Ditto.
(-[WebController userAgentForURL:]): Remove locking. Also add new algorithm for computing the
- user agent which takes the preferred language into account, and incorporates the WebKit version
- and the application name.
+ user agent which takes the preferred language into account, and incorporates the WebKit version
+ and the application name.
* WebView.subproj/WebControllerPrivate.h: No need for a lock.
* WebView.subproj/WebControllerPrivate.m:
@@ -21170,7 +21057,7 @@ en't providing the declared data.
(-[WebControllerPrivate dealloc]): Don't release a lock.
* WebKit.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
- * English.lproj/InfoPlist.strings: In here too.
+ * English.lproj/InfoPlist.strings: In here too.
* English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes.
@@ -21226,85 +21113,85 @@ en't providing the declared data.
Reviewed by Chris.
- - fixed 3122608 -- REGRESSION: Downloads can't be cancelled
+ - fixed 3122608 -- REGRESSION: Downloads can't be cancelled
- When I fixed the leak for other categories of policy interruption, I messed
- things up for downloads. Added new parameters to handle this right.
+ When I fixed the leak for other categories of policy interruption, I messed
+ things up for downloads. Added new parameters to handle this right.
* WebView.subproj/WebBaseResourceHandleDelegate.h: Remove isDownload flag.
* WebView.subproj/WebBaseResourceHandleDelegate.m:
(-[WebBaseResourceHandleDelegate isDownload]): Return NO, override in subclass.
(-[WebBaseResourceHandleDelegate handle:didReceiveResponse:]): Call isDownload
- method instead of looking at flag directly.
+ method instead of looking at flag directly.
* WebView.subproj/WebControllerPrivate.h: Add complete: parameter to _mainReceivedError:.
* WebView.subproj/WebControllerPrivate.m:
(-[WebController _mainReceivedError:fromDataSource:complete:]): If complete is NO, then
- don't mark the primary load as complete.
+ don't mark the primary load as complete.
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient isDownload]): Added. Returns YES if downloadHandler is non-nil.
(-[WebMainResourceClient receivedError:complete:]): Added complete parameter. Call the
- _setPrimaryLoadComplete: method in the download case (fixes a possible leak), and pass
- the complete parameter through to the controller.
+ _setPrimaryLoadComplete: method in the download case (fixes a possible leak), and pass
+ the complete parameter through to the controller.
(-[WebMainResourceClient cancel]): Pass complete:YES.
(-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]): Added the keepLoading
- flag, and pass complete:!keepLoading.
+ flag, and pass complete:!keepLoading.
(-[WebMainResourceClient stopLoadingForPolicyChange]): Pass keepLoading:NO.
(-[WebMainResourceClient continueAfterContentPolicy:response:]): Pass keepLoading:YES,
- and remove the call to the now-obsolete setIsDownload:.
+ and remove the call to the now-obsolete setIsDownload:.
(-[WebMainResourceClient handle:didFailLoadingWithError:]): Pass complete:YES.
2002-12-08 Darin Adler <darin at apple.com>
Reviewed by Don and Dave.
- - fixed 3120578 -- REGRESSION: going to about:blank creates null view
+ - fixed 3120578 -- REGRESSION: going to about:blank creates null view
- This part of the fix makes sure that a renderer is created, even when there are no bytes
- of data passed through. This makes the empty document about:blank case work just like the
- "document with just whitespace in it case". There's another part of the fix in WebCore that
- takes care of the remaining problem.
+ This part of the fix makes sure that a renderer is created, even when there are no bytes
+ of data passed through. This makes the empty document about:blank case work just like the
+ "document with just whitespace in it case". There's another part of the fix in WebCore that
+ takes care of the remaining problem.
* WebView.subproj/WebHTMLRepresentation.m:
(-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
- Call receivedData:withDataSource: on the bridge with nil for the data. It would be even more
- elegant to add a new call for the case where we finish, but it's not necessary, since the
- existing receivedData: call does all the right things if passed nil.
+ Call receivedData:withDataSource: on the bridge with nil for the data. It would be even more
+ elegant to add a new call for the case where we finish, but it's not necessary, since the
+ existing receivedData: call does all the right things if passed nil.
* WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _finishedLoading]):
- Call finishedLoadingWithDataSource: here, to make sure it's done after committing.
- This parallels what we already do for the didReceiveData call.
+ Call finishedLoadingWithDataSource: here, to make sure it's done after committing.
+ This parallels what we already do for the didReceiveData call.
* WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]):
- Remove the call to finishedLoadingWithDataSource: because it's handled by _finishedLoading now.
- This parallels what we already do for the didReceiveData call.
+ Remove the call to finishedLoadingWithDataSource: because it's handled by _finishedLoading now.
+ This parallels what we already do for the didReceiveData call.
- - fixed long standing problem where resizing could make you see a "null view"
+ - fixed long standing problem where resizing could make you see a "null view"
* WebView.subproj/WebView.m:
(-[WebView drawRect:]): Add a "paint cyan" feature in development builds.
- Null view problems are particularly hard to debug without something like this,
- and we don't care if development builds are slightly slower. No change in deployment.
+ Null view problems are particularly hard to debug without something like this,
+ and we don't care if development builds are slightly slower. No change in deployment.
(-[WebView setFrameSize:]): Tell the scroll view to draw the background if we are
- resized. We can't do our "let the old bits show through" thing any more if we have to
- redraw because of resizing.
+ resized. We can't do our "let the old bits show through" thing any more if we have to
+ redraw because of resizing.
- - other changes
+ - other changes
* WebKit.pbproj/project.pbxproj: Remove the old -DAPPLE_CHANGES and -DHAVE_CONFIG_H that we
once needed when WebKit used to compile C++ headers from the KHTML part of WebCore.
We haven't needed those for ages. Also sort things a bit, using the new Electron feature for
- sorting lists of files alphabetically, and some by hand.
+ sorting lists of files alphabetically, and some by hand.
* English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
2002-12-08 Chris Blumenberg <cblu at apple.com>
- Fixed: 3121627 - REGRESSION: partial progress is left in address field after download
+ Fixed: 3121627 - REGRESSION: partial progress is left in address field after download
Reviewed by: darin
- In WebMainResourceClient, make sure to always call receivedError before _clearProvisionalDataSource so that
- receivedError works. This is done in multiple places, so I factored this out into one method interuptForPolicyChange.
+ In WebMainResourceClient, make sure to always call receivedError before _clearProvisionalDataSource so that
+ receivedError works. This is done in multiple places, so I factored this out into one method interuptForPolicyChange.
* WebView.subproj/WebControllerPrivate.m:
(-[WebController _mainReceivedError:fromDataSource:]): added asserts for nil error, dataSource and frame
@@ -21315,7 +21202,7 @@ en't providing the declared data.
2002-12-06 Trey Matteson <trey at apple.com>
- Clean up some printfs. Use WebKitLogPageCache for page cache info.
+ Clean up some printfs. Use WebKitLogPageCache for page cache info.
Reviewed by: rjw
@@ -21327,13 +21214,13 @@ en't providing the declared data.
2002-12-06 Trey Matteson <trey at apple.com>
- 3118584 - implement desired behavior for load - reload - b/f
- 3119241 - page cache needs to be refreshed after reload
- 3118096 - isTargetItem:NO saved to disk with every bookmark
+ 3118584 - implement desired behavior for load - reload - b/f
+ 3119241 - page cache needs to be refreshed after reload
+ 3118096 - isTargetItem:NO saved to disk with every bookmark
- The most noticeable changes are the addition of the "Same" loadType, and that reload
- does not restore form state. 3119241 was noticed in passing, and is related.
- 3118096 is a nit with a possible small perf benefit.
+ The most noticeable changes are the addition of the "Same" loadType, and that reload
+ does not restore form state. 3119241 was noticed in passing, and is related.
+ 3118096 is a nit with a possible small perf benefit.
Reviewed by: rjw
@@ -21356,10 +21243,10 @@ en't providing the declared data.
(-[WebFrame _isLoadComplete]): LoadTypeSame is a NOP.
(-[WebFrame _loadItem:fromItem:withLoadType:]): LoadTypeSame is an ASSERT.
(-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): In
- the LoadTypeSame case load from origin and never do anchor nav. If asked to load
- the same URL, invoke LoadTypeSame case.
+ the LoadTypeSame case load from origin and never do anchor nav. If asked to load
+ the same URL, invoke LoadTypeSame case.
(-[WebFrame _loadURL:intoChild:]): Latent bug: WebFrameLoadTypeReloadAllowingStaleData
- should restore child frame content like reload does.
+ should restore child frame content like reload does.
(-[WebFrame _itemForRestoringDocState]): Prevent form state restore on reload and loadSame.
(-[WebFrame _shouldTreatURLAsSameAsCurrent:]): New utility function.
@@ -21367,23 +21254,23 @@ en't providing the declared data.
Reviewed by: Darin Adler
- - made framework embedding work correctly with buildit
+ - made framework embedding work correctly with buildit
* WebKit.pbproj/project.pbxproj: Give framework a relative
- install path, don't install it the normal way, and copy it
- manually to /AppleInternal/Library/Frameworks if installing. Also
- look for other frameworks in
- ${DSTROOT}/AppleInternal/Library/Frameworks.
+ install path, don't install it the normal way, and copy it
+ manually to /AppleInternal/Library/Frameworks if installing. Also
+ look for other frameworks in
+ ${DSTROOT}/AppleInternal/Library/Frameworks.
2002-12-05 Darin Adler <darin at apple.com>
Reviewed by Trey.
- - fixed 3103691 -- assertion in WebHTMLView addMouseMovedObserver at versiontracker
+ - fixed 3103691 -- assertion in WebHTMLView addMouseMovedObserver at versiontracker
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView addMouseMovedObserver]): Instead of asserting, do the checks here to
- determine if the observer should be installed.
+ determine if the observer should be installed.
(-[WebHTMLView viewDidMoveToWindow]): Remove checks, since addMouseMovedObserver now checks.
(-[WebHTMLView windowDidBecomeMain:]): Remove checks, since addMouseMovedObserver now checks.
@@ -21404,7 +21291,7 @@ en't providing the declared data.
2002-12-05 Chris Blumenberg <cblu at apple.com>
- Added WebDocumentText protocol. Made WebHTMLView and WebTextView implement it.
+ Added WebDocumentText protocol. Made WebHTMLView and WebTextView implement it.
Reviewed by: rjw
@@ -21437,19 +21324,19 @@ en't providing the declared data.
Reviewed by Richard.
- - fixed 3107240 -- world leak: reproducible, trying to open TIFF file
+ - fixed 3107240 -- world leak: reproducible, trying to open TIFF file
* WebView.subproj/WebMainResourceClient.m:
(-[WebMainResourceClient notifyDelegatesOfInterruptionByPolicyChange]):
- Send error to the delegate using receivedError: rather than directly.
- This results in the frame properly stopping the load and fixes the leak.
+ Send error to the delegate using receivedError: rather than directly.
+ This results in the frame properly stopping the load and fixes the leak.
2002-12-05 Darin Adler <darin at apple.com>
Reviewed by Chris.
* Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler initWithDataSource:]):
- Add WebGZipDecoder to the list.
+ Add WebGZipDecoder to the list.
* Downloads.subproj/WebGZipDecoder.h: Finished this.
* Downloads.subproj/WebGZipDecoder.m: Finished this.
@@ -21461,7 +21348,7 @@ en't providing the declared data.
Reviewed by: Darin
* English.lproj/InfoPlist.strings: removed letters from
- CFBundleShortVersionString to make buildit happy.
+ CFBundleShortVersionString to make buildit happy.
=== Alexander-35 ===
@@ -21469,25 +21356,25 @@ en't providing the declared data.
Reviewed by Ken.
- - fixed 3118647 -- REGRESSION: click policy no longer works
+ - fixed 3118647 -- REGRESSION: click policy no longer works
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _actionInformationForNavigationType:event:originalURL:]):
- Allow mouse up events too. Those are usually the ones that trigger navigation.
+ Allow mouse up events too. Those are usually the ones that trigger navigation.
2002-12-04 Darin Adler <darin at apple.com>
Reviewed by Maciej.
- - fixed assert when you choose an item from a menu, for example, and that navigates
+ - fixed assert when you choose an item from a menu, for example, and that navigates
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _actionInformationForNavigationType:event:originalURL:]):
- If the event is over some other element, just don't include the element info.
+ If the event is over some other element, just don't include the element info.
2002-12-04 Chris Blumenberg <cblu at apple.com>
- Fixed: 3116294 - Need "Reload" feature in Downloads window
+ Fixed: 3116294 - Need "Reload" feature in Downloads window
Reviewed by: rjw
@@ -21497,14 +21384,14 @@ en't providing the declared data.
2002-12-04 Trey Matteson <trey at apple.com>
- 3097585 - Crash in -[WebFrame(WebPrivate) _isLoadComplete] at result of google image search
+ 3097585 - Crash in -[WebFrame(WebPrivate) _isLoadComplete] at result of google image search
- The root of this problem was that we would detach child frames by calling detach
- on them all, then clearing the whole array. This would fail because detaching a
- frame might have to stop a load, which calls checkLoadComplete, which visits the
- entire frame tree. But if a previously detached child is still sitting in that
- tree, we end up with an assertion failure. The solution is to remove the kids as
- they are detached.
+ The root of this problem was that we would detach child frames by calling detach
+ on them all, then clearing the whole array. This would fail because detaching a
+ frame might have to stop a load, which calls checkLoadComplete, which visits the
+ entire frame tree. But if a previously detached child is still sitting in that
+ tree, we end up with an assertion failure. The solution is to remove the kids as
+ they are detached.
Reviewed by: Darin Adler
@@ -21520,29 +21407,29 @@ en't providing the declared data.
Reviewed by Trey and Maciej.
- - fixed 3117558 -- Assertion failure in KWQKHTMLPart::slotData after typing "amazon.com" twice
- - update NSEvent handling in preparation for NSView mouse event handling going through WebCore
+ - fixed 3117558 -- Assertion failure in KWQKHTMLPart::slotData after typing "amazon.com" twice
+ - update NSEvent handling in preparation for NSView mouse event handling going through WebCore
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _loadItem:fromItem:withLoadType:]): Added FIXME comments about matching the _loadURL
- case more closely.
+ case more closely.
(-[WebFrame _actionInformationForNavigationType:event:originalURL:]): Only use the event if it's
- a mouse down event. This prevents trouble when we have other kinds of events coming through.
+ a mouse down event. This prevents trouble when we have other kinds of events coming through.
(-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Call the new scrollToAnchorWithURL:
- instead of openURL:. This fixes the assertion failure in the bug above.
+ instead of openURL:. This fixes the assertion failure in the bug above.
(-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Update checks here to more closely
- match the ones in KHTMLPart::openURL that we are replacing. Add more comments.
+ match the ones in KHTMLPart::openURL that we are replacing. Add more comments.
* WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): Function to intercept all clicks at the
- WebHTMLView level, disabled for now because we are not yet ready.
+ WebHTMLView level, disabled for now because we are not yet ready.
- - started a gzip download decoder, not yet hooked up
+ - started a gzip download decoder, not yet hooked up
* Downloads.subproj/WebGZipDecoder.h: Added.
* Downloads.subproj/WebGZipDecoder.m: Added.
* WebKit.pbproj/project.pbxproj: Add WebGZipDecoder and zlib.
- - other changes
+ - other changes
* Panels.subproj/WebAuthenticationPanel.m: Fixed screwed-up indentation.
@@ -21574,13 +21461,13 @@ en't providing the declared data.
2002-12-03 Darin Adler <darin at apple.com>
- - fixed 3117193 -- REGRESSION: Hang on Hixie's weblog
+ - fixed 3117193 -- REGRESSION: Hang on Hixie's weblog
Reviewed by Maciej.
* WebCoreSupport.subproj/WebTextRenderer.m:
(-[WebTextRenderer substituteFontForString:families:]):
- Do the operation on the whole string at once instead of a character at a time.
+ Do the operation on the whole string at once instead of a character at a time.
I decided to do this rather than correct the bug in the character-at-a-time version.
== Rolled over to ChangeLog-2002-12-03 ==
diff --git a/WebKit/WebView.subproj/WebHTMLView.m b/WebKit/WebView.subproj/WebHTMLView.m
index 7db507d..a2558e4 100644
--- a/WebKit/WebView.subproj/WebHTMLView.m
+++ b/WebKit/WebView.subproj/WebHTMLView.m
@@ -81,6 +81,9 @@
static BOOL forceRealHitTest = NO;
+ at interface WebHTMLView (WebTextSizing) <_web_WebDocumentTextSizing>
+ at end
+
@interface WebHTMLView (WebFileInternal)
- (BOOL)_imageExistsAtPaths:(NSArray *)paths;
- (DOMDocumentFragment *)_documentFragmentFromPasteboard:(NSPasteboard *)pasteboard allowPlainText:(BOOL)allowPlainText;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list