[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

weinig at apple.com weinig at apple.com
Wed Dec 22 13:30:54 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit e13ac9b5085e499ed358fe9efd60d806756a5493
Author: weinig at apple.com <weinig at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Sep 17 20:11:26 2010 +0000

    Make WebNumbers immutable matching CF.
    
    Reviewed by Anders Carlsson.
    
    * Shared/WebNumber.h:
    (WebKit::WebNumber::value):
    (WebKit::WebNumber::WebNumber):
    * UIProcess/API/C/WKNumber.cpp:
    (WKUInt64GetValue):
    * UIProcess/API/C/WKNumber.h:
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit2/ChangeLog b/WebKit2/ChangeLog
index 5b66817..e0b7683 100644
--- a/WebKit2/ChangeLog
+++ b/WebKit2/ChangeLog
@@ -1,5 +1,18 @@
 2010-09-17  Sam Weinig  <sam at webkit.org>
 
+        Reviewed by Anders Carlsson.
+
+        Make WebNumbers immutable matching CF.
+
+        * Shared/WebNumber.h:
+        (WebKit::WebNumber::value):
+        (WebKit::WebNumber::WebNumber):
+        * UIProcess/API/C/WKNumber.cpp:
+        (WKUInt64GetValue):
+        * UIProcess/API/C/WKNumber.h:
+
+2010-09-17  Sam Weinig  <sam at webkit.org>
+
         Reviewed by John Sullivan.
 
         Add bool wrapper for WebKit2 API
diff --git a/WebKit2/Shared/WebNumber.h b/WebKit2/Shared/WebNumber.h
index 4459d77..0b092ef 100644
--- a/WebKit2/Shared/WebNumber.h
+++ b/WebKit2/Shared/WebNumber.h
@@ -42,17 +42,16 @@ public:
     }
 
     NumberType value() const { return m_value; }
-    void setValue(NumberType value) { m_value = value; }
 
 private:
-    WebNumber(NumberType value)
+    explicit WebNumber(NumberType value)
         : m_value(value)
     {
     }
 
     virtual Type type() const { return APIType; }
 
-    NumberType m_value;
+    const NumberType m_value;
 };
 
 typedef WebNumber<bool, APIObject::TypeBoolean> WebBoolean;
diff --git a/WebKit2/UIProcess/API/C/WKNumber.cpp b/WebKit2/UIProcess/API/C/WKNumber.cpp
index aac0a58..797db79 100644
--- a/WebKit2/UIProcess/API/C/WKNumber.cpp
+++ b/WebKit2/UIProcess/API/C/WKNumber.cpp
@@ -46,11 +46,6 @@ bool WKBooleanGetValue(WKBooleanRef booleanRef)
     return toWK(booleanRef)->value();
 }
 
-void WKBooleanSetValue(WKBooleanRef booleanRef, bool value)
-{
-    toWK(booleanRef)->setValue(value);
-}
-
 WKTypeID WKDoubleGetTypeID()
 {
     return toRef(WebDouble::APIType);
@@ -67,11 +62,6 @@ double WKDoubleGetValue(WKDoubleRef doubleRef)
     return toWK(doubleRef)->value();
 }
 
-void WKDoubleSetValue(WKDoubleRef doubleRef, double value)
-{
-    toWK(doubleRef)->setValue(value);
-}
-
 WKTypeID WKUInt64GetTypeID()
 {
     return toRef(WebUInt64::APIType);
@@ -87,8 +77,3 @@ uint64_t WKUInt64GetValue(WKUInt64Ref uint64Ref)
 {
     return toWK(uint64Ref)->value();
 }
-
-void WKUInt64SetValue(WKUInt64Ref uint64Ref, uint64_t value)
-{
-    toWK(uint64Ref)->setValue(value);
-}
diff --git a/WebKit2/UIProcess/API/C/WKNumber.h b/WebKit2/UIProcess/API/C/WKNumber.h
index 70a9c63..1b07bef 100644
--- a/WebKit2/UIProcess/API/C/WKNumber.h
+++ b/WebKit2/UIProcess/API/C/WKNumber.h
@@ -36,19 +36,16 @@ extern "C" {
 WK_EXPORT WKTypeID WKBooleanGetTypeID();
 WK_EXPORT WKBooleanRef WKBooleanCreate(bool value);
 WK_EXPORT bool WKBooleanGetValue(WKBooleanRef booleanRef);
-WK_EXPORT void WKBooleanSetValue(WKBooleanRef booleanRef, bool value);
 
 /* WKDouble */
 WK_EXPORT WKTypeID WKDoubleGetTypeID();
 WK_EXPORT WKDoubleRef WKDoubleCreate(double value);
 WK_EXPORT double WKDoubleGetValue(WKDoubleRef doubleRef);
-WK_EXPORT void WKDoubleSetValue(WKDoubleRef doubleRef, double value);
 
 /* WKUInt64 */
 WK_EXPORT WKTypeID WKUInt64GetTypeID();
 WK_EXPORT WKUInt64Ref WKUInt64Create(uint64_t value);
 WK_EXPORT uint64_t WKUInt64GetValue(WKUInt64Ref doubleRef);
-WK_EXPORT void WKUInt64SetValue(WKUInt64Ref uint64Ref, uint64_t value);
 
 #ifdef __cplusplus
 }

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list