[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

ojan at chromium.org ojan at chromium.org
Wed Dec 22 12:31:14 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 9a75910c9bed546cd370d484bba7df01fd92abee
Author: ojan at chromium.org <ojan at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Aug 25 01:09:41 2010 +0000

    2010-08-24  Ojan Vafai  <ojan at chromium.org>
    
            Reviewed by Darin Adler.
    
            GC before running an iteration in the perf tests
            https://bugs.webkit.org/show_bug.cgi?id=44570
    
            This is a speculative attempt at reducing flakiness.
            There definitely are a lot of collected for some tests,
            so, having GC happen in the middle of a run may very well
            be causing flakiness.
    
            * resources/magnitude-perf.js:
            (Magnitude._runIteration):
            (Magnitude):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 29f3550..f0138e6 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,19 @@
+2010-08-24  Ojan Vafai  <ojan at chromium.org>
+
+        Reviewed by Darin Adler.
+
+        GC before running an iteration in the perf tests
+        https://bugs.webkit.org/show_bug.cgi?id=44570
+
+        This is a speculative attempt at reducing flakiness.
+        There definitely are a lot of collected for some tests,
+        so, having GC happen in the middle of a run may very well
+        be causing flakiness.
+
+        * resources/magnitude-perf.js:
+        (Magnitude._runIteration):
+        (Magnitude):
+
 2010-08-24  Tony Chang  <tony at chromium.org>
 
         Reviewed by Ojan Vafai.
diff --git a/LayoutTests/resources/magnitude-perf.js b/LayoutTests/resources/magnitude-perf.js
index cbd1b02..308c228 100644
--- a/LayoutTests/resources/magnitude-perf.js
+++ b/LayoutTests/resources/magnitude-perf.js
@@ -200,9 +200,18 @@ Magnitude._bigOGuess = function(milliseconds)
 
 Magnitude._runIteration = function(setup, test, magnitude, milliseconds, runsPerIteration)
 {
-    Magnitude._debug('run iteration. magnitude ' + magnitude + " milliseconds " + milliseconds + " runsPerIteration " + runsPerIteration);
     setup(magnitude);
 
+    var jsObjectCountBefore = jsObjectCountAfter = 0;
+    if (window.GCController) {
+        jsObjectCountBefore = GCController.getJSObjectCount();
+        GCController.collect();
+        jsObjectCountAfter = GCController.getJSObjectCount();
+    }
+
+    Magnitude._debug('run iteration. magnitude ' + magnitude + " milliseconds " + milliseconds + " runsPerIteration " + runsPerIteration +
+        " jsObjectCountBefore " + jsObjectCountBefore + " jsObjectCountAfter " + jsObjectCountAfter);
+
     var iterations = 0;
     if (window.chromium) {
       // FIXME: If using microseconds turns out to be less flaky, expose microseconds

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list