Bug#836055: webkit2gtk: please use dbus-run-session, GTestDBus, or dbus-daemon directly in tests

[Simon McVittie]

Source: webkit2gtk
Version: 2.12.4-1
Severity: minor
Tags: upstream
User: dbus at packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
This package currently uses dbus-launch in one of its unit tests.
This is really only an upstream bug - Debian doesn't currently seem to run
the tests, either at build time or from autopkgtest - but I'm filing it
downstream because it's one of around 300, so I can't go looking for
upstream bug tracking systems right now.

webkitgtk has the same bug, but I'm ignoring that one because I assume
it's dead upstream.

One way to resolve this would be to use GTestDBus, for which there is
already a FIXME comment.

This Flatpak commit illustrates how eval `dbus-launch` can be replaced
by invoking dbus-daemon directly, avoiding the X11-specific dbus-launch:
<https://github.com/flatpak/flatpak/commit/6cc8062cfb3f9410d54a27e7ccca77c103e441e8>.
The same thing in C/C++ can be seen in
<https://cgit.freedesktop.org/dbus/dbus/tree/test/test-utils-glib.c>
(search for --print-address). This is essentially what GTestDBus does.

Alternatively, the test executable could be run through
dbus-run-session(1), which is available since dbus 1.8, the upstream
"old stable" branch available in Debian stable. That would look something
like this:

    dbus-run-session -- make check

Thanks,
    S