Bug#372208: [pkg-wpa-devel] Bug#372208: missing patches from wpasupplicant

[Kel Modderman]

Soeren Sonnenburg wrote:
> On Fri, 2006-07-14 at 22:16 +1000, kelmo wrote:
>   
>> Soeren Sonnenburg wrote:
>>     
>>> On Fri, 2006-07-14 at 21:09 +1000, Kel Modderman wrote:
>>>   
>>>       
>>>> reopen 372208
>>>> |retitle |372208 Orinoco and wpa_supplicant not working with WEP
>>>> thanks
>>>>
>>>> Hi,
>>>>
>>>> I have a bad feeling about the included patch and would like to drop it 
>>>> for a few reasons:
>>>>
>>>>    1. I currently experience problems with WEP and madwifi (using wext
>>>>       ioctl's), and have had difficulty debugging
>>>>     
>>>>         
>>> well does it help if you remove the patch ?
>>>   
>>>       
>> That is hard to distinguish, this problem may be in the madwifi driver 
>> wext implementation, or in the supplicant itself. Diverging from 
>> mainstream makes asking them for support more difficult.
>>     
>
> so does it help if you remove the patch ?
>   

I cannot say with absolute certainty, like I already indicated above.


>   
>> This has the possibility to effect a wide variety of users. I'd prefer 
>> if the Orinoco problem was discussed properly on the hostap mailing 
>> lists before we continue to carry along a hack of a patch and cause new 
>> problems for other people. I cannot do that well, because I don't have 
>> Orinoco hardware that craps itself with the pristine wpa_supplicant and WEP.
>>     
>
>
> well then do it, have you bothered at looking at the patch at all ?
>   

No, I just added it blindly the first time. Do you think I am stupid 
enough to not to rediff and at least look at the code when adding it to 
the package?


> it is a one liner:
>
> -               iwr.u.encoding.pointer = (caddr_t) key;
> +               iwr.u.encoding.pointer = (caddr_t) NULL;
>   
One line of code can make a huge difference, what is your actual point here?

And what _exactly_ does it do? I cannot say with _absolute_ certainty, 
therefore I contacted you in the chance you may be able to assist in 
finding out, since you have the problem.
>
>   
>> It should be proven that the patch works absolutely correctly (without 
>> disrupting other modules), and as such, it should be known to be worthy 
>> of merging into upstream wpa_supplicant. I am not sure I can provide 
>> those details, therefore I'd prefer to have the same problems as 
>> upstream, and not different ones.
>>     
>
> right, that is why you should try whether your problems vanish w/o this
> patch.
>   

I am and have been testing various WEP networks for the last days. . .

But this is all in vain, The authour of the patch needs to Ack it for me 
to be convinced of its value, full stop. This should have been my 
response in the first place, however I was stupid.

>
> well it is about fixing finding out whether this kills the hostap
> support and you seem to have trouble with it... if the patch is at fault
> then we will see what one can do about it.
>   

I am doing something => dropping it until its been recommended by its 
authour or upstream. You can assist, that would be great.

Kel.