[pkg-wpa-devel] Bug#506328: Bug#506328: wpasupplicant: Missing -d in testing for a directory in init script

[Kel Modderman]

On Friday 21 November 2008 01:01:38 Braun Gábor wrote:
> Package: wpasupplicant
> Version: 0.6.4-2
> Severity: normal
> Tags: patch
> 
> I guess a -d is missing in line 62 in /etc/init.d/wpa-ifupdown:
> 
>      elif [ /var/run/sendsigs.omit.d/ ]; then
> 
> I assume that the intent is to test for the existence of a directory.
> However, the line above tests for the non-emptiness of the string 
> "/var/run/sendsigs.omit.d/" (which is always true).
> 
> Therefore, I suggest the following patch.
> Note that I do not know what is the intent here,
> I have just spotted a suspicious expression.
> 
> --- /etc/init.d/wpa-ifupdown    2008-07-17 16:38:12.000000000 +0200
> +++ /etc/init.d/wpa-ifupdown    2008-11-20 14:53:36.000000000 +0100
> @@ -59,7 +59,7 @@
>         if [ -d /lib/init/rw/sendsigs.omit.d/ ]; then
>                 # Debian
>                 return 0
> -       elif [ /var/run/sendsigs.omit.d/ ]; then
> +       elif [ -d /var/run/sendsigs.omit.d/ ]; then
>                 # Ubuntu, cf. https://bugs.launchpad.net/bugs/181541
>                 return 0
>         fi
> 
>         Gábor Braun

Thanks an obvious bug, I have not time to apply it really soon CC'ing Reinhard
in case he has ability to possibly apply, and even prepare to TPU package?

Reinhard, I'll have little capacity to handle bugs for the next 6 weeks, fyi.

Thanks, Kel.