[pkg-wpa-devel] Bug#622757: wpasupplicant: Faulty ifupdown/functions.sh script?

[Sedat Dilek]

On Fri, Apr 15, 2011 at 3:48 PM, Sedat Dilek <sedat.dilek at googlemail.com> wrote:
> On Fri, Apr 15, 2011 at 3:37 PM, Sedat Dilek <sedat.dilek at googlemail.com> wrote:
>> On Fri, Apr 15, 2011 at 1:17 PM, Kel Modderman <kel at otaku42.de> wrote:
>>> On Thu, 14 Apr 2011 10:50:30 PM Sedat Dilek wrote:
>>>> Package: wpasupplicant
>>>> Version: 0.7.3-2
>>>> Severity: normal
>>>>
>>>> Hi,
>>>>
>>>> with wpasupplicant-0.7.3 entering Debian/sid my Internet connection is
>>>> not established anymore.
>>>>
>>>> By replacing the ifupdown/functions.sh script from wpasupplicant
>>>> (0.6.10-2.1) things are as used to.
>>>> I haven't got the time to look deeper into this as it WorksForMe.
>>>>
>>>> I have collected all relevant material (/e/n/i), the files of
>>>> ifupdown-dirs from 0.6.10 and 0.7.3 (see also the diffs) and added my
>>>> dsc|diff files into the attached tarball.
>>>>
>>>> If this kind of matters I use systemd as sysvinit replacement and
>>>> resolvconf helps for static-IP network setup.
>>>> Furthermore, I have no ifplugd or suggested libengine-pkcs11-openssl installed.
>>>>
>>>> If you have detailed instructions on how to investigate the issue,
>>>> please let me know.
>>>
>>> Without reviewing any diff, it could be related to #622589
>>>
>>> Kel.
>>>
>>
>> Thanks for the reference.
>>
>> As a quick solution like proposed by Sergio WorksForMe, an
>> error-message does not hurt:
>>
>> --- wpasupplicant-0.7.3.orig/debian/ifupdown/functions.sh
>> 2010-05-02 10:41:33.000000000 +0200
>> +++ wpasupplicant-0.7.3/debian/ifupdown/functions.sh    2011-04-15
>> 15:26:50.200897565 +0200
>> @@ -281,7 +281,11 @@ init_wpa_supplicant () {
>>
>>        if [ -n "$WPA_SUP_OMIT_PIDFILE" ]; then
>>                wpa_msg verbose "creating sendsigs omission pidfile:
>> $WPA_SUP_OMIT_PIDFILE"
>> +               sleep 1
>>                cat "$WPA_SUP_PIDFILE" > "$WPA_SUP_OMIT_PIDFILE"
>> +       else
>> +               wpa_msg stderr "$WPA_SUP_BIN daemon could not create
>> sendsigs omission pidfile"
>> +               return 1
>>        fi
>>  }
>>
>> Best would be to wait till $WPA_SUP_PIDFILE really exists and do some
>> value-check.
>>
>> - Sedat -
>>
>
> This hackery does work with sysvinit but not with systemd.
> I switched back to functions.sh from old 0.6.x package.
>
> - Sedat -
>

I played a bit more in my systemd environment.

First, I tried with -ddt in debug-mode to get more informations.
But, this lets in 99% of the case come up the connection fine :-).

The flooding of my syslog, let me take a look at wpa_supplicant
manpage and when I saw -u option and read dbus (...is heart of
systemd) I added it to $WPA_SUP_OPTIONS.
Start/Stop of networking service works now reliable.

- Sedat -

P.S.: Here the diff

--- 0.7.3/functions.sh  2010-05-02 10:41:33.000000000 +0200
+++ functions.sh        2011-04-15 17:52:11.772504404 +0200
@@ -199,11 +199,20 @@ test_wpa_cli () {
 # -b   bridge interface name
 # -f   path to log file
 #
+# DBus options:
+# -u   Enabled DBus control interface. If enabled, interface
definitions may be omitted.
+#
+# Debug options:
+# -d   Increase debugging verbosity (-dd even more).
+# -t   Include timestamp in debug messages.
+#
 init_wpa_supplicant () {
        [ -n "$WPA_SUP_CONF" ] || return 0

        local WPA_SUP_OPTIONS
-       WPA_SUP_OPTIONS="-s -B -P $WPA_SUP_PIDFILE -i $WPA_IFACE"
+       # -ddt: Run daemon in debug mode and include timestamp informations
+       #   -u: Run enabled DBus control interface
+       WPA_SUP_OPTIONS="-s -B -P $WPA_SUP_PIDFILE -i $WPA_IFACE -u"

        if [ -n "$WPA_ACTION_SCRIPT" ]; then
                if [ -x "$WPA_ACTION_SCRIPT" ]; then

- EOT -