[pkg-wpa-devel] Bug#622757 closed by Kel Modderman <kel at otaku42.de> (Bug#622757: fixed in wpasupplicant 0.7.3-3)

Mon Apr 18 09:22:43 UTC 2011

On Mon, 18 Apr 2011 07:13:49 PM Sedat Dilek wrote:
> +++ Not that I plan to reopen this bug-#. +++
> 
> Can you explain why you re-added the removed code part exactly back?
> What was the reason to drop it?

Because it shouldn't be required in theory. Reality is a bit different.

> Why this shell-kung-fu... with that ugly sleep etc.?

Because it works.

> 
> Why is the below "short" fixup not enough in your POV?
> Please, keep the things simple.
> ( I had several startup at weekend, it works nicely. )

Because I think it's crap use of 'until', really.

> 
> Furthermore:
> 1. Are you planning a systemd unit/service file? Co-existence with
> that ugly ifupdown script?

Look, I wrote the script, if you want to flat out call it ugly yet still be
a user of it you can can be ignored from now on.

It is what it is and it made networking work for a few users.

> 2. Plans to upload a package with /run support?

When the time is right.

> 
> - Sedat -

Yours sincerely, Kel.

> 
> [1] http://wiki.debian.org/ReleaseGoals/RunDirectory
>      Section #1: Packages using /lib/init/rw
>      Section #2: How to transition from /lib/init/rw to /run?
> 
> [ CODE ]
> 
> -       if [ -n "$WPA_SUP_OMIT_PIDFILE" ]; then
> -               wpa_msg verbose "creating sendsigs omission pidfile:
> $WPA_SUP_OMIT_PIDFILE"
> -               cat "$WPA_SUP_PIDFILE" > "$WPA_SUP_OMIT_PIDFILE"
> -       fi
> +       until [ -S "$WPA_CTRL_DIR/$WPA_IFACE" ]; do
> +               if [ -n "$WPA_SUP_OMIT_PIDFILE" ]; then
> +                       wpa_msg verbose "creating sendsigs omission
> pidfile: $WPA_SUP_OMIT_PIDFILE"
> +                       cat "$WPA_SUP_PIDFILE" > "$WPA_SUP_OMIT_PIDFILE"
> +               else
> +                       wpa_msg verbose "sendsigs omission pidfile not created"
> +                       wpa_msg stderr "ctrl_interface socket not
> found at $WPA_CTRL_DIR/$WPA_IFACE"
> +                       return 1
> +               fi
> +       done
> 
> [ /CODE ]
> 
> On Sun, Apr 17, 2011 at 10:48 PM, Debian Bug Tracking System
> <owner at bugs.debian.org> wrote:
> > This is an automatic notification regarding your Bug report
> > which was filed against the wpasupplicant package:
> >
> > #622757: wpasupplicant: Faulty ifupdown/functions.sh script?
> >
> > It has been closed by Kel Modderman <kel at otaku42.de>.
> >
> > Their explanation is attached below along with your original report.
> > If this explanation is unsatisfactory and you have not received a
> > better one in a separate message then please contact Kel Modderman <kel at otaku42.de> by
> > replying to this email.
> >
> >
> > --
> > 622757: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622757
> > Debian Bug Tracking System
> > Contact owner at bugs.debian.org with problems
> >
> >
> > ---------- Forwarded message ----------
> > From: Kel Modderman <kel at otaku42.de>
> > To: 622757-close at bugs.debian.org
> > Date: Sun, 17 Apr 2011 20:44:40 +0000
> > Subject: Bug#622757: fixed in wpasupplicant 0.7.3-3
> > Source: wpasupplicant
> > Source-Version: 0.7.3-3
> >
> > We believe that the bug you reported is fixed in the latest version of
> > wpasupplicant, which is due to be installed in the Debian FTP archive:
> >
> > wpagui_0.7.3-3_i386.deb
> >  to main/w/wpasupplicant/wpagui_0.7.3-3_i386.deb
> > wpasupplicant_0.7.3-3.debian.tar.gz
> >  to main/w/wpasupplicant/wpasupplicant_0.7.3-3.debian.tar.gz
> > wpasupplicant_0.7.3-3.dsc
> >  to main/w/wpasupplicant/wpasupplicant_0.7.3-3.dsc
> > wpasupplicant_0.7.3-3_i386.deb
> >  to main/w/wpasupplicant/wpasupplicant_0.7.3-3_i386.deb
> >
> >
> >
> > A summary of the changes between this version and the previous one is
> > attached.
> >
> > Thank you for reporting the bug, which will now be closed.  If you
> > have further comments please address them to 622757 at bugs.debian.org,
> > and the maintainer will reopen the bug report if appropriate.
> >
> > Debian distribution maintenance software
> > pp.
> > Kel Modderman <kel at otaku42.de> (supplier of updated wpasupplicant package)
> >
> > (This message was generated automatically at their request; if you
> > believe that there is a problem with it please contact the archive
> > administrators by mailing ftpmaster at debian.org)
> >
> >
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA256
> >
> > Format: 1.8
> > Date: Sun, 17 Apr 2011 21:07:58 +1000
> > Source: wpasupplicant
> > Binary: wpasupplicant wpagui
> > Architecture: source i386
> > Version: 0.7.3-3
> > Distribution: unstable
> > Urgency: low
> > Maintainer: Debian/Ubuntu wpasupplicant Maintainers <pkg-wpa-devel at lists.alioth.debian.org>
> > Changed-By: Kel Modderman <kel at otaku42.de>
> > Description:
> >  wpagui     - graphical user interface for wpa_supplicant
> >  wpasupplicant - client support for WPA and WPA2 (IEEE 802.11i)
> > Closes: 622587 622589 622757 622821
> > Changes:
> >  wpasupplicant (0.7.3-3) unstable; urgency=low
> >  .
> >   * Restore code which loop waits for wpa_supplicant generated PID and
> >     UNIX socket on the filesystem before proceeeding with execution of
> >     ifupdown script. (Closes: #622757, #622589)
> >   * On DISCONNECTED event using wpa-roam, do not immediately issue
> >     reassociation command. (Closes: #622821)
> >   * Enable CONFIG_IEEE80211W in build configuration. (Closes: #622587)
> > Checksums-Sha1:
> >  cb3a2bbd2d6163e5dc245b92f6ad6295cf49876f 2186 wpasupplicant_0.7.3-3.dsc
> >  c0b0fddc49b46a2d3a8737dc8212bd0237dec78e 61600 wpasupplicant_0.7.3-3.debian.tar.gz
> >  83f8e837da655d04633e99862f2eafe47f4abc65 495072 wpasupplicant_0.7.3-3_i386.deb
> >  89f73bcf66c623efa0e3988cc958f95d44202bdc 323024 wpagui_0.7.3-3_i386.deb
> > Checksums-Sha256:
> >  29753417823e3cebdf2b0f6daaa9c1861dd7f09c242e66af10fd451852695b67 2186 wpasupplicant_0.7.3-3.dsc
> >  47ace892efcf7a9b25ff9096855b78da77dc6ea034077b01366ac365e09b0a4b 61600 wpasupplicant_0.7.3-3.debian.tar.gz
> >  db4fd2e8e7b6a9365db7a7d911b1092fc71a7c2a8410eed2a589b97cf9d29d04 495072 wpasupplicant_0.7.3-3_i386.deb
> >  d198e2e15c0b0cece067e0a443ef76f0c6b629f64c19570da8c9cd2087479f81 323024 wpagui_0.7.3-3_i386.deb
> > Files:
> >  def7e67868582060384bc55b8cd9a173 2186 net optional wpasupplicant_0.7.3-3.dsc
> >  0a20fe46d98254f23df187a37a64ad16 61600 net optional wpasupplicant_0.7.3-3.debian.tar.gz
> >  370cc6247af6a1f73e3218662a7f0613 495072 net optional wpasupplicant_0.7.3-3_i386.deb
> >  b0c7a0360916e6c6aa94aac6efe09f8f 323024 net optional wpagui_0.7.3-3_i386.deb
> >
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.11 (GNU/Linux)
> >
> > iQIcBAEBCAAGBQJNqtqyAAoJEGrh3w1gjyLc73MP/jDeQYZH9w87jHacu9zYx9mk
> > BYqQ6p2e3Pz99YakXW+uLmbxp0T3R4JpMuOdaQsyGigUPBdtBkVHfpnkAWoscGRa
> > oVeVozy4+fjdEbapXC/QFJ6HYdXm3h9fQaS7cJTt1UsqXxsNe0sRxY/bBH/Srmk2
> > Iloh7CoyeQCB8lvOaE5UeJc2U0NOw1e6RxN5OzimrFo3vzaldyKgAWwlEwTYYja5
> > G8G7BjKPKkZADecm5FbOiG15LyMGTldRZ9BGrN3uztm2XTuR0vAxUzOEIOAQZnLY
> > FHWjdnUkG3sHFcody5tAFQ/uGS7/ktXtiDXJX0BrUBCZG6XeEyv56O1eQtOu7Q+v
> > ybZ6NgoLSang6YsBrEB07uK1TXR0DY7J5LbOM+B4J/Y/XI+quS0yhncQ2RRoA49L
> > 0C9fIDTBICCRmbFkaodGz/h2slUSEdkJkxX3HLEBlpcMgLnrXV7QSrRt/sAiUxrW
> > URwQ2bxVczbdFAvL7bN+wn/ouiLAkarPk45eM9PRGhU5aEID25iSItHEC3agK4b+
> > uiZcaoIGHEKulVBrLN2mQHdDSi41TTKTmCVzw0YO8106PUiGc/3uVeNbuEHC4ArA
> > Ykc3MTXhGIWwJLlywxj/PqEXiZ1Vcbz/jfmJIygaUlKTzr4rmy/pK/c71dcw1feb
> > Zdh+0n1BfdmdwMQawF+5
> > =KjnD
> > -----END PGP SIGNATURE-----
> >
> >
> >
> >
> > ---------- Forwarded message ----------
> > From: Sedat Dilek <sedat.dilek at googlemail.com>
> > To: Debian Bug Tracking System <submit at bugs.debian.org>
> > Date: Thu, 14 Apr 2011 14:50:30 +0200
> > Subject: wpasupplicant: Faulty ifupdown/functions.sh script?
> > Package: wpasupplicant
> > Version: 0.7.3-2
> > Severity: normal
> >
> > Hi,
> >
> > with wpasupplicant-0.7.3 entering Debian/sid my Internet connection is
> > not established anymore.
> >
> > By replacing the ifupdown/functions.sh script from wpasupplicant
> > (0.6.10-2.1) things are as used to.
> > I haven't got the time to look deeper into this as it WorksForMe.
> >
> > I have collected all relevant material (/e/n/i), the files of
> > ifupdown-dirs from 0.6.10 and 0.7.3 (see also the diffs) and added my
> > dsc|diff files into the attached tarball.
> >
> > If this kind of matters I use systemd as sysvinit replacement and
> > resolvconf helps for static-IP network setup.
> > Furthermore, I have no ifplugd or suggested libengine-pkcs11-openssl installed.
> >
> > If you have detailed instructions on how to investigate the issue,
> > please let me know.
> >
> > Regards,
> > - Sedat -
> >
> > -- System Information:
> > Debian Release: wheezy/sid
> >  APT prefers unstable
> >  APT policy: (500, 'unstable'), (200, 'experimental')
> > Architecture: i386 (i686)
> >
> > Kernel: Linux 2.6.39-rc3-next20110413.2-686-small (SMP w/1 CPU core)
> > Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
> > Shell: /bin/sh linked to /bin/dash
> >
> > Versions of packages wpasupplicant depends on:
> > ii  adduser                       3.112+nmu2 add and remove users and groups
> > ii  libc6                         2.13-0exp5 Embedded GNU C Library: Shared lib
> > ii  libdbus-1-3                   1.4.6-1    simple interprocess messaging syst
> > ii  libnl1                        1.1-6      library for dealing with netlink s
> > ii  libpcsclite1                  1.7.2-1    Middleware to access a smart card
> > ii  libreadline6                  6.1-3      GNU readline and history libraries
> > ii  libssl1.0.0                   1.0.0d-2   SSL shared libraries
> > ii  lsb-base                      3.2-27     Linux Standard Base 3.2 init scrip
> >
> > wpasupplicant recommends no packages.
> >
> > Versions of packages wpasupplicant suggests:
> > pn  libengine-pkcs11-openss <none>           (no description available)
> > ii  wpagui                  0.7.3-2          graphical user interface for wpa_s
> >
> > -- no debconf information
> >
> >
> 