[pkg-wpa-devel] Bug#617199: Please upload 0.7.3 to experimental (including fix for dbus property events)

[Kel Modderman]

Hi Michael,

On Tuesday 08 March 2011 01:32:48 Michael Biebl wrote:
> Hi Kel!
> 
> Am 07.03.2011 11:47, schrieb Kel Modderman:
> 
> > A source package is available at:
> > http://mentors.debian.net/debian/pool/main/w/wpasupplicant/wpasupplicant_0.7.3-1.dsc
> > 
> > It contains a bunch of experimental appropriate changes including the cherry
> > pick you want. Some of the new changes need a bit of testing and feedback.
> > 
> > Could you please consider review and upload of it?
> 
> I did some basic testing using it via NetworkManager and the package works fine
> so far. I didn't test any of the wpa ifupdown hooks / roaming mode or the new
> libpcsc dlopen.

I use the ifupdown stuff all the time. No person that I know can test pcsc
related functionality.

> 
> Regarding the packaging, there are some smaller points:
> 
> 1/ You use debhelper compat level 8, so you *need* to build depend on debhelper
> (>> 8). Given that squeeze has debhelper 8 and even lenny has a debhelper 8
> backport, there should be no problem bumping it.

No problems.

> 2/ For b-deps like libnl-dev, you can use the new syntax
> libnl-dev [linux-any]
> That makes it more readable imho.

Ok, I agree. Cheers for the tip.

> 3/ Does wpagui work with wpasupplicant (>= 0.6.2) or should that be bumped to
> something 0.7.x like?

It should probably be bumped, the GUI supports a few new features not available
in older wpa_supplicant.

> 4/ Why do you need an explicit Depends on libqt4-svg? Does dh_shlibs not
> generate an appropriate dep?

wpa_gui does not link against libQtSvg.so.4. I think in theory one could
convert the svg -> png and not require svg support in your QT installation.

> 
> Otherwise it looks fine to me and I'd be happy to sponsor the upload.
> Can you address the above issues (1/ one is a must, the other I'll leave to your
> judgement) and let me know.

I have re-uploaded the source package to mentors, same URL as before. Thanks
very much for helping out.

> Should I wait until you get an ACK from the pcscd maintainer regarding the
> dlopen patch?

Nope.

Thanks, Kel.